Inspection of "Merge pull request #360 from kenjis/change-is_test..." - kenjis/ci-phpunit-test - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — master ( 3c4c47...76c067 )

by Kenji

created 2021-02-08 00:59 UTC

Status

Switch Indentation +22 added lines, -22 removed lines patch added patch discarded remove patch

@@ -69,28 +69,28 @@
 block discarded – undo
  */
 switch (ENVIRONMENT)
 {
-	case 'testing':
-	case 'development':
-		error_reporting(-1);
-		ini_set('display_errors', 1);
-	break;
-
-	case 'production':
-		ini_set('display_errors', 0);
-		if (version_compare(PHP_VERSION, '5.3', '>='))
-		{
-			error_reporting(E_ALL & ~E_NOTICE & ~E_DEPRECATED & ~E_STRICT & ~E_USER_NOTICE & ~E_USER_DEPRECATED);
-		}
-		else
-		{
-			error_reporting(E_ALL & ~E_NOTICE & ~E_STRICT & ~E_USER_NOTICE);
-		}
-	break;
-
-	default:
-		header('HTTP/1.1 503 Service Unavailable.', TRUE, 503);
-		echo 'The application environment is not set correctly.';
-		exit(1); // EXIT_ERROR
+		case 'testing':
+		case 'development':
+			error_reporting(-1);
+			ini_set('display_errors', 1);
+		break;
+
+		case 'production':
+			ini_set('display_errors', 0);
+			if (version_compare(PHP_VERSION, '5.3', '>='))
+			{
+				error_reporting(E_ALL & ~E_NOTICE & ~E_DEPRECATED & ~E_STRICT & ~E_USER_NOTICE & ~E_USER_DEPRECATED);
+			}
+			else
+			{
+				error_reporting(E_ALL & ~E_NOTICE & ~E_STRICT & ~E_USER_NOTICE);
+			}
+		break;
+
+		default:
+			header('HTTP/1.1 503 Service Unavailable.', TRUE, 503);
+			echo 'The application environment is not set correctly.';
+			exit(1); // EXIT_ERROR
 }
 
 /*

Please login to merge, or discard this patch.

tests/_ci_phpunit_test/replacing/helpers/old/3.1.9-download_helper.php 1 patch

Spacing +2 added lines, -2 removed lines patch added patch discarded remove patch

@@ -72,7 +72,7 @@  discard block
 block discarded – undo
 			}
 
 			// Load the mime types
-			$mimes =& get_mimes();
+			$mimes = & get_mimes();
 
 			// Only change the default MIME if we can find one
 			if (isset($mimes[$extension]))
@@ -117,7 +117,7 @@  discard block
 block discarded – undo
 
 		if (TestCase::isTestingEnv())
 		{
-			$CI =& get_instance();
+			$CI = & get_instance();
 			$CI->output->set_header('Content-Type: '.$mime);
 			$CI->output->set_header('Content-Disposition: attachment; filename="'.$filename.'"');
 			$CI->output->set_header('Expires: 0');

Please login to merge, or discard this patch.

tests/_ci_phpunit_test/replacing/helpers/old/3.1.8-download_helper.php 1 patch

Spacing +2 added lines, -2 removed lines patch added patch discarded remove patch

@@ -72,7 +72,7 @@  discard block
 block discarded – undo
 			}
 
 			// Load the mime types
-			$mimes =& get_mimes();
+			$mimes = & get_mimes();
 
 			// Only change the default MIME if we can find one
 			if (isset($mimes[$extension]))
@@ -117,7 +117,7 @@  discard block
 block discarded – undo
 
 		if (TestCase::isTestingEnv())
 		{
-			$CI =& get_instance();
+			$CI = & get_instance();
 			$CI->output->set_header('Content-Type: '.$mime);
 			$CI->output->set_header('Content-Disposition: attachment; filename="'.$filename.'"');
 			$CI->output->set_header('Expires: 0');

Please login to merge, or discard this patch.

tests/_ci_phpunit_test/replacing/helpers/old/3.1.7-download_helper.php 1 patch

Spacing +2 added lines, -2 removed lines patch added patch discarded remove patch

@@ -72,7 +72,7 @@  discard block
 block discarded – undo
 			}
 
 			// Load the mime types
-			$mimes =& get_mimes();
+			$mimes = & get_mimes();
 
 			// Only change the default MIME if we can find one
 			if (isset($mimes[$extension]))
@@ -117,7 +117,7 @@  discard block
 block discarded – undo
 
 		if (TestCase::isTestingEnv())
 		{
-			$CI =& get_instance();
+			$CI = & get_instance();
 			$CI->output->set_header('Content-Type: '.$mime);
 			$CI->output->set_header('Content-Disposition: attachment; filename="'.$filename.'"');
 			$CI->output->set_header('Expires: 0');

Please login to merge, or discard this patch.

tests/_ci_phpunit_test/replacing/helpers/old/3.1.6-download_helper.php 1 patch

Spacing +2 added lines, -2 removed lines patch added patch discarded remove patch

@@ -72,7 +72,7 @@  discard block
 block discarded – undo
 			}
 
 			// Load the mime types
-			$mimes =& get_mimes();
+			$mimes = & get_mimes();
 
 			// Only change the default MIME if we can find one
 			if (isset($mimes[$extension]))
@@ -117,7 +117,7 @@  discard block
 block discarded – undo
 
 		if (TestCase::isTestingEnv())
 		{
-			$CI =& get_instance();
+			$CI = & get_instance();
 			$CI->output->set_header('Content-Type: '.$mime);
 			$CI->output->set_header('Content-Disposition: attachment; filename="'.$filename.'"');
 			$CI->output->set_header('Expires: 0');

Please login to merge, or discard this patch.

application/tests/_ci_phpunit_test/replacing/helpers/download_helper.php 1 patch

Spacing +2 added lines, -2 removed lines patch added patch discarded remove patch

@@ -72,7 +72,7 @@  discard block
 block discarded – undo
 			}
 
 			// Load the mime types
-			$mimes =& get_mimes();
+			$mimes = & get_mimes();
 
 			// Only change the default MIME if we can find one
 			if (isset($mimes[$extension]))
@@ -117,7 +117,7 @@  discard block
 block discarded – undo
 
 		if (TestCase::isTestingEnv())
 		{
-			$CI =& get_instance();
+			$CI = & get_instance();
 			$CI->output->set_header('Content-Type: '.$mime);
 			$CI->output->set_header('Content-Disposition: attachment; filename="'.$filename.'"');
 			$CI->output->set_header('Expires: 0');

Please login to merge, or discard this patch.

		@@ -72,7 +72,7 @@ discard block
		block discarded – undo
72	72	}
73	73
74	74	// Load the mime types
75		- $mimes =& get_mimes();
	75	+ $mimes = & get_mimes();
76	76
77	77	// Only change the default MIME if we can find one
78	78	if (isset($mimes[$extension]))
		@@ -117,7 +117,7 @@ discard block
		block discarded – undo
117	117
118	118	if (TestCase::isTestingEnv())
119	119	{
120		- $CI =& get_instance();
	120	+ $CI = & get_instance();
121	121	$CI->output->set_header('Content-Type: '.$mime);
122	122	$CI->output->set_header('Content-Disposition: attachment; filename="'.$filename.'"');
123	123	$CI->output->set_header('Expires: 0');

		@@ -72,7 +72,7 @@ discard block
		block discarded – undo
72	72	}
73	73
74	74	// Load the mime types
75		- $mimes =& get_mimes();
	75	+ $mimes = & get_mimes();
76	76
77	77	// Only change the default MIME if we can find one
78	78	if (isset($mimes[$extension]))
		@@ -117,7 +117,7 @@ discard block
		block discarded – undo
117	117
118	118	if (TestCase::isTestingEnv())
119	119	{
120		- $CI =& get_instance();
	120	+ $CI = & get_instance();
121	121	$CI->output->set_header('Content-Type: '.$mime);
122	122	$CI->output->set_header('Content-Disposition: attachment; filename="'.$filename.'"');
123	123	$CI->output->set_header('Expires: 0');

		@@ -72,7 +72,7 @@ discard block
		block discarded – undo
72	72	}
73	73
74	74	// Load the mime types
75		- $mimes =& get_mimes();
	75	+ $mimes = & get_mimes();
76	76
77	77	// Only change the default MIME if we can find one
78	78	if (isset($mimes[$extension]))
		@@ -117,7 +117,7 @@ discard block
		block discarded – undo
117	117
118	118	if (TestCase::isTestingEnv())
119	119	{
120		- $CI =& get_instance();
	120	+ $CI = & get_instance();
121	121	$CI->output->set_header('Content-Type: '.$mime);
122	122	$CI->output->set_header('Content-Disposition: attachment; filename="'.$filename.'"');
123	123	$CI->output->set_header('Expires: 0');

		@@ -72,7 +72,7 @@ discard block
		block discarded – undo
72	72	}
73	73
74	74	// Load the mime types
75		- $mimes =& get_mimes();
	75	+ $mimes = & get_mimes();
76	76
77	77	// Only change the default MIME if we can find one
78	78	if (isset($mimes[$extension]))
		@@ -117,7 +117,7 @@ discard block
		block discarded – undo
117	117
118	118	if (TestCase::isTestingEnv())
119	119	{
120		- $CI =& get_instance();
	120	+ $CI = & get_instance();
121	121	$CI->output->set_header('Content-Type: '.$mime);
122	122	$CI->output->set_header('Content-Disposition: attachment; filename="'.$filename.'"');
123	123	$CI->output->set_header('Expires: 0');

		@@ -72,7 +72,7 @@ discard block
		block discarded – undo
72	72	}
73	73
74	74	// Load the mime types
75		- $mimes =& get_mimes();
	75	+ $mimes = & get_mimes();
76	76
77	77	// Only change the default MIME if we can find one
78	78	if (isset($mimes[$extension]))
		@@ -117,7 +117,7 @@ discard block
		block discarded – undo
117	117
118	118	if (TestCase::isTestingEnv())
119	119	{
120		- $CI =& get_instance();
	120	+ $CI = & get_instance();
121	121	$CI->output->set_header('Content-Type: '.$mime);
122	122	$CI->output->set_header('Content-Disposition: attachment; filename="'.$filename.'"');
123	123	$CI->output->set_header('Expires: 0');

		@@ -69,28 +69,28 @@
		block discarded – undo
69	69	*/
70	70	switch (ENVIRONMENT)
71	71	{
72		- case 'testing':
73		- case 'development':
74		- error_reporting(-1);
75		- ini_set('display_errors', 1);
76		- break;
77		-
78		- case 'production':
79		- ini_set('display_errors', 0);
80		- if (version_compare(PHP_VERSION, '5.3', '>='))
81		- {
82		- error_reporting(E_ALL & ~E_NOTICE & ~E_DEPRECATED & ~E_STRICT & ~E_USER_NOTICE & ~E_USER_DEPRECATED);
83		- }
84		- else
85		- {
86		- error_reporting(E_ALL & ~E_NOTICE & ~E_STRICT & ~E_USER_NOTICE);
87		- }
88		- break;
89		-
90		- default:
91		- header('HTTP/1.1 503 Service Unavailable.', TRUE, 503);
92		- echo 'The application environment is not set correctly.';
93		- exit(1); // EXIT_ERROR
	72	+ case 'testing':
	73	+ case 'development':
	74	+ error_reporting(-1);
	75	+ ini_set('display_errors', 1);
	76	+ break;
	77	+
	78	+ case 'production':
	79	+ ini_set('display_errors', 0);
	80	+ if (version_compare(PHP_VERSION, '5.3', '>='))
	81	+ {
	82	+ error_reporting(E_ALL & ~E_NOTICE & ~E_DEPRECATED & ~E_STRICT & ~E_USER_NOTICE & ~E_USER_DEPRECATED);
	83	+ }
	84	+ else
	85	+ {
	86	+ error_reporting(E_ALL & ~E_NOTICE & ~E_STRICT & ~E_USER_NOTICE);
	87	+ }
	88	+ break;
	89	+
	90	+ default:
	91	+ header('HTTP/1.1 503 Service Unavailable.', TRUE, 503);
	92	+ echo 'The application environment is not set correctly.';
	93	+ exit(1); // EXIT_ERROR
94	94	}
95	95
96	96	/*

kenjis / ci-phpunit-test

Push — master ( 3c4c47...76c067 )

Status

Category

Switch Indentation +22 added lines, -22 removed lines patch added patch discarded remove patch

Spacing +2 added lines, -2 removed lines patch added patch discarded remove patch

Spacing +2 added lines, -2 removed lines patch added patch discarded remove patch

Spacing +2 added lines, -2 removed lines patch added patch discarded remove patch

Spacing +2 added lines, -2 removed lines patch added patch discarded remove patch

Spacing +2 added lines, -2 removed lines patch added patch discarded remove patch