Completed
Pull Request — master (#291)
by Kenji
05:34
created
tests/_ci_phpunit_test/replacing/helpers/old/3.1.7-url_helper.php 2 patches
Spacing   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -105,7 +105,7 @@
 block discarded – undo
105 105
 				ob_end_clean();
106 106
 			}
107 107
 
108
-			throw new CIPHPUnitTestRedirectException('Redirect to ' . $uri, $code);
108
+			throw new CIPHPUnitTestRedirectException('Redirect to '.$uri, $code);
109 109
 		}
110 110
 	}
111 111
 }
Please login to merge, or discard this patch.
Braces   +3 added lines, -6 removed lines patch added patch discarded remove patch
@@ -63,16 +63,14 @@  discard block
 block discarded – undo
63 63
 		if ($method === 'auto' && isset($_SERVER['SERVER_SOFTWARE']) && strpos($_SERVER['SERVER_SOFTWARE'], 'Microsoft-IIS') !== FALSE)
64 64
 		{
65 65
 			$method = 'refresh';
66
-		}
67
-		elseif ($method !== 'refresh' && (empty($code) OR ! is_numeric($code)))
66
+		} elseif ($method !== 'refresh' && (empty($code) OR ! is_numeric($code)))
68 67
 		{
69 68
 			if (isset($_SERVER['SERVER_PROTOCOL'], $_SERVER['REQUEST_METHOD']) && $_SERVER['SERVER_PROTOCOL'] === 'HTTP/1.1')
70 69
 			{
71 70
 				$code = ($_SERVER['REQUEST_METHOD'] !== 'GET')
72 71
 					? 303	// reference: http://en.wikipedia.org/wiki/Post/Redirect/Get
73 72
 					: 307;
74
-			}
75
-			else
73
+			} else
76 74
 			{
77 75
 				$code = 302;
78 76
 			}
@@ -97,8 +95,7 @@  discard block
 block discarded – undo
97 95
 		if (ENVIRONMENT !== 'testing')
98 96
 		{
99 97
 			exit;
100
-		}
101
-		else
98
+		} else
102 99
 		{
103 100
 			while (ob_get_level() > 1)
104 101
 			{
Please login to merge, or discard this patch.
tests/_ci_phpunit_test/replacing/helpers/old/3.1.7-download_helper.php 2 patches
Spacing   +2 added lines, -2 removed lines patch added patch discarded remove patch
@@ -101,7 +101,7 @@  discard block
 block discarded – undo
101 101
 			}
102 102
 
103 103
 			// Load the mime types
104
-			$mimes =& get_mimes();
104
+			$mimes = & get_mimes();
105 105
 
106 106
 			// Only change the default MIME if we can find one
107 107
 			if (isset($mimes[$extension]))
@@ -146,7 +146,7 @@  discard block
 block discarded – undo
146 146
 
147 147
 		if (ENVIRONMENT === 'testing')
148 148
 		{
149
-			$CI =& get_instance();
149
+			$CI = & get_instance();
150 150
 			$CI->output->set_header('Content-Type: '.$mime);
151 151
 			$CI->output->set_header('Content-Disposition: attachment; filename="'.$filename.'"');
152 152
 			$CI->output->set_header('Expires: 0');
Please login to merge, or discard this patch.
Braces   +4 added lines, -8 removed lines patch added patch discarded remove patch
@@ -67,8 +67,7 @@  discard block
 block discarded – undo
67 67
 		if ($filename === '' OR $data === '')
68 68
 		{
69 69
 			return;
70
-		}
71
-		elseif ($data === NULL)
70
+		} elseif ($data === NULL)
72 71
 		{
73 72
 			if ( ! @is_file($filename) OR ($filesize = @filesize($filename)) === FALSE)
74 73
 			{
@@ -78,8 +77,7 @@  discard block
 block discarded – undo
78 77
 			$filepath = $filename;
79 78
 			$filename = explode('/', str_replace(DIRECTORY_SEPARATOR, '/', $filename));
80 79
 			$filename = end($filename);
81
-		}
82
-		else
80
+		} else
83 81
 		{
84 82
 			$filesize = strlen($data);
85 83
 		}
@@ -158,8 +156,7 @@  discard block
 block discarded – undo
158 156
 			if (ENVIRONMENT !== 'testing')
159 157
 			{
160 158
 				exit($data);
161
-			}
162
-			else
159
+			} else
163 160
 			{
164 161
 				echo($data);
165 162
 				throw new CIPHPUnitTestExitException('exit() from force_download()');
@@ -176,8 +173,7 @@  discard block
 block discarded – undo
176 173
 		if (ENVIRONMENT !== 'testing')
177 174
 		{
178 175
 			exit;
179
-		}
180
-		else
176
+		} else
181 177
 		{
182 178
 			throw new CIPHPUnitTestExitException('exit() from force_download()');
183 179
 		}
Please login to merge, or discard this patch.
application/tests/_ci_phpunit_test/replacing/core/old/3.1.7-CodeIgniter.php 2 patches
Spacing   +11 added lines, -11 removed lines patch added patch discarded remove patch
@@ -185,7 +185,7 @@  discard block
 block discarded – undo
185 185
  *  Start the timer... tick tock tick tock...
186 186
  * ------------------------------------------------------
187 187
  */
188
-	$BM =& load_class('Benchmark', 'core');
188
+	$BM = & load_class('Benchmark', 'core');
189 189
 	CIPHPUnitTestSuperGlobal::set_Global('BM', $BM);
190 190
 	$BM->mark('total_execution_time_start');
191 191
 	$BM->mark('loading_time:_base_classes_start');
@@ -195,7 +195,7 @@  discard block
 block discarded – undo
195 195
  *  Instantiate the hooks class
196 196
  * ------------------------------------------------------
197 197
  */
198
-	$EXT =& load_class('Hooks', 'core');
198
+	$EXT = & load_class('Hooks', 'core');
199 199
 	CIPHPUnitTestSuperGlobal::set_Global('EXT', $EXT);
200 200
 
201 201
 /*
@@ -215,7 +215,7 @@  discard block
 block discarded – undo
215 215
  * depending on another class that uses it.
216 216
  *
217 217
  */
218
-	$CFG =& load_class('Config', 'core');
218
+	$CFG = & load_class('Config', 'core');
219 219
 	CIPHPUnitTestSuperGlobal::set_Global('CFG', $CFG);
220 220
 
221 221
 	// Do we have any manually set config items in the index.php file?
@@ -294,7 +294,7 @@  discard block
 block discarded – undo
294 294
  *  Instantiate the UTF-8 class
295 295
  * ------------------------------------------------------
296 296
  */
297
-	$UNI =& load_class('Utf8', 'core');
297
+	$UNI = & load_class('Utf8', 'core');
298 298
 	CIPHPUnitTestSuperGlobal::set_Global('UNI', $UNI);
299 299
 
300 300
 /*
@@ -302,7 +302,7 @@  discard block
 block discarded – undo
302 302
  *  Instantiate the URI class
303 303
  * ------------------------------------------------------
304 304
  */
305
-	$URI =& load_class('URI', 'core');
305
+	$URI = & load_class('URI', 'core');
306 306
 	CIPHPUnitTestSuperGlobal::set_Global('URI', $URI);
307 307
 
308 308
 /*
@@ -310,7 +310,7 @@  discard block
 block discarded – undo
310 310
  *  Instantiate the routing class and set the routing
311 311
  * ------------------------------------------------------
312 312
  */
313
-	$RTR =& load_class('Router', 'core', isset($routing) ? $routing : NULL);
313
+	$RTR = & load_class('Router', 'core', isset($routing) ? $routing : NULL);
314 314
 	CIPHPUnitTestSuperGlobal::set_Global('RTR', $RTR);
315 315
 
316 316
 /*
@@ -318,7 +318,7 @@  discard block
 block discarded – undo
318 318
  *  Instantiate the output class
319 319
  * ------------------------------------------------------
320 320
  */
321
-	$OUT =& load_class('Output', 'core');
321
+	$OUT = & load_class('Output', 'core');
322 322
 	CIPHPUnitTestSuperGlobal::set_Global('OUT', $OUT);
323 323
 
324 324
 /*
@@ -336,7 +336,7 @@  discard block
 block discarded – undo
336 336
  * Load the security class for xss and csrf support
337 337
  * -----------------------------------------------------
338 338
  */
339
-	$SEC =& load_class('Security', 'core');
339
+	$SEC = & load_class('Security', 'core');
340 340
 	CIPHPUnitTestSuperGlobal::set_Global('SEC', $SEC);
341 341
 
342 342
 /*
@@ -344,7 +344,7 @@  discard block
 block discarded – undo
344 344
  *  Load the Input class and sanitize globals
345 345
  * ------------------------------------------------------
346 346
  */
347
-	$IN	=& load_class('Input', 'core');
347
+	$IN = & load_class('Input', 'core');
348 348
 	CIPHPUnitTestSuperGlobal::set_Global('IN', $IN);
349 349
 
350 350
 /*
@@ -352,7 +352,7 @@  discard block
 block discarded – undo
352 352
  *  Load the Language class
353 353
  * ------------------------------------------------------
354 354
  */
355
-	$LANG =& load_class('Lang', 'core');
355
+	$LANG = & load_class('Lang', 'core');
356 356
 	CIPHPUnitTestSuperGlobal::set_Global('LANG', $LANG);
357 357
 
358 358
 /*
@@ -375,7 +375,7 @@  discard block
 block discarded – undo
375 375
 	 */
376 376
 	function &get_instance()
377 377
 	{
378
-		if (! CIPHPUnitTest::wiredesignzHmvcInstalled())
378
+		if ( ! CIPHPUnitTest::wiredesignzHmvcInstalled())
379 379
 		{
380 380
 			return CI_Controller::get_instance();
381 381
 		}
Please login to merge, or discard this patch.
Braces   +10 added lines, -20 removed lines patch added patch discarded remove patch
@@ -169,12 +169,10 @@  discard block
 block discarded – undo
169 169
 			file_exists(APPPATH.'vendor/autoload.php')
170 170
 				? require_once(APPPATH.'vendor/autoload.php')
171 171
 				: log_message('error', '$config[\'composer_autoload\'] is set to TRUE but '.APPPATH.'vendor/autoload.php was not found.');
172
-		}
173
-		elseif (file_exists($composer_autoload))
172
+		} elseif (file_exists($composer_autoload))
174 173
 		{
175 174
 			require_once($composer_autoload);
176
-		}
177
-		else
175
+		} else
178 176
 		{
179 177
 			log_message('error', 'Could not find the specified $config[\'composer_autoload\'] path: '.$composer_autoload);
180 178
 		}
@@ -253,8 +251,7 @@  discard block
 block discarded – undo
253 251
 		// This is required for mb_convert_encoding() to strip invalid characters.
254 252
 		// That's utilized by CI_Utf8, but it's also done for consistency with iconv.
255 253
 		mb_substitute_character('none');
256
-	}
257
-	else
254
+	} else
258 255
 	{
259 256
 		define('MB_ENABLED', FALSE);
260 257
 	}
@@ -267,8 +264,7 @@  discard block
 block discarded – undo
267 264
 		// iconv.internal_encoding is deprecated starting with PHP 5.6
268 265
 		// and it's usage triggers E_DEPRECATED messages.
269 266
 		@ini_set('iconv.internal_encoding', $charset);
270
-	}
271
-	else
267
+	} else
272 268
 	{
273 269
 		define('ICONV_ENABLED', FALSE);
274 270
 	}
@@ -378,8 +374,7 @@  discard block
 block discarded – undo
378 374
 		if (! CIPHPUnitTest::wiredesignzHmvcInstalled())
379 375
 		{
380 376
 			return CI_Controller::get_instance();
381
-		}
382
-		else
377
+		} else
383 378
 		{
384 379
 			return CI::$APP;
385 380
 		}
@@ -424,21 +419,18 @@  discard block
 block discarded – undo
424 419
 	if (empty($class) OR ! file_exists(APPPATH.'controllers/'.$RTR->directory.$class.'.php'))
425 420
 	{
426 421
 		$e404 = TRUE;
427
-	}
428
-	else
422
+	} else
429 423
 	{
430 424
 		require_once(APPPATH.'controllers/'.$RTR->directory.$class.'.php');
431 425
 
432 426
 		if ( ! class_exists($class, FALSE) OR $method[0] === '_' OR method_exists('CI_Controller', $method))
433 427
 		{
434 428
 			$e404 = TRUE;
435
-		}
436
-		elseif (method_exists($class, '_remap'))
429
+		} elseif (method_exists($class, '_remap'))
437 430
 		{
438 431
 			$params = array($method, array_slice($URI->rsegments, 2));
439 432
 			$method = '_remap';
440
-		}
441
-		elseif ( ! method_exists($class, $method))
433
+		} elseif ( ! method_exists($class, $method))
442 434
 		{
443 435
 			$e404 = TRUE;
444 436
 		}
@@ -490,8 +482,7 @@  discard block
 block discarded – undo
490 482
 						$RTR->directory = '';
491 483
 					}
492 484
 				}
493
-			}
494
-			else
485
+			} else
495 486
 			{
496 487
 				$e404 = FALSE;
497 488
 			}
@@ -507,8 +498,7 @@  discard block
 block discarded – undo
507 498
 				1 => $class,
508 499
 				2 => $method
509 500
 			);
510
-		}
511
-		else
501
+		} else
512 502
 		{
513 503
 			show_404($RTR->directory.$class.'/'.$method);
514 504
 		}
Please login to merge, or discard this patch.
application/tests/_ci_phpunit_test/replacing/core/old/3.1.7-Output.php 2 patches
Spacing   +11 added lines, -11 removed lines patch added patch discarded remove patch
@@ -76,7 +76,7 @@  discard block
 block discarded – undo
76 76
 	 *
77 77
 	 * @var	array
78 78
 	 */
79
-	public $mimes =	array();
79
+	public $mimes = array();
80 80
 
81 81
 	/**
82 82
 	 * Mime-type for the current page
@@ -111,7 +111,7 @@  discard block
 block discarded – undo
111 111
 	 *
112 112
 	 * @var	array
113 113
 	 */
114
-	protected $_profiler_sections =	array();
114
+	protected $_profiler_sections = array();
115 115
 
116 116
 	/**
117 117
 	 * Parse markers flag
@@ -166,7 +166,7 @@  discard block
 block discarded – undo
166 166
 		isset(self::$func_overload) OR self::$func_overload = (extension_loaded('mbstring') && ini_get('mbstring.func_overload'));
167 167
 
168 168
 		// Get mime types for later
169
-		$this->mimes =& get_mimes();
169
+		$this->mimes = & get_mimes();
170 170
 
171 171
 		log_message('info', 'Output Class Initialized');
172 172
 	}
@@ -264,7 +264,7 @@  discard block
 block discarded – undo
264 264
 			// Is this extension supported?
265 265
 			if (isset($this->mimes[$extension]))
266 266
 			{
267
-				$mime_type =& $this->mimes[$extension];
267
+				$mime_type = & $this->mimes[$extension];
268 268
 
269 269
 				if (is_array($mime_type))
270 270
 				{
@@ -334,7 +334,7 @@  discard block
 block discarded – undo
334 334
 		{
335 335
 			if (strncasecmp($header, $headers[$c], $l = self::strlen($header)) === 0)
336 336
 			{
337
-				return trim(self::substr($headers[$c], $l+1));
337
+				return trim(self::substr($headers[$c], $l + 1));
338 338
 			}
339 339
 		}
340 340
 
@@ -437,13 +437,13 @@  discard block
 block discarded – undo
437 437
 		// Note:  We use load_class() because we can't use $CI =& get_instance()
438 438
 		// since this function is sometimes called by the caching mechanism,
439 439
 		// which happens before the CI super object is available.
440
-		$BM =& load_class('Benchmark', 'core');
441
-		$CFG =& load_class('Config', 'core');
440
+		$BM = & load_class('Benchmark', 'core');
441
+		$CFG = & load_class('Config', 'core');
442 442
 
443 443
 		// Grab the super object if we can.
444 444
 		if (class_exists('CI_Controller', FALSE))
445 445
 		{
446
-			$CI =& get_instance();
446
+			$CI = & get_instance();
447 447
 		}
448 448
 
449 449
 		// --------------------------------------------------------------------
@@ -451,7 +451,7 @@  discard block
 block discarded – undo
451 451
 		// Set the output data
452 452
 		if ($output === '')
453 453
 		{
454
-			$output =& $this->final_output;
454
+			$output = & $this->final_output;
455 455
 		}
456 456
 
457 457
 		// --------------------------------------------------------------------
@@ -572,7 +572,7 @@  discard block
 block discarded – undo
572 572
 	 */
573 573
 	public function _write_cache($output)
574 574
 	{
575
-		$CI =& get_instance();
575
+		$CI = & get_instance();
576 576
 		$path = $CI->config->item('cache_path');
577 577
 		$cache_path = ($path === '') ? APPPATH.'cache/' : $path;
578 578
 
@@ -751,7 +751,7 @@  discard block
 block discarded – undo
751 751
 	 */
752 752
 	public function delete_cache($uri = '')
753 753
 	{
754
-		$CI =& get_instance();
754
+		$CI = & get_instance();
755 755
 		$cache_path = $CI->config->item('cache_path');
756 756
 		if ($cache_path === '')
757 757
 		{
Please login to merge, or discard this patch.
Braces   +5 added lines, -10 removed lines patch added patch discarded remove patch
@@ -511,8 +511,7 @@  discard block
 block discarded – undo
511 511
 				{
512 512
 //					header('Content-Encoding: gzip');
513 513
 //					header('Content-Length: '.self::strlen($output));
514
-				}
515
-				else
514
+				} else
516 515
 				{
517 516
 					// User agent doesn't support gzip compression,
518 517
 					// so we'll have to decompress our cache
@@ -552,8 +551,7 @@  discard block
 block discarded – undo
552 551
 		if (method_exists($CI, '_output'))
553 552
 		{
554 553
 			$CI->_output($output);
555
-		}
556
-		else
554
+		} else
557 555
 		{
558 556
 			echo $output; // Send it to the browser!
559 557
 		}
@@ -591,8 +589,7 @@  discard block
 block discarded – undo
591 589
 			if (is_array($cache_query_string))
592 590
 			{
593 591
 				$uri .= '?'.http_build_query(array_intersect_key($_GET, array_flip($cache_query_string)));
594
-			}
595
-			else
592
+			} else
596 593
 			{
597 594
 				$uri .= '?'.$_SERVER['QUERY_STRING'];
598 595
 			}
@@ -685,8 +682,7 @@  discard block
 block discarded – undo
685 682
 			if (is_array($cache_query_string))
686 683
 			{
687 684
 				$uri .= '?'.http_build_query(array_intersect_key($_GET, array_flip($cache_query_string)));
688
-			}
689
-			else
685
+			} else
690 686
 			{
691 687
 				$uri .= '?'.$_SERVER['QUERY_STRING'];
692 688
 			}
@@ -773,8 +769,7 @@  discard block
 block discarded – undo
773 769
 				if (is_array($cache_query_string))
774 770
 				{
775 771
 					$uri .= '?'.http_build_query(array_intersect_key($_GET, array_flip($cache_query_string)));
776
-				}
777
-				else
772
+				} else
778 773
 				{
779 774
 					$uri .= '?'.$_SERVER['QUERY_STRING'];
780 775
 				}
Please login to merge, or discard this patch.
application/tests/_ci_phpunit_test/replacing/libraries/old/3.1.7-Upload.php 2 patches
Spacing   +13 added lines, -13 removed lines patch added patch discarded remove patch
@@ -293,8 +293,8 @@  discard block
 block discarded – undo
293 293
 	{
294 294
 		empty($config) OR $this->initialize($config, FALSE);
295 295
 
296
-		$this->_mimes =& get_mimes();
297
-		$this->_CI =& get_instance();
296
+		$this->_mimes = & get_mimes();
297
+		$this->_CI = & get_instance();
298 298
 
299 299
 		log_message('info', 'Upload Class Initialized');
300 300
 	}
@@ -480,7 +480,7 @@  discard block
 block discarded – undo
480 480
 			else
481 481
 			{
482 482
 				// An extension was provided, let's have it!
483
-				$this->file_ext	= $this->get_extension($this->_file_name_override);
483
+				$this->file_ext = $this->get_extension($this->_file_name_override);
484 484
 			}
485 485
 
486 486
 			if ( ! $this->is_allowed_filetype(TRUE))
@@ -493,7 +493,7 @@  discard block
 block discarded – undo
493 493
 		// Convert the file size to kilobytes
494 494
 		if ($this->file_size > 0)
495 495
 		{
496
-			$this->file_size = round($this->file_size/1024, 2);
496
+			$this->file_size = round($this->file_size / 1024, 2);
497 497
 		}
498 498
 
499 499
 		// Is the file size within the allowed maximum?
@@ -818,10 +818,10 @@  discard block
 block discarded – undo
818 818
 			{
819 819
 				$types = array(1 => 'gif', 2 => 'jpeg', 3 => 'png');
820 820
 
821
-				$this->image_width	= $D[0];
822
-				$this->image_height	= $D[1];
823
-				$this->image_type	= isset($types[$D[2]]) ? $types[$D[2]] : 'unknown';
824
-				$this->image_size_str	= $D[3]; // string containing height and width
821
+				$this->image_width = $D[0];
822
+				$this->image_height = $D[1];
823
+				$this->image_type = isset($types[$D[2]]) ? $types[$D[2]] : 'unknown';
824
+				$this->image_size_str = $D[3]; // string containing height and width
825 825
 			}
826 826
 		}
827 827
 
@@ -869,7 +869,7 @@  discard block
 block discarded – undo
869 869
 			$this->file_type = 'image/jpeg';
870 870
 		}
871 871
 
872
-		$img_mimes = array('image/gif',	'image/jpeg', 'image/png');
872
+		$img_mimes = array('image/gif', 'image/jpeg', 'image/png');
873 873
 
874 874
 		return in_array($this->file_type, $img_mimes, TRUE);
875 875
 	}
@@ -1011,7 +1011,7 @@  discard block
 block discarded – undo
1011 1011
 			return FALSE;
1012 1012
 		}
1013 1013
 
1014
-		$this->upload_path = preg_replace('/(.+?)\/*$/', '\\1/',  $this->upload_path);
1014
+		$this->upload_path = preg_replace('/(.+?)\/*$/', '\\1/', $this->upload_path);
1015 1015
 		return TRUE;
1016 1016
 	}
1017 1017
 
@@ -1055,9 +1055,9 @@  discard block
 block discarded – undo
1055 1055
 		$ext = '';
1056 1056
 		if (strpos($filename, '.') !== FALSE)
1057 1057
 		{
1058
-			$parts		= explode('.', $filename);
1059
-			$ext		= '.'.array_pop($parts);
1060
-			$filename	= implode('.', $parts);
1058
+			$parts = explode('.', $filename);
1059
+			$ext = '.'.array_pop($parts);
1060
+			$filename = implode('.', $parts);
1061 1061
 		}
1062 1062
 
1063 1063
 		return substr($filename, 0, ($length - strlen($ext))).$ext;
Please login to merge, or discard this patch.
Braces   +20 added lines, -17 removed lines patch added patch discarded remove patch
@@ -331,19 +331,16 @@  discard block
 block discarded – undo
331 331
 					if ($reflection->hasMethod('set_'.$key))
332 332
 					{
333 333
 						$this->{'set_'.$key}($config[$key]);
334
-					}
335
-					else
334
+					} else
336 335
 					{
337 336
 						$this->$key = $config[$key];
338 337
 					}
339
-				}
340
-				else
338
+				} else
341 339
 				{
342 340
 					$this->$key = $defaults[$key];
343 341
 				}
344 342
 			}
345
-		}
346
-		else
343
+		} else
347 344
 		{
348 345
 			foreach ($config as $key => &$value)
349 346
 			{
@@ -352,8 +349,7 @@  discard block
 block discarded – undo
352 349
 					if ($reflection->hasMethod('set_'.$key))
353 350
 					{
354 351
 						$this->{'set_'.$key}($value);
355
-					}
356
-					else
352
+					} else
357 353
 					{
358 354
 						$this->$key = $value;
359 355
 					}
@@ -415,9 +411,11 @@  discard block
 block discarded – undo
415 411
 		}
416 412
 
417 413
 		// Was the file able to be uploaded? If not, determine the reason why.
418
-		if ( ! file_exists($_file['tmp_name']))	// modified by ci-phpunit-test
414
+		if ( ! file_exists($_file['tmp_name'])) {
415
+			// modified by ci-phpunit-test
419 416
 		{
420 417
 			$error = isset($_file['error']) ? $_file['error'] : 4;
418
+		}
421 419
 
422 420
 			switch ($error)
423 421
 			{
@@ -482,8 +480,7 @@  discard block
 block discarded – undo
482 480
 			if (strpos($this->_file_name_override, '.') === FALSE)
483 481
 			{
484 482
 				$this->file_name .= $this->file_ext;
485
-			}
486
-			else
483
+			} else
487 484
 			{
488 485
 				// An extension was provided, let's have it!
489 486
 				$this->file_ext	= $this->get_extension($this->_file_name_override);
@@ -881,8 +878,7 @@  discard block
 block discarded – undo
881 878
 		if (in_array($this->file_type, $png_mimes))
882 879
 		{
883 880
 			$this->file_type = 'image/png';
884
-		}
885
-		elseif (in_array($this->file_type, $jpeg_mimes))
881
+		} elseif (in_array($this->file_type, $jpeg_mimes))
886 882
 		{
887 883
 			$this->file_type = 'image/jpeg';
888 884
 		}
@@ -1148,9 +1144,12 @@  discard block
 block discarded – undo
1148 1144
 
1149 1145
 		if (function_exists('getimagesize') && @getimagesize($file) !== FALSE)
1150 1146
 		{
1151
-			if (($file = @fopen($file, 'rb')) === FALSE) // "b" to force binary
1147
+			if (($file = @fopen($file, 'rb')) === FALSE) {
1148
+				// "b" to force binary
1152 1149
 			{
1153
-				return FALSE; // Couldn't open the file, return FALSE
1150
+				return FALSE;
1151
+			}
1152
+			// Couldn't open the file, return FALSE
1154 1153
 			}
1155 1154
 
1156 1155
 			$opening_bytes = fread($file, 256);
@@ -1269,9 +1268,11 @@  discard block
 block discarded – undo
1269 1268
 		if (function_exists('finfo_file'))
1270 1269
 		{
1271 1270
 			$finfo = @finfo_open(FILEINFO_MIME);
1272
-			if (is_resource($finfo)) // It is possible that a FALSE value is returned, if there is no magic MIME database file found on the system
1271
+			if (is_resource($finfo)) {
1272
+				// It is possible that a FALSE value is returned, if there is no magic MIME database file found on the system
1273 1273
 			{
1274 1274
 				$mime = @finfo_file($finfo, $file['tmp_name']);
1275
+			}
1275 1276
 				finfo_close($finfo);
1276 1277
 
1277 1278
 				/* According to the comments section of the PHP manual page,
@@ -1356,10 +1357,12 @@  discard block
 block discarded – undo
1356 1357
 		if (function_exists('mime_content_type'))
1357 1358
 		{
1358 1359
 			$this->file_type = @mime_content_type($file['tmp_name']);
1359
-			if (strlen($this->file_type) > 0) // It's possible that mime_content_type() returns FALSE or an empty string
1360
+			if (strlen($this->file_type) > 0) {
1361
+				// It's possible that mime_content_type() returns FALSE or an empty string
1360 1362
 			{
1361 1363
 				return;
1362 1364
 			}
1365
+			}
1363 1366
 		}
1364 1367
 
1365 1368
 		$this->file_type = $file['type'];
Please login to merge, or discard this patch.
lib/Installer.php 2 patches
Spacing   +10 added lines, -10 removed lines patch added patch discarded remove patch
@@ -29,7 +29,7 @@  discard block
 block discarded – undo
29 29
         }
30 30
 
31 31
         for ($i = 1; $i <= $argc; $i++) {
32
-            if (! isset($argv[$i])) {
32
+            if ( ! isset($argv[$i])) {
33 33
                 break;
34 34
             }
35 35
 
@@ -41,20 +41,20 @@  discard block
 block discarded – undo
41 41
 
42 42
                 // php install.php -a application
43 43
                 case '-a':
44
-                    if (is_dir($argv[$i+1])) {
45
-                        $this->app_dir = $argv[$i+1];
44
+                    if (is_dir($argv[$i + 1])) {
45
+                        $this->app_dir = $argv[$i + 1];
46 46
                     } else {
47
-                        throw new Exception('No such directory: '.$argv[$i+1]);
47
+                        throw new Exception('No such directory: '.$argv[$i + 1]);
48 48
                     }
49 49
                     $i++;
50 50
                     break;
51 51
 
52 52
                 // php install.php -p public
53 53
                 case '-p':
54
-                    if (is_dir($argv[$i+1])) {
55
-                        $this->pub_dir = $argv[$i+1];
54
+                    if (is_dir($argv[$i + 1])) {
55
+                        $this->pub_dir = $argv[$i + 1];
56 56
                     } else {
57
-                        throw new Exception('No such directory: '.$argv[$i+1]);
57
+                        throw new Exception('No such directory: '.$argv[$i + 1]);
58 58
                     }
59 59
                     $i++;
60 60
                     break;
@@ -82,7 +82,7 @@  discard block
 block discarded – undo
82 82
         $file = $this->app_dir.'/'.$this->test_dir.'/Bootstrap.php';
83 83
         $contents = file_get_contents($file);
84 84
 
85
-        if (! file_exists('system')) {
85
+        if ( ! file_exists('system')) {
86 86
             if (file_exists('vendor/codeigniter/framework/system')) {
87 87
                 $contents = str_replace(
88 88
                     '$system_path = \'../../system\';',
@@ -94,7 +94,7 @@  discard block
 block discarded – undo
94 94
             }
95 95
         }
96 96
 
97
-        if (! file_exists('index.php')) {
97
+        if ( ! file_exists('index.php')) {
98 98
             if (file_exists($this->pub_dir.'/index.php')) {
99 99
                 // CodeIgniter 3.0.6 and after
100 100
                 $contents = str_replace(
@@ -167,7 +167,7 @@  discard block
 block discarded – undo
167 167
             } else {
168 168
                 $success = copy($file, $dst.'/'.$iterator->getSubPathName());
169 169
                 if ($success) {
170
-                    if (! $this->silent) {
170
+                    if ( ! $this->silent) {
171 171
                         echo 'copied: '.$dst.'/'.$iterator->getSubPathName().PHP_EOL;
172 172
                     }
173 173
                 }
Please login to merge, or discard this patch.
Indentation   +187 added lines, -187 removed lines patch added patch discarded remove patch
@@ -10,191 +10,191 @@
 block discarded – undo
10 10
 
11 11
 class Installer
12 12
 {
13
-    private $silent = false;
14
-    private $app_dir = 'application';
15
-    private $pub_dir = 'public';
16
-    private $test_dir = 'tests';
17
-
18
-    public function __construct($argv)
19
-    {
20
-        $this->parse_args($argv);
21
-    }
22
-
23
-    private function parse_args($argv)
24
-    {
25
-        $argc = count($argv);
26
-
27
-        if ($argc === 1) {
28
-            return;
29
-        }
30
-
31
-        for ($i = 1; $i <= $argc; $i++) {
32
-            if (! isset($argv[$i])) {
33
-                break;
34
-            }
35
-
36
-            switch ($argv[$i]) {
37
-                // php install.php -s
38
-                case '-s':
39
-                    $this->silent = true;
40
-                    break;
41
-
42
-                // php install.php -a application
43
-                case '-a':
44
-                    if (is_dir($argv[$i+1])) {
45
-                        $this->app_dir = $argv[$i+1];
46
-                    } else {
47
-                        throw new Exception('No such directory: '.$argv[$i+1]);
48
-                    }
49
-                    $i++;
50
-                    break;
51
-
52
-                // php install.php -p public
53
-                case '-p':
54
-                    if (is_dir($argv[$i+1])) {
55
-                        $this->pub_dir = $argv[$i+1];
56
-                    } else {
57
-                        throw new Exception('No such directory: '.$argv[$i+1]);
58
-                    }
59
-                    $i++;
60
-                    break;
61
-
62
-                default:
63
-                    throw new Exception('Unknown argument: '.$argv[$i]);
64
-            }
65
-        }
66
-    }
67
-
68
-    public function install()
69
-    {
70
-        $this->recursiveCopy(
71
-            dirname(dirname(__FILE__)).'/application/tests',
72
-            $this->app_dir.'/'.$this->test_dir
73
-        );
74
-        $this->fixPath();
75
-    }
76
-
77
-    /**
78
-     * Fix paths in Bootstrap.php
79
-     */
80
-    private function fixPath()
81
-    {
82
-        $file = $this->app_dir.'/'.$this->test_dir.'/Bootstrap.php';
83
-        $contents = file_get_contents($file);
84
-
85
-        if (! file_exists('system')) {
86
-            if (file_exists('vendor/codeigniter/framework/system')) {
87
-                $contents = str_replace(
88
-                    '$system_path = \'../../system\';',
89
-                    '$system_path = \'../../vendor/codeigniter/framework/system\';',
90
-                    $contents
91
-                );
92
-            } else {
93
-                throw new Exception('Can\'t find "system" folder.');
94
-            }
95
-        }
96
-
97
-        if (! file_exists('index.php')) {
98
-            if (file_exists($this->pub_dir.'/index.php')) {
99
-                // CodeIgniter 3.0.6 and after
100
-                $contents = str_replace(
101
-                    "define('FCPATH', realpath(dirname(__FILE__).'/../..').DIRECTORY_SEPARATOR);",
102
-                    "define('FCPATH', realpath(dirname(__FILE__).'/../../{$this->pub_dir}').DIRECTORY_SEPARATOR);",
103
-                    $contents
104
-                );
105
-                // CodeIgniter 3.0.5 and before
106
-                $contents = str_replace(
107
-                    "define('FCPATH', realpath(dirname(__FILE__).'/../..').'/');",
108
-                    "define('FCPATH', realpath(dirname(__FILE__).'/../../{$this->pub_dir}').'/');",
109
-                    $contents
110
-                );
111
-            } elseif (file_exists($this->app_dir.'/public/index.php')) {
112
-                // CodeIgniter 3.0.6 and after
113
-                $contents = str_replace(
114
-                    "define('FCPATH', realpath(dirname(__FILE__).'/../..').DIRECTORY_SEPARATOR);",
115
-                    "define('FCPATH', realpath(dirname(__FILE__).'/../public').DIRECTORY_SEPARATOR);",
116
-                    $contents
117
-                );
118
-                // CodeIgniter 3.0.5 and before
119
-                $contents = str_replace(
120
-                    "define('FCPATH', realpath(dirname(__FILE__).'/../..').'/');",
121
-                    "define('FCPATH', realpath(dirname(__FILE__).'/../public').'/');",
122
-                    $contents
123
-                );
124
-                if ($this->app_dir !== 'application') {
125
-                    $contents = str_replace(
126
-                        "\$application_folder = '../../application';",
127
-                        "\$application_folder = '../../{$this->app_dir}';",
128
-                        $contents
129
-                    );
130
-                }
131
-            } else {
132
-                throw new Exception('Can\'t find "index.php".');
133
-            }
134
-        }
135
-
136
-        file_put_contents($file, $contents);
137
-    }
138
-
139
-    public function update()
140
-    {
141
-        $target_dir = $this->app_dir.'/'.$this->test_dir.'/_ci_phpunit_test';
142
-        $this->recursiveUnlink($target_dir);
143
-        $this->recursiveCopy(
144
-            dirname(dirname(__FILE__)).'/application/tests/_ci_phpunit_test',
145
-            $target_dir
146
-        );
147
-    }
148
-
149
-    /**
150
-     * Recursive Copy
151
-     *
152
-     * @param string $src
153
-     * @param string $dst
154
-     */
155
-    private function recursiveCopy($src, $dst)
156
-    {
157
-        @mkdir($dst, 0755);
158
-
159
-        $iterator = new \RecursiveIteratorIterator(
160
-            new \RecursiveDirectoryIterator($src, \RecursiveDirectoryIterator::SKIP_DOTS),
161
-            \RecursiveIteratorIterator::SELF_FIRST
162
-        );
163
-
164
-        foreach ($iterator as $file) {
165
-            if ($file->isDir()) {
166
-                @mkdir($dst.'/'.$iterator->getSubPathName());
167
-            } else {
168
-                $success = copy($file, $dst.'/'.$iterator->getSubPathName());
169
-                if ($success) {
170
-                    if (! $this->silent) {
171
-                        echo 'copied: '.$dst.'/'.$iterator->getSubPathName().PHP_EOL;
172
-                    }
173
-                }
174
-            }
175
-        }
176
-    }
177
-
178
-    /**
179
-     * Recursive Unlink
180
-     *
181
-     * @param string $dir
182
-     */
183
-    private function recursiveUnlink($dir)
184
-    {
185
-        $iterator = new \RecursiveIteratorIterator(
186
-            new \RecursiveDirectoryIterator($dir, \RecursiveDirectoryIterator::SKIP_DOTS),
187
-            \RecursiveIteratorIterator::CHILD_FIRST
188
-        );
189
-
190
-        foreach ($iterator as $file) {
191
-            if ($file->isDir()) {
192
-                rmdir($file);
193
-            } else {
194
-                unlink($file);
195
-            }
196
-        }
197
-
198
-        rmdir($dir);
199
-    }
13
+	private $silent = false;
14
+	private $app_dir = 'application';
15
+	private $pub_dir = 'public';
16
+	private $test_dir = 'tests';
17
+
18
+	public function __construct($argv)
19
+	{
20
+		$this->parse_args($argv);
21
+	}
22
+
23
+	private function parse_args($argv)
24
+	{
25
+		$argc = count($argv);
26
+
27
+		if ($argc === 1) {
28
+			return;
29
+		}
30
+
31
+		for ($i = 1; $i <= $argc; $i++) {
32
+			if (! isset($argv[$i])) {
33
+				break;
34
+			}
35
+
36
+			switch ($argv[$i]) {
37
+				// php install.php -s
38
+				case '-s':
39
+					$this->silent = true;
40
+					break;
41
+
42
+				// php install.php -a application
43
+				case '-a':
44
+					if (is_dir($argv[$i+1])) {
45
+						$this->app_dir = $argv[$i+1];
46
+					} else {
47
+						throw new Exception('No such directory: '.$argv[$i+1]);
48
+					}
49
+					$i++;
50
+					break;
51
+
52
+				// php install.php -p public
53
+				case '-p':
54
+					if (is_dir($argv[$i+1])) {
55
+						$this->pub_dir = $argv[$i+1];
56
+					} else {
57
+						throw new Exception('No such directory: '.$argv[$i+1]);
58
+					}
59
+					$i++;
60
+					break;
61
+
62
+				default:
63
+					throw new Exception('Unknown argument: '.$argv[$i]);
64
+			}
65
+		}
66
+	}
67
+
68
+	public function install()
69
+	{
70
+		$this->recursiveCopy(
71
+			dirname(dirname(__FILE__)).'/application/tests',
72
+			$this->app_dir.'/'.$this->test_dir
73
+		);
74
+		$this->fixPath();
75
+	}
76
+
77
+	/**
78
+	 * Fix paths in Bootstrap.php
79
+	 */
80
+	private function fixPath()
81
+	{
82
+		$file = $this->app_dir.'/'.$this->test_dir.'/Bootstrap.php';
83
+		$contents = file_get_contents($file);
84
+
85
+		if (! file_exists('system')) {
86
+			if (file_exists('vendor/codeigniter/framework/system')) {
87
+				$contents = str_replace(
88
+					'$system_path = \'../../system\';',
89
+					'$system_path = \'../../vendor/codeigniter/framework/system\';',
90
+					$contents
91
+				);
92
+			} else {
93
+				throw new Exception('Can\'t find "system" folder.');
94
+			}
95
+		}
96
+
97
+		if (! file_exists('index.php')) {
98
+			if (file_exists($this->pub_dir.'/index.php')) {
99
+				// CodeIgniter 3.0.6 and after
100
+				$contents = str_replace(
101
+					"define('FCPATH', realpath(dirname(__FILE__).'/../..').DIRECTORY_SEPARATOR);",
102
+					"define('FCPATH', realpath(dirname(__FILE__).'/../../{$this->pub_dir}').DIRECTORY_SEPARATOR);",
103
+					$contents
104
+				);
105
+				// CodeIgniter 3.0.5 and before
106
+				$contents = str_replace(
107
+					"define('FCPATH', realpath(dirname(__FILE__).'/../..').'/');",
108
+					"define('FCPATH', realpath(dirname(__FILE__).'/../../{$this->pub_dir}').'/');",
109
+					$contents
110
+				);
111
+			} elseif (file_exists($this->app_dir.'/public/index.php')) {
112
+				// CodeIgniter 3.0.6 and after
113
+				$contents = str_replace(
114
+					"define('FCPATH', realpath(dirname(__FILE__).'/../..').DIRECTORY_SEPARATOR);",
115
+					"define('FCPATH', realpath(dirname(__FILE__).'/../public').DIRECTORY_SEPARATOR);",
116
+					$contents
117
+				);
118
+				// CodeIgniter 3.0.5 and before
119
+				$contents = str_replace(
120
+					"define('FCPATH', realpath(dirname(__FILE__).'/../..').'/');",
121
+					"define('FCPATH', realpath(dirname(__FILE__).'/../public').'/');",
122
+					$contents
123
+				);
124
+				if ($this->app_dir !== 'application') {
125
+					$contents = str_replace(
126
+						"\$application_folder = '../../application';",
127
+						"\$application_folder = '../../{$this->app_dir}';",
128
+						$contents
129
+					);
130
+				}
131
+			} else {
132
+				throw new Exception('Can\'t find "index.php".');
133
+			}
134
+		}
135
+
136
+		file_put_contents($file, $contents);
137
+	}
138
+
139
+	public function update()
140
+	{
141
+		$target_dir = $this->app_dir.'/'.$this->test_dir.'/_ci_phpunit_test';
142
+		$this->recursiveUnlink($target_dir);
143
+		$this->recursiveCopy(
144
+			dirname(dirname(__FILE__)).'/application/tests/_ci_phpunit_test',
145
+			$target_dir
146
+		);
147
+	}
148
+
149
+	/**
150
+	 * Recursive Copy
151
+	 *
152
+	 * @param string $src
153
+	 * @param string $dst
154
+	 */
155
+	private function recursiveCopy($src, $dst)
156
+	{
157
+		@mkdir($dst, 0755);
158
+
159
+		$iterator = new \RecursiveIteratorIterator(
160
+			new \RecursiveDirectoryIterator($src, \RecursiveDirectoryIterator::SKIP_DOTS),
161
+			\RecursiveIteratorIterator::SELF_FIRST
162
+		);
163
+
164
+		foreach ($iterator as $file) {
165
+			if ($file->isDir()) {
166
+				@mkdir($dst.'/'.$iterator->getSubPathName());
167
+			} else {
168
+				$success = copy($file, $dst.'/'.$iterator->getSubPathName());
169
+				if ($success) {
170
+					if (! $this->silent) {
171
+						echo 'copied: '.$dst.'/'.$iterator->getSubPathName().PHP_EOL;
172
+					}
173
+				}
174
+			}
175
+		}
176
+	}
177
+
178
+	/**
179
+	 * Recursive Unlink
180
+	 *
181
+	 * @param string $dir
182
+	 */
183
+	private function recursiveUnlink($dir)
184
+	{
185
+		$iterator = new \RecursiveIteratorIterator(
186
+			new \RecursiveDirectoryIterator($dir, \RecursiveDirectoryIterator::SKIP_DOTS),
187
+			\RecursiveIteratorIterator::CHILD_FIRST
188
+		);
189
+
190
+		foreach ($iterator as $file) {
191
+			if ($file->isDir()) {
192
+				rmdir($file);
193
+			} else {
194
+				unlink($file);
195
+			}
196
+		}
197
+
198
+		rmdir($dir);
199
+	}
200 200
 }
Please login to merge, or discard this patch.
tests/_ci_phpunit_test/patcher/2.x/Patcher/ConstantPatcher/Proxy.php 1 patch
Spacing   +6 added lines, -6 removed lines patch added patch discarded remove patch
@@ -63,7 +63,7 @@  discard block
 block discarded – undo
63 63
 			$method = isset($info['class_method']) ? $info['class_method'] : $info['function'];
64 64
 
65 65
 			MonkeyPatchManager::log(
66
-				'invoke_const: ' . $constant . ') on line ' . $line . ' in ' . $file . ' by ' . $method . '()'
66
+				'invoke_const: '.$constant.') on line '.$line.' in '.$file.' by '.$method.'()'
67 67
 			);
68 68
 		}
69 69
 	}
@@ -106,12 +106,12 @@  discard block
 block discarded – undo
106 106
 	{
107 107
 		self::logInvocation($constant);
108 108
 
109
-		if (! empty(self::$patches_to_apply[$constant]))
109
+		if ( ! empty(self::$patches_to_apply[$constant]))
110 110
 		{
111
-			if (! self::checkCalledMethod($constant))
111
+			if ( ! self::checkCalledMethod($constant))
112 112
 			{
113 113
 				MonkeyPatchManager::log(
114
-					'invoke_const: ' . $constant . ' not patched (out of scope)'
114
+					'invoke_const: '.$constant.' not patched (out of scope)'
115 115
 				);
116 116
 				return constant($constant);
117 117
 			}
@@ -119,12 +119,12 @@  discard block
 block discarded – undo
119 119
 
120 120
 		if (array_key_exists($constant, self::$patches))
121 121
 		{
122
-			MonkeyPatchManager::log('invoke_const: ' . $constant . ' patched');
122
+			MonkeyPatchManager::log('invoke_const: '.$constant.' patched');
123 123
 			return self::$patches[$constant];
124 124
 		}
125 125
 
126 126
 		MonkeyPatchManager::log(
127
-			'invoke_const: ' . $constant . ' not patched (no patch)'
127
+			'invoke_const: '.$constant.' not patched (no patch)'
128 128
 		);
129 129
 		return constant($constant);
130 130
 	}
Please login to merge, or discard this patch.
update.php 1 patch
Spacing   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -8,7 +8,7 @@
 block discarded – undo
8 8
  * @link       https://github.com/kenjis/ci-phpunit-test
9 9
  */
10 10
 
11
-require __DIR__ . '/lib/Installer.php';
11
+require __DIR__.'/lib/Installer.php';
12 12
 
13 13
 $installer = new Installer($argv);
14 14
 $installer->update();
Please login to merge, or discard this patch.
application/tests/_ci_phpunit_test/CIPHPUnitTestDbTestCase.php 2 patches
Doc Comments   +3 added lines, -3 removed lines patch added patch discarded remove patch
@@ -87,7 +87,7 @@  discard block
 block discarded – undo
87 87
 	 * @param string $table
88 88
 	 * @param array  $where
89 89
 	 *
90
-	 * @return bool
90
+	 * @return boolean|null
91 91
 	 */
92 92
 	public function dontSeeInDatabase($table, array $where)
93 93
 	{
@@ -107,7 +107,7 @@  discard block
 block discarded – undo
107 107
 	 * @param string $table
108 108
 	 * @param array  $where
109 109
 	 *
110
-	 * @return bool
110
+	 * @return boolean|null
111 111
 	 */
112 112
 	public function seeInDatabase($table, array $where)
113 113
 	{
@@ -169,7 +169,7 @@  discard block
 block discarded – undo
169 169
 	 * @param string $table
170 170
 	 * @param array  $where
171 171
 	 *
172
-	 * @return bool
172
+	 * @return boolean|null
173 173
 	 */
174 174
 	public function seeNumRecords($expected, $table, array $where = [])
175 175
 	{
Please login to merge, or discard this patch.
Spacing   +3 added lines, -3 removed lines patch added patch discarded remove patch
@@ -35,7 +35,7 @@  discard block
 block discarded – undo
35 35
 	{
36 36
 		if ($this->db === null)
37 37
 		{
38
-			$CI =& get_instance();
38
+			$CI = & get_instance();
39 39
 			$CI->load->database();
40 40
 			$this->db = $CI->db;
41 41
 		}
@@ -54,7 +54,7 @@  discard block
 block discarded – undo
54 54
 	 */
55 55
 	protected function tearDown()
56 56
 	{
57
-		if (! empty($this->insertCache))
57
+		if ( ! empty($this->insertCache))
58 58
 		{
59 59
 			foreach ($this->insertCache as $row)
60 60
 			{
@@ -71,7 +71,7 @@  discard block
 block discarded – undo
71 71
 		$this->db->close();
72 72
 		$this->db = null;
73 73
 
74
-		$CI =& get_instance();
74
+		$CI = & get_instance();
75 75
 		$CI->load->database();
76 76
 		$this->db = $this->CI->db;
77 77
 	}
Please login to merge, or discard this patch.