Duplicate code is one of the most pungent code smells. A rule that is often used is to re-structure code once it is duplicated in three or more places.
Common duplication problems, and corresponding solutions are:
| 1 | <?php |
||
| 11 | class Installer |
||
|
|
|||
| 12 | { |
||
| 13 | const TEST_FOLDER = 'tests'; |
||
| 14 | |||
| 15 | private $silent = false; |
||
| 16 | |||
| 17 | public function __construct($silent = false) |
||
| 21 | |||
| 22 | public function install($app = 'application', $pub = 'public') |
||
| 23 | { |
||
| 24 | $this->recursiveCopy( |
||
| 25 | dirname(__FILE__) . '/application/tests', |
||
| 26 | $app . '/' . static::TEST_FOLDER |
||
| 27 | ); |
||
| 28 | $this->fixPath($app, $pub); |
||
| 29 | } |
||
| 30 | |||
| 31 | /** |
||
| 32 | * Fix paths in Bootstrap.php |
||
| 33 | */ |
||
| 34 | private function fixPath($app = 'application', $pub = 'public') |
||
| 35 | { |
||
| 36 | $file = $app . '/' . static::TEST_FOLDER . '/Bootstrap.php'; |
||
| 37 | $contents = file_get_contents($file); |
||
| 38 | |||
| 39 | if (! file_exists('system')) { |
||
| 40 | if (file_exists('vendor/codeigniter/framework/system')) { |
||
| 41 | $contents = str_replace( |
||
| 42 | '$system_path = \'../../system\';', |
||
| 43 | '$system_path = \'../../vendor/codeigniter/framework/system\';', |
||
| 44 | $contents |
||
| 45 | ); |
||
| 46 | } else { |
||
| 47 | throw new Exception('Can\'t find "system" folder.'); |
||
| 48 | } |
||
| 49 | } |
||
| 50 | |||
| 51 | if (! file_exists('index.php')) { |
||
| 52 | if (file_exists($pub . '/index.php')) { |
||
| 53 | // CodeIgniter 3.0.6 and after |
||
| 54 | $contents = str_replace( |
||
| 55 | "define('FCPATH', realpath(dirname(__FILE__).'/../..').DIRECTORY_SEPARATOR);", |
||
| 56 | "define('FCPATH', realpath(dirname(__FILE__).'/../../'. $pub).DIRECTORY_SEPARATOR);", |
||
| 57 | $contents |
||
| 58 | ); |
||
| 59 | // CodeIgniter 3.0.5 and before |
||
| 60 | $contents = str_replace( |
||
| 61 | "define('FCPATH', realpath(dirname(__FILE__).'/../..').'/');", |
||
| 62 | "define('FCPATH', realpath(dirname(__FILE__).'/../../' . $pub).'/');", |
||
| 63 | $contents |
||
| 64 | ); |
||
| 65 | } elseif (file_exists($app . '/public/index.php')) { |
||
| 66 | // CodeIgniter 3.0.6 and after |
||
| 67 | $contents = str_replace( |
||
| 68 | "define('FCPATH', realpath(dirname(__FILE__).'/../..').DIRECTORY_SEPARATOR);", |
||
| 69 | "define('FCPATH', realpath(dirname(__FILE__).'/../public').DIRECTORY_SEPARATOR);", |
||
| 70 | $contents |
||
| 71 | ); |
||
| 72 | // CodeIgniter 3.0.5 and before |
||
| 73 | $contents = str_replace( |
||
| 74 | "define('FCPATH', realpath(dirname(__FILE__).'/../..').'/');", |
||
| 75 | "define('FCPATH', realpath(dirname(__FILE__).'/../public').'/');", |
||
| 76 | $contents |
||
| 77 | ); |
||
| 78 | if ($app != 'application') { |
||
| 79 | $contents = str_replace( |
||
| 80 | "\$application_folder = '../../application';", |
||
| 81 | "\$application_folder = '../../{$app}';", |
||
| 82 | $contents |
||
| 83 | ); |
||
| 84 | } |
||
| 85 | } else { |
||
| 86 | throw new Exception('Can\'t find "index.php".'); |
||
| 87 | } |
||
| 88 | } |
||
| 89 | |||
| 90 | file_put_contents($file, $contents); |
||
| 91 | } |
||
| 92 | |||
| 93 | public function update($app = 'application') |
||
| 94 | { |
||
| 95 | $target_dir = $app . '/' . static::TEST_FOLDER . '/_ci_phpunit_test'; |
||
| 96 | $this->recursiveUnlink($target_dir); |
||
| 97 | $this->recursiveCopy( |
||
| 98 | dirname(__FILE__) . '/application/tests/_ci_phpunit_test', |
||
| 99 | $target_dir |
||
| 100 | ); |
||
| 101 | } |
||
| 102 | |||
| 103 | /** |
||
| 104 | * Recursive Copy |
||
| 105 | * |
||
| 106 | * @param string $src |
||
| 107 | * @param string $dst |
||
| 108 | */ |
||
| 109 | private function recursiveCopy($src, $dst) |
||
| 131 | |||
| 132 | /** |
||
| 133 | * Recursive Unlink |
||
| 134 | * |
||
| 135 | * @param string $dir |
||
| 136 | */ |
||
| 137 | View Code Duplication | private function recursiveUnlink($dir) |
|
| 154 | } |
||
| 155 |
You can fix this by adding a namespace to your class:
When choosing a vendor namespace, try to pick something that is not too generic to avoid conflicts with other libraries.