Inspection of "Replace `is_testing_env()` with `TestCase::isTesti..." - kenjis/ci-phpunit-test - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Pull Request — master (#360)

by Kenji

created 2021-02-08 00:58 UTC

Status

Spacing +2 added lines, -2 removed lines patch added patch discarded remove patch

@@ -72,7 +72,7 @@  discard block
 block discarded – undo
 			}
 
 			// Load the mime types
-			$mimes =& get_mimes();
+			$mimes = & get_mimes();
 
 			// Only change the default MIME if we can find one
 			if (isset($mimes[$extension]))
@@ -117,7 +117,7 @@  discard block
 block discarded – undo
 
 		if (TestCase::isTestingEnv())
 		{
-			$CI =& get_instance();
+			$CI = & get_instance();
 			$CI->output->set_header('Content-Type: '.$mime);
 			$CI->output->set_header('Content-Disposition: attachment; filename="'.$filename.'"');
 			$CI->output->set_header('Expires: 0');

Please login to merge, or discard this patch.

tests/_ci_phpunit_test/replacing/helpers/old/3.1.8-download_helper.php 1 patch

Spacing +2 added lines, -2 removed lines patch added patch discarded remove patch

@@ -72,7 +72,7 @@  discard block
 block discarded – undo
 			}
 
 			// Load the mime types
-			$mimes =& get_mimes();
+			$mimes = & get_mimes();
 
 			// Only change the default MIME if we can find one
 			if (isset($mimes[$extension]))
@@ -117,7 +117,7 @@  discard block
 block discarded – undo
 
 		if (TestCase::isTestingEnv())
 		{
-			$CI =& get_instance();
+			$CI = & get_instance();
 			$CI->output->set_header('Content-Type: '.$mime);
 			$CI->output->set_header('Content-Disposition: attachment; filename="'.$filename.'"');
 			$CI->output->set_header('Expires: 0');

Please login to merge, or discard this patch.

tests/_ci_phpunit_test/replacing/helpers/old/3.1.7-download_helper.php 1 patch

Spacing +2 added lines, -2 removed lines patch added patch discarded remove patch

@@ -72,7 +72,7 @@  discard block
 block discarded – undo
 			}
 
 			// Load the mime types
-			$mimes =& get_mimes();
+			$mimes = & get_mimes();
 
 			// Only change the default MIME if we can find one
 			if (isset($mimes[$extension]))
@@ -117,7 +117,7 @@  discard block
 block discarded – undo
 
 		if (TestCase::isTestingEnv())
 		{
-			$CI =& get_instance();
+			$CI = & get_instance();
 			$CI->output->set_header('Content-Type: '.$mime);
 			$CI->output->set_header('Content-Disposition: attachment; filename="'.$filename.'"');
 			$CI->output->set_header('Expires: 0');

Please login to merge, or discard this patch.

tests/_ci_phpunit_test/replacing/helpers/old/3.1.6-download_helper.php 1 patch

Spacing +2 added lines, -2 removed lines patch added patch discarded remove patch

@@ -72,7 +72,7 @@  discard block
 block discarded – undo
 			}
 
 			// Load the mime types
-			$mimes =& get_mimes();
+			$mimes = & get_mimes();
 
 			// Only change the default MIME if we can find one
 			if (isset($mimes[$extension]))
@@ -117,7 +117,7 @@  discard block
 block discarded – undo
 
 		if (TestCase::isTestingEnv())
 		{
-			$CI =& get_instance();
+			$CI = & get_instance();
 			$CI->output->set_header('Content-Type: '.$mime);
 			$CI->output->set_header('Content-Disposition: attachment; filename="'.$filename.'"');
 			$CI->output->set_header('Expires: 0');

Please login to merge, or discard this patch.

application/tests/_ci_phpunit_test/replacing/helpers/download_helper.php 1 patch

Spacing +2 added lines, -2 removed lines patch added patch discarded remove patch

@@ -72,7 +72,7 @@  discard block
 block discarded – undo
 			}
 
 			// Load the mime types
-			$mimes =& get_mimes();
+			$mimes = & get_mimes();
 
 			// Only change the default MIME if we can find one
 			if (isset($mimes[$extension]))
@@ -117,7 +117,7 @@  discard block
 block discarded – undo
 
 		if (TestCase::isTestingEnv())
 		{
-			$CI =& get_instance();
+			$CI = & get_instance();
 			$CI->output->set_header('Content-Type: '.$mime);
 			$CI->output->set_header('Content-Disposition: attachment; filename="'.$filename.'"');
 			$CI->output->set_header('Expires: 0');

Please login to merge, or discard this patch.

		@@ -72,7 +72,7 @@ discard block
		block discarded – undo
72	72	}
73	73
74	74	// Load the mime types
75		- $mimes =& get_mimes();
	75	+ $mimes = & get_mimes();
76	76
77	77	// Only change the default MIME if we can find one
78	78	if (isset($mimes[$extension]))
		@@ -117,7 +117,7 @@ discard block
		block discarded – undo
117	117
118	118	if (TestCase::isTestingEnv())
119	119	{
120		- $CI =& get_instance();
	120	+ $CI = & get_instance();
121	121	$CI->output->set_header('Content-Type: '.$mime);
122	122	$CI->output->set_header('Content-Disposition: attachment; filename="'.$filename.'"');
123	123	$CI->output->set_header('Expires: 0');

		@@ -72,7 +72,7 @@ discard block
		block discarded – undo
72	72	}
73	73
74	74	// Load the mime types
75		- $mimes =& get_mimes();
	75	+ $mimes = & get_mimes();
76	76
77	77	// Only change the default MIME if we can find one
78	78	if (isset($mimes[$extension]))
		@@ -117,7 +117,7 @@ discard block
		block discarded – undo
117	117
118	118	if (TestCase::isTestingEnv())
119	119	{
120		- $CI =& get_instance();
	120	+ $CI = & get_instance();
121	121	$CI->output->set_header('Content-Type: '.$mime);
122	122	$CI->output->set_header('Content-Disposition: attachment; filename="'.$filename.'"');
123	123	$CI->output->set_header('Expires: 0');

		@@ -72,7 +72,7 @@ discard block
		block discarded – undo
72	72	}
73	73
74	74	// Load the mime types
75		- $mimes =& get_mimes();
	75	+ $mimes = & get_mimes();
76	76
77	77	// Only change the default MIME if we can find one
78	78	if (isset($mimes[$extension]))
		@@ -117,7 +117,7 @@ discard block
		block discarded – undo
117	117
118	118	if (TestCase::isTestingEnv())
119	119	{
120		- $CI =& get_instance();
	120	+ $CI = & get_instance();
121	121	$CI->output->set_header('Content-Type: '.$mime);
122	122	$CI->output->set_header('Content-Disposition: attachment; filename="'.$filename.'"');
123	123	$CI->output->set_header('Expires: 0');

		@@ -72,7 +72,7 @@ discard block
		block discarded – undo
72	72	}
73	73
74	74	// Load the mime types
75		- $mimes =& get_mimes();
	75	+ $mimes = & get_mimes();
76	76
77	77	// Only change the default MIME if we can find one
78	78	if (isset($mimes[$extension]))
		@@ -117,7 +117,7 @@ discard block
		block discarded – undo
117	117
118	118	if (TestCase::isTestingEnv())
119	119	{
120		- $CI =& get_instance();
	120	+ $CI = & get_instance();
121	121	$CI->output->set_header('Content-Type: '.$mime);
122	122	$CI->output->set_header('Content-Disposition: attachment; filename="'.$filename.'"');
123	123	$CI->output->set_header('Expires: 0');

		@@ -72,7 +72,7 @@ discard block
		block discarded – undo
72	72	}
73	73
74	74	// Load the mime types
75		- $mimes =& get_mimes();
	75	+ $mimes = & get_mimes();
76	76
77	77	// Only change the default MIME if we can find one
78	78	if (isset($mimes[$extension]))
		@@ -117,7 +117,7 @@ discard block
		block discarded – undo
117	117
118	118	if (TestCase::isTestingEnv())
119	119	{
120		- $CI =& get_instance();
	120	+ $CI = & get_instance();
121	121	$CI->output->set_header('Content-Type: '.$mime);
122	122	$CI->output->set_header('Content-Disposition: attachment; filename="'.$filename.'"');
123	123	$CI->output->set_header('Expires: 0');

kenjis / ci-phpunit-test

Pull Request — master (#360)

Status

Category

Spacing +2 added lines, -2 removed lines patch added patch discarded remove patch

Spacing +2 added lines, -2 removed lines patch added patch discarded remove patch

Spacing +2 added lines, -2 removed lines patch added patch discarded remove patch

Spacing +2 added lines, -2 removed lines patch added patch discarded remove patch

Spacing +2 added lines, -2 removed lines patch added patch discarded remove patch