Installer

Complexity

Total Complexity

27

Size/Duplication

Total Lines	191
Duplicated Lines	17.28 %

Coupling/Cohesion

Components	1
Dependencies	0

Importance

Changes

0

7 Methods

Rating	Name	Duplication	Size	Complexity
A	__construct()	0	4	1
D	parse_args()	16	44	9
A	install()	0	8	1
B	fixPath()	0	58	7
A	update()	0	9	1
B	recursiveCopy()	0	22	5
A	recursiveUnlink()	17	17	3

<?php
/**
 * Part of ci-phpunit-test
 *
 * @author     Kenji Suzuki <https://github.com/kenjis>
 * @license    MIT License
 * @copyright  2015 Kenji Suzuki
 * @link       https://github.com/kenjis/ci-phpunit-test
 */

class Installer

PSR1 recommends that each class must be in a namespace of at least one level to avoid collisions.

{
    const TEST_FOLDER = 'tests';

    private $silent = false;
    private $app_dir = 'application';
    private $pub_dir = 'public';

    public function __construct($argv)
    {
        $this->parse_args($argv);
    }

    private function parse_args($argv)
    {
        $argc = count($argv);

        if ($argc === 1) {
            return;
        }

        for ($i = 1; $i <= $argc; $i++) {
            if (! isset($argv[$i])) {
                break;
            }

            switch ($argv[$i]) {
                // php install.php -s
                case '-s':
                    $this->silent = true;
                    break;

                // php install.php -a application
                case '-a':

This code seems to be duplicated across your project.

                    if (is_dir($argv[$i+1])) {
                        $this->app_dir = $argv[$i+1];
                    } else {
                        throw new Exception('No such directory: ' . $argv[$i+1]);
                    }
                    $i++;
                    break;

                // php install.php -p public
                case '-p':

This code seems to be duplicated across your project.

                    if (is_dir($argv[$i+1])) {
                        $this->pub_dir = $argv[$i+1];
                    } else {
                        throw new Exception('No such directory: ' . $argv[$i+1]);
                    }
                    $i++;
                    break;

                default:
                    throw new Exception('Unknown argument: ' . $argv[$i]);
            }
        }
    }

    public function install()
    {
        $this->recursiveCopy(
            dirname(__FILE__) . '/application/tests',
            $this->app . '/' . static::TEST_FOLDER

The property app does not exist. Did you maybe forget to declare it?

        );
        $this->fixPath($this->app, $this->pub);

The property pub does not exist. Did you maybe forget to declare it?

The call to Installer::fixPath() has too many arguments starting with $this->app.

    }

    /**
     * Fix paths in Bootstrap.php
     */
    private function fixPath()
    {
        $file = $this->app . '/' . static::TEST_FOLDER . '/Bootstrap.php';
        $contents = file_get_contents($file);

        if (! file_exists('system')) {
            if (file_exists('vendor/codeigniter/framework/system')) {
                $contents = str_replace(
                    '$system_path = \'../../system\';',
                    '$system_path = \'../../vendor/codeigniter/framework/system\';',
                    $contents
                );
            } else {
                throw new Exception('Can\'t find "system" folder.');
            }
        }

        if (! file_exists('index.php')) {
            if (file_exists($pub . '/index.php')) {
                // CodeIgniter 3.0.6 and after
                $contents = str_replace(
                    "define('FCPATH', realpath(dirname(__FILE__).'/../..').DIRECTORY_SEPARATOR);",
                    "define('FCPATH', realpath(dirname(__FILE__).'/../../'. $pub).DIRECTORY_SEPARATOR);",

The variable $pub does not exist. Did you forget to declare it?

                    $contents
                );
                // CodeIgniter 3.0.5 and before
                $contents = str_replace(
                    "define('FCPATH', realpath(dirname(__FILE__).'/../..').'/');",
                    "define('FCPATH', realpath(dirname(__FILE__).'/../../' . $pub).'/');",
                    $contents
                );
            } elseif (file_exists($this->app . '/public/index.php')) {
                // CodeIgniter 3.0.6 and after
                $contents = str_replace(
                    "define('FCPATH', realpath(dirname(__FILE__).'/../..').DIRECTORY_SEPARATOR);",
                    "define('FCPATH', realpath(dirname(__FILE__).'/../public').DIRECTORY_SEPARATOR);",
                    $contents
                );
                // CodeIgniter 3.0.5 and before
                $contents = str_replace(
                    "define('FCPATH', realpath(dirname(__FILE__).'/../..').'/');",
                    "define('FCPATH', realpath(dirname(__FILE__).'/../public').'/');",
                    $contents
                );
                if ($this->app != 'application') {
                    $contents = str_replace(
                        "\$application_folder = '../../application';",
                        "\$application_folder = '../../{$this->app}';",
                        $contents
                    );
                }
            } else {
                throw new Exception('Can\'t find "index.php".');
            }
        }

        file_put_contents($file, $contents);
    }

    public function update()
    {
        $target_dir = $this->app . '/' . static::TEST_FOLDER . '/_ci_phpunit_test';
        $this->recursiveUnlink($target_dir);
        $this->recursiveCopy(
            dirname(__FILE__) . '/application/tests/_ci_phpunit_test',
            $target_dir
        );
    }

    /**
     * Recursive Copy
     *
     * @param string $src
     * @param string $dst
     */
    private function recursiveCopy($src, $dst)
    {
        @mkdir($dst, 0755);

It seems like you do not handle an error condition here. This can introduce security issues, and is generally not recommended.

        $iterator = new \RecursiveIteratorIterator(
            new \RecursiveDirectoryIterator($src, \RecursiveDirectoryIterator::SKIP_DOTS),
            \RecursiveIteratorIterator::SELF_FIRST
        );

        foreach ($iterator as $file) {
            if ($file->isDir()) {
                @mkdir($dst . '/' . $iterator->getSubPathName());

It seems like you do not handle an error condition here. This can introduce security issues, and is generally not recommended.

            } else {
                $success = copy($file, $dst . '/' . $iterator->getSubPathName());
                if ($success) {
                    if (! $this->silent) {
                        echo 'copied: ' . $dst . '/' . $iterator->getSubPathName() . PHP_EOL;
                    }
                }
            }
        }
    }

    /**
     * Recursive Unlink
     *
     * @param string $dir
     */
    private function recursiveUnlink($dir)

This method seems to be duplicated in your project.

    {
        $iterator = new \RecursiveIteratorIterator(
            new \RecursiveDirectoryIterator($dir, \RecursiveDirectoryIterator::SKIP_DOTS),
            \RecursiveIteratorIterator::CHILD_FIRST
        );

        foreach ($iterator as $file) {
            if ($file->isDir()) {
                rmdir($file);
            } else {
                unlink($file);
            }
        }

        rmdir($dir);
    }
}