Installer::parse_args() - Code Metrics - Inspection of "Merge pull request #362 from kenjis/luckydonald-pa..." - kenjis/ci-phpunit-test - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — master ( 898158...d9d69e )

by Kenji

created 2021-02-24 07:25 UTC

Installer::parse_args() C

↳ Parent: Installer

Complexity

Conditions	14
Paths	10

Size

Total Lines

Duplication

Lines	24
Ratio	36.36 %

Importance

Changes

Metric	Value
cc	14
nc	10
nop	1
dl	24
loc	66
rs	6.2666
c	0
b	0
f	0

How to fix Long Method Complexity

<?php
/**
 * Part of ci-phpunit-test
 *
 * @author     Kenji Suzuki <https://github.com/kenjis>
 * @license    MIT License
 * @copyright  2015 Kenji Suzuki
 * @link       https://github.com/kenjis/ci-phpunit-test
 */

class Installer
{
    private $silent = false;
    private $app_dir = 'application';  // -a DIRECTORY
    private $pub_dir = 'public';       // -p DIRECTORY
    private $test_dir = null;          // -t DIRECTORY
    private $from_composer = false;

    public function __construct($argv)
    {
        $this->parse_args($argv);
    }

    private function parse_args($argv)
    {
        $argc = count($argv);

        if ($argc === 1) {
            if (is_null($this->test_dir)) {
                $this->test_dir = $this->app_dir.'/tests';
            }

            return;
        }

        for ($i = 1; $i <= $argc; $i++) {
            if (! isset($argv[$i])) {
                break;
            }

            switch ($argv[$i]) {
                // php install.php -s
                case '-s':
                    $this->silent = true;
                    break;

                // php install.php -a application
                case '-a':

                    if (is_dir($argv[$i+1])) {
                        $this->app_dir = $argv[$i+1];
                    } else {
                        throw new Exception('No such application directory: '.$argv[$i+1]);
                    }
                    $i++;
                    break;

                // php install.php -p public
                case '-p':

                    if (is_dir($argv[$i+1])) {
                        $this->pub_dir = $argv[$i+1];
                    } else {
                        throw new Exception('No such public directory: '.$argv[$i+1]);
                    }
                    $i++;
                    break;

                // php install.php -t application/tests
                case '-t':

                    if (is_dir($argv[$i+1])) {
                        $this->test_dir = $argv[$i+1];
                    } else {
                        throw new Exception('No such test directory: '.$argv[$i+1]);
                    }
                    $i++;
                    break;

                case '--from-composer':
                    $this->from_composer = true;
                    break;

                default:
                    throw new Exception('Unknown argument: '.$argv[$i]);
            }
        }

        if (is_null($this->test_dir)) {
            $this->test_dir = $this->app_dir.'/tests';
        }
    }

    public function install()
    {
        $this->recursiveCopy(
            dirname(dirname(__FILE__)).'/application/tests',
            $this->test_dir
        );
        $this->fixPath();
        if ($this->from_composer) {
            $this->recursiveUnlink($this->app_dir.'/'.$this->test_dir.'/_ci_phpunit_test');
        }
    }

    /**
     * Fix paths in Bootstrap.php
     *
     * @FIXME Too ad hoc. Must rewrite, because can't handle complex paths.
     */
    private function fixPath()
    {
        $file = $this->test_dir.'/Bootstrap.php';
        $contents = file_get_contents($file);

        if (! file_exists('system')) {
            if (file_exists('vendor/codeigniter/framework/system')) {
                $contents = str_replace(
                    '$system_path = \'../../system\';',
                    '$system_path = \'../../vendor/codeigniter/framework/system\';',
                    $contents
                );
            } else {
                throw new Exception('Can\'t find "system" folder.');
            }
        }

        if (! file_exists('index.php')) {
            if (file_exists($this->pub_dir.'/index.php')) {
                // CodeIgniter 3.0.6 and after
                $contents = str_replace(
                    "define('FCPATH', realpath(dirname(__FILE__).'/../..').DIRECTORY_SEPARATOR);",
                    "define('FCPATH', realpath(dirname(__FILE__).'/../../{$this->pub_dir}').DIRECTORY_SEPARATOR);",
                    $contents
                );
                // CodeIgniter 3.0.5 and before
                $contents = str_replace(
                    "define('FCPATH', realpath(dirname(__FILE__).'/../..').'/');",
                    "define('FCPATH', realpath(dirname(__FILE__).'/../../{$this->pub_dir}').'/');",
                    $contents
                );
            } elseif (file_exists($this->app_dir.'/public/index.php')) {
                // CodeIgniter 3.0.6 and after
                $contents = str_replace(
                    "define('FCPATH', realpath(dirname(__FILE__).'/../..').DIRECTORY_SEPARATOR);",
                    "define('FCPATH', realpath(dirname(__FILE__).'/../public').DIRECTORY_SEPARATOR);",
                    $contents
                );
                // CodeIgniter 3.0.5 and before
                $contents = str_replace(
                    "define('FCPATH', realpath(dirname(__FILE__).'/../..').'/');",
                    "define('FCPATH', realpath(dirname(__FILE__).'/../public').'/');",
                    $contents
                );
                if ($this->app_dir !== 'application') {
                    $contents = str_replace(
                        "\$application_folder = '../../application';",
                        "\$application_folder = '../../{$this->app_dir}';",
                        $contents
                    );
                }
            } else {
                throw new Exception('Can\'t find "index.php".');
            }
        }

        file_put_contents($file, $contents);
    }

    public function update()
    {
        $target_dir = $this->test_dir.'/_ci_phpunit_test';
        $this->recursiveUnlink($target_dir);
        $this->recursiveCopy(
            dirname(dirname(__FILE__)).'/application/tests/_ci_phpunit_test',
            $target_dir
        );
    }

    /**
     * Recursive Copy
     *
     * @param string $src
     * @param string $dst
     */
    private function recursiveCopy($src, $dst)
    {
        @mkdir($dst, 0755);
// For example instead of
@mkdir($dir);

// Better use
if (@mkdir($dir) === false) {
    throw new \RuntimeException('The directory '.$dir.' could not be created.');
}

        $iterator = new \RecursiveIteratorIterator(
            new \RecursiveDirectoryIterator($src, \RecursiveDirectoryIterator::SKIP_DOTS),
            \RecursiveIteratorIterator::SELF_FIRST
        );

        foreach ($iterator as $file) {
            if ($file->isDir()) {
                @mkdir($dst.'/'.$iterator->getSubPathName());
// For example instead of
@mkdir($dir);

// Better use
if (@mkdir($dir) === false) {
    throw new \RuntimeException('The directory '.$dir.' could not be created.');
}
            } else {
                $success = copy($file, $dst.'/'.$iterator->getSubPathName());
                if ($success) {
                    if (! $this->silent) {
                        echo 'copied: '.$dst.'/'.$iterator->getSubPathName().PHP_EOL;
                    }
                }
            }
        }
    }

    /**
     * Recursive Unlink
     *
     * @param string $dir
     */
    private function recursiveUnlink($dir)

    {
        $iterator = new \RecursiveIteratorIterator(
            new \RecursiveDirectoryIterator($dir, \RecursiveDirectoryIterator::SKIP_DOTS),
            \RecursiveIteratorIterator::CHILD_FIRST
        );

        foreach ($iterator as $file) {
            if ($file->isDir()) {
                rmdir($file);
            } else {
                unlink($file);
            }
        }

        rmdir($dir);
    }
}


1		<?php
2		/**
3		* Part of ci-phpunit-test
4		*
5		* @author Kenji Suzuki <https://github.com/kenjis>
6		* @license MIT License
7		* @copyright 2015 Kenji Suzuki
8		* @link https://github.com/kenjis/ci-phpunit-test
9		*/
10
11		class Installer
12		{
13		private $silent = false;
14		private $app_dir = 'application'; // -a DIRECTORY
15		private $pub_dir = 'public'; // -p DIRECTORY
16		private $test_dir = null; // -t DIRECTORY
17		private $from_composer = false;
18
19		public function __construct($argv)
20		{
21		$this->parse_args($argv);
22		}
23
24		private function parse_args($argv)
25		{
26		$argc = count($argv);
27
28		if ($argc === 1) {
29		if (is_null($this->test_dir)) {
30		$this->test_dir = $this->app_dir.'/tests';
31		}
32
33		return;
34		}
35
36		for ($i = 1; $i <= $argc; $i++) {
37		if (! isset($argv[$i])) {
38		break;
39		}
40
41		switch ($argv[$i]) {
42		// php install.php -s
43		case '-s':
44		$this->silent = true;
45		break;
46
47		// php install.php -a application
48	View Code Duplication	case '-a':
		0 ignored issues – show Duplication introduced 2018-03-18 00:45 UTC by Report Bug Copy Issue Report This code seems to be duplicated across your project. Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation. You can also find more detailed suggestions in the “Code” section of your repository. Loading history...
49		if (is_dir($argv[$i+1])) {
50		$this->app_dir = $argv[$i+1];
51		} else {
52		throw new Exception('No such application directory: '.$argv[$i+1]);
53		}
54		$i++;
55		break;
56
57		// php install.php -p public
58	View Code Duplication	case '-p':
		0 ignored issues – show Duplication introduced 2018-03-18 00:45 UTC by Report Bug Copy Issue Report This code seems to be duplicated across your project. Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation. You can also find more detailed suggestions in the “Code” section of your repository. Loading history...
59		if (is_dir($argv[$i+1])) {
60		$this->pub_dir = $argv[$i+1];
61		} else {
62		throw new Exception('No such public directory: '.$argv[$i+1]);
63		}
64		$i++;
65		break;
66
67		// php install.php -t application/tests
68	View Code Duplication	case '-t':
		0 ignored issues – show Duplication introduced 2019-07-01 17:29 UTC by Report Bug Copy Issue Report This code seems to be duplicated across your project. Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation. You can also find more detailed suggestions in the “Code” section of your repository. Loading history...
69		if (is_dir($argv[$i+1])) {
70		$this->test_dir = $argv[$i+1];
71		} else {
72		throw new Exception('No such test directory: '.$argv[$i+1]);
73		}
74		$i++;
75		break;
76
77		case '--from-composer':
78		$this->from_composer = true;
79		break;
80
81		default:
82		throw new Exception('Unknown argument: '.$argv[$i]);
83		}
84		}
85
86		if (is_null($this->test_dir)) {
87		$this->test_dir = $this->app_dir.'/tests';
88		}
89		}
90
91		public function install()
92		{
93		$this->recursiveCopy(
94		dirname(dirname(__FILE__)).'/application/tests',
95		$this->test_dir
96		);
97		$this->fixPath();
98		if ($this->from_composer) {
99		$this->recursiveUnlink($this->app_dir.'/'.$this->test_dir.'/_ci_phpunit_test');
100		}
101		}
102
103		/**
104		* Fix paths in Bootstrap.php
105		*
106		* @FIXME Too ad hoc. Must rewrite, because can't handle complex paths.
107		*/
108		private function fixPath()
109		{
110		$file = $this->test_dir.'/Bootstrap.php';
111		$contents = file_get_contents($file);
112
113		if (! file_exists('system')) {
114		if (file_exists('vendor/codeigniter/framework/system')) {
115		$contents = str_replace(
116		'$system_path = \'../../system\';',
117		'$system_path = \'../../vendor/codeigniter/framework/system\';',
118		$contents
119		);
120		} else {
121		throw new Exception('Can\'t find "system" folder.');
122		}
123		}
124
125		if (! file_exists('index.php')) {
126		if (file_exists($this->pub_dir.'/index.php')) {
127		// CodeIgniter 3.0.6 and after
128		$contents = str_replace(
129		"define('FCPATH', realpath(dirname(__FILE__).'/../..').DIRECTORY_SEPARATOR);",
130		"define('FCPATH', realpath(dirname(__FILE__).'/../../{$this->pub_dir}').DIRECTORY_SEPARATOR);",
131		$contents
132		);
133		// CodeIgniter 3.0.5 and before
134		$contents = str_replace(
135		"define('FCPATH', realpath(dirname(__FILE__).'/../..').'/');",
136		"define('FCPATH', realpath(dirname(__FILE__).'/../../{$this->pub_dir}').'/');",
137		$contents
138		);
139		} elseif (file_exists($this->app_dir.'/public/index.php')) {
140		// CodeIgniter 3.0.6 and after
141		$contents = str_replace(
142		"define('FCPATH', realpath(dirname(__FILE__).'/../..').DIRECTORY_SEPARATOR);",
143		"define('FCPATH', realpath(dirname(__FILE__).'/../public').DIRECTORY_SEPARATOR);",
144		$contents
145		);
146		// CodeIgniter 3.0.5 and before
147		$contents = str_replace(
148		"define('FCPATH', realpath(dirname(__FILE__).'/../..').'/');",
149		"define('FCPATH', realpath(dirname(__FILE__).'/../public').'/');",
150		$contents
151		);
152		if ($this->app_dir !== 'application') {
153		$contents = str_replace(
154		"\$application_folder = '../../application';",
155		"\$application_folder = '../../{$this->app_dir}';",
156		$contents
157		);
158		}
159		} else {
160		throw new Exception('Can\'t find "index.php".');
161		}
162		}
163
164		file_put_contents($file, $contents);
165		}
166
167		public function update()
168		{
169		$target_dir = $this->test_dir.'/_ci_phpunit_test';
170		$this->recursiveUnlink($target_dir);
171		$this->recursiveCopy(
172		dirname(dirname(__FILE__)).'/application/tests/_ci_phpunit_test',
173		$target_dir
174		);
175		}
176
177		/**
178		* Recursive Copy
179		*
180		* @param string $src
181		* @param string $dst
182		*/
183		private function recursiveCopy($src, $dst)
184		{
185		@mkdir($dst, 0755);
		0 ignored issues – show Security Best Practice introduced 2015-11-20 22:47 UTC by Report Bug Copy Issue Report It seems like you do not handle an error condition here. This can introduce security issues, and is generally not recommended. If you suppress an error, we recommend checking for the error condition explicitly: // For example instead of @mkdir($dir); // Better use if (@mkdir($dir) === false) { throw new \RuntimeException('The directory '.$dir.' could not be created.'); } Loading history...
186
187		$iterator = new \RecursiveIteratorIterator(
188		new \RecursiveDirectoryIterator($src, \RecursiveDirectoryIterator::SKIP_DOTS),
189		\RecursiveIteratorIterator::SELF_FIRST
190		);
191
192		foreach ($iterator as $file) {
193		if ($file->isDir()) {
194		@mkdir($dst.'/'.$iterator->getSubPathName());
		0 ignored issues – show Security Best Practice introduced 2015-11-20 22:47 UTC by Report Bug Copy Issue Report It seems like you do not handle an error condition here. This can introduce security issues, and is generally not recommended. If you suppress an error, we recommend checking for the error condition explicitly: // For example instead of @mkdir($dir); // Better use if (@mkdir($dir) === false) { throw new \RuntimeException('The directory '.$dir.' could not be created.'); } Loading history...
195		} else {
196		$success = copy($file, $dst.'/'.$iterator->getSubPathName());
197		if ($success) {
198		if (! $this->silent) {
199		echo 'copied: '.$dst.'/'.$iterator->getSubPathName().PHP_EOL;
200		}
201		}
202		}
203		}
204		}
205
206		/**
207		* Recursive Unlink
208		*
209		* @param string $dir
210		*/
211	View Code Duplication	private function recursiveUnlink($dir)
		0 ignored issues – show Duplication introduced 2017-08-21 08:20 UTC by Report Bug Copy Issue Report This method seems to be duplicated in your project. Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation. You can also find more detailed suggestions in the “Code” section of your repository. Loading history...
212		{
213		$iterator = new \RecursiveIteratorIterator(
214		new \RecursiveDirectoryIterator($dir, \RecursiveDirectoryIterator::SKIP_DOTS),
215		\RecursiveIteratorIterator::CHILD_FIRST
216		);
217
218		foreach ($iterator as $file) {
219		if ($file->isDir()) {
220		rmdir($file);
221		} else {
222		unlink($file);
223		}
224		}
225
226		rmdir($dir);
227		}
228		}
229

kenjis / ci-phpunit-test

Push — master ( 898158...d9d69e )

Installer::parse_args() C

Complexity

Size

Duplication

Importance

How to fix Long Method Complexity

Long Method

Duplication Side-by-Side

Filter issues like