kenjis / ci-phpunit-test

application/tests/_ci_phpunit_test/patcher/3.x/Patcher/FunctionPatcher/NodeVisitor.php

Unused Use Statements -4 removed lines

@@ -21,15 +21,11 @@
 
 namespace Kenjis\MonkeyPatch\Patcher\FunctionPatcher;
 
-use ReflectionFunction;
-use ReflectionException;
-
 use PhpParser\Node;
 use PhpParser\Node\Expr\FuncCall;
 use PhpParser\Node\Name;
 use PhpParser\Node\Name\FullyQualified;
 use PhpParser\NodeVisitorAbstract;
-
 use Kenjis\MonkeyPatch\Patcher\FunctionPatcher;
 
 class NodeVisitor extends NodeVisitorAbstract

Spacing +5 added lines, -5 removed lines

@@ -36,17 +36,17 @@ 
 {
 	public function leaveNode(Node $node)
 	{
-		if (! ($node instanceof FuncCall))
+		if ( ! ($node instanceof FuncCall))
 		{
 			return;
 		}
 
-		if (! ($node->name instanceof Name))
+		if ( ! ($node->name instanceof Name))
 		{
 			return;
 		}
 
-		if (! $node->name->isUnqualified())
+		if ( ! $node->name->isUnqualified())
 		{
 			return;
 		}
@@ -55,11 +55,11 @@ 
 			FunctionPatcher::isWhitelisted((string) $node->name)
 			&& ! FunctionPatcher::isBlacklisted((string) $node->name)
 		) {
-			$replacement = new FullyQualified('\__FuncProxy__::' . (string) $node->name);
+			$replacement = new FullyQualified('\__FuncProxy__::'.(string) $node->name);
 
 			$pos = $node->getAttribute('startTokenPos');
 			FunctionPatcher::$replacement[$pos] = 
-				'\__FuncProxy__::' . (string) $node->name;
+				'\__FuncProxy__::'.(string) $node->name;
 
 			$node->name = $replacement;
 		}

application/tests/_ci_phpunit_test/patcher/3.x/Patcher/FunctionPatcher/Proxy.php

Doc Comments +10 added lines, -1 removed lines

@@ -37,7 +37,7 @@ 
 	 * 
 	 * @param string $function     function name
 	 * @param mixed  $return_value return value or callable
-	 * @param string $class_name   class::method to apply this patch
+	 * @param string $class_method   class::method to apply this patch
 	 * 
 	 * @throws LogicException
 	 */
@@ -86,6 +86,9 @@ 
 		InvocationVerifier::verify(self::$expected_invocations, self::$invocations);
 	}
 
+	/**
+	 * @param string $function
+	 */
 	protected static function logInvocation($function, $arguments)
 	{
 		if (MonkeyPatchManager::$debug)
@@ -111,6 +114,9 @@ 
 		}
 	}
 
+	/**
+	 * @param string $function
+	 */
 	protected static function checkCalledMethod($function)
 	{
 		$trace = debug_backtrace();
@@ -184,6 +190,9 @@ 
 		return call_user_func_array($function, $arguments);
 	}
 
+	/**
+	 * @param string $function
+	 */
 	protected static function checkPassedByReference($function)
 	{
 		$ref_func = new ReflectionFunction($function);

Unused Use Statements -1 removed lines

@@ -15,7 +15,6 @@
 use LogicException;
 use ReflectionFunction;
 use ReflectionException;
-
 use Kenjis\MonkeyPatch\Patcher\FunctionPatcher;
 use Kenjis\MonkeyPatch\Patcher\Backtrace;
 use Kenjis\MonkeyPatch\MonkeyPatchManager;

Spacing +9 added lines, -9 removed lines

@@ -51,7 +51,7 @@ 
 			self::outputMessage($msg);
 			throw new LogicException($msg);
 		}
-		if (! FunctionPatcher::isWhitelisted($function))
+		if ( ! FunctionPatcher::isWhitelisted($function))
 		{
 			$msg = "<red>Can't patch on '$function'. It is not in whitelist. If you want to patch it, please add it to 'functions_to_patch' in 'tests/Bootstrap.php'. But note that there are some limitations. See <https://github.com/kenjis/ci-phpunit-test/blob/master/docs/HowToWriteTests.md#patching-functions> for details.</red>";
 			self::outputMessage($msg);
@@ -97,16 +97,16 @@ 
 			$line = $info['line'];
 			$method = isset($info['class_method']) ? $info['class_method'] : $info['function'];
 
-			$log_args = function () use ($arguments) {
+			$log_args = function() use ($arguments) {
 				$output = '';
 				foreach ($arguments as $arg) {
-					$output .= var_export($arg, true) . ', ';
+					$output .= var_export($arg, true).', ';
 				}
 				$output = rtrim($output, ', ');
 				return $output;
 			};
 			MonkeyPatchManager::log(
-				'invoke_func: ' . $function . '(' . $log_args() . ') on line ' . $line . ' in ' . $file . ' by ' . $method . '()'
+				'invoke_func: '.$function.'('.$log_args().') on line '.$line.' in '.$file.' by '.$method.'()'
 			);
 		}
 	}
@@ -148,10 +148,10 @@ 
 
 		if (isset(self::$patches_to_apply[$function]))
 		{
-			if (! self::checkCalledMethod($function))
+			if ( ! self::checkCalledMethod($function))
 			{
 				MonkeyPatchManager::log(
-					'invoke_func: ' . $function . '() not patched (out of scope)'
+					'invoke_func: '.$function.'() not patched (out of scope)'
 				);
 				self::checkPassedByReference($function);
 				return call_user_func_array($function, $arguments);
@@ -160,7 +160,7 @@ 
 
 		if (array_key_exists($function, self::$patches))
 		{
-			MonkeyPatchManager::log('invoke_func: ' . $function . '() patched');
+			MonkeyPatchManager::log('invoke_func: '.$function.'() patched');
 
 			if (is_callable(self::$patches[$function]))
 			{
@@ -178,7 +178,7 @@ 
 		}
 
 		MonkeyPatchManager::log(
-			'invoke_func: ' . $function . '() not patched (no patch)'
+			'invoke_func: '.$function.'() not patched (no patch)'
 		);
 		self::checkPassedByReference($function);
 		return call_user_func_array($function, $arguments);
@@ -231,7 +231,7 @@ 
 		$msg = str_replace(
 			['<red>', '</red>'], [$red_begin, $red_end], $msg
 		);
-		echo $msg . "\n";
+		echo $msg."\n";
 	}
 
 	/**

application/tests/_ci_phpunit_test/patcher/3.x/Patcher/MethodPatcher.php

Unused Use Statements -2 removed lines

@@ -13,8 +13,6 @@
 require __DIR__ . '/MethodPatcher/NodeVisitor.php';
 require __DIR__ . '/MethodPatcher/PatchManager.php';
 
-use LogicException;
-
 use Kenjis\MonkeyPatch\Patcher\MethodPatcher\NodeVisitor;
 
 class MethodPatcher extends AbstractPatcher

Spacing +3 added lines, -3 removed lines

@@ -10,8 +10,8 @@ 
 
 namespace Kenjis\MonkeyPatch\Patcher;
 
-require __DIR__ . '/MethodPatcher/NodeVisitor.php';
-require __DIR__ . '/MethodPatcher/PatchManager.php';
+require __DIR__.'/MethodPatcher/NodeVisitor.php';
+require __DIR__.'/MethodPatcher/PatchManager.php';
 
 use LogicException;
 
@@ -55,7 +55,7 @@ 
 			{
 				if ($start_method && $token === '{')
 				{
-					$new_source .= '{ ' . self::CODE;
+					$new_source .= '{ '.self::CODE;
 					$start_method = false;
 					$replacement = each(self::$replacement);
 				}

Braces +2 added lines, -4 removed lines

@@ -58,13 +58,11 @@
 					$new_source .= '{ ' . self::CODE;
 					$start_method = false;
 					$replacement = each(self::$replacement);
-				}
-				else
+				} else
 				{
 					$new_source .= $token;
 				}
-			}
-			else
+			} else
 			{
 				$new_source .= $token[1];
 			}

application/tests/_ci_phpunit_test/patcher/3.x/Patcher/MethodPatcher/NodeVisitor.php

Unused Use Statements -1 removed lines

@@ -13,7 +13,6 @@
 use PhpParser\Node;
 use PhpParser\Node\Stmt\ClassMethod;
 use PhpParser\NodeVisitorAbstract;
-
 use Kenjis\MonkeyPatch\Patcher\MethodPatcher;
 
 class NodeVisitor extends NodeVisitorAbstract

Spacing +1 added lines, -1 removed lines

@@ -20,7 +20,7 @@
 {
 	public function leaveNode(Node $node)
 	{
-		if (! ($node instanceof ClassMethod))
+		if ( ! ($node instanceof ClassMethod))
 		{
 			return;
 		}

application/tests/_ci_phpunit_test/CIPHPUnitTest.php

Braces +2 added lines, -4 removed lines

@@ -85,8 +85,7 @@ 
 		if (! self::wiredesignzHmvcInstalled())
 		{
 			new CI_Controller();
-		}
-		else
+		} else
 		{
 			new MX_Controller();
 		}
@@ -106,8 +105,7 @@ 
 		if (! self::wiredesignzHmvcInstalled())
 		{
 			new CI_Controller();
-		}
-		else
+		} else
 		{
 			new CI();
 			new MX_Controller();

Spacing +16 added lines, -16 removed lines

@@ -33,30 +33,30 @@ 
 		$cwd_backup = getcwd();
 
 		// Load autoloader for ci-phpunit-test
-		require __DIR__ . '/autoloader.php';
+		require __DIR__.'/autoloader.php';
 
-		require APPPATH . '/tests/TestCase.php';
+		require APPPATH.'/tests/TestCase.php';
 
-		$db_test_case_file = APPPATH . '/tests/DbTestCase.php';
+		$db_test_case_file = APPPATH.'/tests/DbTestCase.php';
 		if (is_readable($db_test_case_file))
 		{
 			require $db_test_case_file;
 		}
 
 		// Replace a few Common functions
-		require __DIR__ . '/replacing/core/Common.php';
-		require BASEPATH . 'core/Common.php';
+		require __DIR__.'/replacing/core/Common.php';
+		require BASEPATH.'core/Common.php';
 
 		// Workaround for missing CodeIgniter's error handler
 		// See https://github.com/kenjis/ci-phpunit-test/issues/37
 		set_error_handler('_error_handler');
 
 		// Load new functions of CIPHPUnitTest
-		require __DIR__ . '/functions.php';
+		require __DIR__.'/functions.php';
 		// Load ci-phpunit-test CI_Loader
-		require __DIR__ . '/replacing/core/Loader.php';
+		require __DIR__.'/replacing/core/Loader.php';
 		// Load ci-phpunit-test CI_Input
-		require __DIR__ . '/replacing/core/Input.php';
+		require __DIR__.'/replacing/core/Input.php';
 
 		// Change current directory
 		chdir(FCPATH);
@@ -68,12 +68,12 @@ 
 		 *
 		 * And away we go...
 		 */
-		require __DIR__ . '/replacing/core/CodeIgniter.php';
+		require __DIR__.'/replacing/core/CodeIgniter.php';
 
 		self::replaceHelpers();
 
 		// Create CodeIgniter instance
-		if (! self::wiredesignzHmvcInstalled())
+		if ( ! self::wiredesignzHmvcInstalled())
 		{
 			new CI_Controller();
 		}
@@ -94,7 +94,7 @@ 
 
 	public static function createCodeIgniterInstance()
 	{
-		if (! self::wiredesignzHmvcInstalled())
+		if ( ! self::wiredesignzHmvcInstalled())
 		{
 			new CI_Controller();
 		}
@@ -123,11 +123,11 @@ 
 	protected static function replaceLoader()
 	{
 		$my_loader_file = 
-			APPPATH . 'core/' . config_item('subclass_prefix') . 'Loader.php';
+			APPPATH.'core/'.config_item('subclass_prefix').'Loader.php';
 
 		if (file_exists($my_loader_file))
 		{
-			self::$loader_class = config_item('subclass_prefix') . 'Loader';
+			self::$loader_class = config_item('subclass_prefix').'Loader';
 			if ( ! class_exists(self::$loader_class))
 			{
 				require $my_loader_file;
@@ -146,19 +146,19 @@ 
 
 	protected static function loadHelper($helper)
 	{
-		$my_helper_file = APPPATH . 'helpers/' . config_item('subclass_prefix') . $helper . '.php';
+		$my_helper_file = APPPATH.'helpers/'.config_item('subclass_prefix').$helper.'.php';
 		if (file_exists($my_helper_file))
 		{
 			require $my_helper_file;
 		}
-		require __DIR__ . '/replacing/helpers/' . $helper . '.php';
+		require __DIR__.'/replacing/helpers/'.$helper.'.php';
 	}
 
 	public static function setPatcherCacheDir($dir = null)
 	{
 		if ($dir === null)
 		{
-			$dir = APPPATH . 'tests/_ci_phpunit_test/tmp/cache';
+			$dir = APPPATH.'tests/_ci_phpunit_test/tmp/cache';
 		}
 
 		MonkeyPatchManager::setCacheDir(

application/tests/_ci_phpunit_test/patcher/3.x/Patcher/ConstantPatcher/NodeVisitor.php

Spacing +8 added lines, -8 removed lines

@@ -24,7 +24,7 @@ 
 
 	public function enterNode(Node $node)
 	{
-		$callback = [$this, 'before' . ucfirst($node->getType())];
+		$callback = [$this, 'before'.ucfirst($node->getType())];
 		if (is_callable($callback)) {
 			call_user_func_array($callback, [$node]);
 		}
@@ -32,9 +32,9 @@ 
 
 	public function leaveNode(Node $node)
 	{
-		if (! ($node instanceof ConstFetch))
+		if ( ! ($node instanceof ConstFetch))
 		{
-			$callback = [$this, 'rewrite' . ucfirst($node->getType())];
+			$callback = [$this, 'rewrite'.ucfirst($node->getType())];
 			if (is_callable($callback)) {
 				call_user_func_array($callback, [$node]);
 			}
@@ -47,23 +47,23 @@ 
 			return;
 		}
 
-		if (! ($node->name instanceof Name))
+		if ( ! ($node->name instanceof Name))
 		{
 			return;
 		}
 
-		if (! $node->name->isUnqualified())
+		if ( ! $node->name->isUnqualified())
 		{
 			return;
 		}
 
-		if (! ConstantPatcher::isBlacklisted((string) $node->name))
+		if ( ! ConstantPatcher::isBlacklisted((string) $node->name))
 		{
-			$replacement = new FullyQualified('\__ConstProxy__::get(\'' . (string) $node->name . '\')');
+			$replacement = new FullyQualified('\__ConstProxy__::get(\''.(string) $node->name.'\')');
 
 			$pos = $node->getAttribute('startTokenPos');
 			ConstantPatcher::$replacement[$pos] = 
-				'\__ConstProxy__::get(\'' . (string) $node->name .'\')';
+				'\__ConstProxy__::get(\''.(string) $node->name.'\')';
 
 			$node->name = $replacement;
 		}

Unused Use Statements -1 removed lines

@@ -15,7 +15,6 @@
 use PhpParser\Node\Name;
 use PhpParser\Node\Name\FullyQualified;
 use PhpParser\NodeVisitorAbstract;
-
 use Kenjis\MonkeyPatch\Patcher\ConstantPatcher;
 
 class NodeVisitor extends NodeVisitorAbstract

application/tests/_ci_phpunit_test/patcher/3.x/Patcher/ExitPatcher.php

Spacing +2 added lines, -2 removed lines

@@ -10,7 +10,7 @@ 
 
 namespace Kenjis\MonkeyPatch\Patcher;
 
-require __DIR__ . '/../Exception/ExitException.php';
+require __DIR__.'/../Exception/ExitException.php';
 
 class ExitPatcher
 {
@@ -30,7 +30,7 @@ 
 			}
 			elseif ($token[0] === T_EXIT)
 			{
-				if ($tokens[$i+1] === ';')
+				if ($tokens[$i + 1] === ';')
 				{
 					$new_source .= 'exit__()';
 				}

Braces +3 added lines, -6 removed lines

@@ -27,20 +27,17 @@
 			if (is_string($token))
 			{
 				$new_source .= $token;
-			}
-			elseif ($token[0] === T_EXIT)
+			} elseif ($token[0] === T_EXIT)
 			{
 				if ($tokens[$i+1] === ';')
 				{
 					$new_source .= 'exit__()';
-				}
-				else
+				} else
 				{
 					$new_source .= 'exit__';
 				}
 				$patched = true;
-			}
-			else
+			} else
 			{
 				$new_source .= $token[1];
 			}

application/tests/_ci_phpunit_test/patcher/3.x/Patcher/AbstractPatcher.php

Braces +1 added lines, -2 removed lines

@@ -38,8 +38,7 @@
 		{
 			$patched = true;
 			$new_source = static::generateNewSource($source);
-		}
-		else
+		} else
 		{
 			$new_source = $source;
 		}

application/tests/_ci_phpunit_test/patcher/3.x/Patcher/MethodPatcher/PatchManager.php

Spacing +3 added lines, -3 removed lines

@@ -66,16 +66,16 @@
 				$called_method = 'n/a';
 			}
 			
-			$log_args = function () use ($params) {
+			$log_args = function() use ($params) {
 				$output = '';
 				foreach ($params as $arg) {
-					$output .= var_export($arg, true) . ', ';
+					$output .= var_export($arg, true).', ';
 				}
 				$output = rtrim($output, ', ');
 				return $output;
 			};
 			MonkeyPatchManager::log(
-				'invoke_method: ' . $class.'::'.$method . '(' . $log_args() . ') on line ' . $line . ' in ' . $file . ' by ' . $called_method
+				'invoke_method: '.$class.'::'.$method.'('.$log_args().') on line '.$line.' in '.$file.' by '.$called_method
 			);
 //			var_dump($trace); exit;
 		}

Braces +3 added lines, -6 removed lines

@@ -56,12 +56,10 @@ 
 			if (isset($info['class_method']))
 			{
 				$called_method = $info['class_method'];
-			}
-			elseif (isset($info['function']))
+			} elseif (isset($info['function']))
 			{
 				$called_method = $info['function'];
-			}
-			else
+			} else
 			{
 				$called_method = 'n/a';
 			}
@@ -88,8 +86,7 @@ 
 		)
 		{
 			$patch = self::$patches[$class][$method];
-		}
-		else
+		} else
 		{
 			return __GO_TO_ORIG__;
 		}