Inspection of "Added ability to pass arguments when loading libra..." - kenjis/ci-phpunit-test - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Pull Request — master (#213)

unknown

created 2017-10-25 15:48 UTC

Status

Indentation +127 added lines, -127 removed lines patch added patch discarded remove patch

@@ -10,145 +10,145 @@
 block discarded – undo
 
 class Installer
 {
-    const TEST_FOLDER = 'tests';
+	const TEST_FOLDER = 'tests';
 
-    private $silent = false;
+	private $silent = false;
 
-    public function __construct($silent = false)
-    {
-        $this->silent = $silent;
-    }
+	public function __construct($silent = false)
+	{
+		$this->silent = $silent;
+	}
 
-    public function install($app = 'application')
-    {
-        $this->recursiveCopy(
-            dirname(__FILE__) . '/application/tests',
-            $app . '/' . static::TEST_FOLDER
-        );
-        $this->fixPath($app);
-    }
+	public function install($app = 'application')
+	{
+		$this->recursiveCopy(
+			dirname(__FILE__) . '/application/tests',
+			$app . '/' . static::TEST_FOLDER
+		);
+		$this->fixPath($app);
+	}
 
-    /**
-     * Fix paths in Bootstrap.php
-     */
-    private function fixPath($app = 'application')
-    {
-        $file = $app . '/' . static::TEST_FOLDER . '/Bootstrap.php';
-        $contents = file_get_contents($file);
+	/**
+	 * Fix paths in Bootstrap.php
+	 */
+	private function fixPath($app = 'application')
+	{
+		$file = $app . '/' . static::TEST_FOLDER . '/Bootstrap.php';
+		$contents = file_get_contents($file);
         
-        if (! file_exists('system')) {
-            if (file_exists('vendor/codeigniter/framework/system')) {
-                $contents = str_replace(
-                    '$system_path = \'../../system\';',
-                    '$system_path = \'../../vendor/codeigniter/framework/system\';',
-                    $contents
-                );
-            } else {
-                throw new Exception('Can\'t find "system" folder.');
-            }
-        }
+		if (! file_exists('system')) {
+			if (file_exists('vendor/codeigniter/framework/system')) {
+				$contents = str_replace(
+					'$system_path = \'../../system\';',
+					'$system_path = \'../../vendor/codeigniter/framework/system\';',
+					$contents
+				);
+			} else {
+				throw new Exception('Can\'t find "system" folder.');
+			}
+		}
         
-        if (! file_exists('index.php')) {
-            if (file_exists('public/index.php')) {
-                // CodeIgniter 3.0.6 and after
-                $contents = str_replace(
-                    "define('FCPATH', realpath(dirname(__FILE__).'/../..').DIRECTORY_SEPARATOR);",
-                    "define('FCPATH', realpath(dirname(__FILE__).'/../../public').DIRECTORY_SEPARATOR);",
-                    $contents
-                );
-                // CodeIgniter 3.0.5 and before
-                $contents = str_replace(
-                    "define('FCPATH', realpath(dirname(__FILE__).'/../..').'/');",
-                    "define('FCPATH', realpath(dirname(__FILE__).'/../../public').'/');",
-                    $contents
-                );
-            } elseif (file_exists($app . '/public/index.php')) {
-                // CodeIgniter 3.0.6 and after
-                $contents = str_replace(
-                    "define('FCPATH', realpath(dirname(__FILE__).'/../..').DIRECTORY_SEPARATOR);",
-                    "define('FCPATH', realpath(dirname(__FILE__).'/../public').DIRECTORY_SEPARATOR);",
-                    $contents
-                );
-                // CodeIgniter 3.0.5 and before
-                $contents = str_replace(
-                    "define('FCPATH', realpath(dirname(__FILE__).'/../..').'/');",
-                    "define('FCPATH', realpath(dirname(__FILE__).'/../public').'/');",
-                    $contents
-                );
-                if ($app != 'application') {
-                    $contents = str_replace(
-                        "\$application_folder = '../../application';",
-                        "\$application_folder = '../../{$app}';",
-                        $contents
-                    );
-                }
-            } else {
-                throw new Exception('Can\'t find "index.php".');
-            }
-        }
+		if (! file_exists('index.php')) {
+			if (file_exists('public/index.php')) {
+				// CodeIgniter 3.0.6 and after
+				$contents = str_replace(
+					"define('FCPATH', realpath(dirname(__FILE__).'/../..').DIRECTORY_SEPARATOR);",
+					"define('FCPATH', realpath(dirname(__FILE__).'/../../public').DIRECTORY_SEPARATOR);",
+					$contents
+				);
+				// CodeIgniter 3.0.5 and before
+				$contents = str_replace(
+					"define('FCPATH', realpath(dirname(__FILE__).'/../..').'/');",
+					"define('FCPATH', realpath(dirname(__FILE__).'/../../public').'/');",
+					$contents
+				);
+			} elseif (file_exists($app . '/public/index.php')) {
+				// CodeIgniter 3.0.6 and after
+				$contents = str_replace(
+					"define('FCPATH', realpath(dirname(__FILE__).'/../..').DIRECTORY_SEPARATOR);",
+					"define('FCPATH', realpath(dirname(__FILE__).'/../public').DIRECTORY_SEPARATOR);",
+					$contents
+				);
+				// CodeIgniter 3.0.5 and before
+				$contents = str_replace(
+					"define('FCPATH', realpath(dirname(__FILE__).'/../..').'/');",
+					"define('FCPATH', realpath(dirname(__FILE__).'/../public').'/');",
+					$contents
+				);
+				if ($app != 'application') {
+					$contents = str_replace(
+						"\$application_folder = '../../application';",
+						"\$application_folder = '../../{$app}';",
+						$contents
+					);
+				}
+			} else {
+				throw new Exception('Can\'t find "index.php".');
+			}
+		}
         
-        file_put_contents($file, $contents);
-    }
+		file_put_contents($file, $contents);
+	}
 
-    public function update($app = 'application')
-    {
-        $target_dir = $app . '/' . static::TEST_FOLDER . '/_ci_phpunit_test';
-        $this->recursiveUnlink($target_dir);
-        $this->recursiveCopy(
-            dirname(__FILE__) . '/application/tests/_ci_phpunit_test',
-            $target_dir
-        );
-    }
+	public function update($app = 'application')
+	{
+		$target_dir = $app . '/' . static::TEST_FOLDER . '/_ci_phpunit_test';
+		$this->recursiveUnlink($target_dir);
+		$this->recursiveCopy(
+			dirname(__FILE__) . '/application/tests/_ci_phpunit_test',
+			$target_dir
+		);
+	}
 
-    /**
-     * Recursive Copy
-     *
-     * @param string $src
-     * @param string $dst
-     */
-    private function recursiveCopy($src, $dst)
-    {
-        @mkdir($dst, 0755);
+	/**
+	 * Recursive Copy
+	 *
+	 * @param string $src
+	 * @param string $dst
+	 */
+	private function recursiveCopy($src, $dst)
+	{
+		@mkdir($dst, 0755);
         
-        $iterator = new \RecursiveIteratorIterator(
-            new \RecursiveDirectoryIterator($src, \RecursiveDirectoryIterator::SKIP_DOTS),
-            \RecursiveIteratorIterator::SELF_FIRST
-        );
+		$iterator = new \RecursiveIteratorIterator(
+			new \RecursiveDirectoryIterator($src, \RecursiveDirectoryIterator::SKIP_DOTS),
+			\RecursiveIteratorIterator::SELF_FIRST
+		);
         
-        foreach ($iterator as $file) {
-            if ($file->isDir()) {
-                @mkdir($dst . '/' . $iterator->getSubPathName());
-            } else {
-                $success = copy($file, $dst . '/' . $iterator->getSubPathName());
-                if ($success) {
-                    if (! $this->silent) {
-                        echo 'copied: ' . $dst . '/' . $iterator->getSubPathName() . PHP_EOL;
-                    }
-                }
-            }
-        }
-    }
+		foreach ($iterator as $file) {
+			if ($file->isDir()) {
+				@mkdir($dst . '/' . $iterator->getSubPathName());
+			} else {
+				$success = copy($file, $dst . '/' . $iterator->getSubPathName());
+				if ($success) {
+					if (! $this->silent) {
+						echo 'copied: ' . $dst . '/' . $iterator->getSubPathName() . PHP_EOL;
+					}
+				}
+			}
+		}
+	}
 
-    /**
-     * Recursive Unlink
-     *
-     * @param string $dir
-     */
-    private function recursiveUnlink($dir)
-    {
-        $iterator = new \RecursiveIteratorIterator(
-            new \RecursiveDirectoryIterator($dir, \RecursiveDirectoryIterator::SKIP_DOTS),
-            \RecursiveIteratorIterator::CHILD_FIRST
-        );
+	/**
+	 * Recursive Unlink
+	 *
+	 * @param string $dir
+	 */
+	private function recursiveUnlink($dir)
+	{
+		$iterator = new \RecursiveIteratorIterator(
+			new \RecursiveDirectoryIterator($dir, \RecursiveDirectoryIterator::SKIP_DOTS),
+			\RecursiveIteratorIterator::CHILD_FIRST
+		);
         
-        foreach ($iterator as $file) {
-            if ($file->isDir()) {
-                rmdir($file);
-            } else {
-                unlink($file);
-            }
-        }
+		foreach ($iterator as $file) {
+			if ($file->isDir()) {
+				rmdir($file);
+			} else {
+				unlink($file);
+			}
+		}
         
-        rmdir($dir);
-    }
+		rmdir($dir);
+	}
 }

Please login to merge, or discard this patch.

Spacing +12 added lines, -12 removed lines patch added patch discarded remove patch

@@ -22,8 +22,8 @@  discard block
 block discarded – undo
     public function install($app = 'application')
     {
         $this->recursiveCopy(
-            dirname(__FILE__) . '/application/tests',
-            $app . '/' . static::TEST_FOLDER
+            dirname(__FILE__).'/application/tests',
+            $app.'/'.static::TEST_FOLDER
         );
         $this->fixPath($app);
     }
@@ -33,10 +33,10 @@  discard block
 block discarded – undo
      */
     private function fixPath($app = 'application')
     {
-        $file = $app . '/' . static::TEST_FOLDER . '/Bootstrap.php';
+        $file = $app.'/'.static::TEST_FOLDER.'/Bootstrap.php';
         $contents = file_get_contents($file);
         
-        if (! file_exists('system')) {
+        if ( ! file_exists('system')) {
             if (file_exists('vendor/codeigniter/framework/system')) {
                 $contents = str_replace(
                     '$system_path = \'../../system\';',
@@ -48,7 +48,7 @@  discard block
 block discarded – undo
             }
         }
         
-        if (! file_exists('index.php')) {
+        if ( ! file_exists('index.php')) {
             if (file_exists('public/index.php')) {
                 // CodeIgniter 3.0.6 and after
                 $contents = str_replace(
@@ -62,7 +62,7 @@  discard block
 block discarded – undo
                     "define('FCPATH', realpath(dirname(__FILE__).'/../../public').'/');",
                     $contents
                 );
-            } elseif (file_exists($app . '/public/index.php')) {
+            } elseif (file_exists($app.'/public/index.php')) {
                 // CodeIgniter 3.0.6 and after
                 $contents = str_replace(
                     "define('FCPATH', realpath(dirname(__FILE__).'/../..').DIRECTORY_SEPARATOR);",
@@ -92,10 +92,10 @@  discard block
 block discarded – undo
 
     public function update($app = 'application')
     {
-        $target_dir = $app . '/' . static::TEST_FOLDER . '/_ci_phpunit_test';
+        $target_dir = $app.'/'.static::TEST_FOLDER.'/_ci_phpunit_test';
         $this->recursiveUnlink($target_dir);
         $this->recursiveCopy(
-            dirname(__FILE__) . '/application/tests/_ci_phpunit_test',
+            dirname(__FILE__).'/application/tests/_ci_phpunit_test',
             $target_dir
         );
     }
@@ -117,12 +117,12 @@  discard block
 block discarded – undo
         
         foreach ($iterator as $file) {
             if ($file->isDir()) {
-                @mkdir($dst . '/' . $iterator->getSubPathName());
+                @mkdir($dst.'/'.$iterator->getSubPathName());
             } else {
-                $success = copy($file, $dst . '/' . $iterator->getSubPathName());
+                $success = copy($file, $dst.'/'.$iterator->getSubPathName());
                 if ($success) {
-                    if (! $this->silent) {
-                        echo 'copied: ' . $dst . '/' . $iterator->getSubPathName() . PHP_EOL;
+                    if ( ! $this->silent) {
+                        echo 'copied: '.$dst.'/'.$iterator->getSubPathName().PHP_EOL;
                     }
                 }
             }

Please login to merge, or discard this patch.

application/tests/_ci_phpunit_test/patcher/2.x/MonkeyPatchManager.php 4 patches

Doc Comments +6 added lines patch added patch discarded remove patch

@@ -35,6 +35,9 @@  discard block
 block discarded – undo
 		'ConstantPatcher',
 	];
 
+	/**
+	 * @param string $message
+	 */
 	public static function log($message)
 	{
 		if (! self::$debug)
@@ -303,6 +306,9 @@  discard block
 block discarded – undo
 		self::$load_patchers = true;
 	}
 
+	/**
+	 * @param string $source
+	 */
 	protected static function execPatchers($source)
 	{
 		$patched = false;

Please login to merge, or discard this patch.

Unused Use Statements -1 removed lines patch added patch discarded remove patch

@@ -11,7 +11,6 @@
 block discarded – undo
 namespace Kenjis\MonkeyPatch;
 
 use LogicException;
-use RuntimeException;
 use PhpParser\ParserFactory;
 use Kenjis\MonkeyPatch\Patcher\FunctionPatcher;
 

Please login to merge, or discard this patch.

Braces +1 added lines, -2 removed lines patch added patch discarded remove patch

@@ -70,8 +70,7 @@
 block discarded – undo
 		if (isset($config['root_dir']))
 		{
 			Cache::setProjectRootDir($config['root_dir']);
-		}
-		else
+		} else
 		{
 			// APPPATH is constant in CodeIgniter
 			Cache::setProjectRootDir(APPPATH . '../');

Please login to merge, or discard this patch.

Spacing +17 added lines, -17 removed lines patch added patch discarded remove patch

@@ -37,7 +37,7 @@  discard block
 block discarded – undo
 
 	public static function log($message)
 	{
-		if (! self::$debug)
+		if ( ! self::$debug)
 		{
 			return;
 		}
@@ -72,7 +72,7 @@  discard block
 block discarded – undo
 		}
 		if (self::$debug)
 		{
-			self::$log_file = __DIR__ . '/debug.log';
+			self::$log_file = __DIR__.'/debug.log';
 		}
 	}
 
@@ -85,10 +85,10 @@  discard block
 block discarded – undo
 		else
 		{
 			// APPPATH is constant in CodeIgniter
-			Cache::setProjectRootDir(APPPATH . '../');
+			Cache::setProjectRootDir(APPPATH.'../');
 		}
 
-		if (! isset($config['cache_dir']))
+		if ( ! isset($config['cache_dir']))
 		{
 			throw new LogicException('You have to set "cache_dir"');
 		}
@@ -97,7 +97,7 @@  discard block
 block discarded – undo
 
 	protected static function setPaths(array $config)
 	{
-		if (! isset($config['include_paths']))
+		if ( ! isset($config['include_paths']))
 		{
 			throw new LogicException('You have to set "include_paths"');
 		}
@@ -158,7 +158,7 @@  discard block
 block discarded – undo
 		// Updated?
 		if ($cached !== $current)
 		{
-			MonkeyPatchManager::log('clear_src_cache: from ' . __METHOD__);
+			MonkeyPatchManager::log('clear_src_cache: from '.__METHOD__);
 			Cache::clearSrcCache();
 			Cache::writeTmpIncludePaths($current);
 		}
@@ -169,7 +169,7 @@  discard block
 block discarded – undo
 		// Updated?
 		if ($cached !== $current)
 		{
-			MonkeyPatchManager::log('clear_src_cache: from ' . __METHOD__);
+			MonkeyPatchManager::log('clear_src_cache: from '.__METHOD__);
 			Cache::clearSrcCache();
 			Cache::writeTmpExcludePaths($current);
 		}
@@ -182,7 +182,7 @@  discard block
 block discarded – undo
 		// Updated?
 		if ($cached !== self::$patcher_list)
 		{
-			MonkeyPatchManager::log('clear_src_cache: from ' . __METHOD__);
+			MonkeyPatchManager::log('clear_src_cache: from '.__METHOD__);
 			Cache::clearSrcCache();
 			Cache::writeTmpPatcherList(self::$patcher_list);
 		}
@@ -196,7 +196,7 @@  discard block
 block discarded – undo
 		// Updated?
 		if ($cached !== $current)
 		{
-			MonkeyPatchManager::log('clear_src_cache: from ' . __METHOD__);
+			MonkeyPatchManager::log('clear_src_cache: from '.__METHOD__);
 			Cache::clearSrcCache();
 			Cache::writeTmpFunctionWhitelist($current);
 		}
@@ -258,7 +258,7 @@  discard block
 block discarded – undo
 	 */
 	public static function patch($path)
 	{
-		if (! is_readable($path))
+		if ( ! is_readable($path))
 		{
 			throw new LogicException("Can't read '$path'");
 		}
@@ -266,17 +266,17 @@  discard block
 block discarded – undo
 		// Check cache file
 		if ($cache_file = Cache::getValidSrcCachePath($path))
 		{
-			self::log('cache_hit: ' . $path);
+			self::log('cache_hit: '.$path);
 			return fopen($cache_file, 'r');
 		}
 
-		self::log('cache_miss: ' . $path);
+		self::log('cache_miss: '.$path);
 		$source = file_get_contents($path);
 
 		list($new_source, $patched) = self::execPatchers($source);
 
 		// Write to cache file
-		self::log('write_cache: ' . $path);
+		self::log('write_cache: '.$path);
 		Cache::writeSrcCacheFile($path, $new_source);
 
 		$resource = fopen('php://memory', 'rb+');
@@ -292,12 +292,12 @@  discard block
 block discarded – undo
 			return;
 		}
 
-		require __DIR__ . '/Patcher/AbstractPatcher.php';
-		require __DIR__ . '/Patcher/Backtrace.php';
+		require __DIR__.'/Patcher/AbstractPatcher.php';
+		require __DIR__.'/Patcher/Backtrace.php';
 
 		foreach (self::$patcher_list as $classname)
 		{
-			require __DIR__ . '/Patcher/' . $classname . '.php';
+			require __DIR__.'/Patcher/'.$classname.'.php';
 		}
 
 		self::$load_patchers = true;
@@ -308,7 +308,7 @@  discard block
 block discarded – undo
 		$patched = false;
 		foreach (self::$patcher_list as $classname)
 		{
-			$classname = 'Kenjis\MonkeyPatch\Patcher\\' . $classname;
+			$classname = 'Kenjis\MonkeyPatch\Patcher\\'.$classname;
 			$patcher = new $classname;
 			list($source, $patched_this) = $patcher->patch($source);
 			$patched = $patched || $patched_this;

Please login to merge, or discard this patch.

tests/_ci_phpunit_test/patcher/2.x/Patcher/ConstantPatcher/NodeVisitor.php 2 patches

Unused Use Statements -1 removed lines patch added patch discarded remove patch

@@ -15,7 +15,6 @@
 block discarded – undo
 use PhpParser\Node\Name;
 use PhpParser\Node\Name\FullyQualified;
 use PhpParser\NodeVisitorAbstract;
-
 use Kenjis\MonkeyPatch\Patcher\ConstantPatcher;
 
 class NodeVisitor extends NodeVisitorAbstract

Please login to merge, or discard this patch.

Spacing +8 added lines, -8 removed lines patch added patch discarded remove patch

@@ -24,7 +24,7 @@  discard block
 block discarded – undo
 
 	public function enterNode(Node $node)
 	{
-		$callback = [$this, 'before' . ucfirst($node->getType())];
+		$callback = [$this, 'before'.ucfirst($node->getType())];
 		if (is_callable($callback)) {
 			call_user_func_array($callback, [$node]);
 		}
@@ -32,9 +32,9 @@  discard block
 block discarded – undo
 
 	public function leaveNode(Node $node)
 	{
-		if (! ($node instanceof ConstFetch))
+		if ( ! ($node instanceof ConstFetch))
 		{
-			$callback = [$this, 'rewrite' . ucfirst($node->getType())];
+			$callback = [$this, 'rewrite'.ucfirst($node->getType())];
 			if (is_callable($callback)) {
 				call_user_func_array($callback, [$node]);
 			}
@@ -47,26 +47,26 @@  discard block
 block discarded – undo
 			return;
 		}
 
-		if (! ($node->name instanceof Name))
+		if ( ! ($node->name instanceof Name))
 		{
 			return;
 		}
 
-		if (! $node->name->isUnqualified())
+		if ( ! $node->name->isUnqualified())
 		{
 			return;
 		}
 
-		if (! ConstantPatcher::isBlacklisted((string) $node->name))
+		if ( ! ConstantPatcher::isBlacklisted((string) $node->name))
 		{
 			$replacement = new FullyQualified(array());
 			$replacement->set(
-				'\__ConstProxy__::get(\'' . (string) $node->name . '\')'
+				'\__ConstProxy__::get(\''.(string) $node->name.'\')'
 			);
 
 			$pos = $node->getAttribute('startTokenPos');
 			ConstantPatcher::$replacement[$pos] = 
-				'\__ConstProxy__::get(\'' . (string) $node->name .'\')';
+				'\__ConstProxy__::get(\''.(string) $node->name.'\')';
 
 			$node->name = $replacement;
 		}

Please login to merge, or discard this patch.

tests/_ci_phpunit_test/patcher/2.x/Patcher/FunctionPatcher/NodeVisitor.php 2 patches

Unused Use Statements -4 removed lines patch added patch discarded remove patch

@@ -21,15 +21,11 @@
 block discarded – undo
 
 namespace Kenjis\MonkeyPatch\Patcher\FunctionPatcher;
 
-use ReflectionFunction;
-use ReflectionException;
-
 use PhpParser\Node;
 use PhpParser\Node\Expr\FuncCall;
 use PhpParser\Node\Name;
 use PhpParser\Node\Name\FullyQualified;
 use PhpParser\NodeVisitorAbstract;
-
 use Kenjis\MonkeyPatch\Patcher\FunctionPatcher;
 
 class NodeVisitor extends NodeVisitorAbstract

Please login to merge, or discard this patch.

Spacing +5 added lines, -5 removed lines patch added patch discarded remove patch

@@ -36,17 +36,17 @@  discard block
 block discarded – undo
 {
 	public function leaveNode(Node $node)
 	{
-		if (! ($node instanceof FuncCall))
+		if ( ! ($node instanceof FuncCall))
 		{
 			return;
 		}
 
-		if (! ($node->name instanceof Name))
+		if ( ! ($node->name instanceof Name))
 		{
 			return;
 		}
 
-		if (! $node->name->isUnqualified())
+		if ( ! $node->name->isUnqualified())
 		{
 			return;
 		}
@@ -57,12 +57,12 @@  discard block
 block discarded – undo
 		) {
 			$replacement = new FullyQualified(array());
 			$replacement->set(
-				'\__FuncProxy__::' . (string) $node->name
+				'\__FuncProxy__::'.(string) $node->name
 			);
 
 			$pos = $node->getAttribute('startTokenPos');
 			FunctionPatcher::$replacement[$pos] = 
-				'\__FuncProxy__::' . (string) $node->name;
+				'\__FuncProxy__::'.(string) $node->name;
 
 			$node->name = $replacement;
 		}

Please login to merge, or discard this patch.

tests/_ci_phpunit_test/patcher/2.x/Patcher/FunctionPatcher/Proxy.php 3 patches

Doc Comments +10 added lines, -1 removed lines patch added patch discarded remove patch

@@ -37,7 +37,7 @@  discard block
 block discarded – undo
 	 * 
 	 * @param string $function     function name
 	 * @param mixed  $return_value return value or callable
-	 * @param string $class_name   class::method to apply this patch
+	 * @param string $class_method   class::method to apply this patch
 	 * 
 	 * @throws LogicException
 	 */
@@ -86,6 +86,9 @@  discard block
 block discarded – undo
 		InvocationVerifier::verify(self::$expected_invocations, self::$invocations);
 	}
 
+	/**
+	 * @param string $function
+	 */
 	protected static function logInvocation($function, $arguments)
 	{
 		if (MonkeyPatchManager::$debug)
@@ -111,6 +114,9 @@  discard block
 block discarded – undo
 		}
 	}
 
+	/**
+	 * @param string $function
+	 */
 	protected static function checkCalledMethod($function)
 	{
 		$trace = debug_backtrace();
@@ -184,6 +190,9 @@  discard block
 block discarded – undo
 		return call_user_func_array($function, $arguments);
 	}
 
+	/**
+	 * @param string $function
+	 */
 	protected static function checkPassedByReference($function)
 	{
 		$ref_func = new ReflectionFunction($function);

Please login to merge, or discard this patch.

Unused Use Statements -1 removed lines patch added patch discarded remove patch

@@ -15,7 +15,6 @@
 block discarded – undo
 use LogicException;
 use ReflectionFunction;
 use ReflectionException;
-
 use Kenjis\MonkeyPatch\Patcher\FunctionPatcher;
 use Kenjis\MonkeyPatch\Patcher\Backtrace;
 use Kenjis\MonkeyPatch\MonkeyPatchManager;

Please login to merge, or discard this patch.

Spacing +9 added lines, -9 removed lines patch added patch discarded remove patch

@@ -51,7 +51,7 @@  discard block
 block discarded – undo
 			self::outputMessage($msg);
 			throw new LogicException($msg);
 		}
-		if (! FunctionPatcher::isWhitelisted($function))
+		if ( ! FunctionPatcher::isWhitelisted($function))
 		{
 			$msg = "<red>Can't patch on '$function'. It is not in whitelist. If you want to patch it, please add it to 'functions_to_patch' in 'tests/Bootstrap.php'. But note that there are some limitations. See <https://github.com/kenjis/ci-phpunit-test/blob/master/docs/HowToWriteTests.md#patching-functions> for details.</red>";
 			self::outputMessage($msg);
@@ -97,16 +97,16 @@  discard block
 block discarded – undo
 			$line = $info['line'];
 			$method = isset($info['class_method']) ? $info['class_method'] : $info['function'];
 
-			$log_args = function () use ($arguments) {
+			$log_args = function() use ($arguments) {
 				$output = '';
 				foreach ($arguments as $arg) {
-					$output .= var_export($arg, true) . ', ';
+					$output .= var_export($arg, true).', ';
 				}
 				$output = rtrim($output, ', ');
 				return $output;
 			};
 			MonkeyPatchManager::log(
-				'invoke_func: ' . $function . '(' . $log_args() . ') on line ' . $line . ' in ' . $file . ' by ' . $method . '()'
+				'invoke_func: '.$function.'('.$log_args().') on line '.$line.' in '.$file.' by '.$method.'()'
 			);
 		}
 	}
@@ -148,10 +148,10 @@  discard block
 block discarded – undo
 
 		if (isset(self::$patches_to_apply[$function]))
 		{
-			if (! self::checkCalledMethod($function))
+			if ( ! self::checkCalledMethod($function))
 			{
 				MonkeyPatchManager::log(
-					'invoke_func: ' . $function . '() not patched (out of scope)'
+					'invoke_func: '.$function.'() not patched (out of scope)'
 				);
 				self::checkPassedByReference($function);
 				return call_user_func_array($function, $arguments);
@@ -160,7 +160,7 @@  discard block
 block discarded – undo
 
 		if (array_key_exists($function, self::$patches))
 		{
-			MonkeyPatchManager::log('invoke_func: ' . $function . '() patched');
+			MonkeyPatchManager::log('invoke_func: '.$function.'() patched');
 
 			if (is_callable(self::$patches[$function]))
 			{
@@ -178,7 +178,7 @@  discard block
 block discarded – undo
 		}
 
 		MonkeyPatchManager::log(
-			'invoke_func: ' . $function . '() not patched (no patch)'
+			'invoke_func: '.$function.'() not patched (no patch)'
 		);
 		self::checkPassedByReference($function);
 		return call_user_func_array($function, $arguments);
@@ -231,7 +231,7 @@  discard block
 block discarded – undo
 		$msg = str_replace(
 			['<red>', '</red>'], [$red_begin, $red_end], $msg
 		);
-		echo $msg . "\n";
+		echo $msg."\n";
 	}
 
 	/**

Please login to merge, or discard this patch.

application/tests/_ci_phpunit_test/patcher/3.x/MonkeyPatchManager.php 4 patches

Unused Use Statements -1 removed lines patch added patch discarded remove patch

@@ -11,7 +11,6 @@
 block discarded – undo
 namespace Kenjis\MonkeyPatch;
 
 use LogicException;
-use RuntimeException;
 use PhpParser\ParserFactory;
 use Kenjis\MonkeyPatch\Patcher\FunctionPatcher;
 

Please login to merge, or discard this patch.

Spacing +17 added lines, -17 removed lines patch added patch discarded remove patch

@@ -37,7 +37,7 @@  discard block
 block discarded – undo
 
 	public static function log($message)
 	{
-		if (! self::$debug)
+		if ( ! self::$debug)
 		{
 			return;
 		}
@@ -72,7 +72,7 @@  discard block
 block discarded – undo
 		}
 		if (self::$debug)
 		{
-			self::$log_file = __DIR__ . '/debug.log';
+			self::$log_file = __DIR__.'/debug.log';
 		}
 	}
 
@@ -85,10 +85,10 @@  discard block
 block discarded – undo
 		else
 		{
 			// APPPATH is constant in CodeIgniter
-			Cache::setProjectRootDir(APPPATH . '../');
+			Cache::setProjectRootDir(APPPATH.'../');
 		}
 
-		if (! isset($config['cache_dir']))
+		if ( ! isset($config['cache_dir']))
 		{
 			throw new LogicException('You have to set "cache_dir"');
 		}
@@ -97,7 +97,7 @@  discard block
 block discarded – undo
 
 	protected static function setPaths(array $config)
 	{
-		if (! isset($config['include_paths']))
+		if ( ! isset($config['include_paths']))
 		{
 			throw new LogicException('You have to set "include_paths"');
 		}
@@ -158,7 +158,7 @@  discard block
 block discarded – undo
 		// Updated?
 		if ($cached !== $current)
 		{
-			MonkeyPatchManager::log('clear_src_cache: from ' . __METHOD__);
+			MonkeyPatchManager::log('clear_src_cache: from '.__METHOD__);
 			Cache::clearSrcCache();
 			Cache::writeTmpIncludePaths($current);
 		}
@@ -169,7 +169,7 @@  discard block
 block discarded – undo
 		// Updated?
 		if ($cached !== $current)
 		{
-			MonkeyPatchManager::log('clear_src_cache: from ' . __METHOD__);
+			MonkeyPatchManager::log('clear_src_cache: from '.__METHOD__);
 			Cache::clearSrcCache();
 			Cache::writeTmpExcludePaths($current);
 		}
@@ -182,7 +182,7 @@  discard block
 block discarded – undo
 		// Updated?
 		if ($cached !== self::$patcher_list)
 		{
-			MonkeyPatchManager::log('clear_src_cache: from ' . __METHOD__);
+			MonkeyPatchManager::log('clear_src_cache: from '.__METHOD__);
 			Cache::clearSrcCache();
 			Cache::writeTmpPatcherList(self::$patcher_list);
 		}
@@ -196,7 +196,7 @@  discard block
 block discarded – undo
 		// Updated?
 		if ($cached !== $current)
 		{
-			MonkeyPatchManager::log('clear_src_cache: from ' . __METHOD__);
+			MonkeyPatchManager::log('clear_src_cache: from '.__METHOD__);
 			Cache::clearSrcCache();
 			Cache::writeTmpFunctionWhitelist($current);
 		}
@@ -258,7 +258,7 @@  discard block
 block discarded – undo
 	 */
 	public static function patch($path)
 	{
-		if (! is_readable($path))
+		if ( ! is_readable($path))
 		{
 			throw new LogicException("Can't read '$path'");
 		}
@@ -266,17 +266,17 @@  discard block
 block discarded – undo
 		// Check cache file
 		if ($cache_file = Cache::getValidSrcCachePath($path))
 		{
-			self::log('cache_hit: ' . $path);
+			self::log('cache_hit: '.$path);
 			return fopen($cache_file, 'r');
 		}
 
-		self::log('cache_miss: ' . $path);
+		self::log('cache_miss: '.$path);
 		$source = file_get_contents($path);
 
 		list($new_source, $patched) = self::execPatchers($source);
 
 		// Write to cache file
-		self::log('write_cache: ' . $path);
+		self::log('write_cache: '.$path);
 		Cache::writeSrcCacheFile($path, $new_source);
 
 		$resource = fopen('php://memory', 'rb+');
@@ -292,12 +292,12 @@  discard block
 block discarded – undo
 			return;
 		}
 
-		require __DIR__ . '/Patcher/AbstractPatcher.php';
-		require __DIR__ . '/Patcher/Backtrace.php';
+		require __DIR__.'/Patcher/AbstractPatcher.php';
+		require __DIR__.'/Patcher/Backtrace.php';
 
 		foreach (self::$patcher_list as $classname)
 		{
-			require __DIR__ . '/Patcher/' . $classname . '.php';
+			require __DIR__.'/Patcher/'.$classname.'.php';
 		}
 
 		self::$load_patchers = true;
@@ -308,7 +308,7 @@  discard block
 block discarded – undo
 		$patched = false;
 		foreach (self::$patcher_list as $classname)
 		{
-			$classname = 'Kenjis\MonkeyPatch\Patcher\\' . $classname;
+			$classname = 'Kenjis\MonkeyPatch\Patcher\\'.$classname;
 			$patcher = new $classname;
 			list($source, $patched_this) = $patcher->patch($source);
 			$patched = $patched || $patched_this;

Please login to merge, or discard this patch.

Braces +1 added lines, -2 removed lines patch added patch discarded remove patch

@@ -70,8 +70,7 @@
 block discarded – undo
 		if (isset($config['root_dir']))
 		{
 			Cache::setProjectRootDir($config['root_dir']);
-		}
-		else
+		} else
 		{
 			// APPPATH is constant in CodeIgniter
 			Cache::setProjectRootDir(APPPATH . '../');

Please login to merge, or discard this patch.

Doc Comments +6 added lines patch added patch discarded remove patch

@@ -35,6 +35,9 @@  discard block
 block discarded – undo
 		'ConstantPatcher',
 	];
 
+	/**
+	 * @param string $message
+	 */
 	public static function log($message)
 	{
 		if (! self::$debug)
@@ -303,6 +306,9 @@  discard block
 block discarded – undo
 		self::$load_patchers = true;
 	}
 
+	/**
+	 * @param string $source
+	 */
 	protected static function execPatchers($source)
 	{
 		$patched = false;

Please login to merge, or discard this patch.

application/tests/_ci_phpunit_test/patcher/3.x/Patcher/Backtrace.php 3 patches

Doc Comments +3 added lines patch added patch discarded remove patch

@@ -20,6 +20,9 @@
 block discarded – undo
 		'ConstantPatcher' => 0,
 	];
 
+	/**
+	 * @param string $patcher
+	 */
 	public static function getInfo($patcher, $backtrace)
 	{
 		if (! isset(self::$map[$patcher]))

Please login to merge, or discard this patch.

Spacing +6 added lines, -6 removed lines patch added patch discarded remove patch

@@ -21,7 +21,7 @@  discard block
 block discarded – undo
 
 	public static function getInfo($patcher, $backtrace)
 	{
-		if (! isset(self::$map[$patcher]))
+		if ( ! isset(self::$map[$patcher]))
 		{
 			throw new LogicException("No such a patcher: $patcher");
 		}
@@ -41,12 +41,12 @@  discard block
 block discarded – undo
 		$line = isset($backtrace[$offset]['line'])
 				? $backtrace[$offset]['line'] : null;
 
-		if (isset($backtrace[$offset+2]))
+		if (isset($backtrace[$offset + 2]))
 		{
-			$class  = isset($backtrace[$offset+2]['class'])
-					? $backtrace[$offset+2]['class']
+			$class = isset($backtrace[$offset + 2]['class'])
+					? $backtrace[$offset + 2]['class']
 					: null;
-			$function = $backtrace[$offset+2]['function'];
+			$function = $backtrace[$offset + 2]['function'];
 		}
 		else
 		{
@@ -57,7 +57,7 @@  discard block
 block discarded – undo
 		if (isset($class))
 		{
 			$method = $function;
-			$class_method = $class . '::' . $function;
+			$class_method = $class.'::'.$function;
 			$function = null;
 		}
 		else

Please login to merge, or discard this patch.

Braces +2 added lines, -4 removed lines patch added patch discarded remove patch

@@ -47,8 +47,7 @@  discard block
 block discarded – undo
 					? $backtrace[$offset+2]['class']
 					: null;
 			$function = $backtrace[$offset+2]['function'];
-		}
-		else
+		} else
 		{
 			$class = null;
 			$function = null;
@@ -59,8 +58,7 @@  discard block
 block discarded – undo
 			$method = $function;
 			$class_method = $class . '::' . $function;
 			$function = null;
-		}
-		else
+		} else
 		{
 			$method = null;
 			$class_method = null;

Please login to merge, or discard this patch.

application/tests/_ci_phpunit_test/patcher/3.x/Patcher/ConstantPatcher.php 3 patches

Unused Use Statements -1 removed lines patch added patch discarded remove patch

@@ -14,7 +14,6 @@
 block discarded – undo
 require __DIR__ . '/ConstantPatcher/Proxy.php';
 
 use LogicException;
-
 use Kenjis\MonkeyPatch\Patcher\ConstantPatcher\NodeVisitor;
 
 class ConstantPatcher extends AbstractPatcher

Please login to merge, or discard this patch.

Spacing +2 added lines, -2 removed lines patch added patch discarded remove patch

@@ -10,8 +10,8 @@
 block discarded – undo
 
 namespace Kenjis\MonkeyPatch\Patcher;
 
-require __DIR__ . '/ConstantPatcher/NodeVisitor.php';
-require __DIR__ . '/ConstantPatcher/Proxy.php';
+require __DIR__.'/ConstantPatcher/NodeVisitor.php';
+require __DIR__.'/ConstantPatcher/Proxy.php';
 
 use LogicException;
 

Please login to merge, or discard this patch.

Braces +2 added lines, -4 removed lines patch added patch discarded remove patch

@@ -173,13 +173,11 @@
 block discarded – undo
 			if (is_string($token))
 			{
 				$new_source .= $token;
-			}
-			elseif ($i == $replacement['key'])
+			} elseif ($i == $replacement['key'])
 			{
 				$new_source .= $replacement['value'];
 				$replacement = each(self::$replacement);
-			}
-			else
+			} else
 			{
 				$new_source .= $token[1];
 			}

Please login to merge, or discard this patch.

tests/_ci_phpunit_test/patcher/3.x/Patcher/ConstantPatcher/Proxy.php 3 patches

Doc Comments +6 added lines patch added patch discarded remove patch

@@ -51,6 +51,9 @@  discard block
 block discarded – undo
 		self::$patches_to_apply = [];
 	}
 
+	/**
+	 * @param string $constant
+	 */
 	protected static function logInvocation($constant)
 	{
 		if (MonkeyPatchManager::$debug)
@@ -68,6 +71,9 @@  discard block
 block discarded – undo
 		}
 	}
 
+	/**
+	 * @param string $constant
+	 */
 	protected static function checkCalledMethod($constant)
 	{
 		$trace = debug_backtrace();

Please login to merge, or discard this patch.

Unused Use Statements -5 removed lines patch added patch discarded remove patch

@@ -13,14 +13,9 @@
 block discarded – undo
 class_alias('Kenjis\MonkeyPatch\Patcher\ConstantPatcher\Proxy', '__ConstProxy__');
 
 use LogicException;
-use ReflectionConstant;
-use ReflectionException;
-
 use Kenjis\MonkeyPatch\Patcher\ConstantPatcher;
 use Kenjis\MonkeyPatch\Patcher\Backtrace;
 use Kenjis\MonkeyPatch\MonkeyPatchManager;
-use Kenjis\MonkeyPatch\Cache;
-use Kenjis\MonkeyPatch\InvocationVerifier;
 
 class Proxy
 {

Please login to merge, or discard this patch.

Spacing +5 added lines, -5 removed lines patch added patch discarded remove patch

@@ -65,7 +65,7 @@  discard block
 block discarded – undo
 			$method = isset($info['class_method']) ? $info['class_method'] : $info['function'];
 
 			MonkeyPatchManager::log(
-				'invoke_const: ' . $constant . ') on line ' . $line . ' in ' . $file . ' by ' . $method . '()'
+				'invoke_const: '.$constant.') on line '.$line.' in '.$file.' by '.$method.'()'
 			);
 		}
 	}
@@ -111,10 +111,10 @@  discard block
 block discarded – undo
 
 		if (isset(self::$patches_to_apply[$constant]))
 		{
-			if (! self::checkCalledMethod($constant))
+			if ( ! self::checkCalledMethod($constant))
 			{
 				MonkeyPatchManager::log(
-					'invoke_const: ' . $constant . ' not patched (out of scope)'
+					'invoke_const: '.$constant.' not patched (out of scope)'
 				);
 				return constant($constant);
 			}
@@ -122,12 +122,12 @@  discard block
 block discarded – undo
 
 		if (array_key_exists($constant, self::$patches))
 		{
-			MonkeyPatchManager::log('invoke_const: ' . $constant . ' patched');
+			MonkeyPatchManager::log('invoke_const: '.$constant.' patched');
 			return self::$patches[$constant];
 		}
 
 		MonkeyPatchManager::log(
-			'invoke_const: ' . $constant . ' not patched (no patch)'
+			'invoke_const: '.$constant.' not patched (no patch)'
 		);
 		return constant($constant);
 	}

Please login to merge, or discard this patch.

		@@ -37,7 +37,7 @@ discard block
		block discarded – undo
37	37
38	38	public static function log($message)
39	39	{
40		- if (! self::$debug)
	40	+ if ( ! self::$debug)
41	41	{
42	42	return;
43	43	}
		@@ -72,7 +72,7 @@ discard block
		block discarded – undo
72	72	}
73	73	if (self::$debug)
74	74	{
75		- self::$log_file = __DIR__ . '/debug.log';
	75	+ self::$log_file = __DIR__.'/debug.log';
76	76	}
77	77	}
78	78
		@@ -85,10 +85,10 @@ discard block
		block discarded – undo
85	85	else
86	86	{
87	87	// APPPATH is constant in CodeIgniter
88		- Cache::setProjectRootDir(APPPATH . '../');
	88	+ Cache::setProjectRootDir(APPPATH.'../');
89	89	}
90	90
91		- if (! isset($config['cache_dir']))
	91	+ if ( ! isset($config['cache_dir']))
92	92	{
93	93	throw new LogicException('You have to set "cache_dir"');
94	94	}
		@@ -97,7 +97,7 @@ discard block
		block discarded – undo
97	97
98	98	protected static function setPaths(array $config)
99	99	{
100		- if (! isset($config['include_paths']))
	100	+ if ( ! isset($config['include_paths']))
101	101	{
102	102	throw new LogicException('You have to set "include_paths"');
103	103	}
		@@ -158,7 +158,7 @@ discard block
		block discarded – undo
158	158	// Updated?
159	159	if ($cached !== $current)
160	160	{
161		- MonkeyPatchManager::log('clear_src_cache: from ' . __METHOD__);
	161	+ MonkeyPatchManager::log('clear_src_cache: from '.__METHOD__);
162	162	Cache::clearSrcCache();
163	163	Cache::writeTmpIncludePaths($current);
164	164	}
		@@ -169,7 +169,7 @@ discard block
		block discarded – undo
169	169	// Updated?
170	170	if ($cached !== $current)
171	171	{
172		- MonkeyPatchManager::log('clear_src_cache: from ' . __METHOD__);
	172	+ MonkeyPatchManager::log('clear_src_cache: from '.__METHOD__);
173	173	Cache::clearSrcCache();
174	174	Cache::writeTmpExcludePaths($current);
175	175	}
		@@ -182,7 +182,7 @@ discard block
		block discarded – undo
182	182	// Updated?
183	183	if ($cached !== self::$patcher_list)
184	184	{
185		- MonkeyPatchManager::log('clear_src_cache: from ' . __METHOD__);
	185	+ MonkeyPatchManager::log('clear_src_cache: from '.__METHOD__);
186	186	Cache::clearSrcCache();
187	187	Cache::writeTmpPatcherList(self::$patcher_list);
188	188	}
		@@ -196,7 +196,7 @@ discard block
		block discarded – undo
196	196	// Updated?
197	197	if ($cached !== $current)
198	198	{
199		- MonkeyPatchManager::log('clear_src_cache: from ' . __METHOD__);
	199	+ MonkeyPatchManager::log('clear_src_cache: from '.__METHOD__);
200	200	Cache::clearSrcCache();
201	201	Cache::writeTmpFunctionWhitelist($current);
202	202	}
		@@ -258,7 +258,7 @@ discard block
		block discarded – undo
258	258	*/
259	259	public static function patch($path)
260	260	{
261		- if (! is_readable($path))
	261	+ if ( ! is_readable($path))
262	262	{
263	263	throw new LogicException("Can't read '$path'");
264	264	}
		@@ -266,17 +266,17 @@ discard block
		block discarded – undo
266	266	// Check cache file
267	267	if ($cache_file = Cache::getValidSrcCachePath($path))
268	268	{
269		- self::log('cache_hit: ' . $path);
	269	+ self::log('cache_hit: '.$path);
270	270	return fopen($cache_file, 'r');
271	271	}
272	272
273		- self::log('cache_miss: ' . $path);
	273	+ self::log('cache_miss: '.$path);
274	274	$source = file_get_contents($path);
275	275
276	276	list($new_source, $patched) = self::execPatchers($source);
277	277
278	278	// Write to cache file
279		- self::log('write_cache: ' . $path);
	279	+ self::log('write_cache: '.$path);
280	280	Cache::writeSrcCacheFile($path, $new_source);
281	281
282	282	$resource = fopen('php://memory', 'rb+');
		@@ -292,12 +292,12 @@ discard block
		block discarded – undo
292	292	return;
293	293	}
294	294
295		- require __DIR__ . '/Patcher/AbstractPatcher.php';
296		- require __DIR__ . '/Patcher/Backtrace.php';
	295	+ require __DIR__.'/Patcher/AbstractPatcher.php';
	296	+ require __DIR__.'/Patcher/Backtrace.php';
297	297
298	298	foreach (self::$patcher_list as $classname)
299	299	{
300		- require __DIR__ . '/Patcher/' . $classname . '.php';
	300	+ require __DIR__.'/Patcher/'.$classname.'.php';
301	301	}
302	302
303	303	self::$load_patchers = true;
		@@ -308,7 +308,7 @@ discard block
		block discarded – undo
308	308	$patched = false;
309	309	foreach (self::$patcher_list as $classname)
310	310	{
311		- $classname = 'Kenjis\MonkeyPatch\Patcher\\' . $classname;
	311	+ $classname = 'Kenjis\MonkeyPatch\Patcher\\'.$classname;
312	312	$patcher = new $classname;
313	313	list($source, $patched_this) = $patcher->patch($source);
314	314	$patched = $patched \|\| $patched_this;

		@@ -51,7 +51,7 @@ discard block
		block discarded – undo
51	51	self::outputMessage($msg);
52	52	throw new LogicException($msg);
53	53	}
54		- if (! FunctionPatcher::isWhitelisted($function))
	54	+ if ( ! FunctionPatcher::isWhitelisted($function))
55	55	{
56	56	$msg = "<red>Can't patch on '$function'. It is not in whitelist. If you want to patch it, please add it to 'functions_to_patch' in 'tests/Bootstrap.php'. But note that there are some limitations. See <https://github.com/kenjis/ci-phpunit-test/blob/master/docs/HowToWriteTests.md#patching-functions> for details.</red>";
57	57	self::outputMessage($msg);
		@@ -97,16 +97,16 @@ discard block
		block discarded – undo
97	97	$line = $info['line'];
98	98	$method = isset($info['class_method']) ? $info['class_method'] : $info['function'];
99	99
100		- $log_args = function () use ($arguments) {
	100	+ $log_args = function() use ($arguments) {
101	101	$output = '';
102	102	foreach ($arguments as $arg) {
103		- $output .= var_export($arg, true) . ', ';
	103	+ $output .= var_export($arg, true).', ';
104	104	}
105	105	$output = rtrim($output, ', ');
106	106	return $output;
107	107	};
108	108	MonkeyPatchManager::log(
109		- 'invoke_func: ' . $function . '(' . $log_args() . ') on line ' . $line . ' in ' . $file . ' by ' . $method . '()'
	109	+ 'invoke_func: '.$function.'('.$log_args().') on line '.$line.' in '.$file.' by '.$method.'()'
110	110	);
111	111	}
112	112	}
		@@ -148,10 +148,10 @@ discard block
		block discarded – undo
148	148
149	149	if (isset(self::$patches_to_apply[$function]))
150	150	{
151		- if (! self::checkCalledMethod($function))
	151	+ if ( ! self::checkCalledMethod($function))
152	152	{
153	153	MonkeyPatchManager::log(
154		- 'invoke_func: ' . $function . '() not patched (out of scope)'
	154	+ 'invoke_func: '.$function.'() not patched (out of scope)'
155	155	);
156	156	self::checkPassedByReference($function);
157	157	return call_user_func_array($function, $arguments);
		@@ -160,7 +160,7 @@ discard block
		block discarded – undo
160	160
161	161	if (array_key_exists($function, self::$patches))
162	162	{
163		- MonkeyPatchManager::log('invoke_func: ' . $function . '() patched');
	163	+ MonkeyPatchManager::log('invoke_func: '.$function.'() patched');
164	164
165	165	if (is_callable(self::$patches[$function]))
166	166	{
		@@ -178,7 +178,7 @@ discard block
		block discarded – undo
178	178	}
179	179
180	180	MonkeyPatchManager::log(
181		- 'invoke_func: ' . $function . '() not patched (no patch)'
	181	+ 'invoke_func: '.$function.'() not patched (no patch)'
182	182	);
183	183	self::checkPassedByReference($function);
184	184	return call_user_func_array($function, $arguments);
		@@ -231,7 +231,7 @@ discard block
		block discarded – undo
231	231	$msg = str_replace(
232	232	['<red>', '</red>'], [$red_begin, $red_end], $msg
233	233	);
234		- echo $msg . "\n";
	234	+ echo $msg."\n";
235	235	}
236	236
237	237	/**

		@@ -37,7 +37,7 @@ discard block
		block discarded – undo
37	37
38	38	public static function log($message)
39	39	{
40		- if (! self::$debug)
	40	+ if ( ! self::$debug)
41	41	{
42	42	return;
43	43	}
		@@ -72,7 +72,7 @@ discard block
		block discarded – undo
72	72	}
73	73	if (self::$debug)
74	74	{
75		- self::$log_file = __DIR__ . '/debug.log';
	75	+ self::$log_file = __DIR__.'/debug.log';
76	76	}
77	77	}
78	78
		@@ -85,10 +85,10 @@ discard block
		block discarded – undo
85	85	else
86	86	{
87	87	// APPPATH is constant in CodeIgniter
88		- Cache::setProjectRootDir(APPPATH . '../');
	88	+ Cache::setProjectRootDir(APPPATH.'../');
89	89	}
90	90
91		- if (! isset($config['cache_dir']))
	91	+ if ( ! isset($config['cache_dir']))
92	92	{
93	93	throw new LogicException('You have to set "cache_dir"');
94	94	}
		@@ -97,7 +97,7 @@ discard block
		block discarded – undo
97	97
98	98	protected static function setPaths(array $config)
99	99	{
100		- if (! isset($config['include_paths']))
	100	+ if ( ! isset($config['include_paths']))
101	101	{
102	102	throw new LogicException('You have to set "include_paths"');
103	103	}
		@@ -158,7 +158,7 @@ discard block
		block discarded – undo
158	158	// Updated?
159	159	if ($cached !== $current)
160	160	{
161		- MonkeyPatchManager::log('clear_src_cache: from ' . __METHOD__);
	161	+ MonkeyPatchManager::log('clear_src_cache: from '.__METHOD__);
162	162	Cache::clearSrcCache();
163	163	Cache::writeTmpIncludePaths($current);
164	164	}
		@@ -169,7 +169,7 @@ discard block
		block discarded – undo
169	169	// Updated?
170	170	if ($cached !== $current)
171	171	{
172		- MonkeyPatchManager::log('clear_src_cache: from ' . __METHOD__);
	172	+ MonkeyPatchManager::log('clear_src_cache: from '.__METHOD__);
173	173	Cache::clearSrcCache();
174	174	Cache::writeTmpExcludePaths($current);
175	175	}
		@@ -182,7 +182,7 @@ discard block
		block discarded – undo
182	182	// Updated?
183	183	if ($cached !== self::$patcher_list)
184	184	{
185		- MonkeyPatchManager::log('clear_src_cache: from ' . __METHOD__);
	185	+ MonkeyPatchManager::log('clear_src_cache: from '.__METHOD__);
186	186	Cache::clearSrcCache();
187	187	Cache::writeTmpPatcherList(self::$patcher_list);
188	188	}
		@@ -196,7 +196,7 @@ discard block
		block discarded – undo
196	196	// Updated?
197	197	if ($cached !== $current)
198	198	{
199		- MonkeyPatchManager::log('clear_src_cache: from ' . __METHOD__);
	199	+ MonkeyPatchManager::log('clear_src_cache: from '.__METHOD__);
200	200	Cache::clearSrcCache();
201	201	Cache::writeTmpFunctionWhitelist($current);
202	202	}
		@@ -258,7 +258,7 @@ discard block
		block discarded – undo
258	258	*/
259	259	public static function patch($path)
260	260	{
261		- if (! is_readable($path))
	261	+ if ( ! is_readable($path))
262	262	{
263	263	throw new LogicException("Can't read '$path'");
264	264	}
		@@ -266,17 +266,17 @@ discard block
		block discarded – undo
266	266	// Check cache file
267	267	if ($cache_file = Cache::getValidSrcCachePath($path))
268	268	{
269		- self::log('cache_hit: ' . $path);
	269	+ self::log('cache_hit: '.$path);
270	270	return fopen($cache_file, 'r');
271	271	}
272	272
273		- self::log('cache_miss: ' . $path);
	273	+ self::log('cache_miss: '.$path);
274	274	$source = file_get_contents($path);
275	275
276	276	list($new_source, $patched) = self::execPatchers($source);
277	277
278	278	// Write to cache file
279		- self::log('write_cache: ' . $path);
	279	+ self::log('write_cache: '.$path);
280	280	Cache::writeSrcCacheFile($path, $new_source);
281	281
282	282	$resource = fopen('php://memory', 'rb+');
		@@ -292,12 +292,12 @@ discard block
		block discarded – undo
292	292	return;
293	293	}
294	294
295		- require __DIR__ . '/Patcher/AbstractPatcher.php';
296		- require __DIR__ . '/Patcher/Backtrace.php';
	295	+ require __DIR__.'/Patcher/AbstractPatcher.php';
	296	+ require __DIR__.'/Patcher/Backtrace.php';
297	297
298	298	foreach (self::$patcher_list as $classname)
299	299	{
300		- require __DIR__ . '/Patcher/' . $classname . '.php';
	300	+ require __DIR__.'/Patcher/'.$classname.'.php';
301	301	}
302	302
303	303	self::$load_patchers = true;
		@@ -308,7 +308,7 @@ discard block
		block discarded – undo
308	308	$patched = false;
309	309	foreach (self::$patcher_list as $classname)
310	310	{
311		- $classname = 'Kenjis\MonkeyPatch\Patcher\\' . $classname;
	311	+ $classname = 'Kenjis\MonkeyPatch\Patcher\\'.$classname;
312	312	$patcher = new $classname;
313	313	list($source, $patched_this) = $patcher->patch($source);
314	314	$patched = $patched \|\| $patched_this;

		@@ -10,145 +10,145 @@
		block discarded – undo
10	10
11	11	class Installer
12	12	{
13		- const TEST_FOLDER = 'tests';
	13	+ const TEST_FOLDER = 'tests';
14	14
15		- private $silent = false;
	15	+ private $silent = false;
16	16
17		- public function __construct($silent = false)
18		- {
19		- $this->silent = $silent;
20		- }
	17	+ public function __construct($silent = false)
	18	+ {
	19	+ $this->silent = $silent;
	20	+ }
21	21
22		- public function install($app = 'application')
23		- {
24		- $this->recursiveCopy(
25		- dirname(__FILE__) . '/application/tests',
26		- $app . '/' . static::TEST_FOLDER
27		- );
28		- $this->fixPath($app);
29		- }
	22	+ public function install($app = 'application')
	23	+ {
	24	+ $this->recursiveCopy(
	25	+ dirname(__FILE__) . '/application/tests',
	26	+ $app . '/' . static::TEST_FOLDER
	27	+ );
	28	+ $this->fixPath($app);
	29	+ }
30	30
31		- /**
32		- * Fix paths in Bootstrap.php
33		- */
34		- private function fixPath($app = 'application')
35		- {
36		- $file = $app . '/' . static::TEST_FOLDER . '/Bootstrap.php';
37		- $contents = file_get_contents($file);
	31	+ /**
	32	+ * Fix paths in Bootstrap.php
	33	+ */
	34	+ private function fixPath($app = 'application')
	35	+ {
	36	+ $file = $app . '/' . static::TEST_FOLDER . '/Bootstrap.php';
	37	+ $contents = file_get_contents($file);
38	38
39		- if (! file_exists('system')) {
40		- if (file_exists('vendor/codeigniter/framework/system')) {
41		- $contents = str_replace(
42		- '$system_path = \'../../system\';',
43		- '$system_path = \'../../vendor/codeigniter/framework/system\';',
44		- $contents
45		- );
46		- } else {
47		- throw new Exception('Can\'t find "system" folder.');
48		- }
49		- }
	39	+ if (! file_exists('system')) {
	40	+ if (file_exists('vendor/codeigniter/framework/system')) {
	41	+ $contents = str_replace(
	42	+ '$system_path = \'../../system\';',
	43	+ '$system_path = \'../../vendor/codeigniter/framework/system\';',
	44	+ $contents
	45	+ );
	46	+ } else {
	47	+ throw new Exception('Can\'t find "system" folder.');
	48	+ }
	49	+ }
50	50
51		- if (! file_exists('index.php')) {
52		- if (file_exists('public/index.php')) {
53		- // CodeIgniter 3.0.6 and after
54		- $contents = str_replace(
55		- "define('FCPATH', realpath(dirname(__FILE__).'/../..').DIRECTORY_SEPARATOR);",
56		- "define('FCPATH', realpath(dirname(__FILE__).'/../../public').DIRECTORY_SEPARATOR);",
57		- $contents
58		- );
59		- // CodeIgniter 3.0.5 and before
60		- $contents = str_replace(
61		- "define('FCPATH', realpath(dirname(__FILE__).'/../..').'/');",
62		- "define('FCPATH', realpath(dirname(__FILE__).'/../../public').'/');",
63		- $contents
64		- );
65		- } elseif (file_exists($app . '/public/index.php')) {
66		- // CodeIgniter 3.0.6 and after
67		- $contents = str_replace(
68		- "define('FCPATH', realpath(dirname(__FILE__).'/../..').DIRECTORY_SEPARATOR);",
69		- "define('FCPATH', realpath(dirname(__FILE__).'/../public').DIRECTORY_SEPARATOR);",
70		- $contents
71		- );
72		- // CodeIgniter 3.0.5 and before
73		- $contents = str_replace(
74		- "define('FCPATH', realpath(dirname(__FILE__).'/../..').'/');",
75		- "define('FCPATH', realpath(dirname(__FILE__).'/../public').'/');",
76		- $contents
77		- );
78		- if ($app != 'application') {
79		- $contents = str_replace(
80		- "\$application_folder = '../../application';",
81		- "\$application_folder = '../../{$app}';",
82		- $contents
83		- );
84		- }
85		- } else {
86		- throw new Exception('Can\'t find "index.php".');
87		- }
88		- }
	51	+ if (! file_exists('index.php')) {
	52	+ if (file_exists('public/index.php')) {
	53	+ // CodeIgniter 3.0.6 and after
	54	+ $contents = str_replace(
	55	+ "define('FCPATH', realpath(dirname(__FILE__).'/../..').DIRECTORY_SEPARATOR);",
	56	+ "define('FCPATH', realpath(dirname(__FILE__).'/../../public').DIRECTORY_SEPARATOR);",
	57	+ $contents
	58	+ );
	59	+ // CodeIgniter 3.0.5 and before
	60	+ $contents = str_replace(
	61	+ "define('FCPATH', realpath(dirname(__FILE__).'/../..').'/');",
	62	+ "define('FCPATH', realpath(dirname(__FILE__).'/../../public').'/');",
	63	+ $contents
	64	+ );
	65	+ } elseif (file_exists($app . '/public/index.php')) {
	66	+ // CodeIgniter 3.0.6 and after
	67	+ $contents = str_replace(
	68	+ "define('FCPATH', realpath(dirname(__FILE__).'/../..').DIRECTORY_SEPARATOR);",
	69	+ "define('FCPATH', realpath(dirname(__FILE__).'/../public').DIRECTORY_SEPARATOR);",
	70	+ $contents
	71	+ );
	72	+ // CodeIgniter 3.0.5 and before
	73	+ $contents = str_replace(
	74	+ "define('FCPATH', realpath(dirname(__FILE__).'/../..').'/');",
	75	+ "define('FCPATH', realpath(dirname(__FILE__).'/../public').'/');",
	76	+ $contents
	77	+ );
	78	+ if ($app != 'application') {
	79	+ $contents = str_replace(
	80	+ "\$application_folder = '../../application';",
	81	+ "\$application_folder = '../../{$app}';",
	82	+ $contents
	83	+ );
	84	+ }
	85	+ } else {
	86	+ throw new Exception('Can\'t find "index.php".');
	87	+ }
	88	+ }
89	89
90		- file_put_contents($file, $contents);
91		- }
	90	+ file_put_contents($file, $contents);
	91	+ }
92	92
93		- public function update($app = 'application')
94		- {
95		- $target_dir = $app . '/' . static::TEST_FOLDER . '/_ci_phpunit_test';
96		- $this->recursiveUnlink($target_dir);
97		- $this->recursiveCopy(
98		- dirname(__FILE__) . '/application/tests/_ci_phpunit_test',
99		- $target_dir
100		- );
101		- }
	93	+ public function update($app = 'application')
	94	+ {
	95	+ $target_dir = $app . '/' . static::TEST_FOLDER . '/_ci_phpunit_test';
	96	+ $this->recursiveUnlink($target_dir);
	97	+ $this->recursiveCopy(
	98	+ dirname(__FILE__) . '/application/tests/_ci_phpunit_test',
	99	+ $target_dir
	100	+ );
	101	+ }
102	102
103		- /**
104		- * Recursive Copy
105		- *
106		- * @param string $src
107		- * @param string $dst
108		- */
109		- private function recursiveCopy($src, $dst)
110		- {
111		- @mkdir($dst, 0755);
	103	+ /**
	104	+ * Recursive Copy
	105	+ *
	106	+ * @param string $src
	107	+ * @param string $dst
	108	+ */
	109	+ private function recursiveCopy($src, $dst)
	110	+ {
	111	+ @mkdir($dst, 0755);
112	112
113		- $iterator = new \RecursiveIteratorIterator(
114		- new \RecursiveDirectoryIterator($src, \RecursiveDirectoryIterator::SKIP_DOTS),
115		- \RecursiveIteratorIterator::SELF_FIRST
116		- );
	113	+ $iterator = new \RecursiveIteratorIterator(
	114	+ new \RecursiveDirectoryIterator($src, \RecursiveDirectoryIterator::SKIP_DOTS),
	115	+ \RecursiveIteratorIterator::SELF_FIRST
	116	+ );
117	117
118		- foreach ($iterator as $file) {
119		- if ($file->isDir()) {
120		- @mkdir($dst . '/' . $iterator->getSubPathName());
121		- } else {
122		- $success = copy($file, $dst . '/' . $iterator->getSubPathName());
123		- if ($success) {
124		- if (! $this->silent) {
125		- echo 'copied: ' . $dst . '/' . $iterator->getSubPathName() . PHP_EOL;
126		- }
127		- }
128		- }
129		- }
130		- }
	118	+ foreach ($iterator as $file) {
	119	+ if ($file->isDir()) {
	120	+ @mkdir($dst . '/' . $iterator->getSubPathName());
	121	+ } else {
	122	+ $success = copy($file, $dst . '/' . $iterator->getSubPathName());
	123	+ if ($success) {
	124	+ if (! $this->silent) {
	125	+ echo 'copied: ' . $dst . '/' . $iterator->getSubPathName() . PHP_EOL;
	126	+ }
	127	+ }
	128	+ }
	129	+ }
	130	+ }
131	131
132		- /**
133		- * Recursive Unlink
134		- *
135		- * @param string $dir
136		- */
137		- private function recursiveUnlink($dir)
138		- {
139		- $iterator = new \RecursiveIteratorIterator(
140		- new \RecursiveDirectoryIterator($dir, \RecursiveDirectoryIterator::SKIP_DOTS),
141		- \RecursiveIteratorIterator::CHILD_FIRST
142		- );
	132	+ /**
	133	+ * Recursive Unlink
	134	+ *
	135	+ * @param string $dir
	136	+ */
	137	+ private function recursiveUnlink($dir)
	138	+ {
	139	+ $iterator = new \RecursiveIteratorIterator(
	140	+ new \RecursiveDirectoryIterator($dir, \RecursiveDirectoryIterator::SKIP_DOTS),
	141	+ \RecursiveIteratorIterator::CHILD_FIRST
	142	+ );
143	143
144		- foreach ($iterator as $file) {
145		- if ($file->isDir()) {
146		- rmdir($file);
147		- } else {
148		- unlink($file);
149		- }
150		- }
	144	+ foreach ($iterator as $file) {
	145	+ if ($file->isDir()) {
	146	+ rmdir($file);
	147	+ } else {
	148	+ unlink($file);
	149	+ }
	150	+ }
151	151
152		- rmdir($dir);
153		- }
	152	+ rmdir($dir);
	153	+ }
154	154	}

		@@ -22,8 +22,8 @@ discard block
		block discarded – undo
22	22	public function install($app = 'application')
23	23	{
24	24	$this->recursiveCopy(
25		- dirname(__FILE__) . '/application/tests',
26		- $app . '/' . static::TEST_FOLDER
	25	+ dirname(__FILE__).'/application/tests',
	26	+ $app.'/'.static::TEST_FOLDER
27	27	);
28	28	$this->fixPath($app);
29	29	}
		@@ -33,10 +33,10 @@ discard block
		block discarded – undo
33	33	*/
34	34	private function fixPath($app = 'application')
35	35	{
36		- $file = $app . '/' . static::TEST_FOLDER . '/Bootstrap.php';
	36	+ $file = $app.'/'.static::TEST_FOLDER.'/Bootstrap.php';
37	37	$contents = file_get_contents($file);
38	38
39		- if (! file_exists('system')) {
	39	+ if ( ! file_exists('system')) {
40	40	if (file_exists('vendor/codeigniter/framework/system')) {
41	41	$contents = str_replace(
42	42	'$system_path = \'../../system\';',
		@@ -48,7 +48,7 @@ discard block
		block discarded – undo
48	48	}
49	49	}
50	50
51		- if (! file_exists('index.php')) {
	51	+ if ( ! file_exists('index.php')) {
52	52	if (file_exists('public/index.php')) {
53	53	// CodeIgniter 3.0.6 and after
54	54	$contents = str_replace(
		@@ -62,7 +62,7 @@ discard block
		block discarded – undo
62	62	"define('FCPATH', realpath(dirname(__FILE__).'/../../public').'/');",
63	63	$contents
64	64	);
65		- } elseif (file_exists($app . '/public/index.php')) {
	65	+ } elseif (file_exists($app.'/public/index.php')) {
66	66	// CodeIgniter 3.0.6 and after
67	67	$contents = str_replace(
68	68	"define('FCPATH', realpath(dirname(__FILE__).'/../..').DIRECTORY_SEPARATOR);",
		@@ -92,10 +92,10 @@ discard block
		block discarded – undo
92	92
93	93	public function update($app = 'application')
94	94	{
95		- $target_dir = $app . '/' . static::TEST_FOLDER . '/_ci_phpunit_test';
	95	+ $target_dir = $app.'/'.static::TEST_FOLDER.'/_ci_phpunit_test';
96	96	$this->recursiveUnlink($target_dir);
97	97	$this->recursiveCopy(
98		- dirname(__FILE__) . '/application/tests/_ci_phpunit_test',
	98	+ dirname(__FILE__).'/application/tests/_ci_phpunit_test',
99	99	$target_dir
100	100	);
101	101	}
		@@ -117,12 +117,12 @@ discard block
		block discarded – undo
117	117
118	118	foreach ($iterator as $file) {
119	119	if ($file->isDir()) {
120		- @mkdir($dst . '/' . $iterator->getSubPathName());
	120	+ @mkdir($dst.'/'.$iterator->getSubPathName());
121	121	} else {
122		- $success = copy($file, $dst . '/' . $iterator->getSubPathName());
	122	+ $success = copy($file, $dst.'/'.$iterator->getSubPathName());
123	123	if ($success) {
124		- if (! $this->silent) {
125		- echo 'copied: ' . $dst . '/' . $iterator->getSubPathName() . PHP_EOL;
	124	+ if ( ! $this->silent) {
	125	+ echo 'copied: '.$dst.'/'.$iterator->getSubPathName().PHP_EOL;
126	126	}
127	127	}
128	128	}

		@@ -35,6 +35,9 @@ discard block
		block discarded – undo
35	35	'ConstantPatcher',
36	36	];
37	37
	38	+ /**
	39	+ * @param string $message
	40	+ */
38	41	public static function log($message)
39	42	{
40	43	if (! self::$debug)
		@@ -303,6 +306,9 @@ discard block
		block discarded – undo
303	306	self::$load_patchers = true;
304	307	}
305	308
	309	+ /**
	310	+ * @param string $source
	311	+ */
306	312	protected static function execPatchers($source)
307	313	{
308	314	$patched = false;

		@@ -11,7 +11,6 @@
		block discarded – undo
11	11	namespace Kenjis\MonkeyPatch;
12	12
13	13	use LogicException;
14		-use RuntimeException;
15	14	use PhpParser\ParserFactory;
16	15	use Kenjis\MonkeyPatch\Patcher\FunctionPatcher;
17	16

		@@ -70,8 +70,7 @@
		block discarded – undo
70	70	if (isset($config['root_dir']))
71	71	{
72	72	Cache::setProjectRootDir($config['root_dir']);
73		- }
74		- else
	73	+ } else
75	74	{
76	75	// APPPATH is constant in CodeIgniter
77	76	Cache::setProjectRootDir(APPPATH . '../');

		@@ -15,7 +15,6 @@
		block discarded – undo
15	15	use PhpParser\Node\Name;
16	16	use PhpParser\Node\Name\FullyQualified;
17	17	use PhpParser\NodeVisitorAbstract;
18		-
19	18	use Kenjis\MonkeyPatch\Patcher\ConstantPatcher;
20	19
21	20	class NodeVisitor extends NodeVisitorAbstract

		@@ -24,7 +24,7 @@ discard block
		block discarded – undo
24	24
25	25	public function enterNode(Node $node)
26	26	{
27		- $callback = [$this, 'before' . ucfirst($node->getType())];
	27	+ $callback = [$this, 'before'.ucfirst($node->getType())];
28	28	if (is_callable($callback)) {
29	29	call_user_func_array($callback, [$node]);
30	30	}
		@@ -32,9 +32,9 @@ discard block
		block discarded – undo
32	32
33	33	public function leaveNode(Node $node)
34	34	{
35		- if (! ($node instanceof ConstFetch))
	35	+ if ( ! ($node instanceof ConstFetch))
36	36	{
37		- $callback = [$this, 'rewrite' . ucfirst($node->getType())];
	37	+ $callback = [$this, 'rewrite'.ucfirst($node->getType())];
38	38	if (is_callable($callback)) {
39	39	call_user_func_array($callback, [$node]);
40	40	}
		@@ -47,26 +47,26 @@ discard block
		block discarded – undo
47	47	return;
48	48	}
49	49
50		- if (! ($node->name instanceof Name))
	50	+ if ( ! ($node->name instanceof Name))
51	51	{
52	52	return;
53	53	}
54	54
55		- if (! $node->name->isUnqualified())
	55	+ if ( ! $node->name->isUnqualified())
56	56	{
57	57	return;
58	58	}
59	59
60		- if (! ConstantPatcher::isBlacklisted((string) $node->name))
	60	+ if ( ! ConstantPatcher::isBlacklisted((string) $node->name))
61	61	{
62	62	$replacement = new FullyQualified(array());
63	63	$replacement->set(
64		- '\__ConstProxy__::get(\'' . (string) $node->name . '\')'
	64	+ '\__ConstProxy__::get(\''.(string) $node->name.'\')'
65	65	);
66	66
67	67	$pos = $node->getAttribute('startTokenPos');
68	68	ConstantPatcher::$replacement[$pos] =
69		- '\__ConstProxy__::get(\'' . (string) $node->name .'\')';
	69	+ '\__ConstProxy__::get(\''.(string) $node->name.'\')';
70	70
71	71	$node->name = $replacement;
72	72	}

		@@ -21,15 +21,11 @@
		block discarded – undo
21	21
22	22	namespace Kenjis\MonkeyPatch\Patcher\FunctionPatcher;
23	23
24		-use ReflectionFunction;
25		-use ReflectionException;
26		-
27	24	use PhpParser\Node;
28	25	use PhpParser\Node\Expr\FuncCall;
29	26	use PhpParser\Node\Name;
30	27	use PhpParser\Node\Name\FullyQualified;
31	28	use PhpParser\NodeVisitorAbstract;
32		-
33	29	use Kenjis\MonkeyPatch\Patcher\FunctionPatcher;
34	30
35	31	class NodeVisitor extends NodeVisitorAbstract

		@@ -36,17 +36,17 @@ discard block
		block discarded – undo
36	36	{
37	37	public function leaveNode(Node $node)
38	38	{
39		- if (! ($node instanceof FuncCall))
	39	+ if ( ! ($node instanceof FuncCall))
40	40	{
41	41	return;
42	42	}
43	43
44		- if (! ($node->name instanceof Name))
	44	+ if ( ! ($node->name instanceof Name))
45	45	{
46	46	return;
47	47	}
48	48
49		- if (! $node->name->isUnqualified())
	49	+ if ( ! $node->name->isUnqualified())
50	50	{
51	51	return;
52	52	}
		@@ -57,12 +57,12 @@ discard block
		block discarded – undo
57	57	) {
58	58	$replacement = new FullyQualified(array());
59	59	$replacement->set(
60		- '\__FuncProxy__::' . (string) $node->name
	60	+ '\__FuncProxy__::'.(string) $node->name
61	61	);
62	62
63	63	$pos = $node->getAttribute('startTokenPos');
64	64	FunctionPatcher::$replacement[$pos] =
65		- '\__FuncProxy__::' . (string) $node->name;
	65	+ '\__FuncProxy__::'.(string) $node->name;
66	66
67	67	$node->name = $replacement;
68	68	}

		@@ -37,7 +37,7 @@ discard block
		block discarded – undo
37	37	*
38	38	* @param string $function function name
39	39	* @param mixed $return_value return value or callable
40		- * @param string $class_name class::method to apply this patch
	40	+ * @param string $class_method class::method to apply this patch
41	41	*
42	42	* @throws LogicException
43	43	*/
		@@ -86,6 +86,9 @@ discard block
		block discarded – undo
86	86	InvocationVerifier::verify(self::$expected_invocations, self::$invocations);
87	87	}
88	88
	89	+ /**
	90	+ * @param string $function
	91	+ */
89	92	protected static function logInvocation($function, $arguments)
90	93	{
91	94	if (MonkeyPatchManager::$debug)
		@@ -111,6 +114,9 @@ discard block
		block discarded – undo
111	114	}
112	115	}
113	116
	117	+ /**
	118	+ * @param string $function
	119	+ */
114	120	protected static function checkCalledMethod($function)
115	121	{
116	122	$trace = debug_backtrace();
		@@ -184,6 +190,9 @@ discard block
		block discarded – undo
184	190	return call_user_func_array($function, $arguments);
185	191	}
186	192
	193	+ /**
	194	+ * @param string $function
	195	+ */
187	196	protected static function checkPassedByReference($function)
188	197	{
189	198	$ref_func = new ReflectionFunction($function);

		@@ -20,6 +20,9 @@
		block discarded – undo
20	20	'ConstantPatcher' => 0,
21	21	];
22	22
	23	+ /**
	24	+ * @param string $patcher
	25	+ */
23	26	public static function getInfo($patcher, $backtrace)
24	27	{
25	28	if (! isset(self::$map[$patcher]))

		@@ -21,7 +21,7 @@ discard block
		block discarded – undo
21	21
22	22	public static function getInfo($patcher, $backtrace)
23	23	{
24		- if (! isset(self::$map[$patcher]))
	24	+ if ( ! isset(self::$map[$patcher]))
25	25	{
26	26	throw new LogicException("No such a patcher: $patcher");
27	27	}
		@@ -41,12 +41,12 @@ discard block
		block discarded – undo
41	41	$line = isset($backtrace[$offset]['line'])
42	42	? $backtrace[$offset]['line'] : null;
43	43
44		- if (isset($backtrace[$offset+2]))
	44	+ if (isset($backtrace[$offset + 2]))
45	45	{
46		- $class = isset($backtrace[$offset+2]['class'])
47		- ? $backtrace[$offset+2]['class']
	46	+ $class = isset($backtrace[$offset + 2]['class'])
	47	+ ? $backtrace[$offset + 2]['class']
48	48	: null;
49		- $function = $backtrace[$offset+2]['function'];
	49	+ $function = $backtrace[$offset + 2]['function'];
50	50	}
51	51	else
52	52	{
		@@ -57,7 +57,7 @@ discard block
		block discarded – undo
57	57	if (isset($class))
58	58	{
59	59	$method = $function;
60		- $class_method = $class . '::' . $function;
	60	+ $class_method = $class.'::'.$function;
61	61	$function = null;
62	62	}
63	63	else

		@@ -47,8 +47,7 @@ discard block
		block discarded – undo
47	47	? $backtrace[$offset+2]['class']
48	48	: null;
49	49	$function = $backtrace[$offset+2]['function'];
50		- }
51		- else
	50	+ } else
52	51	{
53	52	$class = null;
54	53	$function = null;
		@@ -59,8 +58,7 @@ discard block
		block discarded – undo
59	58	$method = $function;
60	59	$class_method = $class . '::' . $function;
61	60	$function = null;
62		- }
63		- else
	61	+ } else
64	62	{
65	63	$method = null;
66	64	$class_method = null;

		@@ -14,7 +14,6 @@
		block discarded – undo
14	14	require __DIR__ . '/ConstantPatcher/Proxy.php';
15	15
16	16	use LogicException;
17		-
18	17	use Kenjis\MonkeyPatch\Patcher\ConstantPatcher\NodeVisitor;
19	18
20	19	class ConstantPatcher extends AbstractPatcher

		@@ -10,8 +10,8 @@
		block discarded – undo
10	10
11	11	namespace Kenjis\MonkeyPatch\Patcher;
12	12
13		-require __DIR__ . '/ConstantPatcher/NodeVisitor.php';
14		-require __DIR__ . '/ConstantPatcher/Proxy.php';
	13	+require __DIR__.'/ConstantPatcher/NodeVisitor.php';
	14	+require __DIR__.'/ConstantPatcher/Proxy.php';
15	15
16	16	use LogicException;
17	17

		@@ -173,13 +173,11 @@
		block discarded – undo
173	173	if (is_string($token))
174	174	{
175	175	$new_source .= $token;
176		- }
177		- elseif ($i == $replacement['key'])
	176	+ } elseif ($i == $replacement['key'])
178	177	{
179	178	$new_source .= $replacement['value'];
180	179	$replacement = each(self::$replacement);
181		- }
182		- else
	180	+ } else
183	181	{
184	182	$new_source .= $token[1];
185	183	}

		@@ -51,6 +51,9 @@ discard block
		block discarded – undo
51	51	self::$patches_to_apply = [];
52	52	}
53	53
	54	+ /**
	55	+ * @param string $constant
	56	+ */
54	57	protected static function logInvocation($constant)
55	58	{
56	59	if (MonkeyPatchManager::$debug)
		@@ -68,6 +71,9 @@ discard block
		block discarded – undo
68	71	}
69	72	}
70	73
	74	+ /**
	75	+ * @param string $constant
	76	+ */
71	77	protected static function checkCalledMethod($constant)
72	78	{
73	79	$trace = debug_backtrace();

		@@ -13,14 +13,9 @@
		block discarded – undo
13	13	class_alias('Kenjis\MonkeyPatch\Patcher\ConstantPatcher\Proxy', '__ConstProxy__');
14	14
15	15	use LogicException;
16		-use ReflectionConstant;
17		-use ReflectionException;
18		-
19	16	use Kenjis\MonkeyPatch\Patcher\ConstantPatcher;
20	17	use Kenjis\MonkeyPatch\Patcher\Backtrace;
21	18	use Kenjis\MonkeyPatch\MonkeyPatchManager;
22		-use Kenjis\MonkeyPatch\Cache;
23		-use Kenjis\MonkeyPatch\InvocationVerifier;
24	19
25	20	class Proxy
26	21	{

		@@ -65,7 +65,7 @@ discard block
		block discarded – undo
65	65	$method = isset($info['class_method']) ? $info['class_method'] : $info['function'];
66	66
67	67	MonkeyPatchManager::log(
68		- 'invoke_const: ' . $constant . ') on line ' . $line . ' in ' . $file . ' by ' . $method . '()'
	68	+ 'invoke_const: '.$constant.') on line '.$line.' in '.$file.' by '.$method.'()'
69	69	);
70	70	}
71	71	}
		@@ -111,10 +111,10 @@ discard block
		block discarded – undo
111	111
112	112	if (isset(self::$patches_to_apply[$constant]))
113	113	{
114		- if (! self::checkCalledMethod($constant))
	114	+ if ( ! self::checkCalledMethod($constant))
115	115	{
116	116	MonkeyPatchManager::log(
117		- 'invoke_const: ' . $constant . ' not patched (out of scope)'
	117	+ 'invoke_const: '.$constant.' not patched (out of scope)'
118	118	);
119	119	return constant($constant);
120	120	}
		@@ -122,12 +122,12 @@ discard block
		block discarded – undo
122	122
123	123	if (array_key_exists($constant, self::$patches))
124	124	{
125		- MonkeyPatchManager::log('invoke_const: ' . $constant . ' patched');
	125	+ MonkeyPatchManager::log('invoke_const: '.$constant.' patched');
126	126	return self::$patches[$constant];
127	127	}
128	128
129	129	MonkeyPatchManager::log(
130		- 'invoke_const: ' . $constant . ' not patched (no patch)'
	130	+ 'invoke_const: '.$constant.' not patched (no patch)'
131	131	);
132	132	return constant($constant);
133	133	}

kenjis / ci-phpunit-test

Pull Request — master (#213)

Status

Category

Indentation +127 added lines, -127 removed lines patch added patch discarded remove patch

Spacing +12 added lines, -12 removed lines patch added patch discarded remove patch

Doc Comments +6 added lines patch added patch discarded remove patch

Unused Use Statements -1 removed lines patch added patch discarded remove patch

Braces +1 added lines, -2 removed lines patch added patch discarded remove patch

Spacing +17 added lines, -17 removed lines patch added patch discarded remove patch

Unused Use Statements -1 removed lines patch added patch discarded remove patch

Spacing +8 added lines, -8 removed lines patch added patch discarded remove patch

Unused Use Statements -4 removed lines patch added patch discarded remove patch

Spacing +5 added lines, -5 removed lines patch added patch discarded remove patch

Doc Comments +10 added lines, -1 removed lines patch added patch discarded remove patch

Unused Use Statements -1 removed lines patch added patch discarded remove patch

Spacing +9 added lines, -9 removed lines patch added patch discarded remove patch

Unused Use Statements -1 removed lines patch added patch discarded remove patch

Spacing +17 added lines, -17 removed lines patch added patch discarded remove patch

Braces +1 added lines, -2 removed lines patch added patch discarded remove patch

Doc Comments +6 added lines patch added patch discarded remove patch

Doc Comments +3 added lines patch added patch discarded remove patch

Spacing +6 added lines, -6 removed lines patch added patch discarded remove patch

Braces +2 added lines, -4 removed lines patch added patch discarded remove patch

Unused Use Statements -1 removed lines patch added patch discarded remove patch

Spacing +2 added lines, -2 removed lines patch added patch discarded remove patch

Braces +2 added lines, -4 removed lines patch added patch discarded remove patch

Doc Comments +6 added lines patch added patch discarded remove patch

Unused Use Statements -5 removed lines patch added patch discarded remove patch

Spacing +5 added lines, -5 removed lines patch added patch discarded remove patch