Inspection of "Added ability to pass arguments when loading libra..." - kenjis/ci-phpunit-test - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Pull Request — master (#213)

unknown

created 2017-10-25 15:48 UTC

Status

Doc Comments +9 added lines, -9 removed lines patch added patch discarded remove patch

@@ -191,7 +191,7 @@  discard block
 block discarded – undo
 	 * @param	string	$library	Library name
 	 * @param	array	$params		Optional parameters to pass to the library class constructor
 	 * @param	string	$object_name	An optional object name to assign to
-	 * @return	object
+	 * @return	CI_Loader
 	 *
 	 * @codeCoverageIgnore
 	 */
@@ -237,7 +237,7 @@  discard block
 block discarded – undo
 	 * @param	string	$model		Model name
 	 * @param	string	$name		An optional object name to assign to
 	 * @param	bool	$db_conn	An optional database connection configuration to initialize
-	 * @return	object
+	 * @return	CI_Loader
 	 * 
 	 * modified by ci-phpunit-test
 	 */
@@ -369,7 +369,7 @@  discard block
 block discarded – undo
 	/**
 	 * Database Loader
 	 *
-	 * @param	mixed	$params		Database configuration options
+	 * @param	string|boolean	$params		Database configuration options
 	 * @param	bool	$return 	Whether to return the database object
 	 * @param	bool	$query_builder	Whether to enable Query Builder
 	 *					(overrides the configuration setting)
@@ -535,7 +535,7 @@  discard block
 block discarded – undo
 	 *					An associative array or object containing values
 	 *					to be set, or a value's name if string
 	 * @param 	string	$val	Value to set, only used if $vars is a string
-	 * @return	object
+	 * @return	CI_Loader
 	 *
 	 * @codeCoverageIgnore
 	 */
@@ -609,7 +609,7 @@  discard block
 block discarded – undo
 	 * Helper Loader
 	 *
 	 * @param	string|string[]	$helpers	Helper name(s)
-	 * @return	object
+	 * @return	CI_Loader
 	 *
 	 * @codeCoverageIgnore
 	 */
@@ -688,7 +688,7 @@  discard block
 block discarded – undo
 	 *
 	 * @uses	CI_Loader::helper()
 	 * @param	string|string[]	$helpers	Helper name(s)
-	 * @return	object
+	 * @return	CI_Loader
 	 *
 	 * @codeCoverageIgnore
 	 */
@@ -706,7 +706,7 @@  discard block
 block discarded – undo
 	 *
 	 * @param	string|string[]	$files	List of language file names to load
 	 * @param	string		Language name
-	 * @return	object
+	 * @return	CI_Loader
 	 *
 	 * @codeCoverageIgnore
 	 */
@@ -806,7 +806,7 @@  discard block
 block discarded – undo
 	 *
 	 * @param	string	$path		Path to add
 	 * @param 	bool	$view_cascade	(default: TRUE)
-	 * @return	object
+	 * @return	CI_Loader
 	 *
 	 * @codeCoverageIgnore
 	 */
@@ -854,7 +854,7 @@  discard block
 block discarded – undo
 	 * added path will be removed removed.
 	 *
 	 * @param	string	$path	Path to remove
-	 * @return	object
+	 * @return	CI_Loader
 	 *
 	 * @codeCoverageIgnore
 	 */

Please login to merge, or discard this patch.

application/tests/_ci_phpunit_test/replacing/core/old/3.1.4-Common.php 1 patch

Doc Comments +8 added lines patch added patch discarded remove patch

@@ -136,6 +136,11 @@  discard block
 block discarded – undo
 	return $_is_loaded;
 }
 
+/**
+ * @param boolean $return
+ *
+ * @return boolean
+ */
 function is_cli($return = null)
 {
 	static $_return = TRUE;
@@ -148,6 +153,9 @@  discard block
 block discarded – undo
 	return $_return;
 }
 
+/**
+ * @param string $message
+ */
 function show_error($message, $status_code = 500, $heading = 'An Error Was Encountered')
 {
 	$status_code = abs($status_code);

Please login to merge, or discard this patch.

application/tests/_ci_phpunit_test/replacing/core/old/3.1.4-Input.php 1 patch

Doc Comments +5 added lines, -5 removed lines patch added patch discarded remove patch

@@ -237,7 +237,7 @@  discard block
 block discarded – undo
 	/**
 	 * Fetch an item from the GET array
 	 *
-	 * @param	mixed	$index		Index for item to be fetched from $_GET
+	 * @param	string	$index		Index for item to be fetched from $_GET
 	 * @param	bool	$xss_clean	Whether to apply XSS filtering
 	 * @return	mixed
 	 *
@@ -253,7 +253,7 @@  discard block
 block discarded – undo
 	/**
 	 * Fetch an item from the POST array
 	 *
-	 * @param	mixed	$index		Index for item to be fetched from $_POST
+	 * @param	string	$index		Index for item to be fetched from $_POST
 	 * @param	bool	$xss_clean	Whether to apply XSS filtering
 	 * @return	mixed
 	 *
@@ -321,9 +321,9 @@  discard block
 block discarded – undo
 	/**
 	 * Fetch an item from the SERVER array
 	 *
-	 * @param	mixed	$index		Index for item to be fetched from $_SERVER
+	 * @param	string	$index		Index for item to be fetched from $_SERVER
 	 * @param	bool	$xss_clean	Whether to apply XSS filtering
-	 * @return	mixed
+	 * @return	string
 	 *
 	 * @codeCoverageIgnore
 	 */
@@ -934,7 +934,7 @@  discard block
 block discarded – undo
 	 * Allows read access to protected properties
 	 *
 	 * @param	string	$name
-	 * @return	mixed
+	 * @return	string|null
 	 *
 	 * @codeCoverageIgnore
 	 */

Please login to merge, or discard this patch.

application/tests/_ci_phpunit_test/replacing/core/old/3.1.4-Loader.php 1 patch

Doc Comments +9 added lines, -9 removed lines patch added patch discarded remove patch

@@ -191,7 +191,7 @@  discard block
 block discarded – undo
 	 * @param	string	$library	Library name
 	 * @param	array	$params		Optional parameters to pass to the library class constructor
 	 * @param	string	$object_name	An optional object name to assign to
-	 * @return	object
+	 * @return	CI_Loader
 	 *
 	 * @codeCoverageIgnore
 	 */
@@ -237,7 +237,7 @@  discard block
 block discarded – undo
 	 * @param	string	$model		Model name
 	 * @param	string	$name		An optional object name to assign to
 	 * @param	bool	$db_conn	An optional database connection configuration to initialize
-	 * @return	object
+	 * @return	CI_Loader
 	 * 
 	 * modified by ci-phpunit-test
 	 */
@@ -369,7 +369,7 @@  discard block
 block discarded – undo
 	/**
 	 * Database Loader
 	 *
-	 * @param	mixed	$params		Database configuration options
+	 * @param	string|boolean	$params		Database configuration options
 	 * @param	bool	$return 	Whether to return the database object
 	 * @param	bool	$query_builder	Whether to enable Query Builder
 	 *					(overrides the configuration setting)
@@ -535,7 +535,7 @@  discard block
 block discarded – undo
 	 *					An associative array or object containing values
 	 *					to be set, or a value's name if string
 	 * @param 	string	$val	Value to set, only used if $vars is a string
-	 * @return	object
+	 * @return	CI_Loader
 	 *
 	 * @codeCoverageIgnore
 	 */
@@ -609,7 +609,7 @@  discard block
 block discarded – undo
 	 * Helper Loader
 	 *
 	 * @param	string|string[]	$helpers	Helper name(s)
-	 * @return	object
+	 * @return	CI_Loader
 	 *
 	 * @codeCoverageIgnore
 	 */
@@ -688,7 +688,7 @@  discard block
 block discarded – undo
 	 *
 	 * @uses	CI_Loader::helper()
 	 * @param	string|string[]	$helpers	Helper name(s)
-	 * @return	object
+	 * @return	CI_Loader
 	 *
 	 * @codeCoverageIgnore
 	 */
@@ -706,7 +706,7 @@  discard block
 block discarded – undo
 	 *
 	 * @param	string|string[]	$files	List of language file names to load
 	 * @param	string		Language name
-	 * @return	object
+	 * @return	CI_Loader
 	 *
 	 * @codeCoverageIgnore
 	 */
@@ -806,7 +806,7 @@  discard block
 block discarded – undo
 	 *
 	 * @param	string	$path		Path to add
 	 * @param 	bool	$view_cascade	(default: TRUE)
-	 * @return	object
+	 * @return	CI_Loader
 	 *
 	 * @codeCoverageIgnore
 	 */
@@ -854,7 +854,7 @@  discard block
 block discarded – undo
 	 * added path will be removed removed.
 	 *
 	 * @param	string	$path	Path to remove
-	 * @return	object
+	 * @return	CI_Loader
 	 *
 	 * @codeCoverageIgnore
 	 */

Please login to merge, or discard this patch.

		@@ -191,7 +191,7 @@ discard block
		block discarded – undo
191	191	* @param string $library Library name
192	192	* @param array $params Optional parameters to pass to the library class constructor
193	193	* @param string $object_name An optional object name to assign to
194		- * @return object
	194	+ * @return CI_Loader
195	195	*
196	196	* @codeCoverageIgnore
197	197	*/
		@@ -237,7 +237,7 @@ discard block
		block discarded – undo
237	237	* @param string $model Model name
238	238	* @param string $name An optional object name to assign to
239	239	* @param bool $db_conn An optional database connection configuration to initialize
240		- * @return object
	240	+ * @return CI_Loader
241	241	*
242	242	* modified by ci-phpunit-test
243	243	*/
		@@ -369,7 +369,7 @@ discard block
		block discarded – undo
369	369	/**
370	370	* Database Loader
371	371	*
372		- * @param mixed $params Database configuration options
	372	+ * @param string\|boolean $params Database configuration options
373	373	* @param bool $return Whether to return the database object
374	374	* @param bool $query_builder Whether to enable Query Builder
375	375	* (overrides the configuration setting)
		@@ -535,7 +535,7 @@ discard block
		block discarded – undo
535	535	* An associative array or object containing values
536	536	* to be set, or a value's name if string
537	537	* @param string $val Value to set, only used if $vars is a string
538		- * @return object
	538	+ * @return CI_Loader
539	539	*
540	540	* @codeCoverageIgnore
541	541	*/
		@@ -609,7 +609,7 @@ discard block
		block discarded – undo
609	609	* Helper Loader
610	610	*
611	611	* @param string\|string[] $helpers Helper name(s)
612		- * @return object
	612	+ * @return CI_Loader
613	613	*
614	614	* @codeCoverageIgnore
615	615	*/
		@@ -688,7 +688,7 @@ discard block
		block discarded – undo
688	688	*
689	689	* @uses CI_Loader::helper()
690	690	* @param string\|string[] $helpers Helper name(s)
691		- * @return object
	691	+ * @return CI_Loader
692	692	*
693	693	* @codeCoverageIgnore
694	694	*/
		@@ -706,7 +706,7 @@ discard block
		block discarded – undo
706	706	*
707	707	* @param string\|string[] $files List of language file names to load
708	708	* @param string Language name
709		- * @return object
	709	+ * @return CI_Loader
710	710	*
711	711	* @codeCoverageIgnore
712	712	*/
		@@ -806,7 +806,7 @@ discard block
		block discarded – undo
806	806	*
807	807	* @param string $path Path to add
808	808	* @param bool $view_cascade (default: TRUE)
809		- * @return object
	809	+ * @return CI_Loader
810	810	*
811	811	* @codeCoverageIgnore
812	812	*/
		@@ -854,7 +854,7 @@ discard block
		block discarded – undo
854	854	* added path will be removed removed.
855	855	*
856	856	* @param string $path Path to remove
857		- * @return object
	857	+ * @return CI_Loader
858	858	*
859	859	* @codeCoverageIgnore
860	860	*/

		@@ -136,6 +136,11 @@ discard block
		block discarded – undo
136	136	return $_is_loaded;
137	137	}
138	138
	139	+/**
	140	+ * @param boolean $return
	141	+ *
	142	+ * @return boolean
	143	+ */
139	144	function is_cli($return = null)
140	145	{
141	146	static $_return = TRUE;
		@@ -148,6 +153,9 @@ discard block
		block discarded – undo
148	153	return $_return;
149	154	}
150	155
	156	+/**
	157	+ * @param string $message
	158	+ */
151	159	function show_error($message, $status_code = 500, $heading = 'An Error Was Encountered')
152	160	{
153	161	$status_code = abs($status_code);

		@@ -237,7 +237,7 @@ discard block
		block discarded – undo
237	237	/**
238	238	* Fetch an item from the GET array
239	239	*
240		- * @param mixed $index Index for item to be fetched from $_GET
	240	+ * @param string $index Index for item to be fetched from $_GET
241	241	* @param bool $xss_clean Whether to apply XSS filtering
242	242	* @return mixed
243	243	*
		@@ -253,7 +253,7 @@ discard block
		block discarded – undo
253	253	/**
254	254	* Fetch an item from the POST array
255	255	*
256		- * @param mixed $index Index for item to be fetched from $_POST
	256	+ * @param string $index Index for item to be fetched from $_POST
257	257	* @param bool $xss_clean Whether to apply XSS filtering
258	258	* @return mixed
259	259	*
		@@ -321,9 +321,9 @@ discard block
		block discarded – undo
321	321	/**
322	322	* Fetch an item from the SERVER array
323	323	*
324		- * @param mixed $index Index for item to be fetched from $_SERVER
	324	+ * @param string $index Index for item to be fetched from $_SERVER
325	325	* @param bool $xss_clean Whether to apply XSS filtering
326		- * @return mixed
	326	+ * @return string
327	327	*
328	328	* @codeCoverageIgnore
329	329	*/
		@@ -934,7 +934,7 @@ discard block
		block discarded – undo
934	934	* Allows read access to protected properties
935	935	*
936	936	* @param string $name
937		- * @return mixed
	937	+ * @return string\|null
938	938	*
939	939	* @codeCoverageIgnore
940	940	*/

		@@ -191,7 +191,7 @@ discard block
		block discarded – undo
191	191	* @param string $library Library name
192	192	* @param array $params Optional parameters to pass to the library class constructor
193	193	* @param string $object_name An optional object name to assign to
194		- * @return object
	194	+ * @return CI_Loader
195	195	*
196	196	* @codeCoverageIgnore
197	197	*/
		@@ -237,7 +237,7 @@ discard block
		block discarded – undo
237	237	* @param string $model Model name
238	238	* @param string $name An optional object name to assign to
239	239	* @param bool $db_conn An optional database connection configuration to initialize
240		- * @return object
	240	+ * @return CI_Loader
241	241	*
242	242	* modified by ci-phpunit-test
243	243	*/
		@@ -369,7 +369,7 @@ discard block
		block discarded – undo
369	369	/**
370	370	* Database Loader
371	371	*
372		- * @param mixed $params Database configuration options
	372	+ * @param string\|boolean $params Database configuration options
373	373	* @param bool $return Whether to return the database object
374	374	* @param bool $query_builder Whether to enable Query Builder
375	375	* (overrides the configuration setting)
		@@ -535,7 +535,7 @@ discard block
		block discarded – undo
535	535	* An associative array or object containing values
536	536	* to be set, or a value's name if string
537	537	* @param string $val Value to set, only used if $vars is a string
538		- * @return object
	538	+ * @return CI_Loader
539	539	*
540	540	* @codeCoverageIgnore
541	541	*/
		@@ -609,7 +609,7 @@ discard block
		block discarded – undo
609	609	* Helper Loader
610	610	*
611	611	* @param string\|string[] $helpers Helper name(s)
612		- * @return object
	612	+ * @return CI_Loader
613	613	*
614	614	* @codeCoverageIgnore
615	615	*/
		@@ -688,7 +688,7 @@ discard block
		block discarded – undo
688	688	*
689	689	* @uses CI_Loader::helper()
690	690	* @param string\|string[] $helpers Helper name(s)
691		- * @return object
	691	+ * @return CI_Loader
692	692	*
693	693	* @codeCoverageIgnore
694	694	*/
		@@ -706,7 +706,7 @@ discard block
		block discarded – undo
706	706	*
707	707	* @param string\|string[] $files List of language file names to load
708	708	* @param string Language name
709		- * @return object
	709	+ * @return CI_Loader
710	710	*
711	711	* @codeCoverageIgnore
712	712	*/
		@@ -806,7 +806,7 @@ discard block
		block discarded – undo
806	806	*
807	807	* @param string $path Path to add
808	808	* @param bool $view_cascade (default: TRUE)
809		- * @return object
	809	+ * @return CI_Loader
810	810	*
811	811	* @codeCoverageIgnore
812	812	*/
		@@ -854,7 +854,7 @@ discard block
		block discarded – undo
854	854	* added path will be removed removed.
855	855	*
856	856	* @param string $path Path to remove
857		- * @return object
	857	+ * @return CI_Loader
858	858	*
859	859	* @codeCoverageIgnore
860	860	*/

kenjis / ci-phpunit-test

Pull Request — master (#213)

Status

Category

Doc Comments +9 added lines, -9 removed lines patch added patch discarded remove patch

Doc Comments +8 added lines patch added patch discarded remove patch

Doc Comments +5 added lines, -5 removed lines patch added patch discarded remove patch

Doc Comments +9 added lines, -9 removed lines patch added patch discarded remove patch