kenjis / ci-phpunit-test

application/tests/_ci_phpunit_test/patcher/3.x/Patcher/ConstantPatcher/Proxy.php

Doc Comments +6 added lines

@@ -51,6 +51,9 @@ 
 		self::$patches_to_apply = [];
 	}
 
+	/**
+	 * @param string $constant
+	 */
 	protected static function logInvocation($constant)
 	{
 		if (MonkeyPatchManager::$debug)
@@ -68,6 +71,9 @@ 
 		}
 	}
 
+	/**
+	 * @param string $constant
+	 */
 	protected static function checkCalledMethod($constant)
 	{
 		$trace = debug_backtrace();

Unused Use Statements -5 removed lines

@@ -13,14 +13,9 @@
 class_alias('Kenjis\MonkeyPatch\Patcher\ConstantPatcher\Proxy', '__ConstProxy__');
 
 use LogicException;
-use ReflectionConstant;
-use ReflectionException;
-
 use Kenjis\MonkeyPatch\Patcher\ConstantPatcher;
 use Kenjis\MonkeyPatch\Patcher\Backtrace;
 use Kenjis\MonkeyPatch\MonkeyPatchManager;
-use Kenjis\MonkeyPatch\Cache;
-use Kenjis\MonkeyPatch\InvocationVerifier;
 
 class Proxy
 {

Spacing +6 added lines, -6 removed lines

@@ -63,7 +63,7 @@ 
 			$method = isset($info['class_method']) ? $info['class_method'] : $info['function'];
 
 			MonkeyPatchManager::log(
-				'invoke_const: ' . $constant . ') on line ' . $line . ' in ' . $file . ' by ' . $method . '()'
+				'invoke_const: '.$constant.') on line '.$line.' in '.$file.' by '.$method.'()'
 			);
 		}
 	}
@@ -106,12 +106,12 @@ 
 	{
 		self::logInvocation($constant);
 
-		if (! empty(self::$patches_to_apply[$constant]))
+		if ( ! empty(self::$patches_to_apply[$constant]))
 		{
-			if (! self::checkCalledMethod($constant))
+			if ( ! self::checkCalledMethod($constant))
 			{
 				MonkeyPatchManager::log(
-					'invoke_const: ' . $constant . ' not patched (out of scope)'
+					'invoke_const: '.$constant.' not patched (out of scope)'
 				);
 				return constant($constant);
 			}
@@ -119,12 +119,12 @@ 
 
 		if (array_key_exists($constant, self::$patches))
 		{
-			MonkeyPatchManager::log('invoke_const: ' . $constant . ' patched');
+			MonkeyPatchManager::log('invoke_const: '.$constant.' patched');
 			return self::$patches[$constant];
 		}
 
 		MonkeyPatchManager::log(
-			'invoke_const: ' . $constant . ' not patched (no patch)'
+			'invoke_const: '.$constant.' not patched (no patch)'
 		);
 		return constant($constant);
 	}

application/tests/_ci_phpunit_test/patcher/3.x/Patcher/FunctionPatcher.php

Doc Comments +6 added lines

@@ -84,6 +84,9 @@ 
 		$this->node_visitor = new NodeVisitor();
 	}
 
+	/**
+	 * @param string $error_msg
+	 */
 	protected static function checkLock($error_msg)
 	{
 		if (self::$lock_function_list)
@@ -110,6 +113,9 @@ 
 		return self::$whitelist;
 	}
 
+	/**
+	 * @param string $function_name
+	 */
 	public static function addBlacklist($function_name)
 	{
 		self::checkLock("You can't add to blacklist after initialization");

Unused Use Statements -1 removed lines

@@ -14,7 +14,6 @@
 require __DIR__ . '/FunctionPatcher/Proxy.php';
 
 use LogicException;
-
 use Kenjis\MonkeyPatch\Patcher\FunctionPatcher\NodeVisitor;
 
 class FunctionPatcher extends AbstractPatcher

Spacing +2 added lines, -2 removed lines

@@ -10,8 +10,8 @@
 
 namespace Kenjis\MonkeyPatch\Patcher;
 
-require __DIR__ . '/FunctionPatcher/NodeVisitor.php';
-require __DIR__ . '/FunctionPatcher/Proxy.php';
+require __DIR__.'/FunctionPatcher/NodeVisitor.php';
+require __DIR__.'/FunctionPatcher/Proxy.php';
 
 use LogicException;
 

Braces +2 added lines, -4 removed lines

@@ -181,8 +181,7 @@ 
 			if (is_string($token))
 			{
 				$new_source .= $token;
-			}
-			elseif ($i == $replacement['key'])
+			} elseif ($i == $replacement['key'])
 			{
 				$new_source .= $replacement['value'];
 				$replacement['key'] = key(self::$replacement);
@@ -192,8 +191,7 @@ 
 				{
 					$replacement = false;
 				}
-			}
-			else
+			} else
 			{
 				$new_source .= $token[1];
 			}

application/tests/_ci_phpunit_test/patcher/3.x/Patcher/FunctionPatcher/NodeVisitor.php

Unused Use Statements -4 removed lines

@@ -21,15 +21,11 @@
 
 namespace Kenjis\MonkeyPatch\Patcher\FunctionPatcher;
 
-use ReflectionFunction;
-use ReflectionException;
-
 use PhpParser\Node;
 use PhpParser\Node\Expr\FuncCall;
 use PhpParser\Node\Name;
 use PhpParser\Node\Name\FullyQualified;
 use PhpParser\NodeVisitorAbstract;
-
 use Kenjis\MonkeyPatch\Patcher\FunctionPatcher;
 
 class NodeVisitor extends NodeVisitorAbstract

Spacing +5 added lines, -5 removed lines

@@ -36,17 +36,17 @@ 
 {
 	public function leaveNode(Node $node)
 	{
-		if (! ($node instanceof FuncCall))
+		if ( ! ($node instanceof FuncCall))
 		{
 			return;
 		}
 
-		if (! ($node->name instanceof Name))
+		if ( ! ($node->name instanceof Name))
 		{
 			return;
 		}
 
-		if (! $node->name->isUnqualified())
+		if ( ! $node->name->isUnqualified())
 		{
 			return;
 		}
@@ -55,11 +55,11 @@ 
 			FunctionPatcher::isWhitelisted((string) $node->name)
 			&& ! FunctionPatcher::isBlacklisted((string) $node->name)
 		) {
-			$replacement = new FullyQualified('\__FuncProxy__::' . (string) $node->name);
+			$replacement = new FullyQualified('\__FuncProxy__::'.(string) $node->name);
 
 			$pos = $node->getAttribute('startTokenPos');
 			FunctionPatcher::$replacement[$pos] = 
-				'\__FuncProxy__::' . (string) $node->name;
+				'\__FuncProxy__::'.(string) $node->name;
 
 			$node->name = $replacement;
 		}

application/tests/_ci_phpunit_test/patcher/3.x/Patcher/FunctionPatcher/Proxy.php

Doc Comments +10 added lines, -1 removed lines

@@ -37,7 +37,7 @@ 
 	 * 
 	 * @param string $function     function name
 	 * @param mixed  $return_value return value or callable
-	 * @param string $class_name   class::method to apply this patch
+	 * @param string $class_method   class::method to apply this patch
 	 * 
 	 * @throws LogicException
 	 */
@@ -86,6 +86,9 @@ 
 		InvocationVerifier::verify(self::$expected_invocations, self::$invocations);
 	}
 
+	/**
+	 * @param string $function
+	 */
 	protected static function logInvocation($function, $arguments)
 	{
 		if (MonkeyPatchManager::$debug)
@@ -111,6 +114,9 @@ 
 		}
 	}
 
+	/**
+	 * @param string $function
+	 */
 	protected static function checkCalledMethod($function)
 	{
 		$trace = debug_backtrace();
@@ -184,6 +190,9 @@ 
 		return call_user_func_array($function, $arguments);
 	}
 
+	/**
+	 * @param string $function
+	 */
 	protected static function checkPassedByReference($function)
 	{
 		$ref_func = new ReflectionFunction($function);

Unused Use Statements -1 removed lines

@@ -15,7 +15,6 @@
 use LogicException;
 use ReflectionFunction;
 use ReflectionException;
-
 use Kenjis\MonkeyPatch\Patcher\FunctionPatcher;
 use Kenjis\MonkeyPatch\Patcher\Backtrace;
 use Kenjis\MonkeyPatch\MonkeyPatchManager;

Spacing +9 added lines, -9 removed lines

@@ -51,7 +51,7 @@ 
 			self::outputMessage($msg);
 			throw new LogicException($msg);
 		}
-		if (! FunctionPatcher::isWhitelisted($function))
+		if ( ! FunctionPatcher::isWhitelisted($function))
 		{
 			$msg = "<red>Can't patch on '$function'. It is not in whitelist. If you want to patch it, please add it to 'functions_to_patch' in 'tests/Bootstrap.php'. But note that there are some limitations. See <https://github.com/kenjis/ci-phpunit-test/blob/master/docs/HowToWriteTests.md#patching-functions> for details.</red>";
 			self::outputMessage($msg);
@@ -97,16 +97,16 @@ 
 			$line = $info['line'];
 			$method = isset($info['class_method']) ? $info['class_method'] : $info['function'];
 
-			$log_args = function () use ($arguments) {
+			$log_args = function() use ($arguments) {
 				$output = '';
 				foreach ($arguments as $arg) {
-					$output .= var_export($arg, true) . ', ';
+					$output .= var_export($arg, true).', ';
 				}
 				$output = rtrim($output, ', ');
 				return $output;
 			};
 			MonkeyPatchManager::log(
-				'invoke_func: ' . $function . '(' . $log_args() . ') on line ' . $line . ' in ' . $file . ' by ' . $method . '()'
+				'invoke_func: '.$function.'('.$log_args().') on line '.$line.' in '.$file.' by '.$method.'()'
 			);
 		}
 	}
@@ -148,10 +148,10 @@ 
 
 		if (isset(self::$patches_to_apply[$function]))
 		{
-			if (! self::checkCalledMethod($function))
+			if ( ! self::checkCalledMethod($function))
 			{
 				MonkeyPatchManager::log(
-					'invoke_func: ' . $function . '() not patched (out of scope)'
+					'invoke_func: '.$function.'() not patched (out of scope)'
 				);
 				self::checkPassedByReference($function);
 				return call_user_func_array($function, $arguments);
@@ -160,7 +160,7 @@ 
 
 		if (array_key_exists($function, self::$patches))
 		{
-			MonkeyPatchManager::log('invoke_func: ' . $function . '() patched');
+			MonkeyPatchManager::log('invoke_func: '.$function.'() patched');
 
 			if (is_callable(self::$patches[$function]))
 			{
@@ -178,7 +178,7 @@ 
 		}
 
 		MonkeyPatchManager::log(
-			'invoke_func: ' . $function . '() not patched (no patch)'
+			'invoke_func: '.$function.'() not patched (no patch)'
 		);
 		self::checkPassedByReference($function);
 		return call_user_func_array($function, $arguments);
@@ -231,7 +231,7 @@ 
 		$msg = str_replace(
 			['<red>', '</red>'], [$red_begin, $red_end], $msg
 		);
-		echo $msg . "\n";
+		echo $msg."\n";
 	}
 
 	/**

application/tests/_ci_phpunit_test/patcher/3.x/Patcher/MethodPatcher.php

Unused Use Statements -2 removed lines

@@ -13,8 +13,6 @@
 require __DIR__ . '/MethodPatcher/NodeVisitor.php';
 require __DIR__ . '/MethodPatcher/PatchManager.php';
 
-use LogicException;
-
 use Kenjis\MonkeyPatch\Patcher\MethodPatcher\NodeVisitor;
 
 class MethodPatcher extends AbstractPatcher

Spacing +12 added lines, -12 removed lines

@@ -10,8 +10,8 @@ 
 
 namespace Kenjis\MonkeyPatch\Patcher;
 
-require __DIR__ . '/MethodPatcher/NodeVisitor.php';
-require __DIR__ . '/MethodPatcher/PatchManager.php';
+require __DIR__.'/MethodPatcher/NodeVisitor.php';
+require __DIR__.'/MethodPatcher/PatchManager.php';
 
 use LogicException;
 
@@ -64,11 +64,11 @@ 
 			{
 				if ($start_method && $token === '{')
 				{
-					if(self::isVoidFunction($tokens, $key)){
-						$new_source .= '{ ' . self::CODENORET;
+					if (self::isVoidFunction($tokens, $key)) {
+						$new_source .= '{ '.self::CODENORET;
 					}
-					else{
-						$new_source .= '{ ' . self::CODE;
+					else {
+						$new_source .= '{ '.self::CODE;
 					}
 					$start_method = false;
 					$replacement['key'] = key(self::$replacement);
@@ -100,22 +100,22 @@ 
 	 * @param $key
 	 * @return bool
 	 */
-	protected static function isVoidFunction($tokens, $key){
-		if($key - 1 <= 0){
+	protected static function isVoidFunction($tokens, $key) {
+		if ($key - 1 <= 0) {
 			return false;
 		}
 		$token = $tokens[$key - 1];
-		if(is_array($token)){
+		if (is_array($token)) {
 			$token = $token[1];
 		}
 		//Loop backwards though the start of the function block till you either find "void" or the end of the
 		//parameters declaration.
-		while($token !== ")"){
-			if(strpos($token, "void") !== false){
+		while ($token !== ")") {
+			if (strpos($token, "void") !== false) {
 				return true;
 			}
 			$token = $tokens[$key - 1];
-			if(is_array($token)){
+			if (is_array($token)) {
 				$token = $token[1];
 			}
 			$key--;

Braces +3 added lines, -6 removed lines

@@ -66,8 +66,7 @@ 
 				{
 					if(self::isVoidFunction($tokens, $key)){
 						$new_source .= '{ ' . self::CODENORET;
-					}
-					else{
+					} else{
 						$new_source .= '{ ' . self::CODE;
 					}
 					$start_method = false;
@@ -78,13 +77,11 @@ 
 					{
 						$replacement = false;
 					}
-				}
-				else
+				} else
 				{
 					$new_source .= $token;
 				}
-			}
-			else
+			} else
 			{
 				$new_source .= $token[1];
 			}

application/tests/_ci_phpunit_test/patcher/3.x/Patcher/MethodPatcher/NodeVisitor.php

Unused Use Statements -1 removed lines

@@ -13,7 +13,6 @@
 use PhpParser\Node;
 use PhpParser\Node\Stmt\ClassMethod;
 use PhpParser\NodeVisitorAbstract;
-
 use Kenjis\MonkeyPatch\Patcher\MethodPatcher;
 
 class NodeVisitor extends NodeVisitorAbstract

Spacing +1 added lines, -1 removed lines

@@ -20,7 +20,7 @@
 {
 	public function leaveNode(Node $node)
 	{
-		if (! ($node instanceof ClassMethod))
+		if ( ! ($node instanceof ClassMethod))
 		{
 			return;
 		}

application/tests/_ci_phpunit_test/replacing/core/Input.php

Doc Comments +5 added lines, -5 removed lines

@@ -237,7 +237,7 @@ 
 	/**
 	 * Fetch an item from the GET array
 	 *
-	 * @param	mixed	$index		Index for item to be fetched from $_GET
+	 * @param	string	$index		Index for item to be fetched from $_GET
 	 * @param	bool	$xss_clean	Whether to apply XSS filtering
 	 * @return	mixed
 	 *
@@ -253,7 +253,7 @@ 
 	/**
 	 * Fetch an item from the POST array
 	 *
-	 * @param	mixed	$index		Index for item to be fetched from $_POST
+	 * @param	string	$index		Index for item to be fetched from $_POST
 	 * @param	bool	$xss_clean	Whether to apply XSS filtering
 	 * @return	mixed
 	 *
@@ -321,9 +321,9 @@ 
 	/**
 	 * Fetch an item from the SERVER array
 	 *
-	 * @param	mixed	$index		Index for item to be fetched from $_SERVER
+	 * @param	string	$index		Index for item to be fetched from $_SERVER
 	 * @param	bool	$xss_clean	Whether to apply XSS filtering
-	 * @return	mixed
+	 * @return	string
 	 *
 	 * @codeCoverageIgnore
 	 */
@@ -934,7 +934,7 @@ 
 	 * Allows read access to protected properties
 	 *
 	 * @param	string	$name
-	 * @return	mixed
+	 * @return	string|null
 	 *
 	 * @codeCoverageIgnore
 	 */

Braces +17 added lines, -25 removed lines

@@ -200,29 +200,30 @@ 
 		if (isset($array[$index]))
 		{
 			$value = $array[$index];
-		}
-		elseif (($count = preg_match_all('/(?:^[^\[]+)|\[[^]]*\]/', $index, $matches)) > 1) // Does the index contain array notation
+		} elseif (($count = preg_match_all('/(?:^[^\[]+)|\[[^]]*\]/', $index, $matches)) > 1) {
+			// Does the index contain array notation
 		{
 			$value = $array;
+		}
 			for ($i = 0; $i < $count; $i++)
 			{
 				$key = trim($matches[0][$i], '[]');
-				if ($key === '') // Empty notation will return the value as array
+				if ($key === '') {
+					// Empty notation will return the value as array
 				{
 					break;
 				}
+				}
 
 				if (isset($value[$key]))
 				{
 					$value = $value[$key];
-				}
-				else
+				} else
 				{
 					return NULL;
 				}
 			}
-		}
-		else
+		} else
 		{
 			return NULL;
 		}
@@ -421,8 +422,7 @@ 
 		if ( ! is_numeric($expire))
 		{
 			$expire = time() - 86500;
-		}
-		else
+		} else
 		{
 			$expire = ($expire > 0) ? time() + $expire : 0;
 		}
@@ -483,8 +483,7 @@ 
 					if ( ! $this->valid_ip($spoof))
 					{
 						$spoof = NULL;
-					}
-					else
+					} else
 					{
 						break;
 					}
@@ -537,8 +536,7 @@ 
 							}
 
 							$sprintf = '%016b%016b%016b%016b%016b%016b%016b%016b';
-						}
-						else
+						} else
 						{
 							$ip = explode('.', $this->ip_address);
 							$sprintf = '%08b%08b%08b%08b';
@@ -558,8 +556,7 @@ 
 						{
 							$netaddr[$j] = intval($netaddr[$j], 16);
 						}
-					}
-					else
+					} else
 					{
 						$netaddr = explode('.', $netaddr);
 					}
@@ -646,8 +643,7 @@ 
 		if ($this->_allow_get_array === FALSE)
 		{
 			$_GET = array();
-		}
-		elseif (is_array($_GET))
+		} elseif (is_array($_GET))
 		{
 			foreach ($_GET as $key => $val)
 			{
@@ -683,8 +679,7 @@ 
 				if (($cookie_key = $this->_clean_input_keys($key)) !== FALSE)
 				{
 					$_COOKIE[$cookie_key] = $this->_clean_input_data($val);
-				}
-				else
+				} else
 				{
 					unset($_COOKIE[$key]);
 				}
@@ -774,8 +769,7 @@ 
 			if ($fatal === TRUE)
 			{
 				return FALSE;
-			}
-			else
+			} else
 			{
 				set_status_header(503);
 				echo 'Disallowed Key Characters.';
@@ -814,8 +808,7 @@ 
 		if (function_exists('apache_request_headers'))
 		{
 			$this->headers = apache_request_headers();
-		}
-		else
+		} else
 		{
 			isset($_SERVER['CONTENT_TYPE']) && $this->headers['Content-Type'] = $_SERVER['CONTENT_TYPE'];
 
@@ -944,8 +937,7 @@ 
 		{
 			isset($this->_raw_input_stream) OR $this->_raw_input_stream = file_get_contents('php://input');
 			return $this->_raw_input_stream;
-		}
-		elseif ($name === 'ip_address')
+		} elseif ($name === 'ip_address')
 		{
 			return $this->ip_address;
 		}

Spacing +7 added lines, -7 removed lines

@@ -139,17 +139,17 @@ 
 	 */
 	public function __construct()
 	{
-		$this->_allow_get_array		= (config_item('allow_get_array') !== FALSE);
-		$this->_enable_xss		= (config_item('global_xss_filtering') === TRUE);
-		$this->_enable_csrf		= (config_item('csrf_protection') === TRUE);
-		$this->_standardize_newlines	= (bool) config_item('standardize_newlines');
+		$this->_allow_get_array = (config_item('allow_get_array') !== FALSE);
+		$this->_enable_xss = (config_item('global_xss_filtering') === TRUE);
+		$this->_enable_csrf = (config_item('csrf_protection') === TRUE);
+		$this->_standardize_newlines = (bool) config_item('standardize_newlines');
 
-		$this->security =& load_class('Security', 'core');
+		$this->security = & load_class('Security', 'core');
 
 		// Do we need the UTF-8 class?
 		if (UTF8_ENABLED === TRUE)
 		{
-			$this->uni =& load_class('Utf8', 'core');
+			$this->uni = & load_class('Utf8', 'core');
 		}
 
 		// Sanitize global arrays
@@ -429,7 +429,7 @@ 
 
 		// Save cookie in Output object
 		// added by ci-phpunit-test
-		$CI =& get_instance();
+		$CI = & get_instance();
 		$output = $CI->output;
 		$output->_cookies[$prefix.$name][] = [
 			'value' => $value,

application/tests/_ci_phpunit_test/patcher/3.x/Patcher/ConstantPatcher/NodeVisitor.php

Spacing +8 added lines, -8 removed lines

@@ -24,7 +24,7 @@ 
 
 	public function enterNode(Node $node)
 	{
-		$callback = [$this, 'before' . ucfirst($node->getType())];
+		$callback = [$this, 'before'.ucfirst($node->getType())];
 		if (is_callable($callback)) {
 			call_user_func_array($callback, [$node]);
 		}
@@ -32,9 +32,9 @@ 
 
 	public function leaveNode(Node $node)
 	{
-		if (! ($node instanceof ConstFetch))
+		if ( ! ($node instanceof ConstFetch))
 		{
-			$callback = [$this, 'rewrite' . ucfirst($node->getType())];
+			$callback = [$this, 'rewrite'.ucfirst($node->getType())];
 			if (is_callable($callback)) {
 				call_user_func_array($callback, [$node]);
 			}
@@ -47,23 +47,23 @@ 
 			return;
 		}
 
-		if (! ($node->name instanceof Name))
+		if ( ! ($node->name instanceof Name))
 		{
 			return;
 		}
 
-		if (! $node->name->isUnqualified())
+		if ( ! $node->name->isUnqualified())
 		{
 			return;
 		}
 
-		if (! ConstantPatcher::isBlacklisted((string) $node->name))
+		if ( ! ConstantPatcher::isBlacklisted((string) $node->name))
 		{
-			$replacement = new FullyQualified('\__ConstProxy__::get(\'' . (string) $node->name . '\')');
+			$replacement = new FullyQualified('\__ConstProxy__::get(\''.(string) $node->name.'\')');
 
 			$pos = $node->getAttribute('startTokenPos');
 			ConstantPatcher::$replacement[$pos] = 
-				'\__ConstProxy__::get(\'' . (string) $node->name .'\')';
+				'\__ConstProxy__::get(\''.(string) $node->name.'\')';
 
 			$node->name = $replacement;
 		}

Unused Use Statements -1 removed lines

@@ -15,7 +15,6 @@
 use PhpParser\Node\Name;
 use PhpParser\Node\Name\FullyQualified;
 use PhpParser\NodeVisitorAbstract;
-
 use Kenjis\MonkeyPatch\Patcher\ConstantPatcher;
 
 class NodeVisitor extends NodeVisitorAbstract

application/tests/_ci_phpunit_test/patcher/3.x/Patcher/ExitPatcher.php

Spacing +2 added lines, -2 removed lines

@@ -10,7 +10,7 @@ 
 
 namespace Kenjis\MonkeyPatch\Patcher;
 
-require __DIR__ . '/../Exception/ExitException.php';
+require __DIR__.'/../Exception/ExitException.php';
 
 class ExitPatcher
 {
@@ -30,7 +30,7 @@ 
 			}
 			elseif ($token[0] === T_EXIT)
 			{
-				if ($tokens[$i+1] === ';')
+				if ($tokens[$i + 1] === ';')
 				{
 					$new_source .= 'exit__()';
 				}

Braces +3 added lines, -6 removed lines

@@ -27,20 +27,17 @@
 			if (is_string($token))
 			{
 				$new_source .= $token;
-			}
-			elseif ($token[0] === T_EXIT)
+			} elseif ($token[0] === T_EXIT)
 			{
 				if ($tokens[$i+1] === ';')
 				{
 					$new_source .= 'exit__()';
-				}
-				else
+				} else
 				{
 					$new_source .= 'exit__';
 				}
 				$patched = true;
-			}
-			else
+			} else
 			{
 				$new_source .= $token[1];
 			}