Completed
Pull Request — master (#235)
by Kenji
02:55
created
tests/_ci_phpunit_test/replacing/helpers/old/3.1.6-download_helper.php 2 patches
Spacing   +2 added lines, -2 removed lines patch added patch discarded remove patch
@@ -101,7 +101,7 @@  discard block
 block discarded – undo
101 101
 			}
102 102
 
103 103
 			// Load the mime types
104
-			$mimes =& get_mimes();
104
+			$mimes = & get_mimes();
105 105
 
106 106
 			// Only change the default MIME if we can find one
107 107
 			if (isset($mimes[$extension]))
@@ -146,7 +146,7 @@  discard block
 block discarded – undo
146 146
 
147 147
 		if (ENVIRONMENT === 'testing')
148 148
 		{
149
-			$CI =& get_instance();
149
+			$CI = & get_instance();
150 150
 			$CI->output->set_header('Content-Type: '.$mime);
151 151
 			$CI->output->set_header('Content-Disposition: attachment; filename="'.$filename.'"');
152 152
 			$CI->output->set_header('Expires: 0');
Please login to merge, or discard this patch.
Braces   +4 added lines, -8 removed lines patch added patch discarded remove patch
@@ -67,8 +67,7 @@  discard block
 block discarded – undo
67 67
 		if ($filename === '' OR $data === '')
68 68
 		{
69 69
 			return;
70
-		}
71
-		elseif ($data === NULL)
70
+		} elseif ($data === NULL)
72 71
 		{
73 72
 			if ( ! @is_file($filename) OR ($filesize = @filesize($filename)) === FALSE)
74 73
 			{
@@ -78,8 +77,7 @@  discard block
 block discarded – undo
78 77
 			$filepath = $filename;
79 78
 			$filename = explode('/', str_replace(DIRECTORY_SEPARATOR, '/', $filename));
80 79
 			$filename = end($filename);
81
-		}
82
-		else
80
+		} else
83 81
 		{
84 82
 			$filesize = strlen($data);
85 83
 		}
@@ -158,8 +156,7 @@  discard block
 block discarded – undo
158 156
 			if (ENVIRONMENT !== 'testing')
159 157
 			{
160 158
 				exit($data);
161
-			}
162
-			else
159
+			} else
163 160
 			{
164 161
 				echo($data);
165 162
 				throw new CIPHPUnitTestExitException('exit() from force_download()');
@@ -176,8 +173,7 @@  discard block
 block discarded – undo
176 173
 		if (ENVIRONMENT !== 'testing')
177 174
 		{
178 175
 			exit;
179
-		}
180
-		else
176
+		} else
181 177
 		{
182 178
 			throw new CIPHPUnitTestExitException('exit() from force_download()');
183 179
 		}
Please login to merge, or discard this patch.
tests/_ci_phpunit_test/replacing/helpers/old/3.1.6-url_helper.php 2 patches
Spacing   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -105,7 +105,7 @@
 block discarded – undo
105 105
 				ob_end_clean();
106 106
 			}
107 107
 
108
-			throw new CIPHPUnitTestRedirectException('Redirect to ' . $uri, $code);
108
+			throw new CIPHPUnitTestRedirectException('Redirect to '.$uri, $code);
109 109
 		}
110 110
 	}
111 111
 }
Please login to merge, or discard this patch.
Braces   +3 added lines, -6 removed lines patch added patch discarded remove patch
@@ -63,16 +63,14 @@  discard block
 block discarded – undo
63 63
 		if ($method === 'auto' && isset($_SERVER['SERVER_SOFTWARE']) && strpos($_SERVER['SERVER_SOFTWARE'], 'Microsoft-IIS') !== FALSE)
64 64
 		{
65 65
 			$method = 'refresh';
66
-		}
67
-		elseif ($method !== 'refresh' && (empty($code) OR ! is_numeric($code)))
66
+		} elseif ($method !== 'refresh' && (empty($code) OR ! is_numeric($code)))
68 67
 		{
69 68
 			if (isset($_SERVER['SERVER_PROTOCOL'], $_SERVER['REQUEST_METHOD']) && $_SERVER['SERVER_PROTOCOL'] === 'HTTP/1.1')
70 69
 			{
71 70
 				$code = ($_SERVER['REQUEST_METHOD'] !== 'GET')
72 71
 					? 303	// reference: http://en.wikipedia.org/wiki/Post/Redirect/Get
73 72
 					: 307;
74
-			}
75
-			else
73
+			} else
76 74
 			{
77 75
 				$code = 302;
78 76
 			}
@@ -97,8 +95,7 @@  discard block
 block discarded – undo
97 95
 		if (ENVIRONMENT !== 'testing')
98 96
 		{
99 97
 			exit;
100
-		}
101
-		else
98
+		} else
102 99
 		{
103 100
 			while (ob_get_level() > 1)
104 101
 			{
Please login to merge, or discard this patch.
application/tests/_ci_phpunit_test/replacing/core/old/3.1.6-CodeIgniter.php 2 patches
Spacing   +11 added lines, -11 removed lines patch added patch discarded remove patch
@@ -185,7 +185,7 @@  discard block
 block discarded – undo
185 185
  *  Start the timer... tick tock tick tock...
186 186
  * ------------------------------------------------------
187 187
  */
188
-	$BM =& load_class('Benchmark', 'core');
188
+	$BM = & load_class('Benchmark', 'core');
189 189
 	CIPHPUnitTestSuperGlobal::set_Global('BM', $BM);
190 190
 	$BM->mark('total_execution_time_start');
191 191
 	$BM->mark('loading_time:_base_classes_start');
@@ -195,7 +195,7 @@  discard block
 block discarded – undo
195 195
  *  Instantiate the hooks class
196 196
  * ------------------------------------------------------
197 197
  */
198
-	$EXT =& load_class('Hooks', 'core');
198
+	$EXT = & load_class('Hooks', 'core');
199 199
 	CIPHPUnitTestSuperGlobal::set_Global('EXT', $EXT);
200 200
 
201 201
 /*
@@ -215,7 +215,7 @@  discard block
 block discarded – undo
215 215
  * depending on another class that uses it.
216 216
  *
217 217
  */
218
-	$CFG =& load_class('Config', 'core');
218
+	$CFG = & load_class('Config', 'core');
219 219
 	CIPHPUnitTestSuperGlobal::set_Global('CFG', $CFG);
220 220
 
221 221
 	// Do we have any manually set config items in the index.php file?
@@ -294,7 +294,7 @@  discard block
 block discarded – undo
294 294
  *  Instantiate the UTF-8 class
295 295
  * ------------------------------------------------------
296 296
  */
297
-	$UNI =& load_class('Utf8', 'core');
297
+	$UNI = & load_class('Utf8', 'core');
298 298
 	CIPHPUnitTestSuperGlobal::set_Global('UNI', $UNI);
299 299
 
300 300
 /*
@@ -302,7 +302,7 @@  discard block
 block discarded – undo
302 302
  *  Instantiate the URI class
303 303
  * ------------------------------------------------------
304 304
  */
305
-	$URI =& load_class('URI', 'core');
305
+	$URI = & load_class('URI', 'core');
306 306
 	CIPHPUnitTestSuperGlobal::set_Global('URI', $URI);
307 307
 
308 308
 /*
@@ -310,7 +310,7 @@  discard block
 block discarded – undo
310 310
  *  Instantiate the routing class and set the routing
311 311
  * ------------------------------------------------------
312 312
  */
313
-	$RTR =& load_class('Router', 'core', isset($routing) ? $routing : NULL);
313
+	$RTR = & load_class('Router', 'core', isset($routing) ? $routing : NULL);
314 314
 	CIPHPUnitTestSuperGlobal::set_Global('RTR', $RTR);
315 315
 
316 316
 /*
@@ -318,7 +318,7 @@  discard block
 block discarded – undo
318 318
  *  Instantiate the output class
319 319
  * ------------------------------------------------------
320 320
  */
321
-	$OUT =& load_class('Output', 'core');
321
+	$OUT = & load_class('Output', 'core');
322 322
 	CIPHPUnitTestSuperGlobal::set_Global('OUT', $OUT);
323 323
 
324 324
 /*
@@ -336,7 +336,7 @@  discard block
 block discarded – undo
336 336
  * Load the security class for xss and csrf support
337 337
  * -----------------------------------------------------
338 338
  */
339
-	$SEC =& load_class('Security', 'core');
339
+	$SEC = & load_class('Security', 'core');
340 340
 	CIPHPUnitTestSuperGlobal::set_Global('SEC', $SEC);
341 341
 
342 342
 /*
@@ -344,7 +344,7 @@  discard block
 block discarded – undo
344 344
  *  Load the Input class and sanitize globals
345 345
  * ------------------------------------------------------
346 346
  */
347
-	$IN	=& load_class('Input', 'core');
347
+	$IN = & load_class('Input', 'core');
348 348
 	CIPHPUnitTestSuperGlobal::set_Global('IN', $IN);
349 349
 
350 350
 /*
@@ -352,7 +352,7 @@  discard block
 block discarded – undo
352 352
  *  Load the Language class
353 353
  * ------------------------------------------------------
354 354
  */
355
-	$LANG =& load_class('Lang', 'core');
355
+	$LANG = & load_class('Lang', 'core');
356 356
 	CIPHPUnitTestSuperGlobal::set_Global('LANG', $LANG);
357 357
 
358 358
 /*
@@ -375,7 +375,7 @@  discard block
 block discarded – undo
375 375
 	 */
376 376
 	function &get_instance()
377 377
 	{
378
-		if (! CIPHPUnitTest::wiredesignzHmvcInstalled())
378
+		if ( ! CIPHPUnitTest::wiredesignzHmvcInstalled())
379 379
 		{
380 380
 			return CI_Controller::get_instance();
381 381
 		}
Please login to merge, or discard this patch.
Braces   +10 added lines, -20 removed lines patch added patch discarded remove patch
@@ -169,12 +169,10 @@  discard block
 block discarded – undo
169 169
 			file_exists(APPPATH.'vendor/autoload.php')
170 170
 				? require_once(APPPATH.'vendor/autoload.php')
171 171
 				: log_message('error', '$config[\'composer_autoload\'] is set to TRUE but '.APPPATH.'vendor/autoload.php was not found.');
172
-		}
173
-		elseif (file_exists($composer_autoload))
172
+		} elseif (file_exists($composer_autoload))
174 173
 		{
175 174
 			require_once($composer_autoload);
176
-		}
177
-		else
175
+		} else
178 176
 		{
179 177
 			log_message('error', 'Could not find the specified $config[\'composer_autoload\'] path: '.$composer_autoload);
180 178
 		}
@@ -253,8 +251,7 @@  discard block
 block discarded – undo
253 251
 		// This is required for mb_convert_encoding() to strip invalid characters.
254 252
 		// That's utilized by CI_Utf8, but it's also done for consistency with iconv.
255 253
 		mb_substitute_character('none');
256
-	}
257
-	else
254
+	} else
258 255
 	{
259 256
 		define('MB_ENABLED', FALSE);
260 257
 	}
@@ -267,8 +264,7 @@  discard block
 block discarded – undo
267 264
 		// iconv.internal_encoding is deprecated starting with PHP 5.6
268 265
 		// and it's usage triggers E_DEPRECATED messages.
269 266
 		@ini_set('iconv.internal_encoding', $charset);
270
-	}
271
-	else
267
+	} else
272 268
 	{
273 269
 		define('ICONV_ENABLED', FALSE);
274 270
 	}
@@ -378,8 +374,7 @@  discard block
 block discarded – undo
378 374
 		if (! CIPHPUnitTest::wiredesignzHmvcInstalled())
379 375
 		{
380 376
 			return CI_Controller::get_instance();
381
-		}
382
-		else
377
+		} else
383 378
 		{
384 379
 			return CI::$APP;
385 380
 		}
@@ -424,21 +419,18 @@  discard block
 block discarded – undo
424 419
 	if (empty($class) OR ! file_exists(APPPATH.'controllers/'.$RTR->directory.$class.'.php'))
425 420
 	{
426 421
 		$e404 = TRUE;
427
-	}
428
-	else
422
+	} else
429 423
 	{
430 424
 		require_once(APPPATH.'controllers/'.$RTR->directory.$class.'.php');
431 425
 
432 426
 		if ( ! class_exists($class, FALSE) OR $method[0] === '_' OR method_exists('CI_Controller', $method))
433 427
 		{
434 428
 			$e404 = TRUE;
435
-		}
436
-		elseif (method_exists($class, '_remap'))
429
+		} elseif (method_exists($class, '_remap'))
437 430
 		{
438 431
 			$params = array($method, array_slice($URI->rsegments, 2));
439 432
 			$method = '_remap';
440
-		}
441
-		elseif ( ! method_exists($class, $method))
433
+		} elseif ( ! method_exists($class, $method))
442 434
 		{
443 435
 			$e404 = TRUE;
444 436
 		}
@@ -490,8 +482,7 @@  discard block
 block discarded – undo
490 482
 						$RTR->directory = '';
491 483
 					}
492 484
 				}
493
-			}
494
-			else
485
+			} else
495 486
 			{
496 487
 				$e404 = FALSE;
497 488
 			}
@@ -507,8 +498,7 @@  discard block
 block discarded – undo
507 498
 				1 => $class,
508 499
 				2 => $method
509 500
 			);
510
-		}
511
-		else
501
+		} else
512 502
 		{
513 503
 			show_404($RTR->directory.$class.'/'.$method);
514 504
 		}
Please login to merge, or discard this patch.
application/tests/_ci_phpunit_test/replacing/core/Output.php 2 patches
Spacing   +11 added lines, -11 removed lines patch added patch discarded remove patch
@@ -76,7 +76,7 @@  discard block
 block discarded – undo
76 76
 	 *
77 77
 	 * @var	array
78 78
 	 */
79
-	public $mimes =	array();
79
+	public $mimes = array();
80 80
 
81 81
 	/**
82 82
 	 * Mime-type for the current page
@@ -111,7 +111,7 @@  discard block
 block discarded – undo
111 111
 	 *
112 112
 	 * @var	array
113 113
 	 */
114
-	protected $_profiler_sections =	array();
114
+	protected $_profiler_sections = array();
115 115
 
116 116
 	/**
117 117
 	 * Parse markers flag
@@ -166,7 +166,7 @@  discard block
 block discarded – undo
166 166
 		isset(self::$func_overload) OR self::$func_overload = (extension_loaded('mbstring') && ini_get('mbstring.func_overload'));
167 167
 
168 168
 		// Get mime types for later
169
-		$this->mimes =& get_mimes();
169
+		$this->mimes = & get_mimes();
170 170
 
171 171
 		log_message('info', 'Output Class Initialized');
172 172
 	}
@@ -264,7 +264,7 @@  discard block
 block discarded – undo
264 264
 			// Is this extension supported?
265 265
 			if (isset($this->mimes[$extension]))
266 266
 			{
267
-				$mime_type =& $this->mimes[$extension];
267
+				$mime_type = & $this->mimes[$extension];
268 268
 
269 269
 				if (is_array($mime_type))
270 270
 				{
@@ -334,7 +334,7 @@  discard block
 block discarded – undo
334 334
 		{
335 335
 			if (strncasecmp($header, $headers[$c], $l = self::strlen($header)) === 0)
336 336
 			{
337
-				return trim(self::substr($headers[$c], $l+1));
337
+				return trim(self::substr($headers[$c], $l + 1));
338 338
 			}
339 339
 		}
340 340
 
@@ -437,13 +437,13 @@  discard block
 block discarded – undo
437 437
 		// Note:  We use load_class() because we can't use $CI =& get_instance()
438 438
 		// since this function is sometimes called by the caching mechanism,
439 439
 		// which happens before the CI super object is available.
440
-		$BM =& load_class('Benchmark', 'core');
441
-		$CFG =& load_class('Config', 'core');
440
+		$BM = & load_class('Benchmark', 'core');
441
+		$CFG = & load_class('Config', 'core');
442 442
 
443 443
 		// Grab the super object if we can.
444 444
 		if (class_exists('CI_Controller', FALSE))
445 445
 		{
446
-			$CI =& get_instance();
446
+			$CI = & get_instance();
447 447
 		}
448 448
 
449 449
 		// --------------------------------------------------------------------
@@ -451,7 +451,7 @@  discard block
 block discarded – undo
451 451
 		// Set the output data
452 452
 		if ($output === '')
453 453
 		{
454
-			$output =& $this->final_output;
454
+			$output = & $this->final_output;
455 455
 		}
456 456
 
457 457
 		// --------------------------------------------------------------------
@@ -572,7 +572,7 @@  discard block
 block discarded – undo
572 572
 	 */
573 573
 	public function _write_cache($output)
574 574
 	{
575
-		$CI =& get_instance();
575
+		$CI = & get_instance();
576 576
 		$path = $CI->config->item('cache_path');
577 577
 		$cache_path = ($path === '') ? APPPATH.'cache/' : $path;
578 578
 
@@ -751,7 +751,7 @@  discard block
 block discarded – undo
751 751
 	 */
752 752
 	public function delete_cache($uri = '')
753 753
 	{
754
-		$CI =& get_instance();
754
+		$CI = & get_instance();
755 755
 		$cache_path = $CI->config->item('cache_path');
756 756
 		if ($cache_path === '')
757 757
 		{
Please login to merge, or discard this patch.
Braces   +5 added lines, -10 removed lines patch added patch discarded remove patch
@@ -511,8 +511,7 @@  discard block
 block discarded – undo
511 511
 				{
512 512
 //					header('Content-Encoding: gzip');
513 513
 //					header('Content-Length: '.self::strlen($output));
514
-				}
515
-				else
514
+				} else
516 515
 				{
517 516
 					// User agent doesn't support gzip compression,
518 517
 					// so we'll have to decompress our cache
@@ -552,8 +551,7 @@  discard block
 block discarded – undo
552 551
 		if (method_exists($CI, '_output'))
553 552
 		{
554 553
 			$CI->_output($output);
555
-		}
556
-		else
554
+		} else
557 555
 		{
558 556
 			echo $output; // Send it to the browser!
559 557
 		}
@@ -591,8 +589,7 @@  discard block
 block discarded – undo
591 589
 			if (is_array($cache_query_string))
592 590
 			{
593 591
 				$uri .= '?'.http_build_query(array_intersect_key($_GET, array_flip($cache_query_string)));
594
-			}
595
-			else
592
+			} else
596 593
 			{
597 594
 				$uri .= '?'.$_SERVER['QUERY_STRING'];
598 595
 			}
@@ -685,8 +682,7 @@  discard block
 block discarded – undo
685 682
 			if (is_array($cache_query_string))
686 683
 			{
687 684
 				$uri .= '?'.http_build_query(array_intersect_key($_GET, array_flip($cache_query_string)));
688
-			}
689
-			else
685
+			} else
690 686
 			{
691 687
 				$uri .= '?'.$_SERVER['QUERY_STRING'];
692 688
 			}
@@ -773,8 +769,7 @@  discard block
 block discarded – undo
773 769
 				if (is_array($cache_query_string))
774 770
 				{
775 771
 					$uri .= '?'.http_build_query(array_intersect_key($_GET, array_flip($cache_query_string)));
776
-				}
777
-				else
772
+				} else
778 773
 				{
779 774
 					$uri .= '?'.$_SERVER['QUERY_STRING'];
780 775
 				}
Please login to merge, or discard this patch.
application/tests/_ci_phpunit_test/CIPHPUnitTestCase.php 1 patch
Spacing   +14 added lines, -14 removed lines patch added patch discarded remove patch
@@ -9,7 +9,7 @@  discard block
 block discarded – undo
9 9
  */
10 10
 
11 11
 // Support PHPUnit 6.0
12
-if (! class_exists('PHPUnit_Framework_TestCase'))
12
+if ( ! class_exists('PHPUnit_Framework_TestCase'))
13 13
 {
14 14
 	class_alias('PHPUnit\Framework\TestCase', 'PHPUnit_Framework_TestCase');
15 15
 }
@@ -64,7 +64,7 @@  discard block
 block discarded – undo
64 64
 			return $this->$name;
65 65
 		}
66 66
 
67
-		throw new LogicException('No such property: ' . $name);
67
+		throw new LogicException('No such property: '.$name);
68 68
 	}
69 69
 
70 70
 	public static function setUpBeforeClass()
@@ -87,7 +87,7 @@  discard block
 block discarded – undo
87 87
 	{
88 88
 		reset_instance();
89 89
 		CIPHPUnitTest::createCodeIgniterInstance();
90
-		$this->CI =& get_instance();
90
+		$this->CI = & get_instance();
91 91
 	}
92 92
 
93 93
 	protected function tearDown()
@@ -164,8 +164,8 @@  discard block
 block discarded – undo
164 164
 		}
165 165
 
166 166
 		set_error_handler(
167
-			function ($errno, $errstr, $errfile, $errline) {
168
-				throw new RuntimeException($errstr . ' on line ' . $errline . ' in file ' . $errfile);
167
+			function($errno, $errstr, $errfile, $errline) {
168
+				throw new RuntimeException($errstr.' on line '.$errline.' in file '.$errfile);
169 169
 			}
170 170
 		);
171 171
 
@@ -302,7 +302,7 @@  discard block
 block discarded – undo
302 302
 		$this->assertSame(
303 303
 			$code,
304 304
 			$actual,
305
-			'Status code is not ' . $code . ' but ' . $actual . '.'
305
+			'Status code is not '.$code.' but '.$actual.'.'
306 306
 		);
307 307
 	}
308 308
 
@@ -314,7 +314,7 @@  discard block
 block discarded – undo
314 314
 	 */
315 315
 	public function assertResponseHeader($name, $value)
316 316
 	{
317
-		$CI =& get_instance();
317
+		$CI = & get_instance();
318 318
 		$actual = $CI->output->get_header($name);
319 319
 
320 320
 		if ($actual === null)
@@ -338,7 +338,7 @@  discard block
 block discarded – undo
338 338
 	 */
339 339
 	public function assertResponseCookie($name, $value, $allow_duplicate = false)
340 340
 	{
341
-		$CI =& get_instance();
341
+		$CI = & get_instance();
342 342
 		$cookies = isset($CI->output->_cookies[$name])
343 343
 			? $CI->output->_cookies[$name] : null;
344 344
 
@@ -406,23 +406,23 @@  discard block
 block discarded – undo
406 406
 			$this->fail('redirect() is not called.');
407 407
 		}
408 408
 
409
-		if (! function_exists('site_url'))
409
+		if ( ! function_exists('site_url'))
410 410
 		{
411
-			$CI =& get_instance();
411
+			$CI = & get_instance();
412 412
 			$CI->load->helper('url');
413 413
 		}
414 414
 
415
-		if (! preg_match('#^(\w+:)?//#i', $uri))
415
+		if ( ! preg_match('#^(\w+:)?//#i', $uri))
416 416
 		{
417 417
 			$uri = site_url($uri);
418 418
 		}
419 419
 		$absolute_url = $uri;
420
-		$expected = 'Redirect to ' . $absolute_url;
420
+		$expected = 'Redirect to '.$absolute_url;
421 421
 
422 422
 		$this->assertSame(
423 423
 			$expected,
424 424
 			$status['redirect'],
425
-			'URL to redirect is not ' . $expected . ' but ' . $status['redirect'] . '.'
425
+			'URL to redirect is not '.$expected.' but '.$status['redirect'].'.'
426 426
 		);
427 427
 
428 428
 		if ($code !== null)
@@ -430,7 +430,7 @@  discard block
 block discarded – undo
430 430
 			$this->assertSame(
431 431
 				$code,
432 432
 				$status['code'],
433
-				'Status code is not ' . $code . ' but ' . $status['code'] . '.'
433
+				'Status code is not '.$code.' but '.$status['code'].'.'
434 434
 			);
435 435
 		}
436 436
 	}
Please login to merge, or discard this patch.