Installer::fixPath() - Code Metrics - Inspection of "docs: change sample code to create objest to test" - kenjis/ci-phpunit-test - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — master ( ce859b...64aab5 )

by Kenji

created 2018-03-18 09:33 UTC

Installer::fixPath() B

↳ Parent: Installer

Complexity

Conditions	7
Paths	11

Size

Total Lines	58
Code Lines	38

Duplication

Lines	0
Ratio	0 %

Importance

Changes

Metric	Value
cc	7
eloc	38
nc	11
nop	0
dl	0
loc	58
rs	7.6045
c	0
b	0
f	0

How to fix Long Method

<?php
/**
 * Part of ci-phpunit-test
 *
 * @author     Kenji Suzuki <https://github.com/kenjis>
 * @license    MIT License
 * @copyright  2015 Kenji Suzuki
 * @link       https://github.com/kenjis/ci-phpunit-test
 */

class Installer
namespace YourVendor;

class YourClass { }
{
    private $silent = false;
    private $app_dir = 'application';
    private $pub_dir = 'public';
    private $test_dir = 'tests';

    public function __construct($argv)
    {
        $this->parse_args($argv);
    }

    private function parse_args($argv)
    {
        $argc = count($argv);

        if ($argc === 1) {
            return;
        }

        for ($i = 1; $i <= $argc; $i++) {
            if (! isset($argv[$i])) {
                break;
            }

            switch ($argv[$i]) {
                // php install.php -s
                case '-s':
                    $this->silent = true;
                    break;

                // php install.php -a application
                case '-a':

                    if (is_dir($argv[$i+1])) {
                        $this->app_dir = $argv[$i+1];
                    } else {
                        throw new Exception('No such directory: ' . $argv[$i+1]);
                    }
                    $i++;
                    break;

                // php install.php -p public
                case '-p':

                    if (is_dir($argv[$i+1])) {
                        $this->pub_dir = $argv[$i+1];
                    } else {
                        throw new Exception('No such directory: ' . $argv[$i+1]);
                    }
                    $i++;
                    break;

                default:
                    throw new Exception('Unknown argument: ' . $argv[$i]);
            }
        }
    }

    public function install()
    {
        $this->recursiveCopy(
            dirname(__FILE__) . '/application/tests',
            $this->app_dir . '/' . $this->test_dir
        );
        $this->fixPath();
    }

    /**
     * Fix paths in Bootstrap.php
     */
    private function fixPath()
    {
        $file = $this->app_dir . '/' . $this->test_dir . '/Bootstrap.php';
        $contents = file_get_contents($file);

        if (! file_exists('system')) {
            if (file_exists('vendor/codeigniter/framework/system')) {
                $contents = str_replace(
                    '$system_path = \'../../system\';',
                    '$system_path = \'../../vendor/codeigniter/framework/system\';',
                    $contents
                );
            } else {
                throw new Exception('Can\'t find "system" folder.');
            }
        }

        if (! file_exists('index.php')) {
            if (file_exists($this->pub_dir . '/index.php')) {
                // CodeIgniter 3.0.6 and after
                $contents = str_replace(
                    "define('FCPATH', realpath(dirname(__FILE__).'/../..').DIRECTORY_SEPARATOR);",
                    "define('FCPATH', realpath(dirname(__FILE__).'/../../'. $this->pub_dir).DIRECTORY_SEPARATOR);",
                    $contents
                );
                // CodeIgniter 3.0.5 and before
                $contents = str_replace(
                    "define('FCPATH', realpath(dirname(__FILE__).'/../..').'/');",
                    "define('FCPATH', realpath(dirname(__FILE__).'/../../' . $this->pub_dir).'/');",
                    $contents
                );
            } elseif (file_exists($this->app_dir . '/public/index.php')) {
                // CodeIgniter 3.0.6 and after
                $contents = str_replace(
                    "define('FCPATH', realpath(dirname(__FILE__).'/../..').DIRECTORY_SEPARATOR);",
                    "define('FCPATH', realpath(dirname(__FILE__).'/../public').DIRECTORY_SEPARATOR);",
                    $contents
                );
                // CodeIgniter 3.0.5 and before
                $contents = str_replace(
                    "define('FCPATH', realpath(dirname(__FILE__).'/../..').'/');",
                    "define('FCPATH', realpath(dirname(__FILE__).'/../public').'/');",
                    $contents
                );
                if ($this->app_dir != 'application') {
                    $contents = str_replace(
                        "\$application_folder = '../../application';",
                        "\$application_folder = '../../{$this->app_dir}';",
                        $contents
                    );
                }
            } else {
                throw new Exception('Can\'t find "index.php".');
            }
        }

        file_put_contents($file, $contents);
    }

    public function update()
    {
        $target_dir = $this->app_dir . '/' . $this->test_dir . '/_ci_phpunit_test';
        $this->recursiveUnlink($target_dir);
        $this->recursiveCopy(
            dirname(__FILE__) . '/application/tests/_ci_phpunit_test',
            $target_dir
        );
    }

    /**
     * Recursive Copy
     *
     * @param string $src
     * @param string $dst
     */
    private function recursiveCopy($src, $dst)
    {
        @mkdir($dst, 0755);
// For example instead of
@mkdir($dir);

// Better use
if (@mkdir($dir) === false) {
    throw new \RuntimeException('The directory '.$dir.' could not be created.');
}

        $iterator = new \RecursiveIteratorIterator(
            new \RecursiveDirectoryIterator($src, \RecursiveDirectoryIterator::SKIP_DOTS),
            \RecursiveIteratorIterator::SELF_FIRST
        );

        foreach ($iterator as $file) {
            if ($file->isDir()) {
                @mkdir($dst . '/' . $iterator->getSubPathName());
// For example instead of
@mkdir($dir);

// Better use
if (@mkdir($dir) === false) {
    throw new \RuntimeException('The directory '.$dir.' could not be created.');
}
            } else {
                $success = copy($file, $dst . '/' . $iterator->getSubPathName());
                if ($success) {
                    if (! $this->silent) {
                        echo 'copied: ' . $dst . '/' . $iterator->getSubPathName() . PHP_EOL;
                    }
                }
            }
        }
    }

    /**
     * Recursive Unlink
     *
     * @param string $dir
     */
    private function recursiveUnlink($dir)

    {
        $iterator = new \RecursiveIteratorIterator(
            new \RecursiveDirectoryIterator($dir, \RecursiveDirectoryIterator::SKIP_DOTS),
            \RecursiveIteratorIterator::CHILD_FIRST
        );

        foreach ($iterator as $file) {
            if ($file->isDir()) {
                rmdir($file);
            } else {
                unlink($file);
            }
        }

        rmdir($dir);
    }
}


1		<?php
2		/**
3		* Part of ci-phpunit-test
4		*
5		* @author Kenji Suzuki <https://github.com/kenjis>
6		* @license MIT License
7		* @copyright 2015 Kenji Suzuki
8		* @link https://github.com/kenjis/ci-phpunit-test
9		*/
10
11		class Installer
		0 ignored issues – show Coding Style Compatibility introduced 2018-03-18 01:21 UTC by Report Bug Copy Issue Report PSR1 recommends that each class must be in a namespace of at least one level to avoid collisions. You can fix this by adding a namespace to your class: namespace YourVendor; class YourClass { } When choosing a vendor namespace, try to pick something that is not too generic to avoid conflicts with other libraries. Loading history...
12		{
13		private $silent = false;
14		private $app_dir = 'application';
15		private $pub_dir = 'public';
16		private $test_dir = 'tests';
17
18		public function __construct($argv)
19		{
20		$this->parse_args($argv);
21		}
22
23		private function parse_args($argv)
24		{
25		$argc = count($argv);
26
27		if ($argc === 1) {
28		return;
29		}
30
31		for ($i = 1; $i <= $argc; $i++) {
32		if (! isset($argv[$i])) {
33		break;
34		}
35
36		switch ($argv[$i]) {
37		// php install.php -s
38		case '-s':
39		$this->silent = true;
40		break;
41
42		// php install.php -a application
43	View Code Duplication	case '-a':
		0 ignored issues – show Duplication introduced 2018-03-18 00:45 UTC by Report Bug Copy Issue Report This code seems to be duplicated across your project. Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation. You can also find more detailed suggestions in the “Code” section of your repository. Loading history...
44		if (is_dir($argv[$i+1])) {
45		$this->app_dir = $argv[$i+1];
46		} else {
47		throw new Exception('No such directory: ' . $argv[$i+1]);
48		}
49		$i++;
50		break;
51
52		// php install.php -p public
53	View Code Duplication	case '-p':
		0 ignored issues – show Duplication introduced 2018-03-18 00:45 UTC by Report Bug Copy Issue Report This code seems to be duplicated across your project. Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation. You can also find more detailed suggestions in the “Code” section of your repository. Loading history...
54		if (is_dir($argv[$i+1])) {
55		$this->pub_dir = $argv[$i+1];
56		} else {
57		throw new Exception('No such directory: ' . $argv[$i+1]);
58		}
59		$i++;
60		break;
61
62		default:
63		throw new Exception('Unknown argument: ' . $argv[$i]);
64		}
65		}
66		}
67
68		public function install()
69		{
70		$this->recursiveCopy(
71		dirname(__FILE__) . '/application/tests',
72		$this->app_dir . '/' . $this->test_dir
73		);
74		$this->fixPath();
75		}
76
77		/**
78		* Fix paths in Bootstrap.php
79		*/
80		private function fixPath()
81		{
82		$file = $this->app_dir . '/' . $this->test_dir . '/Bootstrap.php';
83		$contents = file_get_contents($file);
84
85		if (! file_exists('system')) {
86		if (file_exists('vendor/codeigniter/framework/system')) {
87		$contents = str_replace(
88		'$system_path = \'../../system\';',
89		'$system_path = \'../../vendor/codeigniter/framework/system\';',
90		$contents
91		);
92		} else {
93		throw new Exception('Can\'t find "system" folder.');
94		}
95		}
96
97		if (! file_exists('index.php')) {
98		if (file_exists($this->pub_dir . '/index.php')) {
99		// CodeIgniter 3.0.6 and after
100		$contents = str_replace(
101		"define('FCPATH', realpath(dirname(__FILE__).'/../..').DIRECTORY_SEPARATOR);",
102		"define('FCPATH', realpath(dirname(__FILE__).'/../../'. $this->pub_dir).DIRECTORY_SEPARATOR);",
103		$contents
104		);
105		// CodeIgniter 3.0.5 and before
106		$contents = str_replace(
107		"define('FCPATH', realpath(dirname(__FILE__).'/../..').'/');",
108		"define('FCPATH', realpath(dirname(__FILE__).'/../../' . $this->pub_dir).'/');",
109		$contents
110		);
111		} elseif (file_exists($this->app_dir . '/public/index.php')) {
112		// CodeIgniter 3.0.6 and after
113		$contents = str_replace(
114		"define('FCPATH', realpath(dirname(__FILE__).'/../..').DIRECTORY_SEPARATOR);",
115		"define('FCPATH', realpath(dirname(__FILE__).'/../public').DIRECTORY_SEPARATOR);",
116		$contents
117		);
118		// CodeIgniter 3.0.5 and before
119		$contents = str_replace(
120		"define('FCPATH', realpath(dirname(__FILE__).'/../..').'/');",
121		"define('FCPATH', realpath(dirname(__FILE__).'/../public').'/');",
122		$contents
123		);
124		if ($this->app_dir != 'application') {
125		$contents = str_replace(
126		"\$application_folder = '../../application';",
127		"\$application_folder = '../../{$this->app_dir}';",
128		$contents
129		);
130		}
131		} else {
132		throw new Exception('Can\'t find "index.php".');
133		}
134		}
135
136		file_put_contents($file, $contents);
137		}
138
139		public function update()
140		{
141		$target_dir = $this->app_dir . '/' . $this->test_dir . '/_ci_phpunit_test';
142		$this->recursiveUnlink($target_dir);
143		$this->recursiveCopy(
144		dirname(__FILE__) . '/application/tests/_ci_phpunit_test',
145		$target_dir
146		);
147		}
148
149		/**
150		* Recursive Copy
151		*
152		* @param string $src
153		* @param string $dst
154		*/
155		private function recursiveCopy($src, $dst)
156		{
157		@mkdir($dst, 0755);
		0 ignored issues – show Security Best Practice introduced 2015-11-20 22:47 UTC by Report Bug Copy Issue Report It seems like you do not handle an error condition here. This can introduce security issues, and is generally not recommended. If you suppress an error, we recommend checking for the error condition explicitly: // For example instead of @mkdir($dir); // Better use if (@mkdir($dir) === false) { throw new \RuntimeException('The directory '.$dir.' could not be created.'); } Loading history...
158
159		$iterator = new \RecursiveIteratorIterator(
160		new \RecursiveDirectoryIterator($src, \RecursiveDirectoryIterator::SKIP_DOTS),
161		\RecursiveIteratorIterator::SELF_FIRST
162		);
163
164		foreach ($iterator as $file) {
165		if ($file->isDir()) {
166		@mkdir($dst . '/' . $iterator->getSubPathName());
		0 ignored issues – show Security Best Practice introduced 2015-11-20 22:47 UTC by Report Bug Copy Issue Report It seems like you do not handle an error condition here. This can introduce security issues, and is generally not recommended. If you suppress an error, we recommend checking for the error condition explicitly: // For example instead of @mkdir($dir); // Better use if (@mkdir($dir) === false) { throw new \RuntimeException('The directory '.$dir.' could not be created.'); } Loading history...
167		} else {
168		$success = copy($file, $dst . '/' . $iterator->getSubPathName());
169		if ($success) {
170		if (! $this->silent) {
171		echo 'copied: ' . $dst . '/' . $iterator->getSubPathName() . PHP_EOL;
172		}
173		}
174		}
175		}
176		}
177
178		/**
179		* Recursive Unlink
180		*
181		* @param string $dir
182		*/
183	View Code Duplication	private function recursiveUnlink($dir)
		0 ignored issues – show Duplication introduced 2017-08-21 08:20 UTC by Report Bug Copy Issue Report This method seems to be duplicated in your project. Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation. You can also find more detailed suggestions in the “Code” section of your repository. Loading history...
184		{
185		$iterator = new \RecursiveIteratorIterator(
186		new \RecursiveDirectoryIterator($dir, \RecursiveDirectoryIterator::SKIP_DOTS),
187		\RecursiveIteratorIterator::CHILD_FIRST
188		);
189
190		foreach ($iterator as $file) {
191		if ($file->isDir()) {
192		rmdir($file);
193		} else {
194		unlink($file);
195		}
196		}
197
198		rmdir($dir);
199		}
200		}
201

kenjis / ci-phpunit-test

Push — master ( ce859b...64aab5 )

Installer::fixPath() B

Complexity

Size

Duplication

Importance

How to fix Long Method

Long Method

Duplication Side-by-Side

Filter issues like