Installer::update() - Code Metrics - Inspection of "Improvements for installer" - kenjis/ci-phpunit-test - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Pull Request — master (#103)

unknown

created 2016-03-19 20:27 UTC

Installer::update() A

↳ Parent: Installer

Complexity

Conditions	1
Paths	1

Size

Total Lines	9
Code Lines	6

Duplication

Lines	9
Ratio	100 %

Importance

Changes	1
Bugs	0	Features	0

Metric	Value
c	1
b	0
f	0
dl	9
loc	9
rs	9.6666
cc	1
eloc	6
nc	1
nop	1

<?php
/**
 * Part of ci-phpunit-test
 *
 * @author     Kenji Suzuki <https://github.com/kenjis>
 * @license    MIT License
 * @copyright  2015 Kenji Suzuki
 * @link       https://github.com/kenjis/ci-phpunit-test
 */

class Installer
namespace YourVendor;

class YourClass { }
{
    const TEST_FOLDER = 'tests';

    public static function install($app = 'application')

    {
        self::recursiveCopy(
            dirname(__FILE__) . '/application/tests',
            $app . '/' . static::TEST_FOLDER
        );
        self::fixPath($app);
    }

    /**
     * Fix paths in Bootstrap.php
     */
    private static function fixPath($app = 'application')
    {
        $file = $app . '/' . static::TEST_FOLDER . '/Bootstrap.php';
        $contents = file_get_contents($file);
        
        if (! file_exists('system')) {
            if (file_exists('vendor/codeigniter/framework/system')) {
                $contents = str_replace(
                    '$system_path = \'../../system\';',
                    '$system_path = \'../../vendor/codeigniter/framework/system\';',
                    $contents
                );
            } else {
                throw new Exception('Can\'t find "system" folder.');
            }
        }
        
        if (! file_exists('index.php')) {
            if (file_exists('public/index.php')) {
                $contents = str_replace(
                    "define('FCPATH', realpath(dirname(__FILE__).'/../..').'/');",
                    "define('FCPATH', realpath(dirname(__FILE__).'/../../public').'/');",
                    $contents
                );
            } elseif (file_exists($app . '/public/index.php')) {
                $contents = str_replace(
                    "define('FCPATH', realpath(dirname(__FILE__).'/../..').'/');",
                    "define('FCPATH', realpath(dirname(__FILE__).'/../public').'/');",
                    $contents
                );
                if ($app != 'application') {
                    $contents = str_replace(
                        "\$application_folder = '../../application';",
                        "\$application_folder = '../../{$app}';",
                        $contents
                    );
                }
            } else {
                throw new Exception('Can\'t find "index.php".');
            }
        }
        
        file_put_contents($file, $contents);
    }

    public static function update($app = 'application')

    {
        $target_dir = $app . '/' . static::TEST_FOLDER . '/_ci_phpunit_test';
        self::recursiveUnlink($target_dir);
        self::recursiveCopy(
            dirname(__FILE__) . '/application/tests/_ci_phpunit_test',
            $target_dir
        );
    }

    /**
     * Recursive Copy
     *
     * @param string $src
     * @param string $dst
     */
    private static function recursiveCopy($src, $dst)
    {
        @mkdir($dst, 0755);
// For example instead of
@mkdir($dir);

// Better use
if (@mkdir($dir) === false) {
    throw new \RuntimeException('The directory '.$dir.' could not be created.');
}
        
        $iterator = new \RecursiveIteratorIterator(
            new \RecursiveDirectoryIterator($src, \RecursiveDirectoryIterator::SKIP_DOTS),
            \RecursiveIteratorIterator::SELF_FIRST
        );
        
        foreach ($iterator as $file) {
            if ($file->isDir()) {
                @mkdir($dst . '/' . $iterator->getSubPathName());
// For example instead of
@mkdir($dir);

// Better use
if (@mkdir($dir) === false) {
    throw new \RuntimeException('The directory '.$dir.' could not be created.');
}
            } else {
                $success = copy($file, $dst . '/' . $iterator->getSubPathName());
                if ($success) {
                    echo 'copied: ' . $dst . '/' . $iterator->getSubPathName() . PHP_EOL;
                }
            }
        }
    }

    /**
     * Recursive Unlink
     *
     * @param string $dir
     */
    private static function recursiveUnlink($dir)

    {
        $iterator = new \RecursiveIteratorIterator(
            new \RecursiveDirectoryIterator($dir, \RecursiveDirectoryIterator::SKIP_DOTS),
            \RecursiveIteratorIterator::CHILD_FIRST
        );
        
        foreach ($iterator as $file) {
            if ($file->isDir()) {
                rmdir($file);
            } else {
                unlink($file);
            }
        }
        
        rmdir($dir);
    }
}


1		<?php
2		/**
3		* Part of ci-phpunit-test
4		*
5		* @author Kenji Suzuki <https://github.com/kenjis>
6		* @license MIT License
7		* @copyright 2015 Kenji Suzuki
8		* @link https://github.com/kenjis/ci-phpunit-test
9		*/
10
11		class Installer
		0 ignored issues – show Coding Style Compatibility introduced 2015-11-20 22:47 UTC by Report Bug Copy Issue Report PSR1 recommends that each class must be in a namespace of at least one level to avoid collisions. You can fix this by adding a namespace to your class: namespace YourVendor; class YourClass { } When choosing a vendor namespace, try to pick something that is not too generic to avoid conflicts with other libraries. Loading history...
12		{
13		const TEST_FOLDER = 'tests';
14
15	View Code Duplication	public static function install($app = 'application')
		0 ignored issues – show Duplication introduced 2016-03-19 20:29 UTC by Report Bug Copy Issue Report This method seems to be duplicated in your project. Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation. You can also find more detailed suggestions in the “Code” section of your repository. Loading history...
16		{
17		self::recursiveCopy(
18		dirname(__FILE__) . '/application/tests',
19		$app . '/' . static::TEST_FOLDER
20		);
21		self::fixPath($app);
22		}
23
24		/**
25		* Fix paths in Bootstrap.php
26		*/
27		private static function fixPath($app = 'application')
28		{
29		$file = $app . '/' . static::TEST_FOLDER . '/Bootstrap.php';
30		$contents = file_get_contents($file);
31
32		if (! file_exists('system')) {
33		if (file_exists('vendor/codeigniter/framework/system')) {
34		$contents = str_replace(
35		'$system_path = \'../../system\';',
36		'$system_path = \'../../vendor/codeigniter/framework/system\';',
37		$contents
38		);
39		} else {
40		throw new Exception('Can\'t find "system" folder.');
41		}
42		}
43
44		if (! file_exists('index.php')) {
45		if (file_exists('public/index.php')) {
46		$contents = str_replace(
47		"define('FCPATH', realpath(dirname(__FILE__).'/../..').'/');",
48		"define('FCPATH', realpath(dirname(__FILE__).'/../../public').'/');",
49		$contents
50		);
51		} elseif (file_exists($app . '/public/index.php')) {
52		$contents = str_replace(
53		"define('FCPATH', realpath(dirname(__FILE__).'/../..').'/');",
54		"define('FCPATH', realpath(dirname(__FILE__).'/../public').'/');",
55		$contents
56		);
57		if ($app != 'application') {
58		$contents = str_replace(
59		"\$application_folder = '../../application';",
60		"\$application_folder = '../../{$app}';",
61		$contents
62		);
63		}
64		} else {
65		throw new Exception('Can\'t find "index.php".');
66		}
67		}
68
69		file_put_contents($file, $contents);
70		}
71
72	View Code Duplication	public static function update($app = 'application')
		0 ignored issues – show Duplication introduced 2016-03-19 20:29 UTC by Report Bug Copy Issue Report This method seems to be duplicated in your project. Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation. You can also find more detailed suggestions in the “Code” section of your repository. Loading history...
73		{
74		$target_dir = $app . '/' . static::TEST_FOLDER . '/_ci_phpunit_test';
75		self::recursiveUnlink($target_dir);
76		self::recursiveCopy(
77		dirname(__FILE__) . '/application/tests/_ci_phpunit_test',
78		$target_dir
79		);
80		}
81
82		/**
83		* Recursive Copy
84		*
85		* @param string $src
86		* @param string $dst
87		*/
88		private static function recursiveCopy($src, $dst)
89		{
90		@mkdir($dst, 0755);
		0 ignored issues – show Security Best Practice introduced 2015-11-20 22:47 UTC by Report Bug Copy Issue Report It seems like you do not handle an error condition here. This can introduce security issues, and is generally not recommended. If you suppress an error, we recommend checking for the error condition explicitly: // For example instead of @mkdir($dir); // Better use if (@mkdir($dir) === false) { throw new \RuntimeException('The directory '.$dir.' could not be created.'); } Loading history...
91
92		$iterator = new \RecursiveIteratorIterator(
93		new \RecursiveDirectoryIterator($src, \RecursiveDirectoryIterator::SKIP_DOTS),
94		\RecursiveIteratorIterator::SELF_FIRST
95		);
96
97		foreach ($iterator as $file) {
98		if ($file->isDir()) {
99		@mkdir($dst . '/' . $iterator->getSubPathName());
		0 ignored issues – show Security Best Practice introduced 2015-11-20 22:47 UTC by Report Bug Copy Issue Report It seems like you do not handle an error condition here. This can introduce security issues, and is generally not recommended. If you suppress an error, we recommend checking for the error condition explicitly: // For example instead of @mkdir($dir); // Better use if (@mkdir($dir) === false) { throw new \RuntimeException('The directory '.$dir.' could not be created.'); } Loading history...
100		} else {
101		$success = copy($file, $dst . '/' . $iterator->getSubPathName());
102		if ($success) {
103		echo 'copied: ' . $dst . '/' . $iterator->getSubPathName() . PHP_EOL;
104		}
105		}
106		}
107		}
108
109		/**
110		* Recursive Unlink
111		*
112		* @param string $dir
113		*/
114	View Code Duplication	private static function recursiveUnlink($dir)
		0 ignored issues – show Duplication introduced 2015-11-20 22:47 UTC by Report Bug Copy Issue Report This method seems to be duplicated in your project. Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation. You can also find more detailed suggestions in the “Code” section of your repository. Loading history...
115		{
116		$iterator = new \RecursiveIteratorIterator(
117		new \RecursiveDirectoryIterator($dir, \RecursiveDirectoryIterator::SKIP_DOTS),
118		\RecursiveIteratorIterator::CHILD_FIRST
119		);
120
121		foreach ($iterator as $file) {
122		if ($file->isDir()) {
123		rmdir($file);
124		} else {
125		unlink($file);
126		}
127		}
128
129		rmdir($dir);
130		}
131		}
132

kenjis / ci-phpunit-test

Pull Request — master (#103)

Installer::update() A

Complexity

Size

Duplication

Importance

Duplication Side-by-Side

Filter issues like