Issues in InitUI.php (master) - Issues in master - keeko/tools - Measure and Improve Code Quality continuously with Scrutinizer

Issues (74)

Security Analysis not enabled

Cross-Site Scripting

Cross-Site Scripting enables an attacker to inject code into the response of a web-request that is viewed by other users. It can for example be used to bypass access controls, or even to take over other users' accounts.

File Exposure

File Exposure allows an attacker to gain access to local files that he should not be able to access. These files can for example include database credentials, or other configuration files.

File Manipulation

File Manipulation enables an attacker to write custom data to files. This potentially leads to injection of arbitrary code on the server.

Object Injection

Object Injection enables an attacker to inject an object into PHP code, and can lead to arbitrary code execution, file exposure, or file manipulation attacks.

Code Injection

Code Injection enables an attacker to execute arbitrary code on the server.

Response Splitting

Response Splitting can be used to send arbitrary responses.

File Inclusion

File Inclusion enables an attacker to inject custom files into PHP's file loading mechanism, either explicitly passed to include, or for example via PHP's auto-loading mechanism.

Command Injection

Command Injection enables an attacker to inject a shell command that is execute with the privileges of the web-server. This can be used to expose sensitive data, or gain access of your server.

SQL Injection

SQL Injection enables an attacker to execute arbitrary SQL code on your database server gaining access to user data, or manipulating user data.

XPath Injection

XPath Injection enables an attacker to modify the parts of XML document that are read. If that XML document is for example used for authentication, this can lead to further vulnerabilities similar to SQL Injection.

LDAP Injection

LDAP Injection enables an attacker to inject LDAP statements potentially granting permission to run unauthorized queries, or modify content inside the LDAP tree.

Header Injection

Other Vulnerability

This category comprises other attack vectors such as manipulating the PHP runtime, loading custom extensions, freezing the runtime, or similar.

Regex Injection

Regex Injection enables an attacker to execute arbitrary code in your PHP process.

XML Injection

XML Injection enables an attacker to read files on your local filesystem including configuration files, or can be abused to freeze your web-server process.

Variable Injection

Variable Injection enables an attacker to overwrite program variables with custom data, and can lead to further vulnerabilities.

Unfortunately, the security analysis is currently not available for your project. If you are a non-commercial open-source project, please contact support to gain access.

src/ui/InitUI.php (1 issue)

Labels

Coding Style 1

Severity

Minor 1

Upgrade to new PHP Analysis Engine

These results are based on our legacy PHP analysis, consider migrating to our new PHP analysis engine instead. Learn more

<?php
namespace keeko\tools\ui;

use keeko\tools\helpers\InitCommandHelperTrait;
use Symfony\Component\Console\Command\Command;
use Symfony\Component\Console\Question\Question;

class InitUI extends AbstractUI {
	
	use InitCommandHelperTrait;
	
	public function show() {
		$input = $this->io->getInput();
		$output = $this->io->getOutput();
		$formatter = $this->command->getHelperSet()->get('formatter');
		
		// send welcome
		$output->writeln([
			'',
			$formatter->formatBlock('Welcome to the Keeko initializer', 'bg=blue;fg=white', true),
			''
		]);
		$output->writeln([
			'',
			'This command will guide you through creating your Keeko composer package.',
			'',
		]);
		
		// asking for a options
		$name = $this->getName();
		$package = $this->getService()->getPackageService()->getPackage();
		$package->setFullName($name);
		
		$input->setOption('name', $name);
		$input->setOption('description', $this->getDescription());
		$input->setOption('author', $this->getAuthor());
		$input->setOption('license', $this->getLicense());
		
		$type = $this->getType();
		$input->setOption('type', $type);

		// KEEKO values
		$output->writeln([
			'',
			'Information for Keeko ' . ucfirst($type),
			''
		]);
		
		$input->setOption('title', $this->getTitle());
		$input->setOption('classname', $this->getClass());
	}
	
	private function getName() {
// Bad
class Router
{
    public function generate($path)
    {
        return $_SERVER['HOST'].$path;
    }
}

// Better
class Router
{
    private $host;

    public function __construct($host)
    {
        $this->host = $host;
    }

    public function generate($path)
    {
        return $this->host.$path;
    }
}

class Controller
{
    public function myAction(Request $request)
    {
        // Instead of
        $page = isset($_GET['page']) ? intval($_GET['page']) : 1;

        // Better (assuming you use the Symfony2 request)
        $page = $request->query->get('page', 1);
    }
}
		$input = $this->io->getInput();
		$force = $input->getOption('force');
		$package = $this->getService()->getPackageService()->getPackage();
		
		$name = $this->getPackageName();
		$askName = $name === null;
		if ($name === null) {
			$git = $this->getGitConfig();
			$cwd = realpath('.');
			$name = basename($cwd);
			$name = preg_replace('{(?:([a-z])([A-Z])|([A-Z])([A-Z][a-z]))}', '\\1\\3-\\2\\4', $name);
			$name = strtolower($name);
			$localName = $package->getFullName();
			if (!empty($localName)) {
				$name = $package->getFullName();
			} else if (isset($git['github.user'])) {
				$name = $git['github.user'] . '/' . $name;
			} elseif (!empty($_SERVER['USERNAME'])) {
				$name = $_SERVER['USERNAME'] . '/' . $name;
			} elseif (get_current_user()) {
				$name = get_current_user() . '/' . $name;
			} else {
				// package names must be in the format foo/bar
				$name = $name . '/' . $name;
			}
		} else {
			$this->validateName($name);
		}
		
		// asking for the name
		if ($askName || $force) {
			$name = $this->askQuestion(new Question('Package name (<vendor>/<name>)', $name));
			$this->validateName($name);
		}
		
		return $name;
	}
	
	private function getDescription() {
		$force = $this->io->getInput()->getOption('force');
		$desc = $this->getPackageDescription();
		if ($desc === null || $force) {
			$desc = $this->askQuestion(new Question('Description', $desc));
		}
		return $desc;
	}
	
	private function getAuthor() {
		$input = $this->io->getInput();
		$force = $input->getOption('force');
		$package = $this->getService()->getPackageService()->getPackage();
		$git = $this->getGitConfig();
		$author = null;
		if ($package->getAuthors()->isEmpty() || $force) {
			$author = $input->getOption('author');
			if ($author === null && isset($git['user.name'])) {
				$author = $git['user.name'];
		
				if (isset($git['user.email'])) {
					$author = sprintf('%s <%s>', $git['user.name'], $git['user.email']);
				}
			}
		
			$author = $this->askQuestion(new Question('Author', $author));
		}
		return $author;
	}
	
	private function getType() {
		$force = $this->io->getInput()->getOption('force');
		$type = $this->getPackageType();
		if ($type === null || $force) {
			$types = ['module', 'app'];
			$question = new Question('Package type (module|app)', $type);
			$question->setAutocompleterValues($types);
			$question->setValidator(function($answer) use ($types) {
				if (!in_array($answer, $types)) {
					throw new \RuntimeException('The name of the type should be one of: ' .
						implode(',', $types));
				}
				return $answer;
			});
			$question->setMaxAttempts(2);
			$type = $this->askQuestion($question);
		}
		return $type;
	}
	
	private function getLicense() {
		$force = $this->io->getInput()->getOption('force');
		$license = $this->getPackageLicense();
		if ($license === null || $force) {
			$license = $this->askQuestion(new Question('License', $license));
		}
		return $license;
	}
	
	private function getTitle() {
		$force = $this->io->getInput()->getOption('force');
		$title = $this->getPackageTitle();
		if ($title === null || $force) {
			$title = $this->askQuestion(new Question('Title', $title));		
		}
		return $title;
	}
	
	private function getClass() {
		$force = $this->io->getInput()->getOption('force');
		$classname = $this->getPackageClass();
		if ($classname === null || $force) {
			$classname = $this->askQuestion(new Question('Class', $classname));
		}
		return $classname;
	}
}

1			<?php
2			namespace keeko\tools\ui;
3
4			use keeko\tools\helpers\InitCommandHelperTrait;
5			use Symfony\Component\Console\Command\Command;
6			use Symfony\Component\Console\Question\Question;
7
8			class InitUI extends AbstractUI {
9
10			use InitCommandHelperTrait;
11
12			public function show() {
13			$input = $this->io->getInput();
14			$output = $this->io->getOutput();
15			$formatter = $this->command->getHelperSet()->get('formatter');
16
17			// send welcome
18			$output->writeln([
19			'',
20			$formatter->formatBlock('Welcome to the Keeko initializer', 'bg=blue;fg=white', true),
21			''
22			]);
23			$output->writeln([
24			'',
25			'This command will guide you through creating your Keeko composer package.',
26			'',
27			]);
28
29			// asking for a options
30			$name = $this->getName();
31			$package = $this->getService()->getPackageService()->getPackage();
32			$package->setFullName($name);
33
34			$input->setOption('name', $name);
35			$input->setOption('description', $this->getDescription());
36			$input->setOption('author', $this->getAuthor());
37			$input->setOption('license', $this->getLicense());
38
39			$type = $this->getType();
40			$input->setOption('type', $type);
41
42			// KEEKO values
43			$output->writeln([
44			'',
45			'Information for Keeko ' . ucfirst($type),
46			''
47			]);
48
49			$input->setOption('title', $this->getTitle());
50			$input->setOption('classname', $this->getClass());
51			}
52
53			private function getName() {
			0 ignored issues – show Coding Style introduced 2016-04-20 17:00 UTC by Report Bug Copy Issue Report Show Similar Issues like this `getName` uses the super-global variable `$_SERVER` which is generally not recommended. Instead of super-globals, we recommend to explicitly inject the dependencies of your class. This makes your code less dependent on global state and it becomes generally more testable: // Bad class Router { public function generate($path) { return $_SERVER['HOST'].$path; } } // Better class Router { private $host; public function __construct($host) { $this->host = $host; } public function generate($path) { return $this->host.$path; } } class Controller { public function myAction(Request $request) { // Instead of $page = isset($_GET['page']) ? intval($_GET['page']) : 1; // Better (assuming you use the Symfony2 request) $page = $request->query->get('page', 1); } } Loading history...
54			$input = $this->io->getInput();
55			$force = $input->getOption('force');
56			$package = $this->getService()->getPackageService()->getPackage();
57
58			$name = $this->getPackageName();
59			$askName = $name === null;
60			if ($name === null) {
61			$git = $this->getGitConfig();
62			$cwd = realpath('.');
63			$name = basename($cwd);
64			$name = preg_replace('{(?:([a-z])([A-Z])\|([A-Z])([A-Z][a-z]))}', '\\1\\3-\\2\\4', $name);
65			$name = strtolower($name);
66			$localName = $package->getFullName();
67			if (!empty($localName)) {
68			$name = $package->getFullName();
69			} else if (isset($git['github.user'])) {
70			$name = $git['github.user'] . '/' . $name;
71			} elseif (!empty($_SERVER['USERNAME'])) {
72			$name = $_SERVER['USERNAME'] . '/' . $name;
73			} elseif (get_current_user()) {
74			$name = get_current_user() . '/' . $name;
75			} else {
76			// package names must be in the format foo/bar
77			$name = $name . '/' . $name;
78			}
79			} else {
80			$this->validateName($name);
81			}
82
83			// asking for the name
84			if ($askName \|\| $force) {
85			$name = $this->askQuestion(new Question('Package name (<vendor>/<name>)', $name));
86			$this->validateName($name);
87			}
88
89			return $name;
90			}
91
92			private function getDescription() {
93			$force = $this->io->getInput()->getOption('force');
94			$desc = $this->getPackageDescription();
95			if ($desc === null \|\| $force) {
96			$desc = $this->askQuestion(new Question('Description', $desc));
97			}
98			return $desc;
99			}
100
101			private function getAuthor() {
102			$input = $this->io->getInput();
103			$force = $input->getOption('force');
104			$package = $this->getService()->getPackageService()->getPackage();
105			$git = $this->getGitConfig();
106			$author = null;
107			if ($package->getAuthors()->isEmpty() \|\| $force) {
108			$author = $input->getOption('author');
109			if ($author === null && isset($git['user.name'])) {
110			$author = $git['user.name'];
111
112			if (isset($git['user.email'])) {
113			$author = sprintf('%s <%s>', $git['user.name'], $git['user.email']);
114			}
115			}
116
117			$author = $this->askQuestion(new Question('Author', $author));
118			}
119			return $author;
120			}
121
122			private function getType() {
123			$force = $this->io->getInput()->getOption('force');
124			$type = $this->getPackageType();
125			if ($type === null \|\| $force) {
126			$types = ['module', 'app'];
127			$question = new Question('Package type (module\|app)', $type);
128			$question->setAutocompleterValues($types);
129			$question->setValidator(function($answer) use ($types) {
130			if (!in_array($answer, $types)) {
131			throw new \RuntimeException('The name of the type should be one of: ' .
132			implode(',', $types));
133			}
134			return $answer;
135			});
136			$question->setMaxAttempts(2);
137			$type = $this->askQuestion($question);
138			}
139			return $type;
140			}
141
142			private function getLicense() {
143			$force = $this->io->getInput()->getOption('force');
144			$license = $this->getPackageLicense();
145			if ($license === null \|\| $force) {
146			$license = $this->askQuestion(new Question('License', $license));
147			}
148			return $license;
149			}
150
151			private function getTitle() {
152			$force = $this->io->getInput()->getOption('force');
153			$title = $this->getPackageTitle();
154			if ($title === null \|\| $force) {
155			$title = $this->askQuestion(new Question('Title', $title));
156			}
157			return $title;
158			}
159
160			private function getClass() {
161			$force = $this->io->getInput()->getOption('force');
162			$classname = $this->getPackageClass();
163			if ($classname === null \|\| $force) {
164			$classname = $this->askQuestion(new Question('Class', $classname));
165			}
166			return $classname;
167			}
168			}

keeko / tools

Issues (74)

Security Analysis not enabled

src/ui/InitUI.php (1 issue)

Labels

Severity

Introduced By

Upgrade to new PHP Analysis Engine

Duplication Side-by-Side

Filter issues like