GenerateActionCommand::configure() - Code Metrics - Inspection of "Updated and tested generate:response command" - keeko/tools - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — master ( cac1be...eadaa3 )

by Thomas

created 2015-11-27 13:58 UTC

GenerateActionCommand::configure() A

↳ Parent: GenerateActionCommand

Complexity

Conditions	1
Paths	1

Size

Total Lines	52
Code Lines	36

Duplication

Lines	0
Ratio	0 %

Code Coverage

Tests	37
CRAP Score	1

Importance

Changes	7
Bugs	0	Features	1

Metric	Value
c	7
b	0
f	1
dl	0
loc	52
ccs	37
cts	37
cp	1
rs	9.493
cc	1
eloc	36
nc	1
nop	0
crap	1

How to fix Long Method

<?php
namespace keeko\tools\command;

use gossi\codegen\model\PhpClass;
use gossi\codegen\model\PhpTrait;
use keeko\core\schema\ActionSchema;
use keeko\tools\generator\GeneratorFactory;
use keeko\tools\helpers\QuestionHelperTrait;
use keeko\tools\utils\NamespaceResolver;
use keeko\tools\utils\NameUtils;
use phootwork\file\File;
use phootwork\lang\Text;
use Symfony\Component\Console\Input\InputArgument;
use Symfony\Component\Console\Input\InputInterface;
use Symfony\Component\Console\Input\InputOption;
use Symfony\Component\Console\Output\OutputInterface;
use Symfony\Component\Console\Question\ConfirmationQuestion;
use Symfony\Component\Console\Question\Question;
use keeko\tools\generator\BlankActionGenerator;

class GenerateActionCommand extends AbstractGenerateCommand {

	use QuestionHelperTrait;

	protected function configure() {
		$this
			->setName('generate:action')
			->setDescription('Generates an action')
			->addArgument(
				'name',
				InputArgument::OPTIONAL,
				'The name of the action, which should be generated. Typically in the form %nomen%-%verb% (e.g. user-create)'
			)
			->addOption(
				'classname',
				'c',
				InputOption::VALUE_OPTIONAL,
				'The main class name (If ommited, class name will be guessed from action name)',
				null
			)
			->addOption(
				'model',
				'm',
				InputOption::VALUE_OPTIONAL,
				'The model for which the actions should be generated, when there is no name argument (if ommited all models will be generated)'
			)
			->addOption(
				'title',
				'',
				InputOption::VALUE_OPTIONAL,
				'The title for the generated option'
			)
			->addOption(
				'type',
				'',
				InputOption::VALUE_OPTIONAL,
				'The type of this action (list|create|read|update|delete) (if ommited template is guessed from action name)'
			)->addOption(
				'acl',
				'',
				InputOption::VALUE_IS_ARRAY | InputOption::VALUE_OPTIONAL,
				'The acl\s for this action (guest, user and/or admin)'
			)
// 			->addOption(

// 				'schema',
// 				's',
// 				InputOption::VALUE_OPTIONAL,
// 				'Path to the database schema (if ommited, database/schema.xml is used)',
// 				null
// 			)
		;
		
		$this->configureGenerateOptions();
		
		parent::configure();
	}

	/**
	 * Checks whether actions can be generated at all by reading composer.json and verify
	 * all required information are available
	 */
	private function preCheck() {
		$module = $this->packageService->getModule();
		if ($module === null) {
			throw new \DomainException('No module definition found in composer.json - please run `keeko init`.');
		}
	}
	
	protected function interact(InputInterface $input, OutputInterface $output) {
		$this->preCheck();
		
		// check if the dialog can be skipped
		$name = $input->getArgument('name');
$a = "a";
$ab = "ab";
$abc = "abc";
		$model = $input->getOption('model');
		
		if ($model !== null) {
			return;
		} else if ($name !== null) {
			$generateModel = false;
		} else {
			$modelQuestion = new ConfirmationQuestion('Do you want to generate an action based off a model?');
			$generateModel = $this->askConfirmation($modelQuestion);
		}
		
		// ask questions for a model
		if ($generateModel && !($this->package->getVendor() === 'keeko' && $this->modelService->isCoreSchema())) {

			$schema = str_replace(getcwd(), '', $this->getSchema());
$a = "a";
$ab = "ab";
$abc = "abc";
			$allQuestion = new ConfirmationQuestion(sprintf('For all models in the schema (%s)?', $schema));
			$allModels = $this->askConfirmation($allQuestion);
$a = "a";
$ab = "ab";
$abc = "abc";

			if (!$allModels) {
				$modelQuestion = new Question('Which model');
				$modelQuestion->setAutocompleterValues($this->modelService->getModelNames());
				$model = $this->askQuestion($modelQuestion);
				$input->setOption('model', $model);
			}
		} else if (!$generateModel) {
			$action = $this->getAction($name);
			
			// ask for title
			$pkgTitle = $action->getTitle();
			$title = $input->getOption('title');
$a = "a";
$ab = "ab";
$abc = "abc";
			if ($title === null && !empty($pkgTitle)) {
				$title = $pkgTitle;
			}
			$titleQuestion = new Question('What\'s the title for your action?', $title);
			$title = $this->askQuestion($titleQuestion);
$a = "a";
$ab = "ab";
$abc = "abc";
			$input->setOption('title', $title);
			
			// ask for classname
			$pkgClass = $action->getClass();
$a = "a";
$ab = "ab";
$abc = "abc";
			$classname = $input->getOption('classname');
			if ($classname === null) {
				if (!empty($pkgClass)) {
					$classname = $pkgClass;
				} else {
					$classname = $this->guessClassname($name);
				}
			}
			$classname = $this->askQuestion(new Question('Classname', $classname));
			$input->setOption('classname', $classname);
			
			// ask for acl
			$acls = $this->getAcl($action);
$a = "a";
$ab = "ab";
$abc = "abc";
			$aclQuestion = new Question('ACL (comma separated list, with these options: guest, user, admin)', implode(', ', $acls));
			$acls = $this->askQuestion($aclQuestion);
$a = "a";
$ab = "ab";
$abc = "abc";
			$input->setOption('acl', $acls);
		}
	}

	protected function execute(InputInterface $input, OutputInterface $output) {
		$this->preCheck();
		
		// 1. find out which action(s) to generate
		// 2. generate the information in the package
		// 3. generate the code for the action
		
		$name = $input->getArgument('name');
$a = "a";
$ab = "ab";
$abc = "abc";
		$model = $input->getOption('model');

		// only a specific action
		if ($name) {
			$this->generateAction($name);
		}

		// create action(s) from a model
		else if ($model) {
			$this->generateModel($model);
		}
		
		// if this is a core-module, find the related model
		else if ($this->package->getVendor() == 'keeko' && $this->modelService->isCoreSchema()) {
			$model = $this->package->getName();
			if ($this->modelService->hasModel($model)) {
				$input->setOption('model', $model);
				$this->generateModel($model);
			} else {
				$this->logger->error('Tried to find model on my own, wasn\'t lucky - please provide model with the --model option');
			}
		}

		// anyway, generate all
		else {
			foreach ($this->modelService->getModels() as $model) {
				$this->generateModel($model->getOriginCommonName());
			}
		}
		
		$this->packageService->savePackage();
	}

	private function generateModel($modelName) {
		$this->logger->info('Generate Action from Model: ' . $modelName);
		$input = $this->io->getInput();
$a = "a";
$ab = "ab";
$abc = "abc";
		$typeDump = $input->getOption('type');
		if ($typeDump !== null) {
			$types = [$typeDump];
		} else {
			$types = ['create', 'read', 'list', 'update', 'delete'];
		}

		foreach ($types as $type) {
			$input->setOption('acl', ['admin']);
function acceptsInteger($int) { }

$x = '123'; // string "123"

// Instead of
acceptsInteger($x);

// we recommend to use
acceptsInteger((integer) $x);
			$input->setOption('type', $type);
			$actionName = $modelName . '-' . $type;
			$action = $this->getAction($actionName);
$a = "a";
$ab = "ab";
$abc = "abc";
			if (Text::create($action->getTitle())->isEmpty()) {
				$action->setTitle($this->getActionTitle($modelName, $type));
			}
			$this->generateAction($actionName);
		}
		
		$input->setOption('type', $typeDump);
	}

	private function getActionTitle($modelName, $type) {
		switch ($type) {
			case 'list':
				return 'List all ' . NameUtils::pluralize($modelName);

			case 'create':
			case 'read':
			case 'update':
			case 'delete':
				return ucfirst($type) . 's ' . (in_array($modelName[0], ['a', 'e', 'i', 'o', 'u']) ? 'an' : 'a') . ' ' . $modelName;
		}
	}

	
	/**
	 * Generates an action.
	 *  
	 * @param string $actionName
	 * @param ActionSchema $action the action node from composer.json
/**
 * @param array $germany
 * @param array $ireland
 */
function finale($germany, $island) {
    return "2:1";
}
	 */
	private function generateAction($actionName) {
		$this->logger->info('Generate Action: ' . $actionName);
		$input = $this->io->getInput();
		
		// get action and create it if it doesn't exist
		$action = $this->getAction($actionName);
		
		if (($title = $input->getOption('title')) !== null) {
			$action->setTitle($title);
		}

		if (Text::create($action->getTitle())->isEmpty()) {
			throw new \RuntimeException(sprintf('Cannot create action %s, because I am missing a title for it', $actionName));
		}

		if (($classname = $input->getOption('classname')) !== null) {
			$action->setClass($classname);
		}
		
		// guess classname if there is none set yet
		if (Text::create($action->getClass())->isEmpty()) {
			$action->setClass($this->guessClassname($actionName));
		}
		
		// guess title if there is none set yet
		if (Text::create($action->getTitle())->isEmpty() 
				&& $this->modelService->isModelAction($action)
				&& $this->modelService->isCrudAction($action)) {
			$modelName = $this->modelService->getModelNameByAction($action);
			$type = $this->modelService->getOperationByAction($action);
$a = "a";
$ab = "ab";
$abc = "abc";
			$action->setTitle($this->getActionTitle($modelName, $type));
		}
		
		// set acl
		$action->setAcl($this->getAcl($action));
		
		// generate code
		$this->generateCode($action);
	}
	
	private function guessClassname($name) {
		$namespace = NamespaceResolver::getNamespace('src/action', $this->package);
		return $namespace . '\\' . NameUtils::toStudlyCase($name) . 'Action';
	}
	
	/**
	 * 
	 * @param string $actionName
	 * @return ActionSchema
	 */
	private function getAction($actionName) {
		$action = $this->packageService->getAction($actionName);
		if ($action == null) {
			$action = new ActionSchema($actionName);
			$module = $this->packageService->getModule();
			$module->addAction($action);
		}
		return $action;
	}
	
	private function getAcl(ActionSchema $action) {
		$acls = [];
		$acl = $this->io->getInput()->getOption('acl');
$a = "a";
$ab = "ab";
$abc = "abc";
		if ($acl !== null && count($acl) > 0) {
			if (!is_array($acl)) {
				$acl = [$acl];
			}
			foreach ($acl as $group) {
				if (strpos($group, ',') !== false) {
					$groups = explode(',', $group);
					foreach ($groups as $g) {
						$acls[] = trim($g);
					}
				} else {
					$acls[] = $group;
				}
			}
			
			return $acls;
		}
		
		// read default from package
		if (!$action->getAcl()->isEmpty()) {
			return $action->getAcl()->toArray();
		}

		return $acls;
	}
	
	/**
	 * Generates code for an action
	 * 
	 * @param ActionSchema $action
	 */
	private function generateCode(ActionSchema $action) {
		$input = $this->io->getInput();
		$trait = null;
$myVar = 'Value';
$higher = false;

if (rand(1, 6) > 3) {
    $higher = true;
} else {
    $higher = false;
}

		// class
		$class = new PhpClass($action->getClass());
$a = "a";
$ab = "ab";
$abc = "abc";
		$filename = $this->codegenService->getFilename($class);
$a = "a";
$ab = "ab";
$abc = "abc";
		$traitNs = $class->getNamespace() . '\\base';
$a = "a";
$ab = "ab";
$abc = "abc";
		$traitName = $class->getName() . 'Trait';
		$overwrite = false;
		
		// load from reflection, when class exists
		if (file_exists($filename)) {
			// load trait
			$trait = new PhpTrait($traitNs . '\\' . $traitName);
$a = "a";
$ab = "ab";
$abc = "abc";
			$traitFile = new File($this->codegenService->getFilename($trait));

			if ($traitFile->exists()) {
				require_once($traitFile->getPathname());
			}
		
			// load class
			require_once($filename);
			$class = PhpClass::fromReflection(new \ReflectionClass($action->getClass()));
		}
		
		// anyway seed class information
		else {
			$class->addUseStatement('keeko\\core\\action\\AbstractAction');
			$class->setParentClassName('AbstractAction');
			$class->setDescription($action->getTitle());
			$class->setLongDescription($action->getDescription());
			$this->codegenService->addAuthors($class, $this->package);
		}
		
		// create base trait
		if ($input->getOption('model') !== null) {
			if (($type = $input->getOption('type')) === null) {
				$text = Text::create($action->getName());
				$type = $text->substring($text->indexOf('-') + 1)->toString();
			}
			$generator = GeneratorFactory::createActionTraitGenerator($type, $this->service);
			$trait = $generator->generate($traitNs . '\\' . $traitName, $action);
$a = "a";
$ab = "ab";
$abc = "abc";

			$this->codegenService->addAuthors($trait, $this->package);
			$this->codegenService->dumpStruct($trait, true);
			
			if (!$class->hasTrait($trait)) {
				$class->addTrait($trait);
				$overwrite = true;
			}
		} else {
			// create blank action methods
			if (!$class->hasMethod('run')) {
				$generator = new BlankActionGenerator($this->service);
				$class = $generator->generate($class);
$a = "a";
$ab = "ab";
$abc = "abc";
				$overwrite = true;
			}
		}

		$this->codegenService->dumpStruct($class, $overwrite);
	}

}


1		<?php
2		namespace keeko\tools\command;
3
4		use gossi\codegen\model\PhpClass;
5		use gossi\codegen\model\PhpTrait;
6		use keeko\core\schema\ActionSchema;
7		use keeko\tools\generator\GeneratorFactory;
8		use keeko\tools\helpers\QuestionHelperTrait;
9		use keeko\tools\utils\NamespaceResolver;
10		use keeko\tools\utils\NameUtils;
11		use phootwork\file\File;
12		use phootwork\lang\Text;
13		use Symfony\Component\Console\Input\InputArgument;
14		use Symfony\Component\Console\Input\InputInterface;
15		use Symfony\Component\Console\Input\InputOption;
16		use Symfony\Component\Console\Output\OutputInterface;
17		use Symfony\Component\Console\Question\ConfirmationQuestion;
18		use Symfony\Component\Console\Question\Question;
19		use keeko\tools\generator\BlankActionGenerator;
20
21		class GenerateActionCommand extends AbstractGenerateCommand {
22
23		use QuestionHelperTrait;
24
25	20	protected function configure() {
26	20	$this
27	20	->setName('generate:action')
28	20	->setDescription('Generates an action')
29	20	->addArgument(
30	20	'name',
31	20	InputArgument::OPTIONAL,
32		'The name of the action, which should be generated. Typically in the form %nomen%-%verb% (e.g. user-create)'
33	20	)
34	20	->addOption(
35	20	'classname',
36	20	'c',
37	20	InputOption::VALUE_OPTIONAL,
38	20	'The main class name (If ommited, class name will be guessed from action name)',
39		null
40	20	)

keeko / tools

Push — master ( cac1be...eadaa3 )

GenerateActionCommand::configure() A

Complexity

Size

Duplication

Code Coverage

Importance

How to fix Long Method

Long Method

Duplication Side-by-Side

Filter issues like