| Conditions | 13 |
| Paths | 65 |
| Total Lines | 51 |
| Code Lines | 27 |
| Lines | 0 |
| Ratio | 0 % |
| Changes | 1 | ||
| Bugs | 1 | Features | 0 |
Small methods make your code easier to understand, in particular if combined with a good name. Besides, if your method is small, finding a good name is usually much easier.
For example, if you find yourself adding comments to a method's body, this is usually a good sign to extract the commented part to a new method, and use the comment as a starting point when coming up with a good name for this new method.
Commonly applied refactorings include:
If many parameters/temporary variables are present:
| 1 | <?php |
||
| 122 | private function collectInverseRelationships(Table $model) { |
||
| 123 | $relationships = $this->modelService->getRelationships($model); |
||
| 124 | $inverses = []; |
||
| 125 | |||
| 126 | // find reflexive relationships |
||
| 127 | foreach ($relationships->getAll() as $relationship) { |
||
| 128 | |||
| 129 | // find reflexive one-to-many relationships |
||
| 130 | if ($relationship->getType() == Relationship::ONE_TO_MANY && $relationship->isReflexive()) { |
||
| 131 | $prop = NameUtils::toCamelCase($relationship->getRelatedPluralName()); |
||
| 132 | $inverses[$prop] = '\'' . NameUtils::toCamelCase($relationship->getReverseRelatedName()) . '\''; |
||
| 133 | |||
| 134 | // reverse inverse |
||
| 135 | $prop = NameUtils::toCamelCase($relationship->getReverseRelatedName()); |
||
| 136 | $inverses[$prop] = '\'' . NameUtils::toCamelCase($relationship->getRelatedPluralName()) . '\''; |
||
| 137 | } |
||
| 138 | |||
| 139 | // find reflexive many-to-many relationships |
||
| 140 | if ($relationship->getType() == Relationship::MANY_TO_MANY && $relationship->isReflexive()) { |
||
| 141 | $prop = NameUtils::toCamelCase($relationship->getRelatedPluralName()); |
||
| 142 | $inverses[$prop] = '\''.NameUtils::toCamelCase($relationship->getReverseRelatedPluralName()) . '\''; |
||
| 143 | } |
||
| 144 | } |
||
| 145 | |||
| 146 | $dupes = []; |
||
| 147 | foreach ($relationships->getAll() as $relationship) { |
||
| 148 | $rels = $this->modelService->getRelationships($relationship->getForeign()); |
||
| 149 | |||
| 150 | // find null inverse one-to-one relationships |
||
| 151 | foreach ($rels->getOneToOne() as $rel) { |
||
| 152 | if ($rel->getForeign() == $model) { |
||
| 153 | $prop = NameUtils::toCamelCase($relationship->getRelatedName()); |
||
| 154 | if (in_array($prop, $dupes) && !isset($inverses[$prop])) { |
||
| 155 | $inverses[$prop] = 'null'; |
||
| 156 | } else { |
||
| 157 | $dupes[] = $prop; |
||
| 158 | } |
||
| 159 | } |
||
| 160 | } |
||
| 161 | |||
| 162 | // find inverse one-to-many relationship |
||
| 163 | foreach ($rels->getOneToMany() as $rel) { |
||
| 164 | if ($rel->getForeign() == $model) { |
||
| 165 | $prop = NameUtils::toCamelCase($rel->getReverseRelatedName()); |
||
| 166 | $inverses[$prop] = '\'' . NameUtils::toCamelCase($rel->getRelatedPluralName()) . '\''; |
||
| 167 | } |
||
| 168 | } |
||
| 169 | } |
||
| 170 | |||
| 171 | return $inverses; |
||
| 172 | } |
||
| 173 | |||
| 187 | } |