ExtensionDeleteActionTrait::run() - Code Metrics - Inspection of "run `keeko magic`" - keeko/core - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — master ( d6a6e9...1d4c8e )

by Thomas

created 2016-03-07 17:09 UTC

ExtensionDeleteActionTrait::run() A

↳ Parent: ExtensionDeleteActionTrait

Complexity

Conditions	2
Paths	2

Size

Total Lines	16
Code Lines	7

Duplication

Lines	0
Ratio	0 %

Importance

Changes	1
Bugs	0	Features	0

Metric	Value
c	1
b	0
f	0
dl	0
loc	16
rs	9.4285
cc	2
eloc	7
nc	2
nop	1

<?php
namespace keeko\core\action\base;

use Symfony\Component\HttpFoundation\Request;
use Symfony\Component\HttpFoundation\Response;
use Symfony\Component\OptionsResolver\OptionsResolver;
use keeko\core\model\ExtensionQuery;
use Symfony\Component\Routing\Exception\ResourceNotFoundException;

/**
 * Base methods for keeko\core\action\ExtensionDeleteAction
 * 
 * This code is automatically created. Modifications will probably be overwritten.
 * 
 * @author gossi
 */
trait ExtensionDeleteActionTrait {

	/**
	 * @param OptionsResolver $resolver
	 */
	public function configureParams(OptionsResolver $resolver) {
		$resolver->setRequired(['id']);
	}

	/**
	 * Automatically generated run method
	 * 
	 * @param Request $request
	 * @return Response
	 */
	public function run(Request $request) {
		// read
		$id = $this->getParam('id');
trait Idable {
    public function equalIds(Idable $other) {
        return $this->getId() === $other->getId();
    }
}
		$extension = ExtensionQuery::create()->findOneById($id);

		// check existence
		if ($extension === null) {
			throw new ResourceNotFoundException('extension not found.');
		}

		// delete
		$extension->delete();

		// run response
		return $this->response->run($request, $extension);
class MyClass { }

$x = new MyClass();
$x->foo = true;
	}
}


1			<?php
2			namespace keeko\core\action\base;
3
4			use Symfony\Component\HttpFoundation\Request;
5			use Symfony\Component\HttpFoundation\Response;
6			use Symfony\Component\OptionsResolver\OptionsResolver;
7			use keeko\core\model\ExtensionQuery;
8			use Symfony\Component\Routing\Exception\ResourceNotFoundException;
9
10			/**
11			* Base methods for keeko\core\action\ExtensionDeleteAction
12			*
13			* This code is automatically created. Modifications will probably be overwritten.
14			*
15			* @author gossi
16			*/
17			trait ExtensionDeleteActionTrait {
18
19			/**
20			* @param OptionsResolver $resolver
21			*/
22			public function configureParams(OptionsResolver $resolver) {
23			$resolver->setRequired(['id']);
24			}
25
26			/**
27			* Automatically generated run method
28			*
29			* @param Request $request
30			* @return Response
31			*/
32			public function run(Request $request) {
33			// read
34			$id = $this->getParam('id');
			0 ignored issues – show Bug introduced 2016-03-07 17:19 UTC by Report Bug Copy Issue Report It seems like `getParam()` must be provided by classes using this trait. How about adding it as abstract method to this trait? This check looks for methods that are used by a trait but not required by it. To illustrate, let’s look at the following code example trait Idable { public function equalIds(Idable $other) { return $this->getId() === $other->getId(); } } The trait `Idable` provides a method `equalsId` that in turn relies on the method `getId()`. If this method does not exist on a class mixing in this trait, the method will fail. Adding the `getId()` as an abstract method to the trait will make sure it is available. Loading history...
35			$extension = ExtensionQuery::create()->findOneById($id);
36
37			// check existence
38			if ($extension === null) {
39			throw new ResourceNotFoundException('extension not found.');
40			}
41
42			// delete
43			$extension->delete();
44
45			// run response
46			return $this->response->run($request, $extension);
			0 ignored issues – show Bug introduced 2016-03-07 17:19 UTC by Report Bug Copy Issue Report The property `response` does not exist. Did you maybe forget to declare it? In PHP it is possible to write to properties without declaring them. For example, the following is perfectly valid PHP code: class MyClass { } $x = new MyClass(); $x->foo = true; Generally, it is a good practice to explictly declare properties to avoid accidental typos and provide IDE auto-completion: class MyClass { public $foo; } $x = new MyClass(); $x->foo = true; Loading history...
47			}
48			}
49

keeko / core

Push — master ( d6a6e9...1d4c8e )

ExtensionDeleteActionTrait::run() A

Complexity

Size

Duplication

Importance

Duplication Side-by-Side

Filter issues like