ApplicationUriSerializerTrait::getFields() - Code Metrics - Inspection of "moved serializer to own root package" - keeko/core - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — master ( a7ae23...b30b3b )

by Thomas

created 2016-03-09 15:46 UTC

ApplicationUriSerializerTrait::getFields() A

↳ Parent: ApplicationUriSerializerTrait

Complexity

Conditions	1
Paths	1

Size

Total Lines	3
Code Lines	2

Duplication

Lines	0
Ratio	0 %

Importance

Changes	1
Bugs	0	Features	0

Metric	Value
c	1
b	0
f	0
dl	0
loc	3
rs	10
cc	1
eloc	2
nc	1
nop	0

<?php
namespace keeko\core\serializer\base;

use keeko\framework\utils\HydrateUtils;
use Tobscure\JsonApi\Relationship;
use keeko\core\model\Application;
use Tobscure\JsonApi\Resource;
use keeko\core\model\Localization;

/**
 */
trait ApplicationUriSerializerTrait {

	/**
	 * @param mixed $model
	 * @param mixed $related
	 */
	public function application($model, $related) {

		$serializer = Application::getSerializer();
		$relationship = new Relationship(new Resource($model->getApplication(), $serializer));
		$relationship->setLinks([
			'related' => '%apiurl%' . $serializer->getType(null) . '/' . $serializer->getId($model)
		]);
		return $this->addRelationshipSelfLink($relationship, $model, $related);
trait Idable {
    public function equalIds(Idable $other) {
        return $this->getId() === $other->getId();
    }
}
	}

	/**
	 * @param mixed $model
	 * @param array $fields
	 */
	public function getAttributes($model, array $fields = null) {

		return [
			'id' => $model->Id(),
			'httphost' => $model->Httphost(),
			'basepath' => $model->Basepath(),
			'secure' => $model->Secure(),
			'application_id' => $model->ApplicationId(),
			'localization_id' => $model->LocalizationId(),
		];
	}

	/**
	 */
	public function getFields() {
		return ['id', 'httphost', 'basepath', 'secure', 'application_id', 'localization_id'];
	}

	/**
	 * @param mixed $model
	 */
	public function getId($model) {

		return $model->getId();
	}

	/**
	 */
	public function getRelationships() {
		return [
			'application' => Application::getSerializer()->getType(null),
			'localization' => Localization::getSerializer()->getType(null)
		];
	}

	/**
	 */
	public function getSortFields() {
		return ['id', 'httphost', 'basepath', 'secure', 'application_id', 'localization_id'];
	}

	/**
	 * @param mixed $model
	 */
	public function getType($model) {

		return 'core/application-uri';
	}

	/**
	 * @param mixed $model
	 * @param mixed $data
	 */
	public function hydrate($model, $data) {

		// attributes
		$attribs = isset($data['attributes']) ? $data['attributes'] : [];

		$model = HydrateUtils::hydrate($attribs, $model, ['id', 'httphost', 'basepath', 'secure', 'application_id', 'localization_id']);

		// relationships
		$this->hydrateRelationships($model, $data);


		return $model;
	}

	/**
	 * @param mixed $model
	 * @param mixed $related
	 */
	public function localization($model, $related) {

		$serializer = Localization::getSerializer();
		$relationship = new Relationship(new Resource($model->getLocalization(), $serializer));
		$relationship->setLinks([
			'related' => '%apiurl%' . $serializer->getType(null) . '/' . $serializer->getId($model)
		]);
		return $this->addRelationshipSelfLink($relationship, $model, $related);
trait Idable {
    public function equalIds(Idable $other) {
        return $this->getId() === $other->getId();
    }
}
	}

	/**
	 * @param mixed $model
	 * @param mixed $data
	 */
	public function setApplication($model, $data) {
		$model->setApplicationId($data['id']);
	}

	/**
	 * @param mixed $model
	 * @param mixed $data
	 */
	public function setLocalization($model, $data) {
		$model->setLocalizationId($data['id']);
	}
}


1			<?php
2			namespace keeko\core\serializer\base;
3
4			use keeko\framework\utils\HydrateUtils;
5			use Tobscure\JsonApi\Relationship;
6			use keeko\core\model\Application;
7			use Tobscure\JsonApi\Resource;
8			use keeko\core\model\Localization;
9
10			/**
11			*/
12			trait ApplicationUriSerializerTrait {
13
14			/**
15			* @param mixed $model
16			* @param mixed $related
17			*/
18			public function application($model, $related) {
			0 ignored issues – show Documentation introduced 2016-03-09 15:56 UTC by Report Bug Copy Issue Report The return type could not be reliably inferred; please add a `@return` annotation. Our type inference engine in quite powerful, but sometimes the code does not provide enough clues to go by. In these cases we request you to add a `@return` annotation as described here. Loading history...
19			$serializer = Application::getSerializer();
20			$relationship = new Relationship(new Resource($model->getApplication(), $serializer));
21			$relationship->setLinks([
22			'related' => '%apiurl%' . $serializer->getType(null) . '/' . $serializer->getId($model)
23			]);
24			return $this->addRelationshipSelfLink($relationship, $model, $related);
			0 ignored issues – show Bug introduced 2016-03-09 15:56 UTC by Report Bug Copy Issue Report It seems like `addRelationshipSelfLink()` must be provided by classes using this trait. How about adding it as abstract method to this trait? This check looks for methods that are used by a trait but not required by it. To illustrate, let’s look at the following code example trait Idable { public function equalIds(Idable $other) { return $this->getId() === $other->getId(); } } The trait `Idable` provides a method `equalsId` that in turn relies on the method `getId()`. If this method does not exist on a class mixing in this trait, the method will fail. Adding the `getId()` as an abstract method to the trait will make sure it is available. Loading history...
25			}
26
27			/**
28			* @param mixed $model
29			* @param array $fields
30			*/
31			public function getAttributes($model, array $fields = null) {
			1 ignored issue – show Unused Code introduced 2016-03-09 15:56 UTC by Report Bug Copy Issue Report The parameter `$fields` is not used and could be removed. This check looks from parameters that have been defined for a function or method, but which are not used in the method body. Loading history...
32			return [
33			'id' => $model->Id(),
34			'httphost' => $model->Httphost(),
35			'basepath' => $model->Basepath(),
36			'secure' => $model->Secure(),
37			'application_id' => $model->ApplicationId(),
38			'localization_id' => $model->LocalizationId(),
39			];
40			}
41
42			/**
43			*/
44			public function getFields() {
45			return ['id', 'httphost', 'basepath', 'secure', 'application_id', 'localization_id'];
46			}
47
48			/**
49			* @param mixed $model
50			*/
51			public function getId($model) {
			0 ignored issues – show Documentation introduced 2016-03-09 15:56 UTC by Report Bug Copy Issue Report The return type could not be reliably inferred; please add a `@return` annotation. Our type inference engine in quite powerful, but sometimes the code does not provide enough clues to go by. In these cases we request you to add a `@return` annotation as described here. Loading history...
52			return $model->getId();
53			}
54
55			/**
56			*/
57			public function getRelationships() {
58			return [
59			'application' => Application::getSerializer()->getType(null),
60			'localization' => Localization::getSerializer()->getType(null)
61			];
62			}
63
64			/**
65			*/
66			public function getSortFields() {
67			return ['id', 'httphost', 'basepath', 'secure', 'application_id', 'localization_id'];
68			}
69
70			/**
71			* @param mixed $model
72			*/
73			public function getType($model) {
			1 ignored issue – show Unused Code introduced 2016-03-09 15:56 UTC by Report Bug Copy Issue Report The parameter `$model` is not used and could be removed. This check looks from parameters that have been defined for a function or method, but which are not used in the method body. Loading history...
74			return 'core/application-uri';
75			}
76
77			/**
78			* @param mixed $model
79			* @param mixed $data
80			*/
81			public function hydrate($model, $data) {
			0 ignored issues – show Documentation introduced 2016-03-09 15:56 UTC by Report Bug Copy Issue Report The return type could not be reliably inferred; please add a `@return` annotation. Our type inference engine in quite powerful, but sometimes the code does not provide enough clues to go by. In these cases we request you to add a `@return` annotation as described here. Loading history...
82			// attributes
83			$attribs = isset($data['attributes']) ? $data['attributes'] : [];
84
85			$model = HydrateUtils::hydrate($attribs, $model, ['id', 'httphost', 'basepath', 'secure', 'application_id', 'localization_id']);
86
87			// relationships
88			$this->hydrateRelationships($model, $data);
			0 ignored issues – show Bug introduced 2016-03-09 15:56 UTC by Report Bug Copy Issue Report The method `hydrateRelationships()` does not exist on `keeko\core\serializer\ba...ationUriSerializerTrait`. Did you maybe mean `hydrate()`? This check marks calls to methods that do not seem to exist on an object. This is most likely the result of a method being renamed without all references to it being renamed likewise. Loading history...
89
90			return $model;
91			}
92
93			/**
94			* @param mixed $model
95			* @param mixed $related
96			*/
97			public function localization($model, $related) {
			0 ignored issues – show Documentation introduced 2016-03-09 15:56 UTC by Report Bug Copy Issue Report The return type could not be reliably inferred; please add a `@return` annotation. Our type inference engine in quite powerful, but sometimes the code does not provide enough clues to go by. In these cases we request you to add a `@return` annotation as described here. Loading history...
98			$serializer = Localization::getSerializer();
99			$relationship = new Relationship(new Resource($model->getLocalization(), $serializer));
100			$relationship->setLinks([
101			'related' => '%apiurl%' . $serializer->getType(null) . '/' . $serializer->getId($model)
102			]);
103			return $this->addRelationshipSelfLink($relationship, $model, $related);
			0 ignored issues – show Bug introduced 2016-03-09 15:56 UTC by Report Bug Copy Issue Report It seems like `addRelationshipSelfLink()` must be provided by classes using this trait. How about adding it as abstract method to this trait? This check looks for methods that are used by a trait but not required by it. To illustrate, let’s look at the following code example trait Idable { public function equalIds(Idable $other) { return $this->getId() === $other->getId(); } } The trait `Idable` provides a method `equalsId` that in turn relies on the method `getId()`. If this method does not exist on a class mixing in this trait, the method will fail. Adding the `getId()` as an abstract method to the trait will make sure it is available. Loading history...
104			}
105
106			/**
107			* @param mixed $model
108			* @param mixed $data
109			*/
110			public function setApplication($model, $data) {
111			$model->setApplicationId($data['id']);
112			}
113
114			/**
115			* @param mixed $model
116			* @param mixed $data
117			*/
118			public function setLocalization($model, $data) {
119			$model->setLocalizationId($data['id']);
120			}
121			}
122

keeko / core

Push — master ( a7ae23...b30b3b )

ApplicationUriSerializerTrait::getFields() A

Complexity

Size

Duplication

Importance

Duplication Side-by-Side

Filter issues like