keeko\core\serializer\base\UserSerializerTrait

Complexity

Total Complexity

16

Size/Duplication

Total Lines	116
Duplicated Lines	0 %

Coupling/Cohesion

Components	0
Dependencies	4

Importance

Changes	1
Bugs	0	Features	0

11 Methods

Rating	Name	Duplication	Size	Complexity
A	addGroups()	0	8	3
A	getAttributes()	0	13	1
A	getFields()	0	3	1
A	getId()	0	3	1
A	getRelationships()	0	5	1
A	getSortFields()	0	3	1
A	getType()	0	3	1
A	group()	0	4	1
A	hydrate()	0	13	2
A	removeGroups()	0	8	3
A	setGroups()	0	4	1

<?php
namespace keeko\core\serializer\base;

use keeko\framework\utils\HydrateUtils;
use Tobscure\JsonApi\Relationship;
use keeko\core\model\Group;
use keeko\core\model\GroupQuery;
use Tobscure\JsonApi\Collection;
use keeko\core\model\UserGroupQuery;

/**
 */
trait UserSerializerTrait {

	/**
	 * @param mixed $model
	 * @param mixed $data
	 */
	public function addGroups($model, $data) {
		foreach ($data as $item) {
			$group = GroupQuery::create()->findOneById($item['id']);
			if ($group !== null) {
				$model->addGroup($group);
			}
		}
	}

	/**
	 * @param mixed $model
	 * @param array $fields
	 */
	public function getAttributes($model, array $fields = null) {

The parameter $fields is not used and could be removed.

		return [
			'id' => $model->Id(),
			'login_name' => $model->LoginName(),
			'password' => $model->Password(),
			'given_name' => $model->GivenName(),
			'family_name' => $model->FamilyName(),
			'display_name' => $model->DisplayName(),
			'email' => $model->Email(),
			'birthday' => $model->Birthday(\DateTime::ISO8601),
			'sex' => $model->Sex(),
		];
	}

	/**
	 */
	public function getFields() {
		return ['id', 'login_name', 'given_name', 'family_name', 'display_name', 'email', 'birthday', 'sex', 'created_at', 'updated_at'];
	}

	/**
	 * @param mixed $model
	 */
	public function getId($model) {

The return type could not be reliably inferred; please add a @return annotation.

		return $model->getId();
	}

	/**
	 */
	public function getRelationships() {
		return [
			'group' => Group::getSerializer()->getType(null)
		];
	}

	/**
	 */
	public function getSortFields() {
		return ['id', 'login_name', 'password', 'given_name', 'family_name', 'display_name', 'email', 'birthday', 'sex'];
	}

	/**
	 * @param mixed $model
	 */
	public function getType($model) {

The parameter $model is not used and could be removed.

		return 'core/user';
	}

	/**
	 * @param mixed $model
	 * @param mixed $related
	 */
	public function group($model, $related) {

The return type could not be reliably inferred; please add a @return annotation.

		$relationship = new Relationship(new Collection($model->getGroups(), Group::getSerializer()));
		return $this->addRelationshipSelfLink($relationship, $model, $related);

It seems like addRelationshipSelfLink() must be provided by classes using this trait. How about adding it as abstract method to this trait?

	}

	/**
	 * @param mixed $model
	 * @param mixed $data
	 */
	public function hydrate($model, $data) {

The return type could not be reliably inferred; please add a @return annotation.

		// attributes
		$attribs = isset($data['attributes']) ? $data['attributes'] : [];

		$model = HydrateUtils::hydrate($attribs, $model, ['id', 'login_name', 'password' => function($v) {
			return password_hash($v, PASSWORD_BCRYPT);
		}, 'given_name', 'family_name', 'display_name', 'email', 'birthday', 'sex']);

		// relationships
		$this->hydrateRelationships($model, $data);

The method hydrateRelationships() does not exist on keeko\core\serializer\base\UserSerializerTrait. Did you maybe mean hydrate()?

		return $model;
	}

	/**
	 * @param mixed $model
	 * @param mixed $data
	 */
	public function removeGroups($model, $data) {
		foreach ($data as $item) {
			$group = GroupQuery::create()->findOneById($item['id']);
			if ($group !== null) {
				$model->removeGroup($group);
			}
		}
	}

	/**
	 * @param mixed $model
	 * @param mixed $data
	 */
	public function setGroups($model, $data) {
		UserGroupQuery::create()->filterByGroup($model)->delete();
		$this->addGroups($model, $data);
	}
}