keeko\core\serializer\base\ApplicationSerializerTrait

Complexity

Total Complexity

10

Size/Duplication

Total Lines	88
Duplicated Lines	0 %

Coupling/Cohesion

Components	0
Dependencies	4

Importance

Changes	1
Bugs	0	Features	0

9 Methods

Rating	Name	Duplication	Size	Complexity
A	getAttributes()	0	10	1
A	getFields()	0	3	1
A	getId()	0	3	1
A	getRelationships()	0	5	1
A	getSortFields()	0	3	1
A	getType()	0	3	1
A	hydrate()	0	11	2
A	package()	0	8	1
A	setPackage()	0	3	1

<?php
namespace keeko\core\serializer\base;

use keeko\framework\utils\HydrateUtils;
use Tobscure\JsonApi\Relationship;
use keeko\core\model\Package;
use Tobscure\JsonApi\Resource;

/**
 */
trait ApplicationSerializerTrait {

	/**
	 * @param mixed $model
	 * @param array $fields
	 */
	public function getAttributes($model, array $fields = null) {

The parameter $fields is not used and could be removed.

		return [
			'class_name' => $model->ClassName(),
			'id' => $model->Id(),
			'name' => $model->Name(),
			'title' => $model->Title(),
			'description' => $model->Description(),
			'installed_version' => $model->InstalledVersion(),
		];
	}

	/**
	 */
	public function getFields() {
		return ['class_name', 'id', 'name', 'title', 'description', 'installed_version'];
	}

	/**
	 * @param mixed $model
	 */
	public function getId($model) {

The return type could not be reliably inferred; please add a @return annotation.

		return $model->getId();
	}

	/**
	 */
	public function getRelationships() {
		return [
			'package' => Package::getSerializer()->getType(null)
		];
	}

	/**
	 */
	public function getSortFields() {
		return ['class_name', 'id', 'name', 'title', 'description', 'installed_version'];
	}

	/**
	 * @param mixed $model
	 */
	public function getType($model) {

The parameter $model is not used and could be removed.

		return 'core/application';
	}

	/**
	 * @param mixed $model
	 * @param mixed $data
	 */
	public function hydrate($model, $data) {

The return type could not be reliably inferred; please add a @return annotation.

		// attributes
		$attribs = isset($data['attributes']) ? $data['attributes'] : [];

		$model = HydrateUtils::hydrate($attribs, $model, ['class_name', 'id', 'name', 'title', 'description', 'installed_version']);

		// relationships
		$this->hydrateRelationships($model, $data);

The method hydrateRelationships() does not exist on keeko\core\serializer\base\ApplicationSerializerTrait. Did you maybe mean hydrate()?

		return $model;
	}

	/**
	 * @param mixed $model
	 * @param mixed $related
	 */
	public function package($model, $related) {

The return type could not be reliably inferred; please add a @return annotation.

		$serializer = Package::getSerializer();
		$relationship = new Relationship(new Resource($model->getPackage(), $serializer));
		$relationship->setLinks([
			'related' => '%apiurl%' . $serializer->getType(null) . '/' . $serializer->getId($model)
		]);
		return $this->addRelationshipSelfLink($relationship, $model, $related);

It seems like addRelationshipSelfLink() must be provided by classes using this trait. How about adding it as abstract method to this trait?

	}

	/**
	 * @param mixed $model
	 * @param mixed $data
	 */
	public function setPackage($model, $data) {
		$model->setPackageId($data['id']);
	}
}