keeko\core\routing\PageRouter

Complexity

Total Complexity

7

Size/Duplication

Total Lines	62
Duplicated Lines	46.77 %

Coupling/Cohesion

Components	2
Dependencies	5

Test Coverage

Coverage

0%

Importance

Changes	4
Bugs	0	Features	1

3 Methods

Rating	Name	Duplication	Size	Complexity
A	__construct()	0	11	1
B	match()	25	25	4
A	generate()	4	11	2

<?php
namespace keeko\core\routing;

use Symfony\Component\Routing\Route;
use Symfony\Component\Routing\RouteCollection;

class PageRouter extends AbstractRouter implements RouterInterface {
	
	/*
	 * (non-PHPdoc) @see \keeko\core\routing\AbstractRouter::__construct()
	 */
	public function __construct(array $options) {
		// options
		parent::__construct($options);

The call to AbstractRouter::__construct() misses a required argument $options.

$options is of type array, but the function expects a object<Symfony\Component\HttpFoundation\Request>.

		
		// routes
		$routes = new RouteCollection();
		$routes->add('slug', new Route('/{slug}'));
		$routes->add('params', new Route(sprintf('/{slug}%s{params}', $this->options['param-separator'])));
		
		$this->init($routes);
	}
	
	
	/*
	 * (non-PHPdoc) @see \keeko\core\routing\RouteMatcherInterface::match()
	 */
	public function match($destination) {

This method seems to be duplicated in your project.

		if ($destination == '') {
			$destination = '/';
		}
		
		$data = $this->matcher->match($destination);
		
		// find page for matched slug
		if (array_key_exists('slug', $data)) {

This if statement is empty and can be removed.

// 			$data['page'] = PageQuery::create()

58% of this comment could be valid code. Did you maybe forget this after debugging?

// 				->filterByApplication($this->options['application'])
// 				->useRouteQuery()
// 					->filterBySlug($data['slug'])
// 				->endUse()
// 				->find()
// 			;
		}
		
		// unserialize params
		if (array_key_exists('params', $data)) {
			$data['params'] = $this->unserializeParams($data['params']);
		}
		
		return $data;
	}
	
	/*
	 * @TODO: More data params (e.g. page) (non-PHPdoc) @see \keeko\core\routing\RouteGeneratorInterface::match()
	 */
	public function generate($data) {
		
		// params route
		if (array_key_exists('params', $data)) {

This code seems to be duplicated across your project.

			$data['params'] = $this->serializeParams($data['params']);
			return $this->generator->generate('params', $data);
		}
		
		// slug route
		return $this->generator->generate('slug', $data);
	}
}