GroupSerializerTrait::getId() - Code Metrics - Inspection of "add newly generated code with relationship refacto..." - keeko/core - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — master ( 944dfb...9c93d5 )

by Thomas

created 2016-04-19 14:36 UTC

GroupSerializerTrait::getId() A

↳ Parent: GroupSerializerTrait

Complexity

Conditions	1
Paths	1

Size

Total Lines	3
Code Lines	2

Duplication

Lines	0
Ratio	0 %

Importance

Changes	1
Bugs	0	Features	0

Metric	Value
c	1
b	0
f	0
dl	0
loc	3
rs	10
cc	1
eloc	2
nc	1
nop	1

<?php
namespace keeko\core\serializer\base;

use keeko\framework\utils\HydrateUtils;
use Tobscure\JsonApi\Relationship;
use keeko\core\model\User;
use Tobscure\JsonApi\Collection;
use keeko\core\model\Action;

/**
 */
trait GroupSerializerTrait {

	/**
	 * @param mixed $model
	 * @return Relationship
	 */
	public function actions($model) {
		$relationship = new Relationship(new Collection($model->getActions(), Action::getSerializer()));
		return $this->addRelationshipSelfLink($relationship, $model, 'actions');
trait Idable {
    public function equalIds(Idable $other) {
        return $this->getId() === $other->getId();
    }
}
	}

	/**
	 * @param mixed $model
	 * @param array $fields
	 */
	public function getAttributes($model, array $fields = null) {
		return [
			'id' => $model->getId(),
			'owner_id' => $model->getOwnerId(),
			'name' => $model->getName(),
			'is_guest' => $model->getIsGuest(),
			'is_default' => $model->getIsDefault(),
			'is_active' => $model->getIsActive(),
			'is_system' => $model->getIsSystem(),
		];
	}

	/**
	 */
	public function getFields() {
		return ['id', 'owner_id', 'name', 'is_guest', 'is_default', 'is_active', 'is_system', 'created_at', 'updated_at'];
	}

	/**
	 * @param mixed $model
	 * @return string
	 */
	public function getId($model) {
		return $model->getId();
	}

	/**
	 */
	public function getRelationships() {
		return [
			'users' => User::getSerializer()->getType(null),
			'actions' => Action::getSerializer()->getType(null)
		];
	}

	/**
	 */
	public function getSortFields() {
		return ['id', 'owner_id', 'name', 'is_guest', 'is_default', 'is_active', 'is_system'];
	}

	/**
	 * @param mixed $model
	 * @return string
	 */
	public function getType($model) {
		return 'core/group';
	}

	/**
	 * @param mixed $model
	 * @param mixed $data
	 * @return mixed The model
	 */
	public function hydrate($model, $data) {
		// attributes
		$attribs = isset($data['attributes']) ? $data['attributes'] : [];

		$model = HydrateUtils::hydrate($attribs, $model, ['id', 'owner_id', 'name', 'is_guest', 'is_default', 'is_active', 'is_system']);

		// relationships
		$this->hydrateRelationships($model, $data);

		return $model;
	}

	/**
	 * @param mixed $model
	 * @return Relationship
	 */
	public function users($model) {
		$relationship = new Relationship(new Collection($model->getUsers(), User::getSerializer()));
		return $this->addRelationshipSelfLink($relationship, $model, 'users');
trait Idable {
    public function equalIds(Idable $other) {
        return $this->getId() === $other->getId();
    }
}
	}

	/**
	 * @param mixed $model
	 * @param mixed $data
	 */
	abstract protected function hydrateRelationships($model, $data);

}


1			<?php
2			namespace keeko\core\serializer\base;
3
4			use keeko\framework\utils\HydrateUtils;
5			use Tobscure\JsonApi\Relationship;
6			use keeko\core\model\User;
7			use Tobscure\JsonApi\Collection;
8			use keeko\core\model\Action;
9
10			/**
11			*/
12			trait GroupSerializerTrait {
13
14			/**
15			* @param mixed $model
16			* @return Relationship
17			*/
18			public function actions($model) {
19			$relationship = new Relationship(new Collection($model->getActions(), Action::getSerializer()));
20			return $this->addRelationshipSelfLink($relationship, $model, 'actions');
			0 ignored issues – show Bug introduced 2016-04-19 14:46 UTC by Report Bug Copy Issue Report It seems like `addRelationshipSelfLink()` must be provided by classes using this trait. How about adding it as abstract method to this trait? This check looks for methods that are used by a trait but not required by it. To illustrate, let’s look at the following code example trait Idable { public function equalIds(Idable $other) { return $this->getId() === $other->getId(); } } The trait `Idable` provides a method `equalsId` that in turn relies on the method `getId()`. If this method does not exist on a class mixing in this trait, the method will fail. Adding the `getId()` as an abstract method to the trait will make sure it is available. Loading history...
21			}
22
23			/**
24			* @param mixed $model
25			* @param array $fields
26			*/
27			public function getAttributes($model, array $fields = null) {
28			return [
29			'id' => $model->getId(),
30			'owner_id' => $model->getOwnerId(),
31			'name' => $model->getName(),
32			'is_guest' => $model->getIsGuest(),
33			'is_default' => $model->getIsDefault(),
34			'is_active' => $model->getIsActive(),
35			'is_system' => $model->getIsSystem(),
36			];
37			}
38
39			/**
40			*/
41			public function getFields() {
42			return ['id', 'owner_id', 'name', 'is_guest', 'is_default', 'is_active', 'is_system', 'created_at', 'updated_at'];
43			}
44
45			/**
46			* @param mixed $model
47			* @return string
48			*/
49			public function getId($model) {
50			return $model->getId();
51			}
52
53			/**
54			*/
55			public function getRelationships() {
56			return [
57			'users' => User::getSerializer()->getType(null),
58			'actions' => Action::getSerializer()->getType(null)
59			];
60			}
61
62			/**
63			*/
64			public function getSortFields() {
65			return ['id', 'owner_id', 'name', 'is_guest', 'is_default', 'is_active', 'is_system'];
66			}
67
68			/**
69			* @param mixed $model
70			* @return string
71			*/
72			public function getType($model) {
73			return 'core/group';
74			}
75
76			/**
77			* @param mixed $model
78			* @param mixed $data
79			* @return mixed The model
80			*/
81			public function hydrate($model, $data) {
82			// attributes
83			$attribs = isset($data['attributes']) ? $data['attributes'] : [];
84
85			$model = HydrateUtils::hydrate($attribs, $model, ['id', 'owner_id', 'name', 'is_guest', 'is_default', 'is_active', 'is_system']);
86
87			// relationships
88			$this->hydrateRelationships($model, $data);
89
90			return $model;
91			}
92
93			/**
94			* @param mixed $model
95			* @return Relationship
96			*/
97			public function users($model) {
98			$relationship = new Relationship(new Collection($model->getUsers(), User::getSerializer()));
99			return $this->addRelationshipSelfLink($relationship, $model, 'users');
			0 ignored issues – show Bug introduced 2016-03-09 15:56 UTC by Report Bug Copy Issue Report It seems like `addRelationshipSelfLink()` must be provided by classes using this trait. How about adding it as abstract method to this trait? This check looks for methods that are used by a trait but not required by it. To illustrate, let’s look at the following code example trait Idable { public function equalIds(Idable $other) { return $this->getId() === $other->getId(); } } The trait `Idable` provides a method `equalsId` that in turn relies on the method `getId()`. If this method does not exist on a class mixing in this trait, the method will fail. Adding the `getId()` as an abstract method to the trait will make sure it is available. Loading history...
100			}
101
102			/**
103			* @param mixed $model
104			* @param mixed $data
105			*/
106			abstract protected function hydrateRelationships($model, $data);
			0 ignored issues – show Documentation introduced 2016-04-19 14:46 UTC by Report Bug Copy Issue Report For interfaces and abstract methods it is generally a good practice to add a `@return` annotation even if it is just `@return void` or `@return null`, so that implementors know what to do in the overridden method. For interface and abstract methods, it is impossible to infer the return type from the immediate code. In these cases, it is generally advisible to explicitly annotate these methods with a `@return` doc comment to communicate to implementors of these methods what they are expected to return. Loading history...
107			}
108

keeko / core

Push — master ( 944dfb...9c93d5 )

GroupSerializerTrait::getId() A

Complexity

Size

Duplication

Importance

Duplication Side-by-Side

Filter issues like