User::findActivityObject() - Code Metrics - Inspection of "... and commit those forgotten ones" - keeko/core - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — master ( 1d4c8e...a7ae23 )

by Thomas

created 2016-03-07 17:09 UTC

User::findActivityObject() A

↳ Parent: User

Complexity

Conditions	4
Paths	6

Size

Total Lines	21
Code Lines	14

Duplication

Lines	0
Ratio	0 %

Code Coverage

Tests	0
CRAP Score	20

Importance

Changes	3
Bugs	0	Features	1

Metric	Value
c	3
b	0
f	1
dl	0
loc	21
rs	9.0534
ccs	0
cts	6
cp	0
cc	4
eloc	14
nc	6
nop	1
crap	20

<?php
namespace keeko\core\model;

use keeko\core\model\Base\User as BaseUser;
use keeko\core\model\serializer\UserSerializer;
use keeko\framework\model\ApiModelInterface;
use Symfony\Component\OptionsResolver\OptionsResolver;

/**
 * Skeleton subclass for representing a row from the 'kk_user' table.
 *
 * You should add additional methods to this class to meet the
 * application requirements.  This class will only be generated as
 * long as it does not already exist in the output directory.
 */
class User extends BaseUser implements ApiModelInterface {

	/**
	 */
	private static $serializer;

	/**
	 */
	public static function getSerializer() {

		if (self::$serializer === null) {
			self::$serializer = new UserSerializer();
		}

		return self::$serializer;
	}
	
	public function newActivity(array $activity) {
		$resolver = new OptionsResolver();
		$resolver->setRequired(['verb', 'object']);
		$resolver->setOptional(['target']);

		$resolver->setAllowedTypes([
function acceptsInteger($int) { }

$x = '123'; // string "123"

// Instead of
acceptsInteger($x);

// we recommend to use
acceptsInteger((integer) $x);
			'target' => ['keeko\framework\model\ActivityObjectInterface', 'keeko\core\model\ActivityObject'],
			'object' => ['keeko\framework\model\ActivityObjectInterface', 'keeko\core\model\ActivityObject']
		]);
		$options = $resolver->resolve($activity);
		
		$obj = new Activity();
		$obj->setActor($this);
		$obj->setVerb($options['verb']);
		$obj->setObject($this->getActivityObject($options['object']));
		if (isset($options['target'])) {
			$obj->setTarget($this->getActivityObject($options['target']));
		}
		$obj->save();
	}
	
	private function getActivityObject($obj) {

		if ($obj instanceof ActivityObject) {
			return $obj;
		}
	
		if ($obj instanceof ActivityObjectInterface) {
if ($x instanceof DoesNotExist) {
    // Do something.
}
			return $this->findActivityObject($obj->toActivityObject());
		}
	}
	
	private function findActivityObject(ActivityObject $ao) {

		$q = ActivityObjectQuery::create()
			->filterByClassName($ao->getClassName())
			->filterByType($ao->getType())
			->filterByReferenceId($ao->getId());
		
		if (method_exists($ao, 'getVersion')) {
			$version = $ao->getVersion();
			if (!empty($version)) {
				$q = $q->filterByVersion($version);
			}
		}
		
		$result = $q->findOne();
		if ($result) {
			$result->setDisplayName($ao->getDisplayName());
			return $result;
		}
	
		return $ao;
	}
}


1			<?php
2			namespace keeko\core\model;
3
4			use keeko\core\model\Base\User as BaseUser;
5			use keeko\core\model\serializer\UserSerializer;
6			use keeko\framework\model\ApiModelInterface;
7			use Symfony\Component\OptionsResolver\OptionsResolver;
8
9			/**
10			* Skeleton subclass for representing a row from the 'kk_user' table.
11			*
12			* You should add additional methods to this class to meet the
13			* application requirements. This class will only be generated as
14			* long as it does not already exist in the output directory.
15			*/
16			class User extends BaseUser implements ApiModelInterface {
17
18			/**
19			*/
20			private static $serializer;
21
22			/**
23			*/
24			public static function getSerializer() {
			0 ignored issues – show Documentation introduced 2016-03-07 17:25 UTC by Report Bug Copy Issue Report The return type could not be reliably inferred; please add a `@return` annotation. Our type inference engine in quite powerful, but sometimes the code does not provide enough clues to go by. In these cases we request you to add a `@return` annotation as described here. Loading history...
25			if (self::$serializer === null) {
26			self::$serializer = new UserSerializer();
27			}
28
29			return self::$serializer;
30			}
31
32			public function newActivity(array $activity) {
33			$resolver = new OptionsResolver();
34			$resolver->setRequired(['verb', 'object']);
35			$resolver->setOptional(['target']);
			0 ignored issues – show Bug introduced 2016-01-14 15:24 UTC by Report Bug Copy Issue Report The method `setOptional()` does not seem to exist on `object<Symfony\Component...solver\OptionsResolver>`. This check looks for calls to methods that do not seem to exist on a given type. It looks for the method on the type itself as well as in inherited classes or implemented interfaces. This is most likely a typographical error or the method has been renamed. Loading history...
36			$resolver->setAllowedTypes([
			0 ignored issues – show Bug introduced 2016-01-14 15:24 UTC by Report Bug Copy Issue Report The call to `setAllowedTypes()` misses a required argument `$allowedTypes`. This check looks for function calls that miss required arguments. Loading history... Documentation introduced 2016-03-07 17:25 UTC by Report Bug Copy Issue Report `array('target' => array(...odel\\ActivityObject'))` is of type `array<string,array<integ...",\"1\":\"string\"}>"}>`, but the function expects a `string`. It seems like the type of the argument is not accepted by the function/method which you are calling. In some cases, in particular if PHP’s automatic type-juggling kicks in this might be fine. In other cases, however this might be a bug. We suggest to add an explicit type cast like in the following example: function acceptsInteger($int) { } $x = '123'; // string "123" // Instead of acceptsInteger($x); // we recommend to use acceptsInteger((integer) $x); Loading history...
37			'target' => ['keeko\framework\model\ActivityObjectInterface', 'keeko\core\model\ActivityObject'],
38			'object' => ['keeko\framework\model\ActivityObjectInterface', 'keeko\core\model\ActivityObject']
39			]);
40			$options = $resolver->resolve($activity);
41
42			$obj = new Activity();
43			$obj->setActor($this);
44			$obj->setVerb($options['verb']);
45			$obj->setObject($this->getActivityObject($options['object']));
46			if (isset($options['target'])) {
47			$obj->setTarget($this->getActivityObject($options['target']));
48			}
49			$obj->save();
50			}
51
52			private function getActivityObject($obj) {
			0 ignored issues – show Documentation introduced 2015-11-25 17:47 UTC by Report Bug Copy Issue Report The return type could not be reliably inferred; please add a `@return` annotation. Our type inference engine in quite powerful, but sometimes the code does not provide enough clues to go by. In these cases we request you to add a `@return` annotation as described here. Loading history...
53			if ($obj instanceof ActivityObject) {
54			return $obj;
55			}
56
57			if ($obj instanceof ActivityObjectInterface) {
			0 ignored issues – show Bug introduced 2016-03-07 17:25 UTC by Report Bug Copy Issue Report The class `keeko\core\model\ActivityObjectInterface` does not exist. Did you forget a USE statement, or did you not list all dependencies? This error could be the result of: 1. Missing dependencies PHP Analyzer uses your `composer.json` file (if available) to determine the dependencies of your project and to determine all the available classes and functions. It expects the `composer.json` to be in the root folder of your repository. Are you sure this class is defined by one of your dependencies, or did you maybe not list a dependency in either the `require` or `require-dev` section? 2. Missing use statement PHP does not complain about undefined classes in `ìnstanceof` checks. For example, the following PHP code will work perfectly fine: if ($x instanceof DoesNotExist) { // Do something. } If you have not tested against this specific condition, such errors might go unnoticed. Loading history...
58			return $this->findActivityObject($obj->toActivityObject());
59			}
60			}
61
62			private function findActivityObject(ActivityObject $ao) {
			0 ignored issues – show Documentation introduced 2015-11-25 17:47 UTC by Report Bug Copy Issue Report The return type could not be reliably inferred; please add a `@return` annotation. Our type inference engine in quite powerful, but sometimes the code does not provide enough clues to go by. In these cases we request you to add a `@return` annotation as described here. Loading history...
63			$q = ActivityObjectQuery::create()
64			->filterByClassName($ao->getClassName())
65			->filterByType($ao->getType())
66			->filterByReferenceId($ao->getId());
67
68			if (method_exists($ao, 'getVersion')) {
69			$version = $ao->getVersion();
70			if (!empty($version)) {
71			$q = $q->filterByVersion($version);
72			}
73			}
74
75			$result = $q->findOne();
76			if ($result) {
77			$result->setDisplayName($ao->getDisplayName());
78			return $result;
79			}
80
81			return $ao;
82			}
83			}
84

keeko / core

Push — master ( 1d4c8e...a7ae23 )

User::findActivityObject() A

Complexity

Size

Duplication

Code Coverage

Importance

1. Missing dependencies

2. Missing use statement

Duplication Side-by-Side

Filter issues like