Duplicate code is one of the most pungent code smells. A rule that is often used is to re-structure code once it is duplicated in three or more places.
Common duplication problems, and corresponding solutions are:
| 1 | <?php |
||
| 13 | final class ResultPagerTest extends PagerTestCase |
||
| 14 | { |
||
| 15 | /** |
||
| 16 | * @test |
||
| 17 | */ |
||
| 18 | View Code Duplication | public function it_properly_handles_a_too_large_page_as_the_last_page() |
|
| 29 | |||
| 30 | /** |
||
| 31 | * @test |
||
| 32 | */ |
||
| 33 | View Code Duplication | public function invalid_page() |
|
| 41 | |||
| 42 | /** |
||
| 43 | * @test |
||
| 44 | */ |
||
| 45 | View Code Duplication | public function invalid_limit() |
|
| 53 | |||
| 54 | protected function createPager(array $results, int $page, int $limit): Pager |
||
| 58 | } |
||
| 59 |
Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation.
You can also find more detailed suggestions in the “Code” section of your repository.