DBALQueryBuilderResult::take() - Code Metrics - Inspection of "remove unnecessary argument" - kbond/porpaginas - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — master ( 0a4f4d...d259d9 )

by Kevin

created 2016-03-23 19:13 UTC

DBALQueryBuilderResult::take() A

↳ Parent: DBALQueryBuilderResult

Complexity

Conditions	1
Paths	1

Size

Total Lines	13
Code Lines	9

Duplication

Lines	0
Ratio	0 %

Code Coverage

Tests	9
CRAP Score	1

Importance

Changes	1
Bugs	0	Features	1

Metric	Value
c	1
b	0
f	1
dl	0
loc	13
ccs	9
cts	9
cp	1
rs	9.4285
cc	1
eloc	9
nc	1
nop	2
crap	1

<?php

namespace Zenstruck\Porpaginas\Doctrine\DBAL;

use Doctrine\DBAL\Query\QueryBuilder;
use Zenstruck\Porpaginas\Callback\CallbackPage;
use Zenstruck\Porpaginas\Result;

/**
 * @author Kevin Bond <[email protected]>
 */
final class DBALQueryBuilderResult implements Result
{
    private $qb;
    private $countQueryBuilderModifier;
    private $count;

    /**
     * @param QueryBuilder  $qb
     * @param callable|null $countQueryBuilderModifier
     */
    public function __construct(QueryBuilder $qb, callable $countQueryBuilderModifier = null)
    {
        $this->qb = $qb;
        $this->countQueryBuilderModifier = $countQueryBuilderModifier ?: function (QueryBuilder $qb) {
            return $qb->select('COUNT(*)');
        };
    }

    /**
     * {@inheritdoc}
     */
    public function take($offset, $limit)
    {
        $qb = clone $this->qb;
        $results = function ($offset, $limit) use ($qb) {
            return $qb
                ->setFirstResult($offset)
                ->setMaxResults($limit)
                ->execute()
                ->fetchAll();
        };

        return new CallbackPage($results, [$this, 'count'], $offset, $limit);
    }

    /**
     * {@inheritdoc}
     */
    public function count()
    {
        if ($this->count !== null) {
            return $this->count;
        }

        $qb = clone $this->qb;

        call_user_func($this->countQueryBuilderModifier, $qb);

        return $this->count = (int) $qb->execute()->fetchColumn();
    }

    /**
     * {@inheritdoc}
     */
    public function getIterator()
    {
        $stmt = $this->qb->execute();

        while ($data = $stmt->fetch()) {
            yield $data;
        }
    }
}


1		<?php
2
3		namespace Zenstruck\Porpaginas\Doctrine\DBAL;
4
5		use Doctrine\DBAL\Query\QueryBuilder;
6		use Zenstruck\Porpaginas\Callback\CallbackPage;
7		use Zenstruck\Porpaginas\Result;
8
9		/**
10		* @author Kevin Bond <[email protected]>
11		*/
12		final class DBALQueryBuilderResult implements Result
13		{
14		private $qb;
15		private $countQueryBuilderModifier;
16		private $count;
17
18		/**
19		* @param QueryBuilder $qb
20		* @param callable\|null $countQueryBuilderModifier
21		*/
22	12	public function __construct(QueryBuilder $qb, callable $countQueryBuilderModifier = null)
23		{
24	12	$this->qb = $qb;
25		$this->countQueryBuilderModifier = $countQueryBuilderModifier ?: function (QueryBuilder $qb) {
26	4	return $qb->select('COUNT(*)');
27		};
28	12	}
29
30		/**
31		* {@inheritdoc}
32		*/
33	4	public function take($offset, $limit)
34		{
35	4	$qb = clone $this->qb;
36	4	$results = function ($offset, $limit) use ($qb) {
37		return $qb
38	4	->setFirstResult($offset)
39	4	->setMaxResults($limit)
40	4	->execute()
41	4	->fetchAll();
42	4	};
43
44	4	return new CallbackPage($results, [$this, 'count'], $offset, $limit);
45		}
46
47		/**
48		* {@inheritdoc}
49		*/
50	4	public function count()
51		{
52	4	if ($this->count !== null) {
53		return $this->count;
54		}
55
56	4	$qb = clone $this->qb;
57
58	4	call_user_func($this->countQueryBuilderModifier, $qb);
59
60	4	return $this->count = (int) $qb->execute()->fetchColumn();
61		}
62
63		/**
64		* {@inheritdoc}
65		*/
66	1	public function getIterator()
67		{
68	1	$stmt = $this->qb->execute();
69
70	1	while ($data = $stmt->fetch()) {
71	1	yield $data;
72	1	}
73	1	}
74		}
75

kbond / porpaginas

Push — master ( 0a4f4d...d259d9 )

DBALQueryBuilderResult::take() A

Complexity

Size

Duplication

Code Coverage

Importance

Duplication Side-by-Side

Filter issues like