Completed
Push — master ( e214c2...9b8774 )
by Kevin
02:27
created

OpenSSL   A

Complexity

Total Complexity 10

Size/Duplication

Total Lines 67
Duplicated Lines 44.78 %

Coupling/Cohesion

Components 1
Dependencies 4

Test Coverage

Coverage 92.59%

Importance

Changes 1
Bugs 0 Features 0
Metric Value
c 1
b 0
f 0
dl 30
loc 67
wmc 10
lcom 1
cbo 4
ccs 25
cts 27
cp 0.9259
rs 10

6 Methods

Rating   Name   Duplication   Size   Complexity  
A __construct() 0 6 2
A sign() 16 16 3
A verify() 14 14 3
hashingAlgorithm() 0 1 ?
allowedType() 0 1 ?
A verifyType() 0 6 2

How to fix   Duplicated Code   

Duplicated Code

Duplicate code is one of the most pungent code smells. A rule that is often used is to re-structure code once it is duplicated in three or more places.

Common duplication problems, and corresponding solutions are:

1
<?php
2
3
namespace Zenstruck\JWT\Signer;
4
5
use Zenstruck\JWT\Signer;
6
use Zenstruck\JWT\Signer\OpenSSL\Key;
7
use Zenstruck\JWT\Signer\OpenSSL\Keychain;
8
use Zenstruck\JWT\Signer\OpenSSL\PrivateKey;
9
use Zenstruck\JWT\Signer\OpenSSL\PublicKey;
10
11
/**
12
 * @author Alessandro Nadalin <[email protected]>
13
 * @author Kevin Bond <[email protected]>
14
 */
15
abstract class OpenSSL implements Signer
16
{
17 18
    public function __construct()
18
    {
19 18
        if (!extension_loaded('openssl')) {
20
            throw new \RuntimeException('The openssl PHP extension must be enabled to use RSA/ECDSA signers');
21
        }
22 18
    }
23
24
    /**
25
     * {@inheritdoc}
26
     */
27 12 View Code Duplication
    public function sign($input, $key)
0 ignored issues
show
Duplication introduced by
This method seems to be duplicated in your project.

Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation.

You can also find more detailed suggestions in the “Code” section of your repository.

Loading history...
28
    {
29 12
        if ($key instanceof Keychain) {
30 6
            $key = $key->privateKey();
31 6
        }
32
33 12
        if (!$key instanceof PrivateKey) {
34 6
            $key = new PrivateKey($key);
35 6
        }
36
37 12
        $this->verifyType($key);
38
39 12
        openssl_sign($input, $signature, $key->get(), $this->hashingAlgorithm());
40
41 12
        return $signature;
42
    }
43
44
    /**
45
     * {@inheritdoc}
46
     */
47 12 View Code Duplication
    public function verify($input, $signature, $key)
0 ignored issues
show
Duplication introduced by
This method seems to be duplicated in your project.

Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation.

You can also find more detailed suggestions in the “Code” section of your repository.

Loading history...
48
    {
49 12
        if ($key instanceof Keychain) {
50 3
            $key = $key->publicKey();
51 3
        }
52
53 12
        if (!$key instanceof PublicKey) {
54 9
            $key = new PublicKey($key);
55 9
        }
56
57 12
        $this->verifyType($key);
58
59 12
        return (bool) openssl_verify($input, $signature, $key->get(), $this->hashingAlgorithm());
60
    }
61
62
    /**
63
     * @return int
64
     */
65
    abstract protected function hashingAlgorithm();
66
67
    /**
68
     * @return int
69
     */
70
    abstract protected function allowedType();
71
72
    /**
73
     * @param Key $key
74
     */
75 12
    private function verifyType(Key $key)
76
    {
77 12
        if ($this->allowedType() !== $key->type()) {
78
            throw new \InvalidArgumentException(sprintf('Invalid key type.'));
79
        }
80 12
    }
81
}
82