Zenstruck\BackupBundle\DependencyInjection\Configuration

Complexity

Total Complexity

9

Size/Duplication

Total Lines	147
Duplicated Lines	0 %

Coupling/Cohesion

Components	1
Dependencies	4

Test Coverage

Coverage

98.53%

Importance

Changes

0

7 Methods

Rating	Name	Duplication	Size	Complexity
A	__construct()	0	7	1
B	getConfigTreeBuilder()	0	55	2
A	getSourceFactory()	0	4	1
A	getNamerFactory()	0	4	1
A	getDestinationFactory()	0	4	1
A	getProcessorFactory()	0	4	1
A	addFactories()	0	23	2

<?php

namespace Zenstruck\BackupBundle\DependencyInjection;

use Symfony\Component\Config\Definition\Builder\ArrayNodeDefinition;
use Symfony\Component\Config\Definition\Builder\TreeBuilder;
use Symfony\Component\Config\Definition\ConfigurationInterface;
use Zenstruck\BackupBundle\DependencyInjection\Factory\Factory;

/**
 * @author Kevin Bond <kbond@inboxmarketer.com>
 */
class Configuration implements ConfigurationInterface
{
    private $namerFactories;
    private $processorFactories;
    private $sourceFactories;
    private $destinationFactories;

    /**
     * @param Factory[] $namerFactories
     * @param Factory[] $processorFactories
     * @param Factory[] $sourceFactories
     * @param Factory[] $destinationFactories
     */
    public function __construct(array $namerFactories, array $processorFactories, array $sourceFactories, array $destinationFactories)
    {
        $this->namerFactories = $namerFactories;
        $this->processorFactories = $processorFactories;
        $this->sourceFactories = $sourceFactories;
        $this->destinationFactories = $destinationFactories;
    }

    public function getConfigTreeBuilder()
    {
        $treeBuilder = new TreeBuilder('zenstruck_backup');

        // Keep compatibility with symfony/config < 4.2
        if (\method_exists($treeBuilder, 'getRootNode')) {
            $rootNode = $treeBuilder->getRootNode();
        } else {
            $rootNode = $treeBuilder->root('zenstruck_backup');

The method Symfony\Component\Config\Definition\Builder\TreeBuilder::root() has been deprecated with message: since Symfony 4.3, pass the root name to the constructor instead

        }

        $this->addFactories($rootNode, 'namers', 'namer', $this->namerFactories);

$rootNode of type object<Symfony\Component\Config\Definition\Builder\NodeDefinition> is not a sub-type of object<Symfony\Component\Config\Definition\Builder\ArrayNodeDefinition>. It seems like you assume a child class of the class Symfony\Component\Config\Definition\Builder\NodeDefinition to be always present.

        $this->addFactories($rootNode, 'processors', 'processor', $this->processorFactories);

$rootNode of type object<Symfony\Component\Config\Definition\Builder\NodeDefinition> is not a sub-type of object<Symfony\Component\Config\Definition\Builder\ArrayNodeDefinition>. It seems like you assume a child class of the class Symfony\Component\Config\Definition\Builder\NodeDefinition to be always present.

        $this->addFactories($rootNode, 'sources', 'source', $this->sourceFactories);

$rootNode of type object<Symfony\Component\Config\Definition\Builder\NodeDefinition> is not a sub-type of object<Symfony\Component\Config\Definition\Builder\ArrayNodeDefinition>. It seems like you assume a child class of the class Symfony\Component\Config\Definition\Builder\NodeDefinition to be always present.

        $this->addFactories($rootNode, 'destinations', 'destination', $this->destinationFactories);

$rootNode of type object<Symfony\Component\Config\Definition\Builder\NodeDefinition> is not a sub-type of object<Symfony\Component\Config\Definition\Builder\ArrayNodeDefinition>. It seems like you assume a child class of the class Symfony\Component\Config\Definition\Builder\NodeDefinition to be always present.

        $rootNode
            ->children()
                ->arrayNode('profiles')
                    ->useAttributeAsKey('name')
                    ->prototype('array')
                        ->children()
                            ->scalarNode('scratch_dir')->defaultValue('%kernel.cache_dir%/backup')->end()
                            ->arrayNode('sources')
                                ->isRequired()
                                ->requiresAtLeastOneElement()
                                ->prototype('scalar')->end()
                                ->beforeNormalization()
                                    ->ifString()
                                    ->then(function ($v) {
                                        return array($v);
                                    })
                                ->end()
                            ->end()
                            ->scalarNode('namer')->isRequired()->end()
                            ->scalarNode('processor')->isRequired()->end()
                            ->arrayNode('destinations')
                                ->isRequired()
                                ->requiresAtLeastOneElement()
                                ->prototype('scalar')->end()
                                ->beforeNormalization()
                                    ->ifString()
                                    ->then(function ($v) {
                                        return array($v);
                                    })
                                ->end()
                            ->end()
                        ->end()
                    ->end()
                ->end()
            ->end()
        ;

        return $treeBuilder;
    }

    /**
     * @param string $id
     *
     * @return Factory
     */
    public function getSourceFactory($id)
    {
        return $this->sourceFactories[$id];
    }

    /**
     * @param string $id
     *
     * @return Factory
     */
    public function getNamerFactory($id)
    {
        return $this->namerFactories[$id];
    }

    /**
     * @param string $id
     *
     * @return Factory
     */
    public function getDestinationFactory($id)
    {
        return $this->destinationFactories[$id];
    }

    /**
     * @param string $id
     *
     * @return Factory
     */
    public function getProcessorFactory($id)
    {
        return $this->processorFactories[$id];
    }

    /**
     * @param ArrayNodeDefinition $node
     * @param string              $plural
     * @param string              $singular
     * @param Factory[]           $factories
     */
    private function addFactories(ArrayNodeDefinition $node, $plural, $singular, array $factories)
    {
        $nodeBuilder = $node

It seems like you code against a specific sub-type and not the parent class Symfony\Component\Config\Definition\Builder\NodeDefinition as the method canBeUnset() does only exist in the following sub-classes of Symfony\Component\Config\Definition\Builder\NodeDefinition: Symfony\Component\Config\Definition\Builder\ArrayNodeDefinition. Maybe you want to instanceof check for one of these explicitly?

            ->children()
                ->arrayNode($plural)
                    ->useAttributeAsKey('name')
                    ->prototype('array')
                        ->canBeUnset()
                        ->validate()
                            ->ifTrue(function ($v) {
                                return count($v) > 1;
                            })
                            ->thenInvalid(sprintf('Can only have 1 %s per configuration.', $singular))
                        ->end()
                        ->children()
        ;

        foreach ($factories as $name => $factory) {
            $factoryNode = $nodeBuilder->arrayNode($name);

            $factory->addConfiguration($factoryNode);
        }
    }
}