PaymentPeriods::add() - Code Metrics - Inspection of "Merge pull request #7 from kaurikk/refactoring" - kaurikk/loan-payment-period - Measure and Improve Code Quality continuously with Scrutinizer

Passed

Push — master ( 54de7b...3e9604 )

by Kauri

created 2017-04-28 12:18 UTC

PaymentPeriods::add() A

↳ Parent: PaymentPeriods

Complexity

Conditions	2
Paths	2

Size

Total Lines	9
Code Lines	5

Duplication

Lines	0
Ratio	0 %

Code Coverage

Tests	6
CRAP Score	2

Importance

Changes

Metric	Value
dl	0
loc	9
ccs	6
cts	6
cp	1
rs	9.6666
c	0
b	0
f	0
cc	2
eloc	5
nc	2
nop	2
crap	2

<?php

declare(strict_types = 1);

namespace Kauri\Loan;

/**
 * Class PaymentPeriods
 * @package Kauri\Loan
 */
class PaymentPeriods implements PaymentPeriodsInterface
{
    /**
     * @var array
     */
    private $periods = array();
    /**
     * @var int
     */
    private $averagePeriodLenght;

    /**
     * PaymentPeriods constructor.
     * @param int $averagePeriodLength
     */
    public function __construct(int $averagePeriodLength)
    {
        $this->averagePeriodLenght = $averagePeriodLength;
    }

    /**
     * @param PeriodInterface $period
     * @param int|null $sequenceNo
     */
    public function add(PeriodInterface $period, int $sequenceNo = null): void
    {
        if (is_null($sequenceNo)) {
            $sequenceNo = $this->getNoOfPeriods() + 1;
        }

        $period->setSequenceNo($sequenceNo);
        $this->periods[$sequenceNo] = $period;
    }

    public function getAvgPeriodLength(): float
    {
        return $this->averagePeriodLenght;
    }

    /**
     * @return array
     */
    public function getPeriods(): array
    {
        return $this->periods;
    }

    /**
     * @return int
     */
    public function getNoOfPeriods(): int
    {
        return count($this->periods);
    }
}


1		<?php
2
3		declare(strict_types = 1);
4
5		namespace Kauri\Loan;
6
7		/**
8		* Class PaymentPeriods
9		* @package Kauri\Loan
10		*/
11		class PaymentPeriods implements PaymentPeriodsInterface
12		{
13		/**
14		* @var array
15		*/
16		private $periods = array();
17		/**
18		* @var int
19		*/
20		private $averagePeriodLenght;
21
22		/**
23		* PaymentPeriods constructor.
24		* @param int $averagePeriodLength
25		*/
26	5	public function __construct(int $averagePeriodLength)
27		{
28	5	$this->averagePeriodLenght = $averagePeriodLength;
29	5	}
30
31		/**
32		* @param PeriodInterface $period
33		* @param int\|null $sequenceNo
34		*/
35	5	public function add(PeriodInterface $period, int $sequenceNo = null): void
36		{
37	5	if (is_null($sequenceNo)) {
38	2	$sequenceNo = $this->getNoOfPeriods() + 1;
39		}
40
41	5	$period->setSequenceNo($sequenceNo);
42	5	$this->periods[$sequenceNo] = $period;
43	5	}
44
45	3	public function getAvgPeriodLength(): float
46		{
47	3	return $this->averagePeriodLenght;
48		}
49
50		/**
51		* @return array
52		*/
53	5	public function getPeriods(): array
54		{
55	5	return $this->periods;
56		}
57
58		/**
59		* @return int
60		*/
61	2	public function getNoOfPeriods(): int
62		{
63	2	return count($this->periods);
64		}
65		}
66

kaurikk / loan-payment-period

Push — master ( 54de7b...3e9604 )

PaymentPeriods::add() A

Complexity

Size

Duplication

Code Coverage

Importance

Duplication Side-by-Side

Filter issues like