PaymentsCalculatorTest::dataLoader() - Code Metrics - Inspection of "Update PaymentsCalculator.php" - kaurikk/loan-payment-calculator - Measure and Improve Code Quality continuously with Scrutinizer

Passed

Branch — kaurikk-patch-1 (5656e8)

by Kauri

created 2018-10-22 17:53 UTC

PaymentsCalculatorTest::dataLoader() A

↳ Parent: PaymentsCalculatorTest

Complexity

Conditions	1
Paths	1

Size

Total Lines	78
Code Lines	44

Duplication

Lines	0
Ratio	0 %

Importance

Changes

Metric	Value
cc	1
eloc	44
nc	1
nop	0
dl	0
loc	78
rs	9.216
c	0
b	0
f	0

How to fix Long Method

<?php

namespace Kauri\Loan\Test;

use Kauri\Loan\InterestAmountCalculator;
use Kauri\Loan\PaymentAmountCalculator\AnnuityPaymentAmountCalculator;
use Kauri\Loan\PaymentAmountCalculator\EqualPrincipalPaymentAmountCalculator;
use Kauri\Loan\PaymentAmountCalculatorInterface;
use Kauri\Loan\PaymentPeriodsFactory;
use Kauri\Loan\PaymentsCalculator;
use Kauri\Loan\PaymentScheduleConfig;
use Kauri\Loan\PaymentScheduleFactory;
use Kauri\Loan\PeriodInterface;
use PHPUnit\Framework\TestCase;

class PaymentsCalculatorTest extends TestCase
{
    /**
     * @dataProvider dataLoader
     * @param $principal
     * @param $futureValue
     * @param $noOfPayments
     * @param $interestRate
     * @param $pattern
     * @param PaymentAmountCalculatorInterface $paymentAmountCalculator
     * @param $calculationMode
     * @param array $expectedPaymentAmounts
     */
    public function testCalculatePayments(
        $principal,
        $futureValue,
        $noOfPayments,
        $interestRate,
        $pattern,
        PaymentAmountCalculatorInterface $paymentAmountCalculator,
        $calculationMode,
        array $expectedPaymentAmounts
    ) {
        $interestAmountCalculator = new InterestAmountCalculator;

        $config = new PaymentScheduleConfig($noOfPayments, new \DateTime("2016-01-01"), $pattern);
        $schedule = PaymentScheduleFactory::generate($config);
        $periods = PaymentPeriodsFactory::generate($schedule);
        $paymentsCalculator = new PaymentsCalculator($paymentAmountCalculator, $interestAmountCalculator);

        $payments = $paymentsCalculator->calculatePayments($periods, $principal, $interestRate, $calculationMode,
            $futureValue);

        foreach ($payments as $k => $pmt) {
            $this->assertEquals($expectedPaymentAmounts[$k], $pmt['payment']);
        }
    }

    /**
     * @return array
     */
    public function dataLoader(): array
    {
        $interestAmountCalculator = new InterestAmountCalculator;

        $annuityPaymentAmountCalculator = new AnnuityPaymentAmountCalculator($interestAmountCalculator);
        $equalPaymentAmountCalculator = new EqualPrincipalPaymentAmountCalculator($interestAmountCalculator);

        $averageCalculationMode = PeriodInterface::LENGTH_MODE_AVG;
        $exactCalculationMode = PeriodInterface::LENGTH_MODE_EXACT;

        return [
            /* Annuity payments */
            // average interest
            [
                6000,
                0,
                5,
                360,
                'P1M',
                $annuityPaymentAmountCalculator,
                $averageCalculationMode,
                [1 => 2463.49, 2463.49, 2463.49, 2463.49, 2463.47]
            ],
            // exact interest
            [
                6000,
                0,
                5,
                360,
                'P1M',
                $annuityPaymentAmountCalculator,
                $exactCalculationMode,
                [1 => 2480.94, 2480.94, 2480.94, 2480.94, 2470.53]
            ],
            // exact interest with future value
            [
                6000,
                2000,
                5,
                360,
                'P1M',
                $annuityPaymentAmountCalculator,
                $exactCalculationMode,
                [1 => 2261.58, 2261.58, 2261.58, 2261.58, 2252.13]
            ],
            /* Equal principal payments */
            // average interest
            [
                6000,
                0,
                5,
                360,
                'P1M',
                $equalPaymentAmountCalculator,
                $averageCalculationMode,
                [1 => 3000, 2640, 2280, 1920, 1560]
            ],
            // average interest with future value
            [
                6000,
                2000,
                5,
                360,
                'P1M',
                $equalPaymentAmountCalculator,
                $averageCalculationMode,
                [1 => 2600, 2360, 2120, 1880, 1640]
            ],
            // exact payment
            [
                6000,
                0,
                5,
                360,
                'P1M',
                $equalPaymentAmountCalculator,
                $exactCalculationMode,
                [1 => 3060, 2592, 2316, 1920, 1572]
            ]
        ];
    }
}


1			<?php
2
3			namespace Kauri\Loan\Test;
4
5			use Kauri\Loan\InterestAmountCalculator;
6			use Kauri\Loan\PaymentAmountCalculator\AnnuityPaymentAmountCalculator;
7			use Kauri\Loan\PaymentAmountCalculator\EqualPrincipalPaymentAmountCalculator;
8			use Kauri\Loan\PaymentAmountCalculatorInterface;
9			use Kauri\Loan\PaymentPeriodsFactory;
10			use Kauri\Loan\PaymentsCalculator;
11			use Kauri\Loan\PaymentScheduleConfig;
12			use Kauri\Loan\PaymentScheduleFactory;
13			use Kauri\Loan\PeriodInterface;
14			use PHPUnit\Framework\TestCase;
15
16			class PaymentsCalculatorTest extends TestCase
17			{
18			/**
19			* @dataProvider dataLoader
20			* @param $principal
21			* @param $futureValue
22			* @param $noOfPayments
23			* @param $interestRate
24			* @param $pattern
25			* @param PaymentAmountCalculatorInterface $paymentAmountCalculator
26			* @param $calculationMode
27			* @param array $expectedPaymentAmounts
28			*/
29			public function testCalculatePayments(
30			$principal,
31			$futureValue,
32			$noOfPayments,
33			$interestRate,
34			$pattern,
35			PaymentAmountCalculatorInterface $paymentAmountCalculator,
36			$calculationMode,
37			array $expectedPaymentAmounts
38			) {
39			$interestAmountCalculator = new InterestAmountCalculator;
40
41			$config = new PaymentScheduleConfig($noOfPayments, new \DateTime("2016-01-01"), $pattern);
42			$schedule = PaymentScheduleFactory::generate($config);
43			$periods = PaymentPeriodsFactory::generate($schedule);
44			$paymentsCalculator = new PaymentsCalculator($paymentAmountCalculator, $interestAmountCalculator);
45
46			$payments = $paymentsCalculator->calculatePayments($periods, $principal, $interestRate, $calculationMode,
47			$futureValue);
48
49			foreach ($payments as $k => $pmt) {
50			$this->assertEquals($expectedPaymentAmounts[$k], $pmt['payment']);
51			}
52			}
53
54			/**
55			* @return array
56			*/
57			public function dataLoader(): array
58			{
59			$interestAmountCalculator = new InterestAmountCalculator;
60
61			$annuityPaymentAmountCalculator = new AnnuityPaymentAmountCalculator($interestAmountCalculator);
62			$equalPaymentAmountCalculator = new EqualPrincipalPaymentAmountCalculator($interestAmountCalculator);
63
64			$averageCalculationMode = PeriodInterface::LENGTH_MODE_AVG;
65			$exactCalculationMode = PeriodInterface::LENGTH_MODE_EXACT;
66
67			return [
68			/* Annuity payments */
69			// average interest
70			[
71			6000,
72			0,
73			5,
74			360,
75			'P1M',
76			$annuityPaymentAmountCalculator,
77			$averageCalculationMode,
78			[1 => 2463.49, 2463.49, 2463.49, 2463.49, 2463.47]
79			],
80			// exact interest
81			[
82			6000,
83			0,
84			5,
85			360,
86			'P1M',
87			$annuityPaymentAmountCalculator,
88			$exactCalculationMode,
89			[1 => 2480.94, 2480.94, 2480.94, 2480.94, 2470.53]
90			],
91			// exact interest with future value
92			[
93			6000,
94			2000,
95			5,
96			360,
97			'P1M',
98			$annuityPaymentAmountCalculator,
99			$exactCalculationMode,
100			[1 => 2261.58, 2261.58, 2261.58, 2261.58, 2252.13]
101			],
102			/* Equal principal payments */
103			// average interest
104			[
105			6000,
106			0,
107			5,
108			360,
109			'P1M',
110			$equalPaymentAmountCalculator,
111			$averageCalculationMode,
112			[1 => 3000, 2640, 2280, 1920, 1560]
113			],
114			// average interest with future value
115			[
116			6000,
117			2000,
118			5,
119			360,
120			'P1M',
121			$equalPaymentAmountCalculator,
122			$averageCalculationMode,
123			[1 => 2600, 2360, 2120, 1880, 1640]
124			],
125			// exact payment
126			[
127			6000,
128			0,
129			5,
130			360,
131			'P1M',
132			$equalPaymentAmountCalculator,
133			$exactCalculationMode,
134			[1 => 3060, 2592, 2316, 1920, 1572]
135			]
136			];
137			}
138			}
139

kaurikk / loan-payment-calculator

Branch — kaurikk-patch-1 (5656e8)

PaymentsCalculatorTest::dataLoader() A

Complexity

Size

Duplication

Importance

How to fix Long Method

Long Method

Duplication Side-by-Side

Filter issues like