ActionMapper::getAction() - Code Metrics - Inspection of "pass in the request to action getters of Supports*..." - kartenmacherei/rest-framework - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — master ( 31a9ba...a5eb40 )

by Sebastian

created 2017-01-18 15:53 UTC

ActionMapper::getAction() C

↳ Parent: ActionMapper

Complexity

Conditions	7
Paths	7

Size

Total Lines	26
Code Lines	15

Duplication

Lines	0
Ratio	0 %

Importance

Changes

Metric	Value
dl	0
loc	26
rs	6.7272
c	0
b	0
f	0
cc	7
eloc	15
nc	7
nop	2

<?php
namespace Kartenmacherei\RestFramework;

use Kartenmacherei\RestFramework\Action\Action;
use Kartenmacherei\RestFramework\Request\DeleteRequest;
use Kartenmacherei\RestFramework\Request\GetRequest;
use Kartenmacherei\RestFramework\Request\Method\DeleteRequestMethod;
use Kartenmacherei\RestFramework\Request\Method\GetRequestMethod;
use Kartenmacherei\RestFramework\Request\Method\PatchRequestMethod;
use Kartenmacherei\RestFramework\Request\Method\PostRequestMethod;
use Kartenmacherei\RestFramework\Request\Method\PutRequestMethod;
use Kartenmacherei\RestFramework\Request\Method\UnsupportedRequestMethodException;
use Kartenmacherei\RestFramework\Request\PatchRequest;
use Kartenmacherei\RestFramework\Request\PostRequest;
use Kartenmacherei\RestFramework\Request\PutRequest;
use Kartenmacherei\RestFramework\Request\Request;
use Kartenmacherei\RestFramework\RestResource\RestResource;
use Kartenmacherei\RestFramework\RestResource\SupportsDeleteRequests;
use Kartenmacherei\RestFramework\RestResource\SupportsGetRequests;
use Kartenmacherei\RestFramework\RestResource\SupportsPatchRequests;
use Kartenmacherei\RestFramework\RestResource\SupportsPostRequests;
use Kartenmacherei\RestFramework\RestResource\SupportsPutRequests;

class ActionMapper
{
    /**
     * @param Request $request
     * @param RestResource $resource
     * @return Action
     * @throws UnsupportedRequestMethodException
     */
    public function getAction(Request $request, RestResource $resource): Action
    {
        if (!$resource->supports($request->getMethod())) {
            throw new UnsupportedRequestMethodException();
        }

        /** @var RestResource|SupportsDeleteRequests|SupportsGetRequests|SupportsPatchRequests|SupportsPostRequests|SupportsPutRequests $resource */
        switch ($request->getMethod()) {
            case new DeleteRequestMethod():
                /** @var DeleteRequest $request */
                return $resource->getDeleteCommand($request);
class A
{
    public function foo() { }
}

class B extends A
{
    public function bar() { }
}

/**
 * @param A|B $x
 */
function someFunction($x)
{
    $x->foo(); // This call is fine as the method exists in A and B.
    $x->bar(); // This method only exists in B and might cause an error.
}
            case new GetRequestMethod():
                /** @var GetRequest $request */
                return $resource->getQuery($request);
class A
{
    public function foo() { }
}

class B extends A
{
    public function bar() { }
}

/**
 * @param A|B $x
 */
function someFunction($x)
{
    $x->foo(); // This call is fine as the method exists in A and B.
    $x->bar(); // This method only exists in B and might cause an error.
}
            case new PatchRequestMethod():
                /** @var PatchRequest $request */
                return $resource->getPatchCommand($request);
class A
{
    public function foo() { }
}

class B extends A
{
    public function bar() { }
}

/**
 * @param A|B $x
 */
function someFunction($x)
{
    $x->foo(); // This call is fine as the method exists in A and B.
    $x->bar(); // This method only exists in B and might cause an error.
}
            case new PostRequestMethod():
                /** @var PostRequest $request */
                return $resource->getPostCommand($request);
class A
{
    public function foo() { }
}

class B extends A
{
    public function bar() { }
}

/**
 * @param A|B $x
 */
function someFunction($x)
{
    $x->foo(); // This call is fine as the method exists in A and B.
    $x->bar(); // This method only exists in B and might cause an error.
}
            case new PutRequestMethod():
                /** @var PutRequest $request */
                return $resource->getPutCommand($request);
class A
{
    public function foo() { }
}

class B extends A
{
    public function bar() { }
}

/**
 * @param A|B $x
 */
function someFunction($x)
{
    $x->foo(); // This call is fine as the method exists in A and B.
    $x->bar(); // This method only exists in B and might cause an error.
}
        }
        throw new UnsupportedRequestMethodException();
    }
}


Push — master ( 31a9ba...a5eb40 )

ActionMapper::getAction() C

Complexity

Size

Duplication

Importance

Available Fixes

Available Fixes

Available Fixes

Available Fixes

Available Fixes

1			<?php
2			namespace Kartenmacherei\RestFramework;
3
4			use Kartenmacherei\RestFramework\Action\Action;
5			use Kartenmacherei\RestFramework\Request\DeleteRequest;
6			use Kartenmacherei\RestFramework\Request\GetRequest;
7			use Kartenmacherei\RestFramework\Request\Method\DeleteRequestMethod;
8			use Kartenmacherei\RestFramework\Request\Method\GetRequestMethod;
9			use Kartenmacherei\RestFramework\Request\Method\PatchRequestMethod;
10			use Kartenmacherei\RestFramework\Request\Method\PostRequestMethod;
11			use Kartenmacherei\RestFramework\Request\Method\PutRequestMethod;
12			use Kartenmacherei\RestFramework\Request\Method\UnsupportedRequestMethodException;
13			use Kartenmacherei\RestFramework\Request\PatchRequest;
14			use Kartenmacherei\RestFramework\Request\PostRequest;
15			use Kartenmacherei\RestFramework\Request\PutRequest;
16			use Kartenmacherei\RestFramework\Request\Request;
17			use Kartenmacherei\RestFramework\RestResource\RestResource;
18			use Kartenmacherei\RestFramework\RestResource\SupportsDeleteRequests;
19			use Kartenmacherei\RestFramework\RestResource\SupportsGetRequests;
20			use Kartenmacherei\RestFramework\RestResource\SupportsPatchRequests;
21			use Kartenmacherei\RestFramework\RestResource\SupportsPostRequests;
22			use Kartenmacherei\RestFramework\RestResource\SupportsPutRequests;
23
24			class ActionMapper
25			{
26			/**
27			* @param Request $request
28			* @param RestResource $resource
29			* @return Action
30			* @throws UnsupportedRequestMethodException
31			*/
32			public function getAction(Request $request, RestResource $resource): Action
33			{
34			if (!$resource->supports($request->getMethod())) {
35			throw new UnsupportedRequestMethodException();
36			}
37
38			/** @var RestResource\|SupportsDeleteRequests\|SupportsGetRequests\|SupportsPatchRequests\|SupportsPostRequests\|SupportsPutRequests $resource */
39			switch ($request->getMethod()) {
40			case new DeleteRequestMethod():
41			/** @var DeleteRequest $request */
42			return $resource->getDeleteCommand($request);
			0 ignored issues – show Bug introduced 2016-12-13 10:15 UTC by Report Bug Copy Issue Report The method `getDeleteCommand` does only exist in `Kartenmacherei\RestFrame...\SupportsDeleteRequests`, but not in `Kartenmacherei\RestFrame...rce\SupportsPutRequests`. It seems like the method you are trying to call exists only in some of the possible types. Let’s take a look at an example: class A { public function foo() { } } class B extends A { public function bar() { } } /** * @param A\|B $x / function someFunction($x) { $x->foo(); // This call is fine as the method exists in A and B. $x->bar(); // This method only exists in B and might cause an error. } Available Fixes Add an additional type-check: /* * @param A\|B $x / function someFunction($x) { $x->foo(); if ($x instanceof B) { $x->bar(); } } Only allow a single type to be passed if the variable comes from a parameter: function someFunction(B $x) { /* ... */ } Loading history...
43			case new GetRequestMethod():
44			/** @var GetRequest $request */
45			return $resource->getQuery($request);
			0 ignored issues – show Bug introduced 2016-12-13 10:15 UTC by Report Bug Copy Issue Report The method `getQuery` does only exist in `Kartenmacherei\RestFrame...rce\SupportsGetRequests`, but not in `Kartenmacherei\RestFrame...rce\SupportsPutRequests`. It seems like the method you are trying to call exists only in some of the possible types. Let’s take a look at an example: class A { public function foo() { } } class B extends A { public function bar() { } } /** * @param A\|B $x / function someFunction($x) { $x->foo(); // This call is fine as the method exists in A and B. $x->bar(); // This method only exists in B and might cause an error. } Available Fixes Add an additional type-check: /* * @param A\|B $x / function someFunction($x) { $x->foo(); if ($x instanceof B) { $x->bar(); } } Only allow a single type to be passed if the variable comes from a parameter: function someFunction(B $x) { /* ... */ } Loading history...
46			case new PatchRequestMethod():
47			/** @var PatchRequest $request */
48			return $resource->getPatchCommand($request);
			0 ignored issues – show Bug introduced 2016-12-13 10:15 UTC by Report Bug Copy Issue Report The method `getPatchCommand` does only exist in `Kartenmacherei\RestFrame...e\SupportsPatchRequests`, but not in `Kartenmacherei\RestFrame...rce\SupportsPutRequests`. It seems like the method you are trying to call exists only in some of the possible types. Let’s take a look at an example: class A { public function foo() { } } class B extends A { public function bar() { } } /** * @param A\|B $x / function someFunction($x) { $x->foo(); // This call is fine as the method exists in A and B. $x->bar(); // This method only exists in B and might cause an error. } Available Fixes Add an additional type-check: /* * @param A\|B $x / function someFunction($x) { $x->foo(); if ($x instanceof B) { $x->bar(); } } Only allow a single type to be passed if the variable comes from a parameter: function someFunction(B $x) { /* ... */ } Loading history...
49			case new PostRequestMethod():
50			/** @var PostRequest $request */
51			return $resource->getPostCommand($request);
			0 ignored issues – show Bug introduced 2016-12-13 10:15 UTC by Report Bug Copy Issue Report The method `getPostCommand` does only exist in `Kartenmacherei\RestFrame...ce\SupportsPostRequests`, but not in `Kartenmacherei\RestFrame...rce\SupportsPutRequests`. It seems like the method you are trying to call exists only in some of the possible types. Let’s take a look at an example: class A { public function foo() { } } class B extends A { public function bar() { } } /** * @param A\|B $x / function someFunction($x) { $x->foo(); // This call is fine as the method exists in A and B. $x->bar(); // This method only exists in B and might cause an error. } Available Fixes Add an additional type-check: /* * @param A\|B $x / function someFunction($x) { $x->foo(); if ($x instanceof B) { $x->bar(); } } Only allow a single type to be passed if the variable comes from a parameter: function someFunction(B $x) { /* ... */ } Loading history...
52			case new PutRequestMethod():
53			/** @var PutRequest $request */
54			return $resource->getPutCommand($request);
			0 ignored issues – show Bug introduced 2016-12-13 10:15 UTC by Report Bug Copy Issue Report The method `getPutCommand` does only exist in `Kartenmacherei\RestFrame...rce\SupportsPutRequests`, but not in `Kartenmacherei\RestFrame...ce\SupportsPostRequests`. It seems like the method you are trying to call exists only in some of the possible types. Let’s take a look at an example: class A { public function foo() { } } class B extends A { public function bar() { } } /** * @param A\|B $x / function someFunction($x) { $x->foo(); // This call is fine as the method exists in A and B. $x->bar(); // This method only exists in B and might cause an error. } Available Fixes Add an additional type-check: /* * @param A\|B $x / function someFunction($x) { $x->foo(); if ($x instanceof B) { $x->bar(); } } Only allow a single type to be passed if the variable comes from a parameter: function someFunction(B $x) { /* ... */ } Loading history...
55			}
56			throw new UnsupportedRequestMethodException();
57			}
58			}
59

kartenmacherei / rest-framework

Push — master ( 31a9ba...a5eb40 )

ActionMapper::getAction() C

Complexity

Size

Duplication

Importance

Available Fixes

Available Fixes

Available Fixes

Available Fixes

Available Fixes

Duplication Side-by-Side

Filter issues like