ActionMapper::getAction() - Code Metrics - Inspection of "add missing unit tests" - kartenmacherei/rest-framework - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — master ( ae2b3a...9c69f7 )

by Sebastian

created 2016-11-01 10:57 UTC

ActionMapper::getAction() C

↳ Parent: ActionMapper

Complexity

Conditions	11
Paths	11

Size

Total Lines	31
Code Lines	23

Duplication

Lines	0
Ratio	0 %

Importance

Changes

Metric	Value
dl	0
loc	31
c	0
b	0
f	0
rs	5.2653
cc	11
eloc	23
nc	11
nop	2

How to fix Complexity

<?php
namespace Kartenmacherei\RestFramework;

use Kartenmacherei\RestFramework\Action\Action;
use Kartenmacherei\RestFramework\Request\Method\DeleteRequestMethod;
use Kartenmacherei\RestFramework\Request\Method\GetRequestMethod;
use Kartenmacherei\RestFramework\Request\Method\PatchRequestMethod;
use Kartenmacherei\RestFramework\Request\Method\PostRequestMethod;
use Kartenmacherei\RestFramework\Request\Method\PutRequestMethod;
use Kartenmacherei\RestFramework\Request\Method\RequestMethod;
use Kartenmacherei\RestFramework\Request\Method\UnsupportedRequestMethodException;
use Kartenmacherei\RestFramework\RestResource\RestResource;
use Kartenmacherei\RestFramework\RestResource\SupportsDeleteRequests;
use Kartenmacherei\RestFramework\RestResource\SupportsGetRequests;
use Kartenmacherei\RestFramework\RestResource\SupportsPatchRequests;
use Kartenmacherei\RestFramework\RestResource\SupportsPostRequests;
use Kartenmacherei\RestFramework\RestResource\SupportsPutRequests;

class ActionMapper
{
    /**
     * @param RequestMethod $requestMethod
     * @param RestResource $resource
     * @return Action
     * @throws UnsupportedRequestMethodException
     */
    public function getAction(RequestMethod $requestMethod, RestResource $resource): Action
    {
        switch ($requestMethod) {
            case new DeleteRequestMethod():
                if (!$resource instanceof SupportsDeleteRequests) {
                    throw new UnsupportedRequestMethodException();
                }
                return $resource->getDeleteCommand();
            case new GetRequestMethod():
                if (!$resource instanceof SupportsGetRequests) {
                    throw new UnsupportedRequestMethodException();
                }
                return $resource->getQuery();
            case new PatchRequestMethod():
                if (!$resource instanceof SupportsPatchRequests) {
                    throw new UnsupportedRequestMethodException();
                }
                return $resource->getPatchCommand();
            case new PostRequestMethod():
                if (!$resource instanceof SupportsPostRequests) {
                    throw new UnsupportedRequestMethodException();
                }
                return $resource->getPostCommand();
            case new PutRequestMethod():
                if (!$resource instanceof SupportsPutRequests) {
                    throw new UnsupportedRequestMethodException();
                }
                return $resource->getPutCommand();
        }
        throw new UnsupportedRequestMethodException();
    }
}


1			<?php
2			namespace Kartenmacherei\RestFramework;
3
4			use Kartenmacherei\RestFramework\Action\Action;
5			use Kartenmacherei\RestFramework\Request\Method\DeleteRequestMethod;
6			use Kartenmacherei\RestFramework\Request\Method\GetRequestMethod;
7			use Kartenmacherei\RestFramework\Request\Method\PatchRequestMethod;
8			use Kartenmacherei\RestFramework\Request\Method\PostRequestMethod;
9			use Kartenmacherei\RestFramework\Request\Method\PutRequestMethod;
10			use Kartenmacherei\RestFramework\Request\Method\RequestMethod;
11			use Kartenmacherei\RestFramework\Request\Method\UnsupportedRequestMethodException;
12			use Kartenmacherei\RestFramework\RestResource\RestResource;
13			use Kartenmacherei\RestFramework\RestResource\SupportsDeleteRequests;
14			use Kartenmacherei\RestFramework\RestResource\SupportsGetRequests;
15			use Kartenmacherei\RestFramework\RestResource\SupportsPatchRequests;
16			use Kartenmacherei\RestFramework\RestResource\SupportsPostRequests;
17			use Kartenmacherei\RestFramework\RestResource\SupportsPutRequests;
18
19			class ActionMapper
20			{
21			/**
22			* @param RequestMethod $requestMethod
23			* @param RestResource $resource
24			* @return Action
25			* @throws UnsupportedRequestMethodException
26			*/
27			public function getAction(RequestMethod $requestMethod, RestResource $resource): Action
28			{
29			switch ($requestMethod) {
30			case new DeleteRequestMethod():
31			if (!$resource instanceof SupportsDeleteRequests) {
32			throw new UnsupportedRequestMethodException();
33			}
34			return $resource->getDeleteCommand();
35			case new GetRequestMethod():
36			if (!$resource instanceof SupportsGetRequests) {
37			throw new UnsupportedRequestMethodException();
38			}
39			return $resource->getQuery();
40			case new PatchRequestMethod():
41			if (!$resource instanceof SupportsPatchRequests) {
42			throw new UnsupportedRequestMethodException();
43			}
44			return $resource->getPatchCommand();
45			case new PostRequestMethod():
46			if (!$resource instanceof SupportsPostRequests) {
47			throw new UnsupportedRequestMethodException();
48			}
49			return $resource->getPostCommand();
50			case new PutRequestMethod():
51			if (!$resource instanceof SupportsPutRequests) {
52			throw new UnsupportedRequestMethodException();
53			}
54			return $resource->getPutCommand();
55			}
56			throw new UnsupportedRequestMethodException();
57			}
58			}
59

kartenmacherei / rest-framework

Push — master ( ae2b3a...9c69f7 )

ActionMapper::getAction() C

Complexity

Size

Duplication

Importance

How to fix Complexity

Long Method

Duplication Side-by-Side

Filter issues like