kanata-php / socket-conveyor

src/SocketHandlers/SocketMessageRouter.php

<?php

namespace Conveyor\SocketHandlers;

use Exception;
use League\Pipeline\Pipeline;
use Conveyor\Exceptions\InvalidActionException;
use Conveyor\Actions\Interfaces\ActionInterface;
use Conveyor\SocketHandlers\Abstractions\SocketHandler;
use Conveyor\SocketHandlers\Traits\HasPipeline;

class SocketMessageRouter extends SocketHandler
{
    use HasPipeline;

    /**
     * Call this method to get singleton
     *
     * @return SocketMessageRouter
     */
    public static function getInstance(): SocketMessageRouter
    {
        static $instance = null;

        if ($instance === null) {
            $instance = new self;
        }

        return $instance;
    }

    private function __construct()
    {

    }

    /**
     * @internal This method also leave the $parsedData property set to the instance.
     *
     * @param string $data
     * @return ActionInterface
     *
     * @throws InvalidArgumentException|InvalidActionException
     */
    public function parseData(string $data) : ActionInterface
    {
        $this->parsedData = json_decode($data, true);

        // @throws InvalidArgumentException|InvalidActionException
        $this->validateData($this->parsedData);

        return $this->getAction($this->parsedData['action']);

The expression return $this->getAction($this->parsedData['action']) could return the type null which is incompatible with the type-hinted return Conveyor\Actions\Interfaces\ActionInterface. Consider adding an additional type-check to rule them out.

    }
}