Conveyor\SocketHandlers\Abstractions\SocketHandler

Complexity

Total Complexity

7

Size/Duplication

Total Lines	67
Duplicated Lines	0 %

Importance

Changes	1
Bugs	0	Features	0

3 Methods

Rating	Name	Duplication	Size	Complexity
A	__invoke()	0	8	1
A	maybeSetServer()	0	6	3
A	maybeSetFd()	0	6	3

<?php

namespace Conveyor\SocketHandlers\Abstractions;

use Slim\Container;

The type Slim\Container was not found. Maybe you did not declare it correctly or list all dependencies?

use Conveyor\SocketHandlers\Interfaces\SocketHandlerInterface;
use Conveyor\Actions\Interfaces\ActionInterface;

abstract class SocketHandler implements SocketHandlerInterface
{
    /**
     * @param string $data
     * @param int $fd
     */
    public function __invoke(string $data, $fd = null)
    {
        /** @var ActionInterface */
        $action = $this->parseData($data);

        $this->maybeSetFd($fd);
        
        return $action->execute();

The call to Conveyor\Actions\Interfaces\ActionInterface::execute() has too few arguments starting with data.

    }

    /**
     * Set $fd (File descriptor) if method "setFd" exists.
     *
     * @param int|null $fd File descriptor.
     *
     * @return void
     */
    public function maybeSetFd($fd = null): void {
        $parsedData = $this->getParsedData();

The method getParsedData() does not exist on Conveyor\SocketHandlers\Abstractions\SocketHandler. Since it exists in all sub-types, consider adding an abstract or default implementation to Conveyor\SocketHandlers\Abstractions\SocketHandler.

        $action = $this->getAction($parsedData['action']);

The method getAction() does not exist on Conveyor\SocketHandlers\Abstractions\SocketHandler. Since it exists in all sub-types, consider adding an abstract or default implementation to Conveyor\SocketHandlers\Abstractions\SocketHandler.

        if ($fd && method_exists($action, 'setFd')) {

The expression $fd of type integer|null is loosely compared to true; this is ambiguous if the integer can be 0. You might want to explicitly use !== null instead.

            $action->setFd($fd);
        }
    }

    /**
     * Set $server if method "setServer" exists.
     *
     * @param mixed $server Server object, e.g. Swoole\WebSocket\Frame.
     *
     * @return void
     */
    public function maybeSetServer($server = null): void {
        $parsedData = $this->getParsedData();
        $action = $this->getAction($parsedData['action']);

        if ($server && method_exists($action, 'setServer')) {
            $action->setServer($server);
        }
    }

    /**
     * This method identifies the action to be executed
     *
     * @param string $data
     *
     * @return ActionInterface
     *
     * @throws InvalidArgumentException
     */
    abstract public function parseData(string $data) : ActionInterface;

    /**
     * @param array $data
     *
     * @return void
     *
     * @throws InvalidArgumentException
     */
    abstract public function validateData(array $data) : void;
}