CancelResponse::getCardStatus() - Code Metrics - Inspection of "Laravel 6 support" - kamerk22/AmazonGiftCode - Measure and Improve Code Quality continuously with Scrutinizer

Passed

Pull Request — master (#2)

unknown

created 2020-01-28 09:39 UTC

CancelResponse::getCardStatus() A

↳ Parent: Project

Complexity

Conditions	1
Paths	1

Size

Total Lines	3
Code Lines	1

Duplication

Lines	0
Ratio	0 %

Importance

Changes

Metric	Value
cc	1
eloc	1
c	0
b	0
f	0
nc	1
nop	0
dl	0
loc	3
rs	10

<?php

/**
 * Part of the AmazonGiftCode package.
 * Author: Kashyap Merai <[email protected]>
 *
 */


namespace kamerk22\AmazonGiftCode\Response;


class CancelResponse
{

    /**
     * Amazon Gift Card gcId.
     *
     * @var string
     */
    protected $_id;

    /**
     * Amazon Gift Card creationRequestId
     *
     * @var string
     */
    protected $_creation_request_id;

    /**
     * Amazon Gift Card status
     *
     * @var string
     */
    protected $_status;

    /**
     * Amazon Gift Card status
     *
     * @var string
     */
    protected $_card_status;

    /**
     * Amazon Gift Card Raw JSON
     *
     * @var string
     */
    protected $_raw_json;

    /**
     * Response constructor.
     * @param $jsonResponse
     */
    public function __construct($jsonResponse)
    {
        $this->_raw_json = $jsonResponse;
        $this->_status = TRUE;
$answer = 42;

$correct = false;

$correct = (bool) $answer;
        $this->parseJsonResponse($jsonResponse);
    }


    /**
     * @return string
     */
    public function getId(): string
    {
        return $this->_id;
    }

    /**
     * @return string
     */
    public function getCreationRequestId(): string
    {
        return $this->_creation_request_id;
    }


    /**
     * @return string
     */
    public function getStatus(): string
    {
        return $this->_status;
    }

    /**
     * @return string
     */
    public function getCardStatus(): string
    {
        return $this->_card_status;
    }


    /**
     * @return string
     */
    public function getRawJson(): string
    {
        return json_encode($this->_raw_json);
    }


    /**
     * @param $jsonResponse
     * @return CancelResponse
     */
    public function parseJsonResponse($jsonResponse): self
    {
        if (!is_array($jsonResponse)) {
            throw new \RuntimeException('Response must be a scalar value');
        }
        if (array_key_exists('gcId', $jsonResponse)) {
            $this->_id = $jsonResponse['gcId'];
        }
        if (array_key_exists('creationRequestId', $jsonResponse)) {
            $this->_creation_request_id = $jsonResponse['creationRequestId'];
        }
        if (array_key_exists('cardStatus', $jsonResponse['cardInfo'])) {
            $this->_value = $jsonResponse['cardInfo']['cardStatus'];

        }

        return $this;

    }

}

1			<?php
2
3			/**
4			* Part of the AmazonGiftCode package.
5			* Author: Kashyap Merai <[email protected]>
6			*
7			*/
8
9
10			namespace kamerk22\AmazonGiftCode\Response;
11
12
13			class CancelResponse
14			{
15
16			/**
17			* Amazon Gift Card gcId.
18			*
19			* @var string
20			*/
21			protected $_id;
22
23			/**
24			* Amazon Gift Card creationRequestId
25			*
26			* @var string
27			*/
28			protected $_creation_request_id;
29
30			/**
31			* Amazon Gift Card status
32			*
33			* @var string
34			*/
35			protected $_status;
36
37			/**
38			* Amazon Gift Card status
39			*
40			* @var string
41			*/
42			protected $_card_status;
43
44			/**
45			* Amazon Gift Card Raw JSON
46			*
47			* @var string
48			*/
49			protected $_raw_json;
50
51			/**
52			* Response constructor.
53			* @param $jsonResponse
54			*/
55			public function __construct($jsonResponse)
56			{
57			$this->_raw_json = $jsonResponse;
58			$this->_status = TRUE;
			0 ignored issues – show Documentation Bug introduced 2018-12-07 17:19 UTC by Report Bug Copy Issue Report The property `$_status` was declared of type `string`, but `TRUE` is of type `true`. Maybe add a type cast? This check looks for assignments to scalar types that may be of the wrong type. To ensure the code behaves as expected, it may be a good idea to add an explicit type cast. $answer = 42; $correct = false; $correct = (bool) $answer; Loading history...
59			$this->parseJsonResponse($jsonResponse);
60			}
61
62
63			/**
64			* @return string
65			*/
66			public function getId(): string
67			{
68			return $this->_id;
69			}
70
71			/**
72			* @return string
73			*/
74			public function getCreationRequestId(): string
75			{
76			return $this->_creation_request_id;
77			}
78
79
80			/**
81			* @return string
82			*/
83			public function getStatus(): string
84			{
85			return $this->_status;
86			}
87
88			/**
89			* @return string
90			*/
91			public function getCardStatus(): string
92			{
93			return $this->_card_status;
94			}
95
96
97			/**
98			* @return string
99			*/
100			public function getRawJson(): string
101			{
102			return json_encode($this->_raw_json);
103			}
104
105
106			/**
107			* @param $jsonResponse
108			* @return CancelResponse
109			*/
110			public function parseJsonResponse($jsonResponse): self
111			{
112			if (!is_array($jsonResponse)) {
113			throw new \RuntimeException('Response must be a scalar value');
114			}
115			if (array_key_exists('gcId', $jsonResponse)) {
116			$this->_id = $jsonResponse['gcId'];
117			}
118			if (array_key_exists('creationRequestId', $jsonResponse)) {
119			$this->_creation_request_id = $jsonResponse['creationRequestId'];
120			}
121			if (array_key_exists('cardStatus', $jsonResponse['cardInfo'])) {
122			$this->_value = $jsonResponse['cardInfo']['cardStatus'];
			0 ignored issues – show Bug Best Practice introduced 2020-01-28 09:42 UTC by Report Bug Copy Issue Report The property `_value` does not exist. Although not strictly required by PHP, it is generally a best practice to declare properties explicitly. Loading history...
123			}
124
125			return $this;
126
127			}
128
129			}

kamerk22 / AmazonGiftCode

Pull Request — master (#2)

CancelResponse::getCardStatus() A

Complexity

Size

Duplication

Importance

Duplication Side-by-Side

Filter issues like