Kaliop\Queueing\Plugins\StompBundle\Adapter\Stomp\QueueManager

Complexity

Total Complexity

15

Size/Duplication

Total Lines	74
Duplicated Lines	0 %

Coupling/Cohesion

Components	1
Dependencies	0

Importance

Changes

0

7 Methods

Rating	Name	Duplication	Size	Complexity
A	setContainer()	0	4	1
A	setQueueName()	0	4	1
A	listActions()	0	4	1
A	executeAction()	0	10	2
B	listConfiguredQueues()	0	19	8
A	registerProducer()	0	3	1
A	registerConsumer()	0	3	1

<?php

namespace Kaliop\Queueing\Plugins\StompBundle\Adapter\Stomp;

use Kaliop\QueueingBundle\Service\MessageProducer as BaseMessageProducer;
use Symfony\Component\DependencyInjection\ContainerAwareInterface;
use Symfony\Component\DependencyInjection\ContainerInterface;
use InvalidArgumentException;
use Kaliop\QueueingBundle\Queue\Queue;
use Kaliop\QueueingBundle\Queue\QueueManagerInterface;

/**
 * Since STOMP does not provide commands for Queue management, all this does is allow listing of configured queues
 */
class QueueManager implements ContainerAwareInterface, QueueManagerInterface
{
    protected $queueName;
    protected $container;
    protected $registeredProducers = array();
    protected $registeredConsumers = array();

    public function setContainer(ContainerInterface $container = null)
    {
        $this->container = $container;
    }

    /**
     * Does nothing
     * @param string $queue
     * @return $this
     */
    public function setQueueName($queue)
    {
        return $this;
    }

    public function listActions()
    {
        return array('list-configured');
    }

    public function executeAction($action, array $arguments=array())
    {
        switch ($action) {
            case 'list-configured':
                return $this->listConfiguredQueues();

            default:
                throw new InvalidArgumentException("Action $action not supported");
        }
    }

    protected function listConfiguredQueues($type = Queue::TYPE_ANY)

The parameter $type is not used and could be removed.

    {
        $out = array();
        if ($type = Queue::TYPE_PRODUCER || $type = Queue::TYPE_ANY) {

$type is not used, you could remove the assignment.

Consider adding parentheses for clarity. Current Interpretation: $type = (\Kaliop\QueueingBundle\Queue\Queue::TYPE_PRODUCER || ($type = \Kaliop\QueueingBundle\Queue\Queue::TYPE_ANY)), Probably Intended Meaning: ($type = \Kaliop\QueueingBundle\Queue\Queue::TYPE_PRODUCER) || $type = \Kaliop\QueueingBundle\Queue\Queue::TYPE_ANY

            foreach ($this->registeredProducers as $queueName) {
                $out[$queueName] = Queue::TYPE_PRODUCER;
            }
        }
        if ($type = Queue::TYPE_CONSUMER || $type = Queue::TYPE_ANY) {

$type is not used, you could remove the assignment.

Consider adding parentheses for clarity. Current Interpretation: $type = (\Kaliop\QueueingBundle\Queue\Queue::TYPE_CONSUMER || ($type = \Kaliop\QueueingBundle\Queue\Queue::TYPE_ANY)), Probably Intended Meaning: ($type = \Kaliop\QueueingBundle\Queue\Queue::TYPE_CONSUMER) || $type = \Kaliop\QueueingBundle\Queue\Queue::TYPE_ANY

            foreach ($this->registeredConsumers as $queueName) {
                if (isset($out[$queueName])) {
                    $out[$queueName] = Queue::TYPE_ANY;
                } else {
                    $out[$queueName] = Queue::TYPE_CONSUMER;
                }
            }
        }
        return $out;
    }

    /**
     * Used to keep track of the queues which are available (configured in the bundle)
     * @param string $queueName
     */
    public function registerProducer($queueName) {
        $this->registeredProducers[] = $queueName;
    }

    /**
     * Used to keep track of the queues which are available (configured in the bundle)
     * @param string $queueName
     */
    public function registerConsumer($queueName) {
        $this->registeredConsumers[] = $queueName;
    }
}