kaliop-uk / ezworkflowenginebundle

DependencyInjection/EzWorkflowEngineExtension.php

<?php

namespace Kaliop\eZWorkflowEngineBundle\DependencyInjection;

use Symfony\Component\DependencyInjection\ContainerBuilder;
use Symfony\Component\Config\FileLocator;
use Symfony\Component\HttpKernel\DependencyInjection\Extension;
use Symfony\Component\DependencyInjection\Loader;

/**
 * This is the class that loads and manages your bundle configuration
 *
 * To learn more see {@link http://symfony.com/doc/current/cookbook/bundles/extension.html}
 */
class EzWorkflowEngineExtension extends Extension
{
    public static $loadTestConfig = false;

    /**
     * {@inheritDoc}
     */
    public function load(array $configs, ContainerBuilder $container)
    {
        $configuration = new Configuration();
        $config = $this->processConfiguration($configuration, $configs);

The assignment to $config is dead and can be removed.

        $loader = new Loader\YamlFileLoader($container, new FileLocator(__DIR__ . '/../Resources/config'));
        $loader->load('services.yml');

        if (self::$loadTestConfig != false) {

It seems like you are loosely comparing two booleans. Considering using the strict comparison !== instead.

            $loader = new Loader\YamlFileLoader($container, new FileLocator(__DIR__ . '/../Tests/config'));
            $loader->load('services.yml');
        }
    }
}