kaliop-uk / ezworkflowenginebundle

Command/DebugCommand.php

<?php

namespace Kaliop\eZWorkflowEngineBundle\Command;

use Kaliop\eZMigrationBundle\API\Value\MigrationDefinition;
use Symfony\Component\Console\Helper\Table;
use Symfony\Component\Console\Input\InputInterface;
use Symfony\Component\Console\Input\InputOption;
use Symfony\Component\Console\Output\OutputInterface;

/**
 * Command to display the defined workflow definitions.
 */
class DebugCommand extends AbstractCommand
{
    protected function configure()
    {
        $this->setName('kaliop:workflows:debug')
            ->setDescription('List the configured workflow definitions')
            ->addOption('path', null, InputOption::VALUE_OPTIONAL | InputOption::VALUE_IS_ARRAY, "The directory or file to load the workflow definitions from")
            ->addOption('show-path', null, InputOption::VALUE_NONE, "Print definition path instead of notes")
        ;
    }

    public function execute(InputInterface $input, OutputInterface $output)
    {
        $workflowService = $this->getWorkflowService();

        $displayPath = $input->getOption('show-path');

        $workflowDefinitions = $workflowService->getWorkflowsDefinitions($input->getOption('path'));

It seems like $input->getOption('path') can also be of type boolean and string; however, parameter $paths of Kaliop\eZWorkflowEngineBundle\Core\WorkflowServiceFacade::getWorkflowsDefinitions() does only seem to accept string[], maybe add an additional type check?

        if (!count($workflowDefinitions)) {
            $output->writeln('<info>No workflow definitions found</info>');
            return 0;
        }

        $i = 1;
        foreach ($workflowDefinitions as $workflowDefinition) {
            switch ($workflowDefinition->status) {
                case MigrationDefinition::STATUS_INVALID:
                    $name = '<error>' . $workflowDefinition->name . '</error>';
                    break;
                default:
                    $name = $workflowDefinition->name;
            }
            $data[] = array(
                $i++,
                $name,
                $workflowDefinition->signalName,
                //$workflowDefinition->path,
                ($workflowDefinition->runAs === false) ? '-' : $workflowDefinition->runAs,
                $workflowDefinition->useTransaction ? 'Y' : 'N',
                $displayPath ? $workflowDefinition->path : $workflowDefinition->parsingError
            );

        }

        $table = new Table($output);
        $table
            ->setHeaders(array('#', 'Workflow definition', 'Signal', 'Switch user', 'Use transaction', /*'Path',*/ 'Notes'))
            ->setRows($data);

The variable $data seems to be defined by a foreach iteration on line 39. Are you sure the iterator is never empty, otherwise this variable is not defined?

        $table->render();

        return 0;
    }
}