kaliop-uk / ezmigrationbundle

Core/ReferenceResolver/EmbeddedRegexpReferenceResolverTrait.php

Spacing +2 added lines, -2 removed lines

@@ -18,7 +18,7 @@ 
     public function hasEmbeddedReferences($string)
     {
         $regexp = $this->getEmbeddedRegexp();
-        return (bool) preg_match_all($regexp, $string, $matches);
+        return (bool)preg_match_all($regexp, $string, $matches);
     }
     
     /**
@@ -52,7 +52,7 @@ 
     {
         // we need to alter the regexp we usr for std ref resolving, as it will be used to match parts of text, not the whole string
         $regexp = substr($this->getRegexp(), 1, -1);
-        return '/' . preg_quote($this->beginToken). preg_replace(array('/^\^/'), array(''), $regexp) . '[^' . $this->endToken . ']+' . preg_quote($this->endToken) . '/';
+        return '/' . preg_quote($this->beginToken) . preg_replace(array('/^\^/'), array(''), $regexp) . '[^' . $this->endToken . ']+' . preg_quote($this->endToken) . '/';
     }
 
     /**

Core/FieldHandler/EzRichText.php

Spacing +1 added lines, -1 removed lines

@@ -11,7 +11,7 @@
 {
     public function setReferenceResolver(ReferenceResolverInterface $referenceResolver)
     {
-        if (! $referenceResolver instanceof EmbeddedReferenceResolverInterface) {
+        if (!$referenceResolver instanceof EmbeddedReferenceResolverInterface) {
             throw new \Exception("Reference resolver injected into EzRichText field handler should implement EmbeddedReferenceResolverInterface");
         }
         parent::setReferenceResolver($referenceResolver);

Core/FieldHandler/EzXmlText.php

Spacing +1 added lines, -1 removed lines

@@ -11,7 +11,7 @@
 {
     public function setReferenceResolver(ReferenceResolverInterface $referenceResolver)
     {
-        if (! $referenceResolver instanceof EmbeddedReferenceResolverInterface) {
+        if (!$referenceResolver instanceof EmbeddedReferenceResolverInterface) {
             throw new \Exception("Reference resolver injected into EzXmlText field handler should implement EmbeddedReferenceResolverInterface");
         }
         parent::setReferenceResolver($referenceResolver);

Command/TestBenchCommand.php

Unused Use Statements -1 removed lines

@@ -6,7 +6,6 @@
 use Kaliop\eZMigrationBundle\Core\MigrationService;
 use Symfony\Component\Console\Input\InputInterface;
 use Symfony\Component\Console\Output\OutputInterface;
-use Symfony\Component\Console\Input\InputOption;
 use Kaliop\eZMigrationBundle\API\Value\Migration;
 use Kaliop\eZMigrationBundle\API\Value\MigrationDefinition;
 

Spacing +3 added lines, -3 removed lines

@@ -49,7 +49,7 @@ 
 echo 'B';*/
 
         $ms->executeMigration(new MigrationDefinition(
-            'test_'.time(),
+            'test_' . time(),
             '/hello',
             '123',
             MigrationDefinition::STATUS_PARSED,
@@ -62,8 +62,8 @@ 
 
         $sh = $this->getContainer()->get('ez_migration_bundle.storage_handler');
 
-        $m1 = 'hello_'.time();
-        $m2 = 'there_'.time();
+        $m1 = 'hello_' . time();
+        $m2 = 'there_' . time();
         $sh->startMigration(new MigrationDefinition(
             $m1,
             '/hello',

Core/Executor/RepositoryExecutor.php

Spacing +2 added lines, -2 removed lines

@@ -225,7 +225,7 @@ 
             }
         }
 
-        foreach($referencesDefs as $reference) {
+        foreach ($referencesDefs as $reference) {
             $overwrite = false;
             if (isset($reference['overwrite'])) {
                 $overwrite = $reference['overwrite'];
@@ -246,7 +246,7 @@ 
     {
         // allow setting *some* refs even when we have 0 or N matches
         foreach ($referencesDefinition as $key => $reference) {
-            switch($reference['attribute']) {
+            switch ($reference['attribute']) {
 
                 case 'count':
                     $value = count($entity);

Doc Comments +5 added lines, -2 removed lines

@@ -313,7 +313,7 @@ 
     }
 
     /**
-     * @param array $step
+     * @param MigrationStep $step
      * @return string
      */
     protected function getReferencesType($step)
@@ -322,7 +322,7 @@ 
     }
 
     /**
-     * @param array $step
+     * @param MigrationStep $step
      * @return bool
      */
     protected function allowEmptyReferences($step)
@@ -343,6 +343,9 @@ 
         return preg_replace('/(?<!^)[A-Z]/', ' $0', $className);
     }
 
+    /**
+     * @param AbstractCollection $collection
+     */
     protected function getCollectionName($collection)
     {
         $className = get_class($collection);

Braces +3 added lines, -2 removed lines

@@ -329,8 +329,9 @@
     {
         if (isset($step->dsl['references_type']) && $step->dsl['references_type'] == self::REFERENCE_TYPE_ARRAY &&
             isset($step->dsl['references_allow_empty']) && $step->dsl['references_allow_empty'] == true
-        )
-            return true;
+        ) {
+                    return true;
+        }
         return false;
     }
 

Core/ReferenceResolver/LoopResolver.php

Spacing +1 added lines, -1 removed lines

@@ -35,7 +35,7 @@
      */
     public function getReferenceValue($identifier)
     {
-        switch(substr($identifier, 5)) {
+        switch (substr($identifier, 5)) {
             case 'iteration':
                 $current = end($this->stack);
                 return $current['step'];

Core/Executor/LoopExecutor.php

Spacing +2 added lines, -2 removed lines

@@ -80,7 +80,7 @@ 
                     $subStep = new MigrationStep($type, $stepDef, array_merge($step->context, array()));
                     try {
                         $result = $stepExecutors[$j]->execute($subStep);
-                    } catch(MigrationStepSkippedException $e) {
+                    } catch (MigrationStepSkippedException $e) {
                         // all ok, continue the loop
                     }
                 }
@@ -97,7 +97,7 @@ 
                     $subStep = new MigrationStep($type, $stepDef, array_merge($step->context, array()));
                     try {
                         $result = $stepExecutors[$j]->execute($subStep);
-                    } catch(MigrationStepSkippedException $e) {
+                    } catch (MigrationStepSkippedException $e) {
                         // all ok, continue the loop
                     }
                 }

Core/Matcher/QueryBasedMatcher.php

Doc Comments +3 added lines

@@ -308,6 +308,9 @@
         return $out;
     }
 
+    /**
+     * @return string
+     */
     protected function hash2SortOrder($value)
     {
         $sortOrder = null;

Spacing +7 added lines, -7 removed lines

@@ -146,7 +146,7 @@ 
                 return new Query\Criterion\DateMetadata(Query\Criterion\DateMetadata::CREATED, self::$operatorsMap[$operator], $match);
 
             case self::MATCH_GROUP:
-                foreach($values as &$value) {
+                foreach ($values as &$value) {
                     if (!ctype_digit($value)) {
                         $value = $this->groupMatcher->matchOneByKey($value)->id;
                     }
@@ -165,7 +165,7 @@ 
                 return new Query\Criterion\DateMetadata(Query\Criterion\DateMetadata::MODIFIED, self::$operatorsMap[$operator], $match);
 
             case self::MATCH_OBJECT_STATE:
-                foreach($values as &$value) {
+                foreach ($values as &$value) {
                     if (!ctype_digit($value)) {
                         $value = $this->stateMatcher->matchOneByKey($value)->id;
                     }
@@ -173,7 +173,7 @@ 
                 return new Query\Criterion\ObjectStateId($values);
 
             case self::MATCH_OWNER:
-                foreach($values as &$value) {
+                foreach ($values as &$value) {
                     if (!ctype_digit($value)) {
                         $value = $this->userMatcher->matchOneByKey($value)->id;
                     }
@@ -193,7 +193,7 @@ 
                 return new Query\Criterion\ParentLocationId($locationIds);
 
             case self::MATCH_SECTION:
-                foreach($values as &$value) {
+                foreach ($values as &$value) {
                     if (!ctype_digit($value)) {
                         $value = $this->sectionMatcher->matchOneByKey($value)->id;
                     }
@@ -214,7 +214,7 @@ 
 
             case self::MATCH_AND:
                 $subCriteria = array();
-                foreach($values as $subCriterion) {
+                foreach ($values as $subCriterion) {
                     $value = reset($subCriterion);
                     $subCriteria[] = $this->getQueryCriterion(key($subCriterion), $value);
                 }
@@ -222,7 +222,7 @@ 
 
             case self::MATCH_OR:
                 $subCriteria = array();
-                foreach($values as $subCriterion) {
+                foreach ($values as $subCriterion) {
                     $value = reset($subCriterion);
                     $subCriteria[] = $this->getQueryCriterion(key($subCriterion), $value);
                 }
@@ -259,7 +259,7 @@ 
 
             $direction = $this->hash2SortOrder($sortItem['sort_order']);
 
-            switch($sortItem['sort_field']) {
+            switch ($sortItem['sort_field']) {
                 case SELF::SORT_CONTENT_ID:
                     $out[] = new SortClause\ContentId($direction);
                     break;

Core/Helper/SortConverter.php

Spacing +1 added lines, -1 removed lines

@@ -40,7 +40,7 @@
     public function sortField2Hash($value)
     {
         $ref = new \ReflectionClass('eZ\Publish\API\Repository\Values\Content\Location');
-        foreach($ref->getConstants() as $key => $val) {
+        foreach ($ref->getConstants() as $key => $val) {
             if (strpos($key, 'SORT_FIELD_') === 0 && $val == $value) {
                 $out = strtolower(substr($key, 11));
                 if ($out == 'contentobject_id') {