EzSelection::hashToFieldValue() - Code Metrics - Inspection of "make it harder to create filedTypes with bad ezele..." - kaliop-uk/ezmigrationbundle - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — master ( 4eca5c...1ce7e1 )

by Gaetano

created 2017-10-01 12:28 UTC

EzSelection::hashToFieldValue() D

↳ Parent: EzSelection

Complexity

Conditions	10
Paths	19

Size

Total Lines	33
Code Lines	18

Duplication

Lines	0
Ratio	0 %

Importance

Changes

Metric	Value
dl	0
loc	33
c	0
b	0
f	0
rs	4.8196
cc	10
eloc	18
nc	19
nop	2

How to fix Complexity

<?php

namespace Kaliop\eZMigrationBundle\Core\FieldHandler;

use eZ\Publish\Core\FieldType\Selection\Value as SelectionValue;
use Kaliop\eZMigrationBundle\API\FieldValueImporterInterface;
use Kaliop\eZMigrationBundle\API\FieldDefinitionConverterInterface;
use \eZ\Publish\API\Repository\Repository;

class EzSelection extends AbstractFieldHandler implements FieldValueImporterInterface, FieldDefinitionConverterInterface
{
    protected $repository;

    public function __construct(Repository $repository)
    {
        $this->repository = $repository;
    }

    /**
     * Creates a value object to use as the field value when setting a selection field type.
     *
     * @param $fieldValue int|string|string[]|int[] should all work
     * @param array $context The context for execution of the current migrations. Contains f.e. the path to the migration
     * @return SelectionValue
     */
    public function hashToFieldValue($fieldValue, array $context = array())
    {
        if ($fieldValue === null) {
            return new SelectionValue();
        }

        // allow user to pass in a single value
        if (is_string($fieldValue) || is_int($fieldValue)) {
            $fieldValue = array($fieldValue);
        }

        // allow user to pass in selection values by name
        $fieldSettings = null;
        foreach($fieldValue as $key => $val) {
$collection = json_decode($data, true);
if ( ! is_array($collection)) {
    throw new \RuntimeException('$collection must be an array.');
}

foreach ($collection as $item) { /** ... */ }
            if (is_string($val)) {
                if (ctype_digit($val)) {
                    $fieldValue[$key] = (int)$val;
                } else {
                    if ($fieldSettings === null) {
                        $fieldSettings = $this->loadFieldSettings($context['contentTypeIdentifier'], $context['fieldIdentifier']);
                    }
                    foreach($fieldSettings['options'] as $pos => $name) {
                        if ($name === $val) {
                            $fieldValue[$key] = $pos;
                            break;
                        }
                    }
                }
            }
        }

        return new SelectionValue($fieldValue);
    }

    /**
     * @param string $contentTypeIdentifier
     * @param string $fieldIdentifier
     * @return mixed
     */
    protected function loadFieldSettings($contentTypeIdentifier, $fieldIdentifier)
    {
        $contentTypeService = $this->repository->getContentTypeService();
        $contentType = $contentTypeService->loadContentTypeByIdentifier($contentTypeIdentifier);
        $fieldDefinition = $contentType->fieldDefinitionsByIdentifier[$fieldIdentifier];

        return $fieldDefinition->fieldSettings;
    }

    public function fieldSettingsToHash($settingsValue, array $context = array())
    {
        return $settingsValue;
    }

    public function hashToFieldSettings($settingsHash, array $context = array())
    {
        foreach ($settingsHash['options'] as $key => $value) {
            if (!ctype_digit($key)) {
                throw new \Exception("The list of values allowed for an eZSelection field can only use integer keys, found: '$key'");
            }
        }
        return $settingsHash;
    }
}


1			<?php
2
3			namespace Kaliop\eZMigrationBundle\Core\FieldHandler;
4
5			use eZ\Publish\Core\FieldType\Selection\Value as SelectionValue;
6			use Kaliop\eZMigrationBundle\API\FieldValueImporterInterface;
7			use Kaliop\eZMigrationBundle\API\FieldDefinitionConverterInterface;
8			use \eZ\Publish\API\Repository\Repository;
9
10			class EzSelection extends AbstractFieldHandler implements FieldValueImporterInterface, FieldDefinitionConverterInterface
11			{
12			protected $repository;
13
14			public function __construct(Repository $repository)
15			{
16			$this->repository = $repository;
17			}
18
19			/**
20			* Creates a value object to use as the field value when setting a selection field type.
21			*
22			* @param $fieldValue int\|string\|string[]\|int[] should all work
23			* @param array $context The context for execution of the current migrations. Contains f.e. the path to the migration
24			* @return SelectionValue
25			*/
26			public function hashToFieldValue($fieldValue, array $context = array())
27			{
28			if ($fieldValue === null) {
29			return new SelectionValue();
30			}
31
32			// allow user to pass in a single value
33			if (is_string($fieldValue) \|\| is_int($fieldValue)) {
34			$fieldValue = array($fieldValue);
35			}
36
37			// allow user to pass in selection values by name
38			$fieldSettings = null;
39			foreach($fieldValue as $key => $val) {
			0 ignored issues – show Bug introduced 2017-02-11 13:38 UTC by Report Bug Copy Issue Report The expression `$fieldValue` of type `object\|double\|null\|array\|boolean` is not guaranteed to be traversable. How about adding an additional type check? There are different options of fixing this problem. If you want to be on the safe side, you can add an additional type-check: $collection = json_decode($data, true); if ( ! is_array($collection)) { throw new \RuntimeException('$collection must be an array.'); } foreach ($collection as $item) { /** ... / } If you are sure that the expression is traversable, you might want to add a doc comment cast* to improve IDE auto-completion and static analysis: /** @var array $collection / $collection = json_decode($data, true); foreach ($collection as $item) { /* .. / } Mark the issue as a false-positive*: Just hover the remove button, in the top-right corner of this issue for more options. Loading history...
40			if (is_string($val)) {
41			if (ctype_digit($val)) {
42			$fieldValue[$key] = (int)$val;
43			} else {
44			if ($fieldSettings === null) {
45			$fieldSettings = $this->loadFieldSettings($context['contentTypeIdentifier'], $context['fieldIdentifier']);
46			}
47			foreach($fieldSettings['options'] as $pos => $name) {
48			if ($name === $val) {
49			$fieldValue[$key] = $pos;
50			break;
51			}
52			}
53			}
54			}
55			}
56
57			return new SelectionValue($fieldValue);
58			}
59
60			/**
61			* @param string $contentTypeIdentifier
62			* @param string $fieldIdentifier
63			* @return mixed
64			*/
65			protected function loadFieldSettings($contentTypeIdentifier, $fieldIdentifier)
66			{
67			$contentTypeService = $this->repository->getContentTypeService();
68			$contentType = $contentTypeService->loadContentTypeByIdentifier($contentTypeIdentifier);
69			$fieldDefinition = $contentType->fieldDefinitionsByIdentifier[$fieldIdentifier];
			0 ignored issues – show Bug introduced 2017-05-13 23:58 UTC by Report Bug Copy Issue Report The property `fieldDefinitionsByIdentifier` does not seem to exist. Did you mean `fieldDefinitions`? An attempt at access to an undefined property has been detected. This may either be a typographical error or the property has been renamed but there are still references to its old name. If you really want to allow access to undefined properties, you can define magic methods to allow access. See the php core documentation on Overloading. Loading history...
70			return $fieldDefinition->fieldSettings;
71			}
72
73			public function fieldSettingsToHash($settingsValue, array $context = array())
74			{
75			return $settingsValue;
76			}
77
78			public function hashToFieldSettings($settingsHash, array $context = array())
79			{
80			foreach ($settingsHash['options'] as $key => $value) {
81			if (!ctype_digit($key)) {
82			throw new \Exception("The list of values allowed for an eZSelection field can only use integer keys, found: '$key'");
83			}
84			}
85			return $settingsHash;
86			}
87			}
88

kaliop-uk / ezmigrationbundle

Push — master ( 4eca5c...1ce7e1 )

EzSelection::hashToFieldValue() D

Complexity

Size

Duplication

Importance

How to fix Complexity

Long Method

Duplication Side-by-Side

Filter issues like