RoleMatcher::matchRole() - Code Metrics - Inspection of "Allow composite matching using and and or" - kaliop-uk/ezmigrationbundle - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — master ( 8c5037...eed80c )

by Gaetano

created 2017-02-04 01:45 UTC

RoleMatcher::matchRole() C

↳ Parent: RoleMatcher

Complexity

Conditions	11
Paths	19

Size

Total Lines	33
Code Lines	20

Duplication

Lines	33
Ratio	100 %

Importance

Changes

Metric	Value
dl	33
loc	33
c	0
b	0
f	0
rs	5.2653
cc	11
eloc	20
nc	19
nop	1

How to fix Complexity

<?php

namespace Kaliop\eZMigrationBundle\Core\Matcher;

use eZ\Publish\API\Repository\Values\User\Role;
use Kaliop\eZMigrationBundle\API\Collection\RoleCollection;
use Kaliop\eZMigrationBundle\API\KeyMatcherInterface;

class RoleMatcher extends RepositoryMatcher implements KeyMatcherInterface

{
    use FlexibleKeyMatcherTrait;

    const MATCH_ROLE_ID = 'role_id';
    const MATCH_ROLE_IDENTIFIER = 'role_identifier';

    protected $allowedConditions = array(
        self::MATCH_ALL, self::MATCH_AND, self::MATCH_OR, self::MATCH_NOT,
        self::MATCH_ROLE_ID, self::MATCH_ROLE_IDENTIFIER,
        // aliases
        'id', 'identifier'
    );
    protected $returns = 'Role';

    /**
     * @param array $conditions key: condition, value: int / string / int[] / string[]
     * @return RoleCollection
     */
    public function match(array $conditions)
    {
        return $this->matchRole($conditions);
    }

    /**
     * @param array $conditions key: condition, value: int / string / int[] / string[]
     * @return RoleCollection
     */
    public function matchRole(array $conditions)
    {
        $this->validateConditions($conditions);

        foreach ($conditions as $key => $values) {

            if (!is_array($values)) {
                $values = array($values);
            }

            switch ($key) {
                case 'id':
                case self::MATCH_ROLE_ID:
                   return new RoleCollection($this->findRolesById($values));

                case 'identifier':
                case self::MATCH_ROLE_IDENTIFIER:
                    return new RoleCollection($this->findRolesByIdentifier($values));

                case self::MATCH_ALL:
                    return new RoleCollection($this->findAllRoles());

                case self::MATCH_AND:
                    return $this->matchAnd($values);


                case self::MATCH_OR:
                    return $this->matchOr($values);


                case self::MATCH_NOT:
                    return new RoleCollection(array_diff_key($this->findAllRoles(), $this->matchRole($values)->getArrayCopy()));
            }
        }
    }

    protected function getConditionsFromKey($key)
    {
        if (is_int($key) || ctype_digit($key)) {
            return array(self::MATCH_ROLE_ID => $key);
        }
        return array(self::MATCH_ROLE_IDENTIFIER => $key);
    }

    /**
     * @param int[] $roleIds
     * @return Role[]
     */
    protected function findRolesById(array $roleIds)
    {
        $roles = [];

        foreach ($roleIds as $roleId) {
            // return unique contents
            $role = $this->repository->getRoleService()->loadRole($roleId);
            $roles[$role->id] = $role;
        }

        return $roles;
    }

    /**
     * @param string[] $roleIdentifiers
     * @return Role[]
     */
    protected function findRolesByIdentifier(array $roleIdentifiers)
    {
        $roles = [];

        foreach ($roleIdentifiers as $roleIdentifier) {
            // return unique contents
            $role = $this->repository->getRoleService()->loadRoleByIdentifier($roleIdentifier);
            $roles[$role->id] = $role;
        }

        return $roles;
    }

    /**
     * @return Role[]
     */
    protected function findAllRoles()
    {
        $roles = [];

        foreach ($this->repository->getRoleService()->loadRoles() as $role) {
            // return unique contents
            $roles[$role->id] = $role;
        }

        return $roles;
    }
}


1		<?php
2
3		namespace Kaliop\eZMigrationBundle\Core\Matcher;
4
5		use eZ\Publish\API\Repository\Values\User\Role;
6		use Kaliop\eZMigrationBundle\API\Collection\RoleCollection;
7		use Kaliop\eZMigrationBundle\API\KeyMatcherInterface;
8
9	View Code Duplication	class RoleMatcher extends RepositoryMatcher implements KeyMatcherInterface
		0 ignored issues – show Duplication introduced 2016-09-25 22:10 UTC by Report Bug Copy Issue Report This class seems to be duplicated in your project. Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation. You can also find more detailed suggestions in the “Code” section of your repository. Loading history...
10		{
11		use FlexibleKeyMatcherTrait;
12
13		const MATCH_ROLE_ID = 'role_id';
14		const MATCH_ROLE_IDENTIFIER = 'role_identifier';
15
16		protected $allowedConditions = array(
17		self::MATCH_ALL, self::MATCH_AND, self::MATCH_OR, self::MATCH_NOT,
18		self::MATCH_ROLE_ID, self::MATCH_ROLE_IDENTIFIER,
19		// aliases
20		'id', 'identifier'
21		);
22		protected $returns = 'Role';
23
24		/**
25		* @param array $conditions key: condition, value: int / string / int[] / string[]
26		* @return RoleCollection
27		*/
28		public function match(array $conditions)
29		{
30		return $this->matchRole($conditions);
31		}
32
33		/**
34		* @param array $conditions key: condition, value: int / string / int[] / string[]
35		* @return RoleCollection
36		*/
37		public function matchRole(array $conditions)
38		{
39		$this->validateConditions($conditions);
40
41		foreach ($conditions as $key => $values) {
42
43		if (!is_array($values)) {
44		$values = array($values);
45		}
46
47		switch ($key) {
48		case 'id':
49		case self::MATCH_ROLE_ID:
50		return new RoleCollection($this->findRolesById($values));
51
52		case 'identifier':
53		case self::MATCH_ROLE_IDENTIFIER:
54		return new RoleCollection($this->findRolesByIdentifier($values));
55
56		case self::MATCH_ALL:
57		return new RoleCollection($this->findAllRoles());
58
59		case self::MATCH_AND:
60		return $this->matchAnd($values);
		0 ignored issues – show Bug Compatibility introduced 2017-02-04 01:52 UTC by Report Bug Copy Issue Report The expression `$this->matchAnd($values);` of type `object\|array` adds the type `array` to the return on line 60 which is incompatible with the return type documented by `Kaliop\eZMigrationBundle...\RoleMatcher::matchRole` of type `Kaliop\eZMigrationBundle...ion\RoleCollection\|null`. Loading history...
61
62		case self::MATCH_OR:
63		return $this->matchOr($values);
		0 ignored issues – show Bug Compatibility introduced 2017-02-04 01:52 UTC by Report Bug Copy Issue Report The expression `$this->matchOr($values);` of type `object\|array` adds the type `array` to the return on line 63 which is incompatible with the return type documented by `Kaliop\eZMigrationBundle...\RoleMatcher::matchRole` of type `Kaliop\eZMigrationBundle...ion\RoleCollection\|null`. Loading history...
64
65		case self::MATCH_NOT:
66		return new RoleCollection(array_diff_key($this->findAllRoles(), $this->matchRole($values)->getArrayCopy()));
67		}
68		}
69		}
70
71		protected function getConditionsFromKey($key)
72		{
73		if (is_int($key) \|\| ctype_digit($key)) {
74		return array(self::MATCH_ROLE_ID => $key);
75		}
76		return array(self::MATCH_ROLE_IDENTIFIER => $key);
77		}
78
79		/**
80		* @param int[] $roleIds
81		* @return Role[]
82		*/
83		protected function findRolesById(array $roleIds)
84		{
85		$roles = [];
86
87		foreach ($roleIds as $roleId) {
88		// return unique contents
89		$role = $this->repository->getRoleService()->loadRole($roleId);
90		$roles[$role->id] = $role;
91		}
92
93		return $roles;
94		}
95
96		/**
97		* @param string[] $roleIdentifiers
98		* @return Role[]
99		*/
100		protected function findRolesByIdentifier(array $roleIdentifiers)
101		{
102		$roles = [];
103
104		foreach ($roleIdentifiers as $roleIdentifier) {
105		// return unique contents
106		$role = $this->repository->getRoleService()->loadRoleByIdentifier($roleIdentifier);
107		$roles[$role->id] = $role;
108		}
109
110		return $roles;
111		}
112
113		/**
114		* @return Role[]
115		*/
116		protected function findAllRoles()
117		{
118		$roles = [];
119
120		foreach ($this->repository->getRoleService()->loadRoles() as $role) {
121		// return unique contents
122		$roles[$role->id] = $role;
123		}
124
125		return $roles;
126		}
127		}
128

kaliop-uk / ezmigrationbundle

Push — master ( 8c5037...eed80c )

RoleMatcher::matchRole() C

Complexity

Size

Duplication

Importance

How to fix Complexity

Long Method

Duplication Side-by-Side

Filter issues like