kaliop-uk / ezmigrationbundle

Command/MigrationCommand.php

Spacing +2 added lines, -2 removed lines

@@ -49,7 +49,7 @@ 
      */
     protected function execute(InputInterface $input, OutputInterface $output)
     {
-        if (! $input->getOption('add') && ! $input->getOption('delete')) {
+        if (!$input->getOption('add') && !$input->getOption('delete')) {
             throw new \InvalidArgumentException('You must specify whether you want to --add or --delete the specified migration.');
         }
 
@@ -79,7 +79,7 @@ 
                 throw new \InvalidArgumentException(sprintf('The path "%s" does not correspond to any migration definition.', $migrationNameOrPath));
             }
 
-            foreach($migrationDefinitionCollection as $migrationDefinition) {
+            foreach ($migrationDefinitionCollection as $migrationDefinition) {
                 $migrationName = basename($migrationDefinition->path);
 
                 $migration = $migrationService->getMigration($migrationNameOrPath);

Tests/bootstrap.php

Spacing +1 added lines, -1 removed lines

@@ -1,7 +1,7 @@
 <?php
 
 // try to load autoloade both when extension is top-level project and when it is installed as part of a working eZPUblish
-if (!file_exists($file = __DIR__.'/../vendor/autoload.php') && !file_exists($file = __DIR__.'/../../../../vendor/autoload.php')) {
+if (!file_exists($file = __DIR__ . '/../vendor/autoload.php') && !file_exists($file = __DIR__ . '/../../../../vendor/autoload.php')) {
     throw new \RuntimeException('Install the dependencies to run the test suite.');
 }
 

Tests/phpunit/Core/BundleMigrationDBTestCase.php

Spacing +1 added lines, -1 removed lines

@@ -10,6 +10,6 @@
 
     public function setUp()
     {
-        $this->connection = DriverManager::getConnection( array( 'driver' => 'pdo_sqlite', 'memory' => true ) );
+        $this->connection = DriverManager::getConnection(array('driver' => 'pdo_sqlite', 'memory' => true));
     }
 }

Core/Executor/ContentManager.php

Spacing +1 added lines, -1 removed lines

@@ -180,7 +180,7 @@
             }
 
             $draft = $contentService->createContentDraft($contentInfo);
-            $contentService->updateContent($draft->versionInfo,$contentUpdateStruct);
+            $contentService->updateContent($draft->versionInfo, $contentUpdateStruct);
             $content = $contentService->publishVersion($draft->versionInfo);
 
             if (array_key_exists('new_remote_id', $this->dsl)) {

Command/MigrateCommand.php

Spacing +4 added lines, -4 removed lines

@@ -67,7 +67,7 @@ 
 
         // filter away all migrations except 'to do' ones
         $toExecute = array();
-        foreach($migrationDefinitions as $name => $migrationDefinition) {
+        foreach ($migrationDefinitions as $name => $migrationDefinition) {
             if (!isset($migrations[$name]) || (($migration = $migrations[$name]) && $migration->status == Migration::STATUS_TODO)) {
                 $toExecute[$name] = $migrationsService->parseMigrationDefinition($migrationDefinition);
             }
@@ -100,7 +100,7 @@ 
 
         $data = array();
         $i = 1;
-        foreach($toExecute as $name => $migrationDefinition) {
+        foreach ($toExecute as $name => $migrationDefinition) {
             $notes = '';
             if ($migrationDefinition->status != MigrationDefinition::STATUS_PARSED) {
                 $notes = '<error>' . $migrationDefinition->parsingError . '</error>';
@@ -135,7 +135,7 @@ 
             $output->writeln("=============================================\n");
         }
 
-        foreach($toExecute as $name => $migrationDefinition) {
+        foreach ($toExecute as $name => $migrationDefinition) {
 
             // let's skip migrations that we know are invalid - user was warned and he decided to proceed anyway
             if ($migrationDefinition->status == MigrationDefinition::STATUS_INVALID) {
@@ -147,7 +147,7 @@ 
 
             try {
                 $migrationsService->executeMigration($migrationDefinition);
-            } catch(\Exception $e) {
+            } catch (\Exception $e) {
                 if ($input->getOption('ignore-failures')) {
                     $output->writeln("\n<error>Migration failed! Reason: " . $e->getMessage() . "</error>\n");
                     continue;

Tests/phpunit/CommandTest.php

Spacing +2 added lines, -2 removed lines

@@ -57,7 +57,7 @@ 
 
     protected function tearDown()
     {
-        foreach($this->leftovers as $file) {
+        foreach ($this->leftovers as $file) {
             unlink($file);
         }
 
@@ -83,7 +83,7 @@ 
         );
         try {
             static::$kernel = static::createKernel($options);
-        } catch(\RuntimeException $e) {
+        } catch (\RuntimeException $e) {
             throw new \RuntimeException($e->getMessage() . " Did you forget to define the environment variable KERNEL_DIR?", $e->getCode(), $e->getPrevious());
         }
         static::$kernel->boot();

API/Collection/AbstractCollection.php

Spacing +7 added lines, -7 removed lines

@@ -15,9 +15,9 @@ 
      * @param int $flags
      * @param string $iterator_class
      */
-    public function __construct ($input = array(), $flags = 0, $iterator_class = "ArrayIterator")
+    public function __construct($input = array(), $flags = 0, $iterator_class = "ArrayIterator")
     {
-        foreach($input as $value) {
+        foreach ($input as $value) {
             if (!is_a($value, $this->allowedClass)) {
                 $this->throwInvalid($value);
             }
@@ -29,7 +29,7 @@ 
     /**
      * @param mixed $value
      */
-    public function append ($value)
+    public function append($value)
     {
         if (!is_a($value, $this->allowedClass)) {
             $this->throwInvalid($value);
@@ -42,9 +42,9 @@ 
      * @param mixed $input
      * @return array the old array
      */
-    public function exchangeArray ($input)
+    public function exchangeArray($input)
     {
-        foreach($input as $value) {
+        foreach ($input as $value) {
             if (!is_a($value, $this->allowedClass)) {
                 $this->throwInvalid($value);
             }
@@ -57,13 +57,13 @@ 
      * @param mixed $index
      * @param mixed $newval
      */
-    public function offsetSet ($index , $newval)
+    public function offsetSet($index, $newval)
     {
         if (!is_a($newval, $this->allowedClass)) {
             $this->throwInvalid($newval);
         }
 
-        return parent::offsetSet($index , $newval);
+        return parent::offsetSet($index, $newval);
     }
 
     protected function throwInvalid($newval)

Tests/behat/FeatureContext.php

Unused Use Statements -1 removed lines

@@ -1,7 +1,6 @@
 <?php
 
 use Kaliop\eZMigrationBundle\API\MigrationInterface;
-
 use Symfony\Component\DependencyInjection\ContainerInterface;
 use Kaliop\eZMigrationBundle\API\Value\Migration;
 use Kaliop\eZMigrationBundle\API\Value\MigrationDefinition;

Spacing +25 added lines, -25 removed lines

@@ -52,7 +52,7 @@ 
     /**
      * @Given /^I have the parsed DSL:$/
      */
-    public function iHaveTheParsedDsl( TableNode $table )
+    public function iHaveTheParsedDsl(TableNode $table)
     {
         $hash = $table->getHash();
         $this->dsl = $hash[0];
@@ -61,7 +61,7 @@ 
     /**
      * @Given /^the attributes:$/
      */
-    public function theAttributes( TableNode $table )
+    public function theAttributes(TableNode $table)
     {
         $this->dsl['attributes'] = $table->getHash();
     }
@@ -69,23 +69,23 @@ 
     /**
      * @When /^I create a "([^"]*)"$/
      */
-    public function iCreateA( $className )
+    public function iCreateA($className)
     {
-        $this->stepResults = $this->createObject( $className );
+        $this->stepResults = $this->createObject($className);
 
     }
 
     /**
      * @Then /^I should get an object of "([^"]*)"$/
      */
-    public function iShouldGetAnObjectOf( $className )
+    public function iShouldGetAnObjectOf($className)
     {
-        switch( $className ) {
+        switch ($className) {
             case 'ContentCreateStruct':
-                Assertion::assertInstanceOf( 'eZ\Publish\Core\Repository\Values\Content\ContentCreateStruct', $this->stepResults );
+                Assertion::assertInstanceOf('eZ\Publish\Core\Repository\Values\Content\ContentCreateStruct', $this->stepResults);
                 break;
             default:
-                throw new PendingException( 'Handling for class name: ' . $className . ' not implemented.' );
+                throw new PendingException('Handling for class name: ' . $className . ' not implemented.');
         }
 
     }
@@ -93,58 +93,58 @@ 
     /**
      * @Given /^it should have (\d+) fields of type "([^"]*)"$/
      */
-    public function itShouldHaveFieldsOfType( $numberOfFields, $className )
+    public function itShouldHaveFieldsOfType($numberOfFields, $className)
     {
-        switch( $className )
+        switch ($className)
         {
             case 'Field':
                 $fieldType = 'eZ\Publish\API\Repository\Values\Content\Field';
                 break;
             default:
-                throw new PendingException( 'Handling for class ' . $className . ' not implemented' );
+                throw new PendingException('Handling for class ' . $className . ' not implemented');
         }
 
-        $fieldCount = count( $this->stepResults->fields );
+        $fieldCount = count($this->stepResults->fields);
 
-        Assertion::assertEquals( $numberOfFields, $fieldCount );
-        foreach( $this->stepResults->fields as $field )
+        Assertion::assertEquals($numberOfFields, $fieldCount);
+        foreach ($this->stepResults->fields as $field)
         {
-            Assertion::assertInstanceOf( $fieldType, $field );
+            Assertion::assertInstanceOf($fieldType, $field);
         }
     }
 
     /**
      * @Given /^the fields should have the values:$/
      */
-    public function theFieldsShouldHaveTheValues(TableNode $table )
+    public function theFieldsShouldHaveTheValues(TableNode $table)
     {
         throw new PendingException();
     }
 
-    private function createObject( $className )
+    private function createObject($className)
     {
         $object = null;
 
-        switch( $className )
+        switch ($className)
         {
             case 'ContentCreateStruct':
                 /** @var $repository \eZ\Publish\API\Repository\Repository */
-                $repository = $this->kernel->getContainer()->get( 'ezpublish.api.repository' );
+                $repository = $this->kernel->getContainer()->get('ezpublish.api.repository');
 
                 $contentService = $repository->getContentService();
 
                 $contentType = $this->createArticleContentType();
 
-                $object = $contentService->newContentCreateStruct( $contentType, self::DEFAULT_LANGUAGE_CODE );
+                $object = $contentService->newContentCreateStruct($contentType, self::DEFAULT_LANGUAGE_CODE);
 
-                foreach( $this->dsl['attributes'][0] as $field => $value )
+                foreach ($this->dsl['attributes'][0] as $field => $value)
                 {
-                    $object->setField( $field, $value );
+                    $object->setField($field, $value);
                 }
 
                 break;
             default:
-                throw new UndefinedException( $className );
+                throw new UndefinedException($className);
         }
 
         return $object;
@@ -159,7 +159,7 @@ 
         $fieldDefinitions = $this->createArticleFieldDefinitions();
 
         $dateTime = new DateTime();
-        $dateTime->setTimestamp( time() );
+        $dateTime->setTimestamp(time());
 
         return new ContentType(
             array(
@@ -282,7 +282,7 @@ 
     private function createContentTypeGroup()
     {
         $dateTime = new DateTime();
-        $dateTime->setTimestamp( time() );
+        $dateTime->setTimestamp(time());
 
         return new ContentTypeGroup(
             array(

Tests/phpunit/2_MigrateTest.php

Spacing +10 added lines, -10 removed lines

@@ -1,6 +1,6 @@ 
 <?php
 
-include_once(__DIR__.'/CommandTest.php');
+include_once(__DIR__ . '/CommandTest.php');
 
 use Symfony\Component\Console\Input\ArrayInput;
 
@@ -115,13 +115,13 @@ 
 
     public function goodDSLProvider()
     {
-        $dslDir = $this->dslDir.'/good';
-        if(!is_dir($dslDir)) {
+        $dslDir = $this->dslDir . '/good';
+        if (!is_dir($dslDir)) {
             return array();
         }
 
         $out = array();
-        foreach(scandir($dslDir) as $fileName) {
+        foreach (scandir($dslDir) as $fileName) {
             $filePath = $dslDir . '/' . $fileName;
             if (is_file($filePath)) {
                 $out[] = array($filePath);
@@ -132,13 +132,13 @@ 
 
     public function invalidDSLProvider()
     {
-        $dslDir = $this->dslDir.'/bad/parsing';
-        if(!is_dir($dslDir)) {
+        $dslDir = $this->dslDir . '/bad/parsing';
+        if (!is_dir($dslDir)) {
             return array();
         }
 
         $out = array();
-        foreach(scandir($dslDir) as $fileName) {
+        foreach (scandir($dslDir) as $fileName) {
             $filePath = $dslDir . '/' . $fileName;
             if (is_file($filePath)) {
                 $out[] = array($filePath);
@@ -149,13 +149,13 @@ 
 
     public function badDSLProvider()
     {
-        $dslDir = $this->dslDir.'/bad/execution';
-        if(!is_dir($dslDir)) {
+        $dslDir = $this->dslDir . '/bad/execution';
+        if (!is_dir($dslDir)) {
             return array();
         }
 
         $out = array();
-        foreach(scandir($dslDir) as $fileName) {
+        foreach (scandir($dslDir) as $fileName) {
             $filePath = $dslDir . '/' . $fileName;
             if (is_file($filePath)) {
                 $out[] = array($filePath);