Kaliop\eZMigrationBundle\Core\Matcher\TrashMatcher

Complexity

Total Complexity

5

Size/Duplication

Total Lines	43
Duplicated Lines	46.51 %

Coupling/Cohesion

Components	1
Dependencies	4

Importance

Changes

0

2 Methods

Rating	Name	Duplication	Size	Complexity
A	match()	0	4	1
A	matchItem()	20	20	4

<?php

namespace Kaliop\eZMigrationBundle\Core\Matcher;

use Kaliop\eZMigrationBundle\API\Collection\TrashedItemCollection;
use \eZ\Publish\API\Repository\Values\Content\Query;

/// q: is it better to extends Content or Location Matcher ?
class TrashMatcher extends ContentMatcher
{
    const MATCH_ITEM_ID = 'item_id';

    protected $returns = 'Trashed-Item';

    /**
     * @param array $conditions key: condition, value: int / string / int[] / string[]
     * @return TrashedItemCollection
     */
    public function match(array $conditions)
    {
        return $this->matchItem($conditions);

The expression $this->matchItem($conditions); of type Kaliop\eZMigrationBundle\API\Collection\TrashedItemCollection|null adds the type Kaliop\eZMigrationBundle\API\Collection\TrashedItemCollection to the return on line 21 which is incompatible with the return type declared by the interface Kaliop\eZMigrationBundle\API\MatcherInterface::match of type array|ArrayObject.

    }

    /**
     * @param array $conditions
     * @return TrashedItemCollection
     *
     * @todo test all supported matching conditions
     * @todo support matching by item_id
     */
    public function matchItem(array $conditions)

This method seems to be duplicated in your project.

    {
        $this->validateConditions($conditions);

        foreach ($conditions as $key => $values) {

            $query = new Query();
            $query->limit = self::INT_MAX_16BIT;
            if (isset($query->performCount)) $query->performCount = false;
            $query->filter = $this->getQueryCriterion($key, $values);
            $results = $this->repository->getTrashService()->findTrashItems($query);

            $items = [];
            foreach ($results->searchHits as $result) {
                $items[$result->valueObject->id] = $result->valueObject;
            }

            return new TrashedItemCollection($items);
        }
    }
}