Kaliop\eZMigrationBundle\Core\FieldHandler\EzSelection

Complexity

Total Complexity

12

Size/Duplication

Total Lines	63
Duplicated Lines	0 %

Coupling/Cohesion

Components	1
Dependencies	4

Importance

Changes

0

3 Methods

Rating	Name	Duplication	Size	Complexity
A	__construct()	0	4	1
D	hashToFieldValue()	0	33	10
A	loadFieldSettings()	0	7	1

<?php

namespace Kaliop\eZMigrationBundle\Core\FieldHandler;

use eZ\Publish\Core\FieldType\Selection\Value as SelectionValue;
use Kaliop\eZMigrationBundle\API\FieldValueImporterInterface;
use \eZ\Publish\API\Repository\Repository;

class EzSelection extends AbstractFieldHandler implements FieldValueImporterInterface
{
    protected $repository;

    public function __construct(Repository $repository)
    {
        $this->repository = $repository;
    }

    /**
     * Creates a value object to use as the field value when setting a selection field type.
     *
     * @param $fieldValue int|string|string[]|int[] should all work
     * @param array $context The context for execution of the current migrations. Contains f.e. the path to the migration
     * @return SelectionValue
     */
    public function hashToFieldValue($fieldValue, array $context = array())
    {
        if ($fieldValue === null) {
            return new SelectionValue();
        }

        // allow user to pass in a single value
        if (is_string($fieldValue) || is_int($fieldValue)) {
            $fieldValue = array($fieldValue);
        }

        // allow user to pass in selection values by name
        $fieldSettings = null;
        foreach($fieldValue as $key => $val) {

The expression $fieldValue of type object|double|null|array|boolean is not guaranteed to be traversable. How about adding an additional type check?

            if (is_string($val)) {
                if (ctype_digit($val)) {
                    $fieldValue[$key] = (int)$val;
                } else {
                    if ($fieldSettings === null) {
                        $fieldSettings = $this->loadFieldSettings($context['contentTypeIdentifier'], $context['fieldIdentifier']);
                    }
                    foreach($fieldSettings['options'] as $pos => $name) {
                        if ($name === $val) {
                            $fieldValue[$key] = $pos;
                            break;
                        }
                    }
                }
            }
        }

        return new SelectionValue($fieldValue);
    }

    /**
     * @param string $contentTypeIdentifier
     * @param string $fieldIdentifier
     * @return mixed
     */
    protected function loadFieldSettings($contentTypeIdentifier, $fieldIdentifier)
    {
        $contentTypeService = $this->repository->getContentTypeService();
        $contentType = $contentTypeService->loadContentTypeByIdentifier($contentTypeIdentifier);
        $fieldDefinition = $contentType->fieldDefinitionsByIdentifier[$fieldIdentifier];

The property fieldDefinitionsByIdentifier does not seem to exist. Did you mean fieldDefinitions?

        return $fieldDefinition->fieldSettings;
    }
}