Kaliop\eZMigrationBundle\Core\Matcher\LanguageMatcher

Complexity

Total Complexity

21

Size/Duplication

Total Lines	119
Duplicated Lines	100 %

Coupling/Cohesion

Components	1
Dependencies	6

Test Coverage

Coverage

0%

Importance

Changes

0

6 Methods

Rating	Name	Duplication	Size	Complexity
A	match()	4	4	1
B	matchLanguage()	33	33	11
A	getConditionsFromKey()	7	7	3
A	findLanguagesById()	12	12	2
A	findLanguagesByCode()	12	12	2
A	findAllLanguages()	11	11	2

<?php

namespace Kaliop\eZMigrationBundle\Core\Matcher;

use eZ\Publish\API\Repository\Values\Content\Language;
use Kaliop\eZMigrationBundle\API\Collection\LanguageCollection;
use Kaliop\eZMigrationBundle\API\KeyMatcherInterface;

class LanguageMatcher extends RepositoryMatcher implements KeyMatcherInterface

This class seems to be duplicated in your project.

{
    use FlexibleKeyMatcherTrait;

    const MATCH_LANGUAGE_ID = 'language_id';
    const MATCH_LANGUAGE_CODE = 'language_code';

    protected $allowedConditions = array(
        self::MATCH_ALL, self::MATCH_AND, self::MATCH_OR, self::MATCH_NOT,
        self::MATCH_LANGUAGE_ID, self::MATCH_LANGUAGE_CODE,
        // aliases
        'id', 'language'
    );
    protected $returns = 'Language';

    /**
     * @param array $conditions key: condition, value: int / string / int[] / string[]
     * @return LanguageCollection
     */
    public function match(array $conditions)
    {
        return $this->matchLanguage($conditions);
    }

    /**
     * @param array $conditions key: condition, value: int / string / int[] / string[]
     * @return LanguageCollection
     */
    public function matchLanguage(array $conditions)
    {
        $this->validateConditions($conditions);

        foreach ($conditions as $key => $values) {

            if (!is_array($values)) {
                $values = array($values);
            }

            switch ($key) {
                case 'id':
                case self::MATCH_LANGUAGE_ID:
                    return new LanguageCollection($this->findLanguagesById($values));

                case 'langauge_code':
                case self::MATCH_LANGUAGE_CODE:
                    return new LanguageCollection($this->findLanguagesByCode($values));

                case self::MATCH_ALL:
                    return new LanguageCollection($this->findAllLanguages());

                case self::MATCH_AND:
                    return $this->matchAnd($values);

The expression $this->matchAnd($values); of type object|array adds the type array to the return on line 60 which is incompatible with the return type documented by Kaliop\eZMigrationBundle\Core\Matcher\LanguageMatcher::matchLanguage of type Kaliop\eZMigrationBundle\API\Collection\LanguageCollection|null.

                case self::MATCH_OR:
                    return $this->matchOr($values);

The expression $this->matchOr($values); of type object|array adds the type array to the return on line 63 which is incompatible with the return type documented by Kaliop\eZMigrationBundle\Core\Matcher\LanguageMatcher::matchLanguage of type Kaliop\eZMigrationBundle\API\Collection\LanguageCollection|null.

                case self::MATCH_NOT:
                    return new LanguageCollection(array_diff_key($this->findAllLanguages(), $this->matchLanguage($values)->getArrayCopy()));
            }
        }
    }

    protected function getConditionsFromKey($key)
    {
        if (is_int($key) || ctype_digit($key)) {
            return array(self::MATCH_LANGUAGE_ID => $key);
        }
        return array(self::MATCH_LANGUAGE_CODE => $key);
    }

    /**
     * @param int[] $languageIds
     * @return Language[]
     */
    protected function findLanguagesById(array $languageIds)
    {
        $languages = [];

        foreach ($languageIds as $languageId) {
            // return unique contents
            $language = $this->repository->getContentLanguageService()->loadLanguageById($languageId);
            $languages[$language->id] = $language;
        }

        return $languages;
    }

    /**
     * @param string[] $languageIdentifiers
     * @return Language[]
     */
    protected function findLanguagesByCode(array $languageIdentifiers)
    {
        $languages = [];

        foreach ($languageIdentifiers as $languageIdentifier) {
            // return unique contents
            $language = $this->repository->getContentLanguageService()->loadLanguage($languageIdentifier);
            $languages[$language->id] = $language;
        }

        return $languages;
    }

    /**
     * @return Language[]
     */
    protected function findAllLanguages()
    {
        $languages = [];

        foreach ($this->repository->getLanguageService()->loadLanguages() as $language) {

The method getLanguageService() does not seem to exist on object<eZ\Publish\API\Repository\Repository>.

            // return unique contents
            $languages[$language->id] = $language;
        }

        return $languages;
    }
}