kaliop-uk / ezmigrationbundle

Core/Matcher/ContentMatcherDirectLoad.php

Spacing +2 added lines, -2 removed lines

@@ -22,13 +22,13 @@
             $contents = array();
             switch ($key) {
                 case self::MATCH_CONTENT_ID:
-                    foreach($match as $contentId) {
+                    foreach ($match as $contentId) {
                         $content = $this->repository->getContentService()->loadContent($contentId);
                         $contents[$content->id] = $content;
                     }
                     break;
                 case self::MATCH_CONTENT_REMOTE_ID:
-                    foreach($match as $contentRemoteId) {
+                    foreach ($match as $contentRemoteId) {
                         $content = $this->repository->getContentService()->loadContentByRemoteId($contentRemoteId);
                         $contents[$content->id] = $content;
                     }

Core/Matcher/LocationMatcherDirectLoad.php

Spacing +2 added lines, -2 removed lines

@@ -24,13 +24,13 @@
             $locations = array();
             switch ($key) {
                 case self::MATCH_LOCATION_ID:
-                    foreach($match as $locationId) {
+                    foreach ($match as $locationId) {
                         $location = $this->repository->getLocationService()->loadLocation($locationId);
                         $locations[$location->id] = $location;
                     }
                     break;
                 case self::MATCH_LOCATION_REMOTE_ID:
-                    foreach($match as $locationRemoteId) {
+                    foreach ($match as $locationRemoteId) {
                         $location = $this->repository->getLocationService()->loadLocationByRemoteId($locationRemoteId);
                         $locations[$location->id] = $location;
                     }

Core/Loader/FilesystemRecursive.php

Spacing +2 added lines, -2 removed lines

@@ -57,7 +57,7 @@ 
         if (empty($paths)) {
             $paths = array();
             /** @var $bundle \Symfony\Component\HttpKernel\Bundle\BundleInterface */
-            foreach($this->kernel->getBundles() as $bundle)
+            foreach ($this->kernel->getBundles() as $bundle)
             {
                 $path = $bundle->getPath() . "/" . $this->versionDirectory;
                 if (is_dir($path)) {
@@ -67,7 +67,7 @@ 
         }
 
         $definitions = array();
-        foreach($paths as $path) {
+        foreach ($paths as $path) {
             if (is_file($path)) {
                 $definitions[basename($path)] = $returnFilename ? $path : new MigrationDefinition(
                     basename($path),

Braces +1 added lines, -2 removed lines

@@ -60,8 +60,7 @@
                         }
                     }
                 }
-            }
-            else {
+            } else {
                 throw new \Exception("Path '$path' is neither a file nor directory");
             }
         }

Command/MassMigrateCommand.php

Doc Comments +1 added lines, -1 removed lines

@@ -331,7 +331,7 @@
 
     /**
      * @param string $paths
-     * @param $migrationService
+     * @param \Kaliop\eZMigrationBundle\Core\MigrationService $migrationService
      * @param bool $isChild when not in child mode, do not waste time parsing migrations
      * @return MigrationDefinition[] parsed or unparsed, depending on
      *

Spacing +16 added lines, -16 removed lines

@@ -89,7 +89,7 @@ 
             }
 
             $concurrency = $input->getOption('concurrency');
-            $this->writeln("Executing migrations using ".count($paths)." processes with a concurrency of $concurrency");
+            $this->writeln("Executing migrations using " . count($paths) . " processes with a concurrency of $concurrency");
 
             $kernel = $this->getContainer()->get('kernel');
             $builder = new ProcessBuilder();
@@ -110,23 +110,23 @@ 
                 $builderArgs[] = '--no-debug';
             }
             if ($input->getOption('default-language')) {
-                $builderArgs[]='--default-language='.$input->getOption('default-language');
+                $builderArgs[] = '--default-language=' . $input->getOption('default-language');
             }
             if ($input->getOption('no-transactions')) {
-                $builderArgs[]='--no-transactions';
+                $builderArgs[] = '--no-transactions';
             }
             if ($input->getOption('siteaccess')) {
-                $builderArgs[]='--siteaccess='.$input->getOption('siteaccess');
+                $builderArgs[] = '--siteaccess=' . $input->getOption('siteaccess');
             }
             if ($input->getOption('ignore-failures')) {
-                $builderArgs[]='--ignore-failures';
+                $builderArgs[] = '--ignore-failures';
             }
             if ($input->getOption('separate-process')) {
-                $builderArgs[]='--separate-process';
+                $builderArgs[] = '--separate-process';
             }
             $processes = array();
             /** @var MigrationDefinition $migrationDefinition */
-            foreach($paths as $path => $count) {
+            foreach ($paths as $path => $count) {
                 $this->writeln("<info>Queueing processing of: $path ($count migrations)</info>", OutputInterface::VERBOSITY_VERBOSE);
 
                 $process = $builder
@@ -163,11 +163,11 @@ 
 
             $time = microtime(true) - $start;
 
-            $this->writeln('<info>'.$this->migrationsDone[0].' migrations executed, '.$this->migrationsDone[1].' failed, '.$this->migrationsDone[2].' skipped</info>');
+            $this->writeln('<info>' . $this->migrationsDone[0] . ' migrations executed, ' . $this->migrationsDone[1] . ' failed, ' . $this->migrationsDone[2] . ' skipped</info>');
             $this->writeln("<info>Import finished</info>\n");
 
             // since we use subprocesses, we can not measure max memory used
-            $this->writeln("Time taken: ".sprintf('%.2f', $time)." secs");
+            $this->writeln("Time taken: " . sprintf('%.2f', $time) . " secs");
 
             return $failed;
 
@@ -206,7 +206,7 @@ 
             foreach ($toExecute as  $name => $migrationDefinition) {
                 // let's skip migrations that we know are invalid - user was warned and he decided to proceed anyway
                 if ($migrationDefinition->status == MigrationDefinition::STATUS_INVALID) {
-                    $this->writeln("<comment>Skipping migration (invalid definition?) Path: ".$migrationDefinition->path."</comment>", self::VERBOSITY_CHILD);
+                    $this->writeln("<comment>Skipping migration (invalid definition?) Path: " . $migrationDefinition->path . "</comment>", self::VERBOSITY_CHILD);
                     $skipped++;
                     continue;
                 }
@@ -280,7 +280,7 @@ 
                         );
 
                         $executed++;
-                    } catch(\Exception $e) {
+                    } catch (\Exception $e) {
                         $failed++;
                         if ($input->getOption('ignore-failures')) {
                             $this->writeln("<error>Migration failed! Path: " . $migrationDefinition->path . ", Reason: " . $e->getMessage() . "</error>", self::VERBOSITY_CHILD);
@@ -306,7 +306,7 @@ 
         }
     }
 
-    public function onSubProcessOutput($type, $buffer, $process=null)
+    public function onSubProcessOutput($type, $buffer, $process = null)
     {
         $lines = explode("\n", trim($buffer));
 
@@ -324,7 +324,7 @@ 
 
             // we tag the output from the different processes
             if (trim($line) !== '') {
-                echo '[' . ($process ? $process->getPid() : ''). '] ' . trim($line) . "\n";
+                echo '[' . ($process ? $process->getPid() : '') . '] ' . trim($line) . "\n";
             }
         }
     }
@@ -346,7 +346,7 @@ 
 
         // filter away all migrations except 'to do' ones
         $toExecute = array();
-        foreach($migrationDefinitions as $name => $migrationDefinition) {
+        foreach ($migrationDefinitions as $name => $migrationDefinition) {
             if (!isset($migrations[$name]) || (($migration = $migrations[$name]) && $migration->status == Migration::STATUS_TODO)) {
                 $toExecute[$name] = $isChild ? $migrationService->parseMigrationDefinition($migrationDefinition) : $migrationDefinition;
             }
@@ -388,7 +388,7 @@ 
     {
         $output->writeln('Found ' . count($toExecute) . ' migrations in ' . count($paths) . ' directories');
         $output->writeln('In the same directories, migrations previously executed: ' . $this->migrationsAlreadyDone[Migration::STATUS_DONE] .
-            ', failed: ' . $this->migrationsAlreadyDone[Migration::STATUS_FAILED] . ', skipped: '. $this->migrationsAlreadyDone[Migration::STATUS_SKIPPED]);
+            ', failed: ' . $this->migrationsAlreadyDone[Migration::STATUS_FAILED] . ', skipped: ' . $this->migrationsAlreadyDone[Migration::STATUS_SKIPPED]);
     }
 
     protected function askForConfirmation(InputInterface $input, OutputInterface $output)
@@ -419,7 +419,7 @@ 
     protected function groupMigrationsByPath($toExecute)
     {
         $paths = array();
-        foreach($toExecute as $name => $migrationDefinition) {
+        foreach ($toExecute as $name => $migrationDefinition) {
             $path = dirname($migrationDefinition->path);
             if (!isset($paths[$path])) {
                 $paths[$path] = 1;

Core/Helper/ProcessManager.php

Spacing +2 added lines, -2 removed lines

@@ -28,7 +28,7 @@ 
         $currentProcesses = array_splice($processesQueue, 0, $maxParallel);
         // start the initial stack of processes
         foreach ($currentProcesses as $process) {
-            $process->start(function ($type, $buffer) use ($callback, $process) {
+            $process->start(function($type, $buffer) use ($callback, $process) {
                 if ($callback) {
                     $callback($type, $buffer, $process);
                 }
@@ -44,7 +44,7 @@ 
                     // directly add and start new process after the previous finished
                     if (count($processesQueue) > 0) {
                         $nextProcess = array_shift($processesQueue);
-                        $nextProcess->start(function ($type, $buffer) use ($callback, $nextProcess) {
+                        $nextProcess->start(function($type, $buffer) use ($callback, $nextProcess) {
                             if ($callback) {
                                 $callback($type, $buffer, $nextProcess);
                             }

Command/MigrateCommand.php

Spacing +3 added lines, -3 removed lines

@@ -124,7 +124,7 @@ 
                 $builderArgs[] = '--no-transactions';
             }
             if ($input->getOption('siteaccess')) {
-                $builderArgs[]='--siteaccess='.$input->getOption('siteaccess');
+                $builderArgs[] = '--siteaccess=' . $input->getOption('siteaccess');
             }
         }
 
@@ -233,9 +233,9 @@ 
         $this->writeln("Executed $executed migrations, failed $failed, skipped $skipped");
         if ($input->getOption('separate-process')) {
             // in case of using subprocesses, we can not measure max memory used
-            $this->writeln("Time taken: ".sprintf('%.2f', $time)." secs");
+            $this->writeln("Time taken: " . sprintf('%.2f', $time) . " secs");
         } else {
-            $this->writeln("Time taken: ".sprintf('%.2f', $time)." secs, memory: ".sprintf('%.2f', (memory_get_peak_usage(true) / 1000000)). ' MB');
+            $this->writeln("Time taken: " . sprintf('%.2f', $time) . " secs, memory: " . sprintf('%.2f', (memory_get_peak_usage(true) / 1000000)) . ' MB');
         }
     }
 

Core/Executor/ServiceExecutor.php

Spacing +1 added lines, -1 removed lines

@@ -74,7 +74,7 @@
         } else {
             $args = array();
         }
-        foreach($args as &$val) {
+        foreach ($args as &$val) {
             $val = $this->resolveReferencesRecursively($val);
         }
 

Core/Executor/FileExecutor.php

Doc Comments +4 added lines, -4 removed lines

@@ -68,7 +68,7 @@ 
     /**
      * @param array $dsl
      * @param array $context
-     * @return string
+     * @return boolean
      * @throws \Exception
      */
     protected function exists($dsl, $context)
@@ -196,7 +196,7 @@ 
     /**
      * @param array $dsl
      * @param array $context
-     * @return true
+     * @return boolean
      * @throws \Exception
      */
     protected function copy($dsl, $context)
@@ -228,7 +228,7 @@ 
     /**
      * @param array $dsl
      * @param array $context
-     * @return true
+     * @return boolean
      * @throws \Exception
      */
     protected function move($dsl, $context)
@@ -260,7 +260,7 @@ 
     /**
      * @param array $dsl
      * @param array $context
-     * @return true
+     * @return boolean
      * @throws \Exception
      */
     protected function delete($dsl, $context)

Core/ReferenceResolver/EmbeddedRegexpReferenceResolverTrait.php

Spacing +2 added lines, -2 removed lines

@@ -18,7 +18,7 @@ 
     public function hasEmbeddedReferences($string)
     {
         $regexp = $this->getEmbeddedRegexp();
-        return (bool) preg_match_all($regexp, $string, $matches);
+        return (bool)preg_match_all($regexp, $string, $matches);
     }
     
     /**
@@ -52,7 +52,7 @@ 
     {
         // we need to alter the regexp we usr for std ref resolving, as it will be used to match parts of text, not the whole string
         $regexp = substr($this->getRegexp(), 1, -1);
-        return '/' . preg_quote($this->beginToken). preg_replace(array('/^\^/'), array(''), $regexp) . '[^' . $this->endToken . ']+' . preg_quote($this->endToken) . '/';
+        return '/' . preg_quote($this->beginToken) . preg_replace(array('/^\^/'), array(''), $regexp) . '[^' . $this->endToken . ']+' . preg_quote($this->endToken) . '/';
     }
 
     /**