kaliop-uk / ezmigrationbundle

Core/Executor/MailExecutor.php

Doc Comments +1 added lines, -1 removed lines

@@ -48,7 +48,7 @@
     /**
      * @param array $dsl
      * @param array $context
-     * @return true
+     * @return boolean
      * @throws \Exception
      */
     protected function send($dsl, $context)

Core/Executor/HTTPExecutor.php

Spacing +1 added lines, -1 removed lines

@@ -67,7 +67,7 @@
         $body = isset($dsl['body']) ? $this->resolveReferencesInText($dsl['body']) : null;
 
         if (isset($dsl['client'])) {
-            $client = $this->container->get('httplug.client.'.$dsl['client']);
+            $client = $this->container->get('httplug.client.' . $dsl['client']);
         } else {
             $client = $this->container->get('httplug.client');
         }

Core/StorageHandler/Database/Migration.php

Doc Comments +3 added lines

@@ -447,6 +447,9 @@
         );
     }
 
+    /**
+     * @param APIMigration $migration
+     */
     protected function getEntityName($migration)
     {
         return end(explode('\\', get_class($migration)));

Spacing +5 added lines, -5 removed lines

@@ -171,7 +171,7 @@ 
     public function endMigration(APIMigration $migration, $force = false)
     {
         if ($migration->status == APIMigration::STATUS_STARTED) {
-            throw new \Exception($this->getEntityName($migration)." '{$migration->name}' can not be ended as its status is 'started'...");
+            throw new \Exception($this->getEntityName($migration) . " '{$migration->name}' can not be ended as its status is 'started'...");
         }
 
         $this->createTableIfNeeded();
@@ -198,13 +198,13 @@ 
         if (!is_array($existingMigrationData)) {
             // commit to release the lock
             $conn->commit();
-            throw new \Exception($this->getEntityName($migration)." '{$migration->name}' can not be ended as it is not found");
+            throw new \Exception($this->getEntityName($migration) . " '{$migration->name}' can not be ended as it is not found");
         }
 
         if (($existingMigrationData['status'] != APIMigration::STATUS_STARTED) && !$force) {
             // commit to release the lock
             $conn->commit();
-            throw new \Exception($this->getEntityName($migration)." '{$migration->name}' can not be ended as it is not executing");
+            throw new \Exception($this->getEntityName($migration) . " '{$migration->name}' can not be ended as it is not executing");
         }
 
         $conn->update(
@@ -355,7 +355,7 @@ 
         if (!is_array($existingMigrationData)) {
             // commit immediately, to release the lock and avoid deadlocks
             $conn->commit();
-            throw new \Exception($this->getEntityName($migration)." '{$migration->name}' can not be resumed as it is not found");
+            throw new \Exception($this->getEntityName($migration) . " '{$migration->name}' can not be resumed as it is not found");
         }
 
         // migration exists
@@ -364,7 +364,7 @@ 
         if ($existingMigrationData['status'] != APIMigration::STATUS_SUSPENDED) {
             // commit to release the lock
             $conn->commit();
-            throw new \Exception($this->getEntityName($migration)." '{$migration->name}' can not be resumed as it is not suspended");
+            throw new \Exception($this->getEntityName($migration) . " '{$migration->name}' can not be resumed as it is not suspended");
         }
 
         $migration = new APIMigration(

Unused Use Statements -1 removed lines

@@ -10,7 +10,6 @@
 use Kaliop\eZMigrationBundle\API\Collection\MigrationCollection;
 use Kaliop\eZMigrationBundle\API\Value\Migration as APIMigration;
 use Kaliop\eZMigrationBundle\API\Value\MigrationDefinition;
-
 use Kaliop\eZMigrationBundle\API\ConfigResolverInterface;
 
 /**

Core/Executor/ProcessExecutor.php

Spacing +1 added lines, -1 removed lines

@@ -63,7 +63,7 @@
         $builderArgs = array($this->referenceResolver->resolveReference($dsl['command']));
 
         if (isset($dsl['arguments'])) {
-            foreach($dsl['arguments'] as $arg) {
+            foreach ($dsl['arguments'] as $arg) {
                 $builderArgs[] = $this->referenceResolver->resolveReference($arg);
             }
         }

Command/ResumeCommand.php

Spacing +2 added lines, -2 removed lines

@@ -93,7 +93,7 @@ 
         $executed = 0;
         $failed = 0;
 
-        foreach($suspendedMigrations as $suspendedMigration) {
+        foreach ($suspendedMigrations as $suspendedMigration) {
             $output->writeln("<info>Resuming {$suspendedMigration->name}</info>");
 
             try {
@@ -113,7 +113,7 @@ 
 
         $time = microtime(true) - $start;
         $output->writeln("Resumed $executed migrations, failed $failed");
-        $output->writeln("Time taken: ".sprintf('%.2f', $time)." secs, memory: ".sprintf('%.2f', (memory_get_peak_usage(true) / 1000000)). ' MB');
+        $output->writeln("Time taken: " . sprintf('%.2f', $time) . " secs, memory: " . sprintf('%.2f', (memory_get_peak_usage(true) / 1000000)) . ' MB');
 
         if ($failed) {
             return 2;

Core/Matcher/ContentMatcher.php

Spacing +5 added lines, -5 removed lines

@@ -46,15 +46,15 @@ 
 
         foreach ($conditions as $key => $values) {
 
-            switch($key) {
+            switch ($key) {
 
                 case self::MATCH_RELATES_TO:
                     $contentService = $this->repository->getContentService();
                     $contents = array();
                     // allow to specify the objects to relate to using different ways
                     $relatedContents = $this->match($values);
-                    foreach($relatedContents as $relatedContent) {
-                        foreach($contentService->loadReverseRelations($relatedContent->contentInfo) as $relatingContent) {
+                    foreach ($relatedContents as $relatedContent) {
+                        foreach ($contentService->loadReverseRelations($relatedContent->contentInfo) as $relatingContent) {
                             $contents[$relatingContent->contentInfo->id] = $relatingContent;
                         }
                     }
@@ -65,8 +65,8 @@ 
                     $contents = array();
                     // allow to specify the objects we relate to using different ways
                     $relatingContents = $this->match($values);
-                    foreach($relatingContents as $relatingContent) {
-                        foreach($contentService->loadRelations($relatingContent->contentInfo) as $relatedContent) {
+                    foreach ($relatingContents as $relatingContent) {
+                        foreach ($contentService->loadRelations($relatingContent->contentInfo) as $relatedContent) {
                             $contents[$relatedContent->contentInfo->id] = $relatedContent;
                         }
                     }

Braces +12 added lines, -4 removed lines

@@ -85,7 +85,9 @@ 
 
                     $query = new Query();
                     $query->limit = self::INT_MAX_16BIT;
-                    if (isset($query->performCount)) $query->performCount = false;
+                    if (isset($query->performCount)) {
+                        $query->performCount = false;
+                    }
                     $query->filter = $this->getQueryCriterion($key, $values);
                     switch ($key) {
                         case 'content_type_id':
@@ -206,7 +208,9 @@ 
     {
         $query = new Query();
         $query->limit = self::INT_MAX_16BIT;
-        if (isset($query->performCount)) $query->performCount = false;
+        if (isset($query->performCount)) {
+            $query->performCount = false;
+        }
         $query->filter = new Query\Criterion\ParentLocationId($parentLocationIds);
         $results = $this->repository->getSearchService()->findContent($query);
 
@@ -246,7 +250,9 @@ 
     {
         $query = new Query();
         $query->limit = self::INT_MAX_16BIT;
-        if (isset($query->performCount)) $query->performCount = false;
+        if (isset($query->performCount)) {
+            $query->performCount = false;
+        }
         $query->filter = new Query\Criterion\ContentTypeIdentifier($contentTypeIdentifiers);
         // sort objects by depth, lower to higher, so that deleting them has less chances of failure
         // NB: we only do this in eZP versions that allow depth sorting on content queries
@@ -274,7 +280,9 @@ 
     {
         $query = new Query();
         $query->limit = self::INT_MAX_16BIT;
-        if (isset($query->performCount)) $query->performCount = false;
+        if (isset($query->performCount)) {
+            $query->performCount = false;
+        }
         $query->filter = new Query\Criterion\ContentTypeId($contentTypeIds);
         // sort objects by depth, lower to higher, so that deleting them has less chances of failure
         // NB: we only do this in eZP versions that allow depth sorting on content queries

Core/Executor/RepositoryExecutor.php

Spacing +2 added lines, -2 removed lines

@@ -161,7 +161,7 @@ 
     {
         // allow setting *some* refs even when we have 0 or N matches
         foreach ($referencesDefinition as $key => $reference) {
-            switch($reference['attribute']) {
+            switch ($reference['attribute']) {
 
                 case 'count':
                     $value = count($entity);
@@ -197,7 +197,7 @@ 
                     throw new \InvalidArgumentException($this->getSelfName() . ' does not support setting references for multiple ' . $this->getCollectionName($entity) . 's');
                 }
                 if (count($entity) == 0) {
-                    throw new \InvalidArgumentException($this->getSelfName() . ' does not support setting references for no ' . $this->getCollectionName($entity). 's');
+                    throw new \InvalidArgumentException($this->getSelfName() . ' does not support setting references for no ' . $this->getCollectionName($entity) . 's');
                 }
             }
 

Core/FieldHandler/EzDateAndTime.php

Spacing +7 added lines, -7 removed lines

@@ -58,26 +58,26 @@
     {
         $format = array();
         if (0 != $dateInterval->y) {
-            $format[] = $dateInterval->y.' years';
+            $format[] = $dateInterval->y . ' years';
         }
         if (0 != $dateInterval->m) {
-            $format[] = $dateInterval->m.' months';
+            $format[] = $dateInterval->m . ' months';
         }
         if (0 != $dateInterval->d) {
-            $format[] = $dateInterval->d.' days';
+            $format[] = $dateInterval->d . ' days';
         }
         //if (0 < $dateInterval->h || 0 < $dateInterval->i || 0 < $dateInterval->s) {
         //    $format .= 'T';
         //}
         if (0 != $dateInterval->h) {
-            $format[] = $dateInterval->h.' hours';
+            $format[] = $dateInterval->h . ' hours';
         }
         if (0 != $dateInterval->i) {
-            $format[] = $dateInterval->i.' minutes';
+            $format[] = $dateInterval->i . ' minutes';
         }
         if (0 != $dateInterval->s) {
-            $format[] = $dateInterval->s.' seconds';
+            $format[] = $dateInterval->s . ' seconds';
         }
-        return implode( ', ', $format);
+        return implode(', ', $format);
     }
 }

Core/Executor/ContentVersionManager.php

Spacing +3 added lines, -3 removed lines

@@ -29,18 +29,18 @@
         $versions = (array)$step->dsl['versions'];
 
         foreach ($contentCollection as $content) {
-            foreach($versions as $versionId) {
+            foreach ($versions as $versionId) {
                 try {
                     if ($versionId < 0) {
                         $contentVersions = $contentService->loadVersions($content->contentInfo);
                         // different eZ kernels apparently sort versions in different order...
                         $sortedVersions = array();
-                        foreach($contentVersions as $versionInfo) {
+                        foreach ($contentVersions as $versionInfo) {
                             $sortedVersions[$versionInfo->versionNo] = $versionInfo;
                         }
                         ksort($sortedVersions);
                         $sortedVersions = array_slice($sortedVersions, 0, $versionId);
-                        foreach($sortedVersions as $versionInfo) {
+                        foreach ($sortedVersions as $versionInfo) {
                             $contentService->deleteVersion($versionInfo);
                         }
                     } else {