kaliop-uk / ezmigrationbundle

Core/ReferenceResolver/LocationResolver.php

Spacing +1 added lines, -1 removed lines

@@ -34,7 +34,7 @@
     public function getReferenceValue($stringIdentifier)
     {
         $ref = $this->getReferenceIdentifierByPrefix($stringIdentifier);
-        switch($ref['prefix']) {
+        switch ($ref['prefix']) {
             case 'content_remote_id:':
                 return $this->repository->getContentService()->loadContentByRemoteId($ref['identifier'])->id;
             //case 'content_id::':

Core/Executor/RoleManager.php

Spacing +4 added lines, -4 removed lines

@@ -42,7 +42,7 @@ 
 
         if (array_key_exists('policies', $this->dsl)) {
             $ymlPolicies = $this->dsl['policies'];
-            foreach($ymlPolicies as $key => $ymlPolicy) {
+            foreach ($ymlPolicies as $key => $ymlPolicy) {
                 $this->addPolicy($role, $roleService, $ymlPolicy);
             }
         }
@@ -82,11 +82,11 @@ 
                 // Removing all policies so we can add them back.
                 // TODO: Check and update policies instead of remove and add.
                 $policies = $role->getPolicies();
-                foreach($policies as $policy) {
+                foreach ($policies as $policy) {
                     $roleService->deletePolicy($policy);
                 }
 
-                foreach($ymlPolicies as $key => $ymlPolicy) {
+                foreach ($ymlPolicies as $key => $ymlPolicy) {
                     $this->addPolicy($role, $roleService, $ymlPolicy);
                 }
             }
@@ -175,7 +175,7 @@ 
 
         $limitationValue = is_array($limitation['values']) ? $limitation['values'] : array($limitation['values']);
 
-        foreach($limitationValue as $id => $value) {
+        foreach ($limitationValue as $id => $value) {
             if ($this->referenceResolver->isReference($value)) {
                 $value = $this->referenceResolver->getReferenceValue($value);
                 $limitationValue[$id] = $value;

Command/GenerateCommand.php

Spacing +3 added lines, -3 removed lines

@@ -80,7 +80,7 @@ 
         }
 
         $activeBundles = array();
-        foreach($this->getApplication()->getKernel()->getBundles() as $bundle)
+        foreach ($this->getApplication()->getKernel()->getBundles() as $bundle)
         {
             $activeBundles[] = $bundle->getName();
         }
@@ -155,7 +155,7 @@ 
                     $className = 'Migration';
                 }
                 // Make sure that php class names are unique, not only migration definition file names
-                $existingMigrations = count(glob($migrationDirectory.'/*_' . $className .'*.php'));
+                $existingMigrations = count(glob($migrationDirectory . '/*_' . $className . '*.php'));
                 if ($existingMigrations) {
                     $className = $className . sprintf('%03d', $existingMigrations + 1);
                 }
@@ -201,7 +201,7 @@ 
         if ($migrationType == 'role') {
             $code = $this->generateRoleTemplate($parameters['role']);
         } else {
-            $code = $this->getContainer()->get('twig')->render($this->thisBundle . ':MigrationTemplate:'.$template, $parameters);
+            $code = $this->getContainer()->get('twig')->render($this->thisBundle . ':MigrationTemplate:' . $template, $parameters);
         }
 
         file_put_contents($path, $code);

Core/Executor/ContentManager.php

Spacing +3 added lines, -3 removed lines

@@ -177,7 +177,7 @@ 
             }
 
             $draft = $contentService->createContentDraft($contentInfo);
-            $contentService->updateContent($draft->versionInfo,$contentUpdateStruct);
+            $contentService->updateContent($draft->versionInfo, $contentUpdateStruct);
             $content = $contentService->publishVersion($draft->versionInfo);
 
             if (array_key_exists('new_remote_id', $this->dsl)) {
@@ -221,7 +221,7 @@ 
      * @param ContentCreateStruct $createStruct
      * @param array $fields
      */
-    protected function setFields(ContentCreateStruct &$createStruct, array $fields)
+    protected function setFields(ContentCreateStruct & $createStruct, array $fields)
     {
         foreach ($fields as $field) {
             // each $field is one key value pair
@@ -248,7 +248,7 @@ 
      * @param ContentUpdateStruct $updateStruct
      * @param array $fields
      */
-    protected function setFieldsToUpdate(ContentUpdateStruct &$updateStruct, array $fields, ContentType $contentType)
+    protected function setFieldsToUpdate(ContentUpdateStruct & $updateStruct, array $fields, ContentType $contentType)
     {
         foreach ($fields as $field) {
             // each $field is one key value pair

Core/StorageHandler/Database.php

Doc Comments +1 added lines, -1 removed lines

@@ -98,7 +98,7 @@
     /**
      * Creates and stores a new migration (leaving it in TODO status)
      * @param MigrationDefinition $migrationDefinition
-     * @return mixed
+     * @return Migration
      * @throws \Exception If the migration exists already (we rely on the PK for that)
      */
     public function addMigration(MigrationDefinition $migrationDefinition)

Spacing +3 added lines, -3 removed lines

@@ -116,7 +116,7 @@ 
         );
         try {
             $conn->insert($this->migrationsTableName, $this->migrationToArray($migration));
-        } catch(UniqueConstraintViolationException $e) {
+        } catch (UniqueConstraintViolationException $e) {
             throw new \Exception("Migration '{$migrationDefinition->name}' already exists");
         }
 
@@ -311,7 +311,7 @@ 
         $t->addColumn('execution_error', 'string', array('length' => 4000, 'notnull' => false));
         $t->setPrimaryKey(array('migration'));
 
-        foreach($schema->toSql($dbPlatform) as $sql) {
+        foreach ($schema->toSql($dbPlatform) as $sql) {
             $this->dbHandler->exec($sql);
         }
     }
@@ -326,7 +326,7 @@ 
     {
         /** @var \Doctrine\DBAL\Schema\AbstractSchemaManager $sm */
         $sm = $this->dbHandler->getConnection()->getSchemaManager();
-        foreach($sm->listTables() as $table) {
+        foreach ($sm->listTables() as $table) {
             if ($table->getName() == $tableName) {
                 return true;
             }

Command/MigrationCommand.php

Spacing +2 added lines, -2 removed lines

@@ -49,7 +49,7 @@ 
      */
     protected function execute(InputInterface $input, OutputInterface $output)
     {
-        if (! $input->getOption('add') && ! $input->getOption('delete')) {
+        if (!$input->getOption('add') && !$input->getOption('delete')) {
             throw new \InvalidArgumentException('You must specify whether you want to --add or --delete the specified migration.');
         }
 
@@ -79,7 +79,7 @@ 
                 throw new \InvalidArgumentException(sprintf('The path "%s" does not correspond to any migration definition.', $migrationNameOrPath));
             }
 
-            foreach($migrationDefinitionCollection as $migrationDefinition) {
+            foreach ($migrationDefinitionCollection as $migrationDefinition) {
                 $migrationName = basename($migrationDefinition->path);
 
                 $migration = $migrationService->getMigration($migrationNameOrPath);

Command/MigrateCommand.php

Spacing +6 added lines, -6 removed lines

@@ -67,7 +67,7 @@ 
 
         // filter away all migrations except 'to do' ones
         $toExecute = array();
-        foreach($migrationDefinitions as $name => $migrationDefinition) {
+        foreach ($migrationDefinitions as $name => $migrationDefinition) {
             if (!isset($migrations[$name]) || (($migration = $migrations[$name]) && $migration->status == Migration::STATUS_TODO)) {
                 $toExecute[$name] = $migrationsService->parseMigrationDefinition($migrationDefinition);
             }
@@ -100,7 +100,7 @@ 
 
         $data = array();
         $i = 1;
-        foreach($toExecute as $name => $migrationDefinition) {
+        foreach ($toExecute as $name => $migrationDefinition) {
             $notes = '';
             if ($migrationDefinition->status != MigrationDefinition::STATUS_PARSED) {
                 $notes = '<error>' . $migrationDefinition->parsingError . '</error>';
@@ -135,7 +135,7 @@ 
             $output->writeln("=============================================\n");
         }
 
-        foreach($toExecute as $name => $migrationDefinition) {
+        foreach ($toExecute as $name => $migrationDefinition) {
 
             // let's skip migrations that we know are invalid - user was warned and he decided to proceed anyway
             if ($migrationDefinition->status == MigrationDefinition::STATUS_INVALID) {
@@ -147,12 +147,12 @@ 
 
             try {
                 $migrationsService->executeMigration($migrationDefinition);
-            } catch(\Exception $e) {
+            } catch (\Exception $e) {
                 if ($input->getOption('ignore-failures')) {
-                    $output->writeln("\n<error>Migration failed! Reason: ".$this->getFullExceptionMessage($e)."</error>\n");
+                    $output->writeln("\n<error>Migration failed! Reason: " . $this->getFullExceptionMessage($e) . "</error>\n");
                     continue;
                 }
-                $output->writeln("\n<error>Migration aborted! Reason: ".$this->getFullExceptionMessage($e)."</error>");
+                $output->writeln("\n<error>Migration aborted! Reason: " . $this->getFullExceptionMessage($e) . "</error>");
                 return 1;
             }
 

Tests/bootstrap.php

Spacing +1 added lines, -1 removed lines

@@ -1,7 +1,7 @@
 <?php
 
 // try to load autoloade both when extension is top-level project and when it is installed as part of a working eZPUblish
-if (!file_exists($file = __DIR__.'/../vendor/autoload.php') && !file_exists($file = __DIR__.'/../../../../vendor/autoload.php')) {
+if (!file_exists($file = __DIR__ . '/../vendor/autoload.php') && !file_exists($file = __DIR__ . '/../../../../vendor/autoload.php')) {
     throw new \RuntimeException('Install the dependencies to run the test suite.');
 }
 

Tests/phpunit/1_GenerateTest.php

Spacing +2 added lines, -2 removed lines

@@ -1,6 +1,6 @@ 
 <?php
 
-include_once(__DIR__.'/CommandTest.php');
+include_once(__DIR__ . '/CommandTest.php');
 
 use Symfony\Component\Console\Input\ArrayInput;
 
@@ -64,6 +64,6 @@ 
         $exitCode = $this->app->run($input, $this->output);
         $output = $this->output->fetch();
         $this->assertSame(0, $exitCode);
-        $this->assertRegExp('?\| ' . basename($filePath) . ' +\| not executed \|?', $output );
+        $this->assertRegExp('?\| ' . basename($filePath) . ' +\| not executed \|?', $output);
     }
 }

Doc Comments +6 added lines

@@ -48,6 +48,9 @@ 
         $this->checkGeneratedFile($this->saveGeneratedFile($output));
     }
 
+    /**
+     * @param null|string $output
+     */
     protected function saveGeneratedFile($output)
     {
 var_dump($output);
@@ -59,6 +62,9 @@ 
         return null;
     }
 
+    /**
+     * @param string|null $filePath
+     */
     protected function checkGeneratedFile($filePath)
     {
         $input = new ArrayInput(array('command' => 'kaliop:migration:status'));