kaliop-uk / ezmigrationbundle

Core/Executor/UserGroupManager.php

Spacing +1 added lines, -1 removed lines

@@ -129,7 +129,7 @@
             $groupIds = array($groupIds);
         }
 
-        foreach($groupIds as $groupId) {
+        foreach ($groupIds as $groupId) {
             $userGroup = $userService->loadUserGroup($groupId);
             $userService->deleteUserGroup($userGroup);
         }

Core/Loader/Filesystem.php

Spacing +2 added lines, -2 removed lines

@@ -57,7 +57,7 @@ 
         if (empty($paths)) {
             $paths = array();
             /** @var $bundle \Symfony\Component\HttpKernel\Bundle\BundleInterface */
-            foreach($this->kernel->getBundles() as $bundle)
+            foreach ($this->kernel->getBundles() as $bundle)
             {
                 $path = $bundle->getPath() . "/" . $this->versionDirectory;
                 if (is_dir($path)) {
@@ -67,7 +67,7 @@ 
         }
 
         $definitions = array();
-        foreach($paths as $path) {
+        foreach ($paths as $path) {
             if (is_file($path)) {
                 $definitions[basename($path)] = $returnFilename ? $path : new MigrationDefinition(
                     basename($path),

Braces +1 added lines, -2 removed lines

@@ -85,8 +85,7 @@
                             );
                     }
                 }
-            }
-            else {
+            } else {
                 throw new \Exception("Path '$path' is neither a file nor directory");
             }
         }

Core/MigrationService.php

Spacing +7 added lines, -7 removed lines

@@ -43,7 +43,7 @@ 
 
     public function addExecutor(ExecutorInterface $executor)
     {
-        foreach($executor->supportedTypes() as $type) {
+        foreach ($executor->supportedTypes() as $type) {
             $this->executors[$type] = $executor;
         }
     }
@@ -58,8 +58,8 @@ 
     {
         // we try to be flexible in file types we support, and the same time avoid loading all files in a directory
         $handledDefinitions = array();
-        foreach($this->loader->listAvailableDefinitions($paths) as $migrationName => $definitionPath) {
-            foreach($this->DefinitionParsers as $definitionParser) {
+        foreach ($this->loader->listAvailableDefinitions($paths) as $migrationName => $definitionPath) {
+            foreach ($this->DefinitionParsers as $definitionParser) {
                 if ($definitionParser->supports($migrationName)) {
                     $handledDefinitions[] = $definitionPath;
                 }
@@ -106,13 +106,13 @@ 
      */
     public function parseMigrationDefinition(MigrationDefinition $migrationDefinition)
     {
-        foreach($this->DefinitionParsers as $definitionParser) {
+        foreach ($this->DefinitionParsers as $definitionParser) {
             if ($definitionParser->supports($migrationDefinition->name)) {
                 // parse the source file
                 $migrationDefinition = $definitionParser->parseMigrationDefinition($migrationDefinition);
 
                 // and make sure we know how to handle all steps
-                foreach($migrationDefinition->steps as $step) {
+                foreach ($migrationDefinition->steps as $step) {
                     if (!isset($this->executors[$step->type])) {
                         return new MigrationDefinition(
                             $migrationDefinition->name,
@@ -154,7 +154,7 @@ 
         $this->repository->beginTransaction();
         try {
 
-            foreach($migrationDefinition->steps as $step) {
+            foreach ($migrationDefinition->steps as $step) {
                 // we validated the fact that we have a good executor at parsing time
                 $executor = $this->executors[$step->type];
                 $executor->execute($step);
@@ -173,7 +173,7 @@ 
 
             $this->repository->commit();
 
-        } catch(\Exception $e) {
+        } catch (\Exception $e) {
             $this->repository->rollBack();
 
             /// set migration as failed

Doc Comments -1 removed lines

@@ -94,7 +94,6 @@
     }
 
     /**
-     * @param Migration $migration
      */
     public function addMigration(MigrationDefinition $migrationDefinition)
     {

Core/ComplexField/EzBinaryFile.php

Spacing +1 added lines, -1 removed lines

@@ -14,7 +14,7 @@
      */
     public function createValue(array $fieldValueArray, array $context = array())
     {
-        $filePath = dirname($context['path']) .  '/files/' . $fieldValueArray['path'];
+        $filePath = dirname($context['path']) . '/files/' . $fieldValueArray['path'];
 
         return new BinaryFileValue(
             array(

Core/ComplexField/EzAuthor.php

Spacing +1 added lines, -1 removed lines

@@ -19,7 +19,7 @@
     public function createValue(array $fieldValueArray, array $context = array())
     {
         $authors = array();
-        foreach($fieldValueArray['authors'] as $author) {
+        foreach ($fieldValueArray['authors'] as $author) {
             $authors[] = new Author($author);
         }
 

Core/ComplexField/ComplexFieldManager.php

Braces +1 added lines, -2 removed lines

@@ -32,8 +32,7 @@
         {
             $fieldService = $this->fieldTypeMap[$fieldTypeIdentifier];
             return $fieldService->createValue($fieldValueArray, $context);
-        }
-        else
+        } else
         {
             throw new \InvalidArgumentException("Field of type '$fieldTypeIdentifier' can not be handled as it does not have a complex field class defined");
         }

Core/DefinitionParser/YamlDefinitionParser.php

Spacing +3 added lines, -3 removed lines

@@ -41,7 +41,7 @@ 
     {
         try {
             $data = Yaml::parse($definition->rawDefinition);
-        } catch(\Exception $e) {
+        } catch (\Exception $e) {
             return new MigrationDefinition(
                 $definition->name,
                 $definition->path,
@@ -62,7 +62,7 @@ 
             $status = MigrationDefinition::STATUS_INVALID;
             $message = "Yaml migration file '{$definition->path}' must contain an array as top element";
         } else {
-            foreach($data as $i => $stepDef) {
+            foreach ($data as $i => $stepDef) {
                 if (!isset($stepDef['type']) || !is_string($stepDef['type'])) {
                     $status = MigrationDefinition::STATUS_INVALID;
                     $message = "Yaml migration file '{$definition->path}' misses or has a non-string 'type' element in step $i";
@@ -84,7 +84,7 @@ 
         }
 
         $stepDefs = array();
-        foreach($data as $stepDef) {
+        foreach ($data as $stepDef) {
             $type = $stepDef['type'];
             unset($stepDef['type']);
             $stepDefs[] = new MigrationStep($type, $stepDef, array('path' => $definition->path));

Core/ReferenceResolver/ContentResolver.php

Spacing +1 added lines, -1 removed lines

@@ -34,7 +34,7 @@
     public function getReferenceValue($stringIdentifier)
     {
         $ref = $this->getReferenceIdentifierByPrefix($stringIdentifier);
-        switch($ref['prefix']) {
+        switch ($ref['prefix']) {
             case 'content_remote_id:':
                 return $this->repository->getContentService()->loadContentByRemoteId($ref['identifier'])->id;
             //case 'content_id::':

Core/ReferenceResolver/AbstractResolver.php

Spacing +2 added lines, -2 removed lines

@@ -15,7 +15,7 @@ 
     public function __construct()
     {
         $quotedPrefixes = [];
-        foreach($this->referencePrefixes as $prefix) {
+        foreach ($this->referencePrefixes as $prefix) {
             $quotedPrefixes[] = preg_quote($prefix, '/');
         }
         $this->prefixMatchRegexp = '/^(' . implode('|', $quotedPrefixes) . ')/';
@@ -55,7 +55,7 @@ 
      */
     protected function getReferenceIdentifierByPrefix($stringIdentifier)
     {
-        foreach($this->referencePrefixes as $prefix) {
+        foreach ($this->referencePrefixes as $prefix) {
             $regexp = '/^' . preg_quote($prefix, '/') . '/';
             if (preg_match($regexp, $stringIdentifier)) {
                 return array('prefix' => $prefix, 'identifier' => preg_replace($regexp, '', $stringIdentifier));