kaliop-uk /
ezmigrationbundle
| Conditions | 21 |
| Paths | 348 |
| Total Lines | 107 |
| Code Lines | 65 |
| Lines | 14 |
| Ratio | 13.08 % |
| Changes | 4 | ||
| Bugs | 2 | Features | 2 |
Small methods make your code easier to understand, in particular if combined with a good name. Besides, if your method is small, finding a good name is usually much easier.
For example, if you find yourself adding comments to a method's body, this is usually a good sign to extract the commented part to a new method, and use the comment as a starting point when coming up with a good name for this new method.
Commonly applied refactorings include:
If many parameters/temporary variables are present:
| 1 | <?php |
||
| 61 | protected function execute(InputInterface $input, OutputInterface $output) |
||
| 62 | { |
||
| 63 | $migrationsService = $this->getMigrationService(); |
||
| 64 | |||
| 65 | $migrationDefinitions = $migrationsService->getMigrationsDefinitions($input->getOption('path')); |
||
| 66 | $migrations = $migrationsService->getMigrations(); |
||
| 67 | |||
| 68 | // filter away all migrations except 'to do' ones |
||
| 69 | $toExecute = array(); |
||
| 70 | foreach($migrationDefinitions as $name => $migrationDefinition) { |
||
| 71 | if (!isset($migrations[$name]) || (($migration = $migrations[$name]) && $migration->status == Migration::STATUS_TODO)) { |
||
| 72 | $toExecute[$name] = $migrationsService->parseMigrationDefinition($migrationDefinition); |
||
| 73 | } |
||
| 74 | } |
||
| 75 | |||
| 76 | // if user wants to execute 'all' migrations: look for some which are registered in the database even if not |
||
| 77 | // found by the loader |
||
| 78 | if (empty($input->getOption('path'))) { |
||
| 79 | foreach ($migrations as $migration) { |
||
| 80 | if ($migration->status == Migration::STATUS_TODO && !isset($toExecute[$migration->name])) { |
||
| 81 | $migrationDefinitions = $migrationsService->getMigrationsDefinitions(array($migration->path)); |
||
| 82 | if (count($migrationDefinitions)) { |
||
| 83 | $migrationDefinition = reset($migrationDefinitions); |
||
| 84 | $toExecute[$migration->name] = $migrationsService->parseMigrationDefinition($migrationDefinition); |
||
| 85 | } else { |
||
|
|
|||
| 86 | // q: shall we raise a warning here ? |
||
| 87 | } |
||
| 88 | } |
||
| 89 | } |
||
| 90 | } |
||
| 91 | |||
| 92 | ksort($toExecute); |
||
| 93 | |||
| 94 | if (!count($toExecute)) { |
||
| 95 | $output->writeln('<info>No migrations to execute</info>'); |
||
| 96 | return; |
||
| 97 | } |
||
| 98 | |||
| 99 | $output->writeln("\n <info>==</info> Migrations to be executed\n"); |
||
| 100 | |||
| 101 | $data = array(); |
||
| 102 | $i = 1; |
||
| 103 | foreach($toExecute as $name => $migrationDefinition) { |
||
| 104 | $notes = ''; |
||
| 105 | if ($migrationDefinition->status != MigrationDefinition::STATUS_PARSED) { |
||
| 106 | $notes = '<error>' . $migrationDefinition->parsingError . '</error>'; |
||
| 107 | } |
||
| 108 | $data[] = array( |
||
| 109 | $i++, |
||
| 110 | $name, |
||
| 111 | $notes |
||
| 112 | ); |
||
| 113 | } |
||
| 114 | |||
| 115 | $table = $this->getHelperSet()->get('table'); |
||
| 116 | $table |
||
| 117 | ->setHeaders(array('#', 'Migration', 'Notes')) |
||
| 118 | ->setRows($data); |
||
| 119 | $table->render($output); |
||
| 120 | |||
| 121 | $output->writeln(''); |
||
| 122 | // ask user for confirmation to make changes |
||
| 123 | View Code Duplication | if ($input->isInteractive() && !$input->getOption('no-interaction')) { |
|
| 124 | $dialog = $this->getHelperSet()->get('dialog'); |
||
| 125 | if (!$dialog->askConfirmation( |
||
| 126 | $output, |
||
| 127 | '<question>Careful, the database will be modified. Do you want to continue Y/N ?</question>', |
||
| 128 | false |
||
| 129 | ) |
||
| 130 | ) { |
||
| 131 | $output->writeln('<error>Migration execution cancelled!</error>'); |
||
| 132 | return 0; |
||
| 133 | } |
||
| 134 | } else { |
||
| 135 | $output->writeln("=============================================\n"); |
||
| 136 | } |
||
| 137 | |||
| 138 | foreach($toExecute as $name => $migrationDefinition) { |
||
| 139 | |||
| 140 | // let's skip migrations that we know are invalid - user was warned and he decided to proceed anyway |
||
| 141 | if ($migrationDefinition->status == MigrationDefinition::STATUS_INVALID) { |
||
| 142 | $output->writeln("<comment>Skipping $name</comment>\n"); |
||
| 143 | continue; |
||
| 144 | } |
||
| 145 | |||
| 146 | $output->writeln("<info>Processing $name</info>"); |
||
| 147 | |||
| 148 | try { |
||
| 149 | $migrationsService->executeMigration($migrationDefinition); |
||
| 150 | } catch(\Exception $e) { |
||
| 151 | if ($input->getOption('ignore-failures')) { |
||
| 152 | $output->writeln("\n<error>Migration failed! Reason: ".$this->getFullExceptionMessage($e)."</error>\n"); |
||
| 153 | continue; |
||
| 154 | } |
||
| 155 | $output->writeln("\n<error>Migration aborted! Reason: ".$this->getFullExceptionMessage($e)."</error>"); |
||
| 156 | return 1; |
||
| 157 | } |
||
| 158 | |||
| 159 | $output->writeln(''); |
||
| 160 | } |
||
| 161 | |||
| 162 | if ($input->getOption('clear-cache')) { |
||
| 163 | $command = $this->getApplication()->find('cache:clear'); |
||
| 164 | $inputArray = new ArrayInput(array('command' => 'cache:clear')); |
||
| 165 | $command->run($inputArray, $output); |
||
| 166 | } |
||
| 167 | } |
||
| 168 | |||
| 206 |
Loading history...
This check looks for the
elsebranches ofifstatements that have no statements or where all statements have been commented out. This may be the result of changes for debugging or the code may simply be obsolete.These
elsebranches can be removed.could be turned into
This is much more concise to read.