MigrateTest

Complexity

Total Complexity

10

Size/Duplication

Total Lines	98
Duplicated Lines	85.71 %

Coupling/Cohesion

Components	2
Dependencies	1

Importance

Changes	1
Bugs	0	Features	1

4 Methods

Rating	Name	Duplication	Size	Complexity
B	testExecuteGoodDSL()	30	30	2
B	testExecuteBadDSL()	30	30	2
A	goodDSLProvider()	12	12	3
A	badDSLProvider()	12	12	3

<?php

For compatibility and reusability of your code, PSR1 recommends that a file should introduce either new symbols (like classes, functions, etc.) or have side-effects (like outputting something, or including other files), but not both at the same time. The first symbol is defined on line 10 and the first side effect is on line 3.

include_once(__DIR__.'/CommandTest.php');

use Symfony\Component\Console\Input\ArrayInput;

/**
 * Tests the 'migrate' as well as the 'migration' command
 */
class MigrateTest extends CommandTest

PSR1 recommends that each class must be in a namespace of at least one level to avoid collisions.

{
    /**
     * @param string $filePath
     * @dataProvider goodDSLProvider
     */
    public function testExecuteGoodDSL($filePath = '')

This method seems to be duplicated in your project.

    {
        if ($filePath == '') {
            $this->markTestSkipped();
            return;
        }

        // Make user migration is not in the db: delete it, ignoring errors
        $input = new ArrayInput(array('command' => 'kaliop:migration:migration', 'migration' => basename($filePath), '--delete' => true, '-n' => true));
        $exitCode = $this->app->run($input, $this->output);

$exitCode is not used, you could remove the assignment.

        $output = $this->output->fetch();

$output is not used, you could remove the assignment.

        $input = new ArrayInput(array('command' => 'kaliop:migration:migration', 'migration' => $filePath, '--add' => true, '-n' => true));
        $exitCode = $this->app->run($input, $this->output);
        $output = $this->output->fetch();
        $this->assertSame(0, $exitCode);
        $this->assertRegexp('?Added migration?', $output);

        $input = new ArrayInput(array('command' => 'kaliop:migration:migrate', '--path' => array($filePath), '-n' => true));
        $exitCode = $this->app->run($input, $this->output);
        $output = $this->output->fetch();
        $this->assertSame(0, $exitCode);
        // check that there are no notes after adding the migration
        $this->assertRegexp('?\| ' . basename($filePath) . ' +\| +\|?', $output);

        $input = new ArrayInput(array('command' => 'kaliop:migration:migration', 'migration' => basename($filePath), '--delete' => true, '-n' => true));
        $exitCode = $this->app->run($input, $this->output);
        $output = $this->output->fetch();

$output is not used, you could remove the assignment.

        $this->assertSame(0, $exitCode);
    }

    /**
     * @param string $filePath
     * @dataProvider badDSLProvider
     */
    public function testExecuteBadDSL($filePath = '')

This method seems to be duplicated in your project.

    {
        if ($filePath == '') {
            $this->markTestSkipped();
            return;
        }

        // Make user migration is not in the db: delete it, ignoring errors
        $input = new ArrayInput(array('command' => 'kaliop:migration:migration', 'migration' => basename($filePath), '--delete' => true, '-n' => true));
        $exitCode = $this->app->run($input, $this->output);

$exitCode is not used, you could remove the assignment.

        $output = $this->output->fetch();

$output is not used, you could remove the assignment.

        $input = new ArrayInput(array('command' => 'kaliop:migration:migration', 'migration' => $filePath, '--add' => true, '-n' => true));
        $exitCode = $this->app->run($input, $this->output);
        $output = $this->output->fetch();
        $this->assertSame(0, $exitCode);
        $this->assertRegexp('?Added migration?', $output);

        $input = new ArrayInput(array('command' => 'kaliop:migration:migrate', '--path' => array($filePath), '-n' => true));
        $exitCode = $this->app->run($input, $this->output);
        $output = $this->output->fetch();
        $this->assertSame(0, $exitCode);
        // check that there are no notes after adding the migration
        $this->assertRegexp('?Skipping ' . basename($filePath) . '?', $output);

        $input = new ArrayInput(array('command' => 'kaliop:migration:migration', 'migration' => basename($filePath), '--delete' => true, '-n' => true));
        $exitCode = $this->app->run($input, $this->output);
        $output = $this->output->fetch();

$output is not used, you could remove the assignment.

        $this->assertSame(0, $exitCode);
    }

    public function goodDSLProvider()

This method seems to be duplicated in your project.

    {
        $dslDir = $this->dslDir.'/good';
        $out = array();
        foreach(scandir($dslDir) as $fileName) {
            $filePath = $dslDir . '/' . $fileName;
            if (is_file($filePath)) {
                $out[] = array($filePath);
            }
        }
        return $out;
    }

    public function badDSLProvider()

This method seems to be duplicated in your project.

    {
        $dslDir = $this->dslDir.'/bad';
        $out = array();
        foreach(scandir($dslDir) as $fileName) {
            $filePath = $dslDir . '/' . $fileName;
            if (is_file($filePath)) {
                $out[] = array($filePath);
            }
        }
        return $out;
    }
}